[INFO] crate pact_mock_server 0.4.0 is already in cache [INFO] extracting crate pact_mock_server 0.4.0 into work/ex/clippy-test-run/sources/stable/reg/pact_mock_server/0.4.0 [INFO] extracting crate pact_mock_server 0.4.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pact_mock_server/0.4.0 [INFO] validating manifest of pact_mock_server-0.4.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pact_mock_server-0.4.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pact_mock_server-0.4.0 [INFO] finished frobbing pact_mock_server-0.4.0 [INFO] frobbed toml for pact_mock_server-0.4.0 written to work/ex/clippy-test-run/sources/stable/reg/pact_mock_server/0.4.0/Cargo.toml [INFO] started frobbing pact_mock_server-0.4.0 [INFO] finished frobbing pact_mock_server-0.4.0 [INFO] frobbed toml for pact_mock_server-0.4.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pact_mock_server/0.4.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pact_mock_server-0.4.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/pact_mock_server/0.4.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 869ee7bd9298384bef4dd4080bdc374d0b424bab628850957af35db81564e813 [INFO] running `"docker" "start" "-a" "869ee7bd9298384bef4dd4080bdc374d0b424bab628850957af35db81564e813"` [INFO] [stderr] Checking p-macro v0.2.0 [INFO] [stderr] Checking indextree v1.3.0 [INFO] [stderr] Checking sxd-document v0.2.6 [INFO] [stderr] Checking expectest v0.9.2 [INFO] [stderr] Checking pact_matching v0.4.5 [INFO] [stderr] Checking pact_mock_server v0.4.0 (/opt/crater/workdir) [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/lib.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | RequestMismatch(Interaction, Vec), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] --> src/lib.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | RequestMismatch(Interaction, Vec), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:105:9 [INFO] [stderr] | [INFO] [stderr] 105 | / match self { [INFO] [stderr] 106 | | &MatchResult::RequestMatch(_) => s!("Request-Matched"), [INFO] [stderr] 107 | | &MatchResult::RequestMismatch(_, _) => s!("Request-Mismatch"), [INFO] [stderr] 108 | | &MatchResult::RequestNotFound(_) => s!("Unexpected-Request"), [INFO] [stderr] 109 | | &MatchResult::MissingRequest(_) => s!("Missing-Request") [INFO] [stderr] 110 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 105 | match *self { [INFO] [stderr] 106 | MatchResult::RequestMatch(_) => s!("Request-Matched"), [INFO] [stderr] 107 | MatchResult::RequestMismatch(_, _) => s!("Request-Mismatch"), [INFO] [stderr] 108 | MatchResult::RequestNotFound(_) => s!("Unexpected-Request"), [INFO] [stderr] 109 | MatchResult::MissingRequest(_) => s!("Missing-Request") [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:115:9 [INFO] [stderr] | [INFO] [stderr] 115 | / match self { [INFO] [stderr] 116 | | &MatchResult::RequestMatch(_) => true, [INFO] [stderr] 117 | | _ => false [INFO] [stderr] 118 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 115 | match *self { [INFO] [stderr] 116 | MatchResult::RequestMatch(_) => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:123:9 [INFO] [stderr] | [INFO] [stderr] 123 | / match self { [INFO] [stderr] 124 | | &MatchResult::RequestMatch(_) => json!({ s!("type") : s!("request-match")}), [INFO] [stderr] 125 | | &MatchResult::RequestMismatch(ref interaction, ref mismatches) => mismatches_to_json(&interaction.request, mismatches), [INFO] [stderr] 126 | | &MatchResult::RequestNotFound(ref req) => json!({ [INFO] [stderr] ... | [INFO] [stderr] 137 | | }) [INFO] [stderr] 138 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 123 | match *self { [INFO] [stderr] 124 | MatchResult::RequestMatch(_) => json!({ s!("type") : s!("request-match")}), [INFO] [stderr] 125 | MatchResult::RequestMismatch(ref interaction, ref mismatches) => mismatches_to_json(&interaction.request, mismatches), [INFO] [stderr] 126 | MatchResult::RequestNotFound(ref req) => json!({ [INFO] [stderr] 127 | "type": json!("request-not-found"), [INFO] [stderr] 128 | "method": json!(req.method), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:142:54 [INFO] [stderr] | [INFO] [stderr] 142 | fn mismatches_to_json(request: &Request, mismatches: &Vec) -> serde_json::Value { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Mismatch]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:198:26 [INFO] [stderr] | [INFO] [stderr] 198 | let mismatches = self.matches.iter() [INFO] [stderr] | __________________________^ [INFO] [stderr] 199 | | .filter(|m| !m.matched()) [INFO] [stderr] 200 | | .map(|m| m.clone()); [INFO] [stderr] | |_______________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 198 | let mismatches = self.matches.iter() [INFO] [stderr] 199 | .filter(|m| !m.matched()).cloned(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:252:47 [INFO] [stderr] | [INFO] [stderr] 252 | fn match_request(req: &Request, interactions: &Vec) -> MatchResult { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[Interaction]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/lib.rs:254:10 [INFO] [stderr] | [INFO] [stderr] 254 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:275:40 [INFO] [stderr] | [INFO] [stderr] 275 | fn method_or_path_mismatch(mismatches: &Vec) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Mismatch]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:283:5 [INFO] [stderr] | [INFO] [stderr] 283 | / match uri { [INFO] [stderr] 284 | | &RequestUri::AbsolutePath(ref s) => s!(s.splitn(2, "?").next().unwrap_or("/")), [INFO] [stderr] 285 | | &RequestUri::AbsoluteUri(ref url) => s!(url.path()), [INFO] [stderr] 286 | | _ => uri.to_string() [INFO] [stderr] 287 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 283 | match *uri { [INFO] [stderr] 284 | RequestUri::AbsolutePath(ref s) => s!(s.splitn(2, "?").next().unwrap_or("/")), [INFO] [stderr] 285 | RequestUri::AbsoluteUri(ref url) => s!(url.path()), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:284:60 [INFO] [stderr] | [INFO] [stderr] 284 | &RequestUri::AbsolutePath(ref s) => s!(s.splitn(2, "?").next().unwrap_or("/")), [INFO] [stderr] | ^^^ help: try using a char instead: `'?'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:291:5 [INFO] [stderr] | [INFO] [stderr] 291 | / match uri { [INFO] [stderr] 292 | | &RequestUri::AbsolutePath(ref s) => { [INFO] [stderr] 293 | | if s.contains("?") { [INFO] [stderr] 294 | | match s.splitn(2, "?").last() { [INFO] [stderr] ... | [INFO] [stderr] 306 | | _ => None [INFO] [stderr] 307 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 291 | match *uri { [INFO] [stderr] 292 | RequestUri::AbsolutePath(ref s) => { [INFO] [stderr] 293 | if s.contains("?") { [INFO] [stderr] 294 | match s.splitn(2, "?").last() { [INFO] [stderr] 295 | Some(q) => parse_query_string(&s!(q)), [INFO] [stderr] 296 | None => None [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:293:27 [INFO] [stderr] | [INFO] [stderr] 293 | if s.contains("?") { [INFO] [stderr] | ^^^ help: try using a char instead: `'?'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:294:35 [INFO] [stderr] | [INFO] [stderr] 294 | match s.splitn(2, "?").last() { [INFO] [stderr] | ^^^ help: try using a char instead: `'?'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lib.rs:345:37 [INFO] [stderr] | [INFO] [stderr] 345 | fn error_body(req: &Request, error: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lib.rs:350:31 [INFO] [stderr] | [INFO] [stderr] 350 | fn insert_new_mock_server(id: &String, pact: &Pact) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lib.rs:354:30 [INFO] [stderr] | [INFO] [stderr] 354 | fn update_mock_server(id: &String, f: &Fn(&mut MockServer) -> R) -> Option { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lib.rs:369:22 [INFO] [stderr] | [INFO] [stderr] 369 | fn record_result(id: &String, match_result: &MatchResult) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:398:62 [INFO] [stderr] | [INFO] [stderr] 398 | res.headers_mut().set_raw("X-Pact", vec!["Mock server has been shut down".as_bytes().to_vec()]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"Mock server has been shut down"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:414:29 [INFO] [stderr] | [INFO] [stderr] 414 | / match response.headers { [INFO] [stderr] 415 | | Some(ref headers) => { [INFO] [stderr] 416 | | for (k, v) in headers.clone() { [INFO] [stderr] 417 | | res.headers_mut().set_raw(k, vec![v.into_bytes()]); [INFO] [stderr] ... | [INFO] [stderr] 420 | | None => () [INFO] [stderr] 421 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 414 | if let Some(ref headers) = response.headers { [INFO] [stderr] 415 | for (k, v) in headers.clone() { [INFO] [stderr] 416 | res.headers_mut().set_raw(k, vec![v.into_bytes()]); [INFO] [stderr] 417 | } [INFO] [stderr] 418 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:422:29 [INFO] [stderr] | [INFO] [stderr] 422 | / match response.body { [INFO] [stderr] 423 | | OptionalBody::Present(ref body) => { [INFO] [stderr] 424 | | res.send(body).unwrap(); [INFO] [stderr] 425 | | }, [INFO] [stderr] 426 | | _ => () [INFO] [stderr] 427 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 422 | if let OptionalBody::Present(ref body) = response.body { [INFO] [stderr] 423 | res.send(body).unwrap(); [INFO] [stderr] 424 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:449:28 [INFO] [stderr] | [INFO] [stderr] 449 | let port = server.socket.port() as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(server.socket.port())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lib.rs:520:33 [INFO] [stderr] | [INFO] [stderr] 520 | pub fn shutdown_mock_server(id: &String) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `0 as *mut _` detected. Consider using `ptr::null_mut()` [INFO] [stderr] --> src/lib.rs:696:21 [INFO] [stderr] | [INFO] [stderr] 696 | None => 0 as *mut _ [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: `0 as *mut _` detected. Consider using `ptr::null_mut()` [INFO] [stderr] --> src/lib.rs:704:13 [INFO] [stderr] | [INFO] [stderr] 704 | 0 as *mut _ [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/lib.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | RequestMismatch(Interaction, Vec), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] --> src/lib.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | RequestMismatch(Interaction, Vec), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:105:9 [INFO] [stderr] | [INFO] [stderr] 105 | / match self { [INFO] [stderr] 106 | | &MatchResult::RequestMatch(_) => s!("Request-Matched"), [INFO] [stderr] 107 | | &MatchResult::RequestMismatch(_, _) => s!("Request-Mismatch"), [INFO] [stderr] 108 | | &MatchResult::RequestNotFound(_) => s!("Unexpected-Request"), [INFO] [stderr] 109 | | &MatchResult::MissingRequest(_) => s!("Missing-Request") [INFO] [stderr] 110 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 105 | match *self { [INFO] [stderr] 106 | MatchResult::RequestMatch(_) => s!("Request-Matched"), [INFO] [stderr] 107 | MatchResult::RequestMismatch(_, _) => s!("Request-Mismatch"), [INFO] [stderr] 108 | MatchResult::RequestNotFound(_) => s!("Unexpected-Request"), [INFO] [stderr] 109 | MatchResult::MissingRequest(_) => s!("Missing-Request") [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:115:9 [INFO] [stderr] | [INFO] [stderr] 115 | / match self { [INFO] [stderr] 116 | | &MatchResult::RequestMatch(_) => true, [INFO] [stderr] 117 | | _ => false [INFO] [stderr] 118 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 115 | match *self { [INFO] [stderr] 116 | MatchResult::RequestMatch(_) => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:123:9 [INFO] [stderr] | [INFO] [stderr] 123 | / match self { [INFO] [stderr] 124 | | &MatchResult::RequestMatch(_) => json!({ s!("type") : s!("request-match")}), [INFO] [stderr] 125 | | &MatchResult::RequestMismatch(ref interaction, ref mismatches) => mismatches_to_json(&interaction.request, mismatches), [INFO] [stderr] 126 | | &MatchResult::RequestNotFound(ref req) => json!({ [INFO] [stderr] ... | [INFO] [stderr] 137 | | }) [INFO] [stderr] 138 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 123 | match *self { [INFO] [stderr] 124 | MatchResult::RequestMatch(_) => json!({ s!("type") : s!("request-match")}), [INFO] [stderr] 125 | MatchResult::RequestMismatch(ref interaction, ref mismatches) => mismatches_to_json(&interaction.request, mismatches), [INFO] [stderr] 126 | MatchResult::RequestNotFound(ref req) => json!({ [INFO] [stderr] 127 | "type": json!("request-not-found"), [INFO] [stderr] 128 | "method": json!(req.method), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:142:54 [INFO] [stderr] | [INFO] [stderr] 142 | fn mismatches_to_json(request: &Request, mismatches: &Vec) -> serde_json::Value { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Mismatch]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:198:26 [INFO] [stderr] | [INFO] [stderr] 198 | let mismatches = self.matches.iter() [INFO] [stderr] | __________________________^ [INFO] [stderr] 199 | | .filter(|m| !m.matched()) [INFO] [stderr] 200 | | .map(|m| m.clone()); [INFO] [stderr] | |_______________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 198 | let mismatches = self.matches.iter() [INFO] [stderr] 199 | .filter(|m| !m.matched()).cloned(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:252:47 [INFO] [stderr] | [INFO] [stderr] 252 | fn match_request(req: &Request, interactions: &Vec) -> MatchResult { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[Interaction]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/lib.rs:254:10 [INFO] [stderr] | [INFO] [stderr] 254 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:275:40 [INFO] [stderr] | [INFO] [stderr] 275 | fn method_or_path_mismatch(mismatches: &Vec) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Mismatch]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:283:5 [INFO] [stderr] | [INFO] [stderr] 283 | / match uri { [INFO] [stderr] 284 | | &RequestUri::AbsolutePath(ref s) => s!(s.splitn(2, "?").next().unwrap_or("/")), [INFO] [stderr] 285 | | &RequestUri::AbsoluteUri(ref url) => s!(url.path()), [INFO] [stderr] 286 | | _ => uri.to_string() [INFO] [stderr] 287 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 283 | match *uri { [INFO] [stderr] 284 | RequestUri::AbsolutePath(ref s) => s!(s.splitn(2, "?").next().unwrap_or("/")), [INFO] [stderr] 285 | RequestUri::AbsoluteUri(ref url) => s!(url.path()), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:284:60 [INFO] [stderr] | [INFO] [stderr] 284 | &RequestUri::AbsolutePath(ref s) => s!(s.splitn(2, "?").next().unwrap_or("/")), [INFO] [stderr] | ^^^ help: try using a char instead: `'?'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:291:5 [INFO] [stderr] | [INFO] [stderr] 291 | / match uri { [INFO] [stderr] 292 | | &RequestUri::AbsolutePath(ref s) => { [INFO] [stderr] 293 | | if s.contains("?") { [INFO] [stderr] 294 | | match s.splitn(2, "?").last() { [INFO] [stderr] ... | [INFO] [stderr] 306 | | _ => None [INFO] [stderr] 307 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 291 | match *uri { [INFO] [stderr] 292 | RequestUri::AbsolutePath(ref s) => { [INFO] [stderr] 293 | if s.contains("?") { [INFO] [stderr] 294 | match s.splitn(2, "?").last() { [INFO] [stderr] 295 | Some(q) => parse_query_string(&s!(q)), [INFO] [stderr] 296 | None => None [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:293:27 [INFO] [stderr] | [INFO] [stderr] 293 | if s.contains("?") { [INFO] [stderr] | ^^^ help: try using a char instead: `'?'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:294:35 [INFO] [stderr] | [INFO] [stderr] 294 | match s.splitn(2, "?").last() { [INFO] [stderr] | ^^^ help: try using a char instead: `'?'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lib.rs:345:37 [INFO] [stderr] | [INFO] [stderr] 345 | fn error_body(req: &Request, error: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lib.rs:350:31 [INFO] [stderr] | [INFO] [stderr] 350 | fn insert_new_mock_server(id: &String, pact: &Pact) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lib.rs:354:30 [INFO] [stderr] | [INFO] [stderr] 354 | fn update_mock_server(id: &String, f: &Fn(&mut MockServer) -> R) -> Option { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lib.rs:369:22 [INFO] [stderr] | [INFO] [stderr] 369 | fn record_result(id: &String, match_result: &MatchResult) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:398:62 [INFO] [stderr] | [INFO] [stderr] 398 | res.headers_mut().set_raw("X-Pact", vec!["Mock server has been shut down".as_bytes().to_vec()]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"Mock server has been shut down"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:414:29 [INFO] [stderr] | [INFO] [stderr] 414 | / match response.headers { [INFO] [stderr] 415 | | Some(ref headers) => { [INFO] [stderr] 416 | | for (k, v) in headers.clone() { [INFO] [stderr] 417 | | res.headers_mut().set_raw(k, vec![v.into_bytes()]); [INFO] [stderr] ... | [INFO] [stderr] 420 | | None => () [INFO] [stderr] 421 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 414 | if let Some(ref headers) = response.headers { [INFO] [stderr] 415 | for (k, v) in headers.clone() { [INFO] [stderr] 416 | res.headers_mut().set_raw(k, vec![v.into_bytes()]); [INFO] [stderr] 417 | } [INFO] [stderr] 418 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:422:29 [INFO] [stderr] | [INFO] [stderr] 422 | / match response.body { [INFO] [stderr] 423 | | OptionalBody::Present(ref body) => { [INFO] [stderr] 424 | | res.send(body).unwrap(); [INFO] [stderr] 425 | | }, [INFO] [stderr] 426 | | _ => () [INFO] [stderr] 427 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 422 | if let OptionalBody::Present(ref body) = response.body { [INFO] [stderr] 423 | res.send(body).unwrap(); [INFO] [stderr] 424 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:449:28 [INFO] [stderr] | [INFO] [stderr] 449 | let port = server.socket.port() as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(server.socket.port())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lib.rs:520:33 [INFO] [stderr] | [INFO] [stderr] 520 | pub fn shutdown_mock_server(id: &String) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `0 as *mut _` detected. Consider using `ptr::null_mut()` [INFO] [stderr] --> src/lib.rs:696:21 [INFO] [stderr] | [INFO] [stderr] 696 | None => 0 as *mut _ [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: `0 as *mut _` detected. Consider using `ptr::null_mut()` [INFO] [stderr] --> src/lib.rs:704:13 [INFO] [stderr] | [INFO] [stderr] 704 | 0 as *mut _ [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 17.65s [INFO] running `"docker" "inspect" "869ee7bd9298384bef4dd4080bdc374d0b424bab628850957af35db81564e813"` [INFO] running `"docker" "rm" "-f" "869ee7bd9298384bef4dd4080bdc374d0b424bab628850957af35db81564e813"` [INFO] [stdout] 869ee7bd9298384bef4dd4080bdc374d0b424bab628850957af35db81564e813