[INFO] crate pact_consumer 0.4.0 is already in cache [INFO] extracting crate pact_consumer 0.4.0 into work/ex/clippy-test-run/sources/stable/reg/pact_consumer/0.4.0 [INFO] extracting crate pact_consumer 0.4.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pact_consumer/0.4.0 [INFO] validating manifest of pact_consumer-0.4.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pact_consumer-0.4.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pact_consumer-0.4.0 [INFO] finished frobbing pact_consumer-0.4.0 [INFO] frobbed toml for pact_consumer-0.4.0 written to work/ex/clippy-test-run/sources/stable/reg/pact_consumer/0.4.0/Cargo.toml [INFO] started frobbing pact_consumer-0.4.0 [INFO] finished frobbing pact_consumer-0.4.0 [INFO] frobbed toml for pact_consumer-0.4.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pact_consumer/0.4.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pact_consumer-0.4.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/pact_consumer/0.4.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f746d7b23fd729628d6de31319885dd03938f69db465aef52d73be25dbdb9ea5 [INFO] running `"docker" "start" "-a" "f746d7b23fd729628d6de31319885dd03938f69db465aef52d73be25dbdb9ea5"` [INFO] [stderr] Checking indextree v1.3.0 [INFO] [stderr] Checking semver v0.7.0 [INFO] [stderr] Checking sxd-document v0.2.6 [INFO] [stderr] Checking base64 v0.7.0 [INFO] [stderr] Checking quickcheck v0.2.27 [INFO] [stderr] Checking reqwest v0.7.3 [INFO] [stderr] Checking pact_matching v0.4.5 [INFO] [stderr] Checking pact_mock_server v0.4.0 [INFO] [stderr] Checking pact_consumer v0.4.0 (/opt/crater/workdir) [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the HashMap [INFO] [stderr] --> src/patterns/json_pattern.rs:69:34 [INFO] [stderr] | [INFO] [stderr] 69 | let fields = obj.into_iter().map(|(k, v)| (k.to_owned(), v.to_example())); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/patterns/json_pattern.rs:80:37 [INFO] [stderr] | [INFO] [stderr] 80 | for (i, val) in arr.into_iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/patterns/json_pattern.rs:171:32 [INFO] [stderr] | [INFO] [stderr] 171 | JsonPattern::Array(arr.into_iter().map(|v| v.clone().into()).collect()) [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the HashMap [INFO] [stderr] --> src/patterns/json_pattern.rs:69:34 [INFO] [stderr] | [INFO] [stderr] 69 | let fields = obj.into_iter().map(|(k, v)| (k.to_owned(), v.to_example())); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/patterns/json_pattern.rs:80:37 [INFO] [stderr] | [INFO] [stderr] 80 | for (i, val) in arr.into_iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/patterns/json_pattern.rs:171:32 [INFO] [stderr] | [INFO] [stderr] 171 | JsonPattern::Array(arr.into_iter().map(|v| v.clone().into()).collect()) [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 35.64s [INFO] running `"docker" "inspect" "f746d7b23fd729628d6de31319885dd03938f69db465aef52d73be25dbdb9ea5"` [INFO] running `"docker" "rm" "-f" "f746d7b23fd729628d6de31319885dd03938f69db465aef52d73be25dbdb9ea5"` [INFO] [stdout] f746d7b23fd729628d6de31319885dd03938f69db465aef52d73be25dbdb9ea5