[INFO] crate pact-stub-server 0.2.0 is already in cache [INFO] extracting crate pact-stub-server 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/pact-stub-server/0.2.0 [INFO] extracting crate pact-stub-server 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pact-stub-server/0.2.0 [INFO] validating manifest of pact-stub-server-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pact-stub-server-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pact-stub-server-0.2.0 [INFO] finished frobbing pact-stub-server-0.2.0 [INFO] frobbed toml for pact-stub-server-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/pact-stub-server/0.2.0/Cargo.toml [INFO] started frobbing pact-stub-server-0.2.0 [INFO] finished frobbing pact-stub-server-0.2.0 [INFO] frobbed toml for pact-stub-server-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pact-stub-server/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pact-stub-server-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/pact-stub-server/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 02a473e505293c75ff23c6056ce95406100a6298641dd9e062bf46f1d6a0ac7e [INFO] running `"docker" "start" "-a" "02a473e505293c75ff23c6056ce95406100a6298641dd9e062bf46f1d6a0ac7e"` [INFO] [stderr] Checking p-macro v0.2.0 [INFO] [stderr] Checking sxd-document v0.2.6 [INFO] [stderr] Compiling pulldown-cmark v0.0.3 [INFO] [stderr] Checking uuid v0.5.1 [INFO] [stderr] Checking hyper-tls v0.3.1 [INFO] [stderr] Checking pact_matching v0.4.5 [INFO] [stderr] Compiling skeptic v0.4.0 [INFO] [stderr] Compiling expectest v0.5.1 [INFO] [stderr] Checking pact-stub-server v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/pact_support.rs:18:8 [INFO] [stderr] | [INFO] [stderr] 18 | if headers.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!headers.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/pact_support.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | / match response.headers { [INFO] [stderr] 44 | | Some(ref headers) => { [INFO] [stderr] 45 | | for (k, v) in headers.clone() { [INFO] [stderr] 46 | | res.header(k.as_str(), v); [INFO] [stderr] ... | [INFO] [stderr] 49 | | None => () [INFO] [stderr] 50 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 43 | if let Some(ref headers) = response.headers { [INFO] [stderr] 44 | for (k, v) in headers.clone() { [INFO] [stderr] 45 | res.header(k.as_str(), v); [INFO] [stderr] 46 | } [INFO] [stderr] 47 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: a const item with interior mutability should not be borrowed [INFO] [stderr] --> src/pact_support.rs:52:34 [INFO] [stderr] | [INFO] [stderr] 52 | if !response.has_header(&ACCESS_CONTROL_ALLOW_ORIGIN.as_str().into()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::borrow_interior_mutable_const)] on by default [INFO] [stderr] = help: assign this const to a local or static variable, and use the variable here [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_interior_mutable_const [INFO] [stderr] [INFO] [stderr] error: a const item with interior mutability should not be borrowed [INFO] [stderr] --> src/pact_support.rs:58:42 [INFO] [stderr] | [INFO] [stderr] 58 | if !response.has_header(&CONTENT_TYPE.as_str().into()) { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: assign this const to a local or static variable, and use the variable here [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_interior_mutable_const [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/server.rs:32:71 [INFO] [stderr] | [INFO] [stderr] 32 | fn find_matching_request(request: &Request, auto_cors: bool, sources: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Pact]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/server.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | / match mismatch { [INFO] [stderr] 39 | | &Mismatch::MethodMismatch { .. } => false, [INFO] [stderr] 40 | | &Mismatch::PathMismatch { .. } => false, [INFO] [stderr] 41 | | &Mismatch::QueryMismatch { .. } => false, [INFO] [stderr] 42 | | &Mismatch::BodyMismatch { .. } => !(method_supports_payload(request) && request.body.is_present()), [INFO] [stderr] 43 | | _ => true [INFO] [stderr] 44 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 38 | match *mismatch { [INFO] [stderr] 39 | Mismatch::MethodMismatch { .. } => false, [INFO] [stderr] 40 | Mismatch::PathMismatch { .. } => false, [INFO] [stderr] 41 | Mismatch::QueryMismatch { .. } => false, [INFO] [stderr] 42 | Mismatch::BodyMismatch { .. } => !(method_supports_payload(request) && request.body.is_present()), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/server.rs:169:21 [INFO] [stderr] | [INFO] [stderr] 169 | format!("error occurred scheduling server future on Tokio runtime"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"error occurred scheduling server future on Tokio runtime".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:129:5 [INFO] [stderr] | [INFO] [stderr] 129 | / match matches.values_of("file") { [INFO] [stderr] 130 | | Some(values) => sources.extend(values.map(|v| PactSource::File(s!(v))).collect::>()), [INFO] [stderr] 131 | | None => () [INFO] [stderr] 132 | | }; [INFO] [stderr] | |_____^ help: try this: `if let Some(values) = matches.values_of("file") { sources.extend(values.map(|v| PactSource::File(s!(v))).collect::>()) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:133:5 [INFO] [stderr] | [INFO] [stderr] 133 | / match matches.values_of("dir") { [INFO] [stderr] 134 | | Some(values) => sources.extend(values.map(|v| PactSource::Dir(s!(v))).collect::>()), [INFO] [stderr] 135 | | None => () [INFO] [stderr] 136 | | }; [INFO] [stderr] | |_____^ help: try this: `if let Some(values) = matches.values_of("dir") { sources.extend(values.map(|v| PactSource::Dir(s!(v))).collect::>()) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:137:5 [INFO] [stderr] | [INFO] [stderr] 137 | / match matches.values_of("url") { [INFO] [stderr] 138 | | Some(values) => sources.extend(values.map(|v| { [INFO] [stderr] 139 | | PactSource::URL(s!(v), matches.value_of("user").map(|u| u.to_string())) [INFO] [stderr] 140 | | }).collect::>()), [INFO] [stderr] 141 | | None => () [INFO] [stderr] 142 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 137 | if let Some(values) = matches.values_of("url") { sources.extend(values.map(|v| { [INFO] [stderr] 138 | PactSource::URL(s!(v), matches.value_of("user").map(|u| u.to_string())) [INFO] [stderr] 139 | }).collect::>()) }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:199:9 [INFO] [stderr] | [INFO] [stderr] 199 | / match s { [INFO] [stderr] 200 | | &PactSource::File(ref file) => vec![Pact::read_pact(Path::new(&file)) [INFO] [stderr] 201 | | .map_err(|err| format!("Failed to load pact '{}' - {}", file, err))], [INFO] [stderr] 202 | | &PactSource::Dir(ref dir) => match walkdir(Path::new(dir)) { [INFO] [stderr] ... | [INFO] [stderr] 212 | | .map_err(|err| format!("Failed to load pact '{}' - {}", url, err))] [INFO] [stderr] 213 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 199 | match *s { [INFO] [stderr] 200 | PactSource::File(ref file) => vec![Pact::read_pact(Path::new(&file)) [INFO] [stderr] 201 | .map_err(|err| format!("Failed to load pact '{}' - {}", file, err))], [INFO] [stderr] 202 | PactSource::Dir(ref dir) => match walkdir(Path::new(dir)) { [INFO] [stderr] 203 | Ok(ref pacts) => pacts.iter().map(|p| { [INFO] [stderr] 204 | match p { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:204:25 [INFO] [stderr] | [INFO] [stderr] 204 | / match p { [INFO] [stderr] 205 | | &Ok(ref pact) => Ok(pact.clone()), [INFO] [stderr] 206 | | &Err(ref err) => Err(format!("Failed to load pact from '{}' - {}", dir, err)) [INFO] [stderr] 207 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 204 | match *p { [INFO] [stderr] 205 | Ok(ref pact) => Ok(pact.clone()), [INFO] [stderr] 206 | Err(ref err) => Err(format!("Failed to load pact from '{}' - {}", dir, err)) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:331:3 [INFO] [stderr] | [INFO] [stderr] 331 | / match TermLogger::init(log_level, Config::default()) { [INFO] [stderr] 332 | | Err(_) => SimpleLogger::init(log_level, Config::default()).unwrap_or(()), [INFO] [stderr] 333 | | Ok(_) => () [INFO] [stderr] 334 | | } [INFO] [stderr] | |___^ help: try this: `if let Err(_) = TermLogger::init(log_level, Config::default()) { SimpleLogger::init(log_level, Config::default()).unwrap_or(()) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `pact-stub-server`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/pact_support.rs:18:8 [INFO] [stderr] | [INFO] [stderr] 18 | if headers.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!headers.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/pact_support.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | / match response.headers { [INFO] [stderr] 44 | | Some(ref headers) => { [INFO] [stderr] 45 | | for (k, v) in headers.clone() { [INFO] [stderr] 46 | | res.header(k.as_str(), v); [INFO] [stderr] ... | [INFO] [stderr] 49 | | None => () [INFO] [stderr] 50 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 43 | if let Some(ref headers) = response.headers { [INFO] [stderr] 44 | for (k, v) in headers.clone() { [INFO] [stderr] 45 | res.header(k.as_str(), v); [INFO] [stderr] 46 | } [INFO] [stderr] 47 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: a const item with interior mutability should not be borrowed [INFO] [stderr] --> src/pact_support.rs:52:34 [INFO] [stderr] | [INFO] [stderr] 52 | if !response.has_header(&ACCESS_CONTROL_ALLOW_ORIGIN.as_str().into()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::borrow_interior_mutable_const)] on by default [INFO] [stderr] = help: assign this const to a local or static variable, and use the variable here [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_interior_mutable_const [INFO] [stderr] [INFO] [stderr] error: a const item with interior mutability should not be borrowed [INFO] [stderr] --> src/pact_support.rs:58:42 [INFO] [stderr] | [INFO] [stderr] 58 | if !response.has_header(&CONTENT_TYPE.as_str().into()) { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: assign this const to a local or static variable, and use the variable here [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_interior_mutable_const [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/server.rs:32:71 [INFO] [stderr] | [INFO] [stderr] 32 | fn find_matching_request(request: &Request, auto_cors: bool, sources: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Pact]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/server.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | / match mismatch { [INFO] [stderr] 39 | | &Mismatch::MethodMismatch { .. } => false, [INFO] [stderr] 40 | | &Mismatch::PathMismatch { .. } => false, [INFO] [stderr] 41 | | &Mismatch::QueryMismatch { .. } => false, [INFO] [stderr] 42 | | &Mismatch::BodyMismatch { .. } => !(method_supports_payload(request) && request.body.is_present()), [INFO] [stderr] 43 | | _ => true [INFO] [stderr] 44 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 38 | match *mismatch { [INFO] [stderr] 39 | Mismatch::MethodMismatch { .. } => false, [INFO] [stderr] 40 | Mismatch::PathMismatch { .. } => false, [INFO] [stderr] 41 | Mismatch::QueryMismatch { .. } => false, [INFO] [stderr] 42 | Mismatch::BodyMismatch { .. } => !(method_supports_payload(request) && request.body.is_present()), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/server.rs:169:21 [INFO] [stderr] | [INFO] [stderr] 169 | format!("error occurred scheduling server future on Tokio runtime"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"error occurred scheduling server future on Tokio runtime".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:129:5 [INFO] [stderr] | [INFO] [stderr] 129 | / match matches.values_of("file") { [INFO] [stderr] 130 | | Some(values) => sources.extend(values.map(|v| PactSource::File(s!(v))).collect::>()), [INFO] [stderr] 131 | | None => () [INFO] [stderr] 132 | | }; [INFO] [stderr] | |_____^ help: try this: `if let Some(values) = matches.values_of("file") { sources.extend(values.map(|v| PactSource::File(s!(v))).collect::>()) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:133:5 [INFO] [stderr] | [INFO] [stderr] 133 | / match matches.values_of("dir") { [INFO] [stderr] 134 | | Some(values) => sources.extend(values.map(|v| PactSource::Dir(s!(v))).collect::>()), [INFO] [stderr] 135 | | None => () [INFO] [stderr] 136 | | }; [INFO] [stderr] | |_____^ help: try this: `if let Some(values) = matches.values_of("dir") { sources.extend(values.map(|v| PactSource::Dir(s!(v))).collect::>()) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:137:5 [INFO] [stderr] | [INFO] [stderr] 137 | / match matches.values_of("url") { [INFO] [stderr] 138 | | Some(values) => sources.extend(values.map(|v| { [INFO] [stderr] 139 | | PactSource::URL(s!(v), matches.value_of("user").map(|u| u.to_string())) [INFO] [stderr] 140 | | }).collect::>()), [INFO] [stderr] 141 | | None => () [INFO] [stderr] 142 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 137 | if let Some(values) = matches.values_of("url") { sources.extend(values.map(|v| { [INFO] [stderr] 138 | PactSource::URL(s!(v), matches.value_of("user").map(|u| u.to_string())) [INFO] [stderr] 139 | }).collect::>()) }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:199:9 [INFO] [stderr] | [INFO] [stderr] 199 | / match s { [INFO] [stderr] 200 | | &PactSource::File(ref file) => vec![Pact::read_pact(Path::new(&file)) [INFO] [stderr] 201 | | .map_err(|err| format!("Failed to load pact '{}' - {}", file, err))], [INFO] [stderr] 202 | | &PactSource::Dir(ref dir) => match walkdir(Path::new(dir)) { [INFO] [stderr] ... | [INFO] [stderr] 212 | | .map_err(|err| format!("Failed to load pact '{}' - {}", url, err))] [INFO] [stderr] 213 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 199 | match *s { [INFO] [stderr] 200 | PactSource::File(ref file) => vec![Pact::read_pact(Path::new(&file)) [INFO] [stderr] 201 | .map_err(|err| format!("Failed to load pact '{}' - {}", file, err))], [INFO] [stderr] 202 | PactSource::Dir(ref dir) => match walkdir(Path::new(dir)) { [INFO] [stderr] 203 | Ok(ref pacts) => pacts.iter().map(|p| { [INFO] [stderr] 204 | match p { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:204:25 [INFO] [stderr] | [INFO] [stderr] 204 | / match p { [INFO] [stderr] 205 | | &Ok(ref pact) => Ok(pact.clone()), [INFO] [stderr] 206 | | &Err(ref err) => Err(format!("Failed to load pact from '{}' - {}", dir, err)) [INFO] [stderr] 207 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 204 | match *p { [INFO] [stderr] 205 | Ok(ref pact) => Ok(pact.clone()), [INFO] [stderr] 206 | Err(ref err) => Err(format!("Failed to load pact from '{}' - {}", dir, err)) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:331:3 [INFO] [stderr] | [INFO] [stderr] 331 | / match TermLogger::init(log_level, Config::default()) { [INFO] [stderr] 332 | | Err(_) => SimpleLogger::init(log_level, Config::default()).unwrap_or(()), [INFO] [stderr] 333 | | Ok(_) => () [INFO] [stderr] 334 | | } [INFO] [stderr] | |___^ help: try this: `if let Err(_) = TermLogger::init(log_level, Config::default()) { SimpleLogger::init(log_level, Config::default()).unwrap_or(()) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/test.rs:16:65 [INFO] [stderr] | [INFO] [stderr] 16 | Err(_) => TestResult::from_bool(s.is_empty() || s.chars().find(|ch| !ch.is_numeric() ).is_some()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::search_is_some)] on by default [INFO] [stderr] = note: replace `find(|ch| !ch.is_numeric()).is_some()` with `any(|ch| !ch.is_numeric())` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `pact-stub-server`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "02a473e505293c75ff23c6056ce95406100a6298641dd9e062bf46f1d6a0ac7e"` [INFO] running `"docker" "rm" "-f" "02a473e505293c75ff23c6056ce95406100a6298641dd9e062bf46f1d6a0ac7e"` [INFO] [stdout] 02a473e505293c75ff23c6056ce95406100a6298641dd9e062bf46f1d6a0ac7e