[INFO] crate packet 0.1.2 is already in cache [INFO] extracting crate packet 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/packet/0.1.2 [INFO] extracting crate packet 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/packet/0.1.2 [INFO] validating manifest of packet-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of packet-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing packet-0.1.2 [INFO] finished frobbing packet-0.1.2 [INFO] frobbed toml for packet-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/packet/0.1.2/Cargo.toml [INFO] started frobbing packet-0.1.2 [INFO] finished frobbing packet-0.1.2 [INFO] frobbed toml for packet-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/packet/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting packet-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/packet/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1af155d526f88cea5929b2926fb9dc919135686f730620daba1443710bb263d4 [INFO] running `"docker" "start" "-a" "1af155d526f88cea5929b2926fb9dc919135686f730620daba1443710bb263d4"` [INFO] [stderr] Compiling encoding_rs v0.8.14 [INFO] [stderr] Compiling base64 v0.10.1 [INFO] [stderr] Compiling libflate v0.1.19 [INFO] [stderr] Compiling mime v0.3.13 [INFO] [stderr] Compiling phf v0.7.24 [INFO] [stderr] Compiling serde_urlencoded v0.5.4 [INFO] [stderr] Compiling uuid v0.7.2 [INFO] [stderr] Compiling tokio v0.1.15 [INFO] [stderr] Compiling mime_guess v2.0.0-alpha.6 [INFO] [stderr] Compiling hyper v0.12.23 [INFO] [stderr] Compiling hyper-tls v0.3.1 [INFO] [stderr] Compiling reqwest v0.9.9 [INFO] [stderr] Compiling hwaddr v0.1.5 [INFO] [stderr] Checking packet v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ether/builder.rs:41:4 [INFO] [stderr] | [INFO] [stderr] 41 | buffer: buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `buffer` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ip/builder.rs:30:4 [INFO] [stderr] | [INFO] [stderr] 30 | buffer: buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ip/v4/option.rs:154:4 [INFO] [stderr] | [INFO] [stderr] 154 | buffer: buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ip/v4/builder.rs:52:4 [INFO] [stderr] | [INFO] [stderr] 52 | buffer: buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ip/v6/builder.rs:31:4 [INFO] [stderr] | [INFO] [stderr] 31 | buffer: buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/icmp/builder.rs:34:4 [INFO] [stderr] | [INFO] [stderr] 34 | buffer: buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/icmp/echo/builder.rs:41:4 [INFO] [stderr] | [INFO] [stderr] 41 | buffer: buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/icmp/information/builder.rs:39:4 [INFO] [stderr] | [INFO] [stderr] 39 | buffer: buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/icmp/timestamp/builder.rs:40:4 [INFO] [stderr] | [INFO] [stderr] 40 | buffer: buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `buffer` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ether/builder.rs:41:4 [INFO] [stderr] | [INFO] [stderr] 41 | buffer: buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tcp/option.rs:87:4 [INFO] [stderr] | [INFO] [stderr] 87 | buffer: buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tcp/packet.rs:263:4 [INFO] [stderr] | [INFO] [stderr] 263 | ip: ip, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `ip` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tcp/builder.rs:52:4 [INFO] [stderr] | [INFO] [stderr] 52 | buffer: buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tcp/builder.rs:55:4 [INFO] [stderr] | [INFO] [stderr] 55 | ip: ip, [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `ip` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/udp/packet.rs:214:4 [INFO] [stderr] | [INFO] [stderr] 214 | ip: ip, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `ip` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/udp/builder.rs:44:4 [INFO] [stderr] | [INFO] [stderr] 44 | buffer: buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/udp/builder.rs:47:4 [INFO] [stderr] | [INFO] [stderr] 47 | ip: ip, [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `ip` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ip/builder.rs:30:4 [INFO] [stderr] | [INFO] [stderr] 30 | buffer: buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ip/v4/option.rs:154:4 [INFO] [stderr] | [INFO] [stderr] 154 | buffer: buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ip/v4/builder.rs:52:4 [INFO] [stderr] | [INFO] [stderr] 52 | buffer: buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ip/v6/builder.rs:31:4 [INFO] [stderr] | [INFO] [stderr] 31 | buffer: buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/icmp/builder.rs:34:4 [INFO] [stderr] | [INFO] [stderr] 34 | buffer: buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/icmp/echo/builder.rs:41:4 [INFO] [stderr] | [INFO] [stderr] 41 | buffer: buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/icmp/information/builder.rs:39:4 [INFO] [stderr] | [INFO] [stderr] 39 | buffer: buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/icmp/timestamp/builder.rs:40:4 [INFO] [stderr] | [INFO] [stderr] 40 | buffer: buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tcp/option.rs:87:4 [INFO] [stderr] | [INFO] [stderr] 87 | buffer: buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tcp/packet.rs:263:4 [INFO] [stderr] | [INFO] [stderr] 263 | ip: ip, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `ip` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tcp/builder.rs:52:4 [INFO] [stderr] | [INFO] [stderr] 52 | buffer: buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tcp/builder.rs:55:4 [INFO] [stderr] | [INFO] [stderr] 55 | ip: ip, [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `ip` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/udp/packet.rs:214:4 [INFO] [stderr] | [INFO] [stderr] 214 | ip: ip, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `ip` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/udp/builder.rs:44:4 [INFO] [stderr] | [INFO] [stderr] 44 | buffer: buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/udp/builder.rs:47:4 [INFO] [stderr] | [INFO] [stderr] 47 | ip: ip, [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `ip` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/ip/v4/packet.rs:43:51 [INFO] [stderr] | [INFO] [stderr] 43 | size: p => (p.length() as usize).saturating_sub((p.header() as usize * 4)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/ip/v4/packet.rs:43:51 [INFO] [stderr] | [INFO] [stderr] 43 | size: p => (p.length() as usize).saturating_sub((p.header() as usize * 4)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::net::Ipv4Addr` [INFO] [stderr] --> src/ip/v6/packet.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | use std::net::Ipv4Addr; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `BigEndian`, `ReadBytesExt` [INFO] [stderr] --> src/ip/v6/packet.rs:17:17 [INFO] [stderr] | [INFO] [stderr] 17 | use byteorder::{ReadBytesExt, BigEndian}; [INFO] [stderr] | ^^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `size` [INFO] [stderr] --> src/ip/v6/packet.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | use size; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `ip::Protocol` [INFO] [stderr] --> src/ip/v6/packet.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | use ip::Protocol; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `ip::v4::Flags` [INFO] [stderr] --> src/ip/v6/packet.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | use ip::v4::Flags; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `ip::v4::option` [INFO] [stderr] --> src/ip/v6/packet.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | use ip::v4::option; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `ip::v4::checksum` [INFO] [stderr] --> src/ip/v6/packet.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | use ip::v4::checksum; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::Cursor` [INFO] [stderr] --> src/ip/v6/builder.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | use std::io::Cursor; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `BigEndian`, `WriteBytesExt` [INFO] [stderr] --> src/ip/v6/builder.rs:16:17 [INFO] [stderr] | [INFO] [stderr] 16 | use byteorder::{WriteBytesExt, BigEndian}; [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/ip/v4/packet.rs:43:51 [INFO] [stderr] | [INFO] [stderr] 43 | size: p => (p.length() as usize).saturating_sub((p.header() as usize * 4)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/ip/v4/packet.rs:43:51 [INFO] [stderr] | [INFO] [stderr] 43 | size: p => (p.length() as usize).saturating_sub((p.header() as usize * 4)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::net::Ipv4Addr` [INFO] [stderr] --> src/ip/v6/packet.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | use std::net::Ipv4Addr; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `BigEndian`, `ReadBytesExt` [INFO] [stderr] --> src/ip/v6/packet.rs:17:17 [INFO] [stderr] | [INFO] [stderr] 17 | use byteorder::{ReadBytesExt, BigEndian}; [INFO] [stderr] | ^^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `size` [INFO] [stderr] --> src/ip/v6/packet.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | use size; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `ip::Protocol` [INFO] [stderr] --> src/ip/v6/packet.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | use ip::Protocol; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `ip::v4::Flags` [INFO] [stderr] --> src/ip/v6/packet.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | use ip::v4::Flags; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `ip::v4::option` [INFO] [stderr] --> src/ip/v6/packet.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | use ip::v4::option; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `ip::v4::checksum` [INFO] [stderr] --> src/ip/v6/packet.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | use ip::v4::checksum; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::Cursor` [INFO] [stderr] --> src/ip/v6/builder.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | use std::io::Cursor; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `BigEndian`, `WriteBytesExt` [INFO] [stderr] --> src/ip/v6/builder.rs:16:17 [INFO] [stderr] | [INFO] [stderr] 16 | use byteorder::{WriteBytesExt, BigEndian}; [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `packet` [INFO] [stderr] --> src/tcp/mod.rs:53:22 [INFO] [stderr] | [INFO] [stderr] 53 | ip::Packet::V6(ref packet) => { [INFO] [stderr] | ^^^^^^ help: consider using `_packet` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `packet` [INFO] [stderr] --> src/udp/mod.rs:45:22 [INFO] [stderr] | [INFO] [stderr] 45 | ip::Packet::V6(ref packet) => { [INFO] [stderr] | ^^^^^^ help: consider using `_packet` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/ip/v4/packet.rs:173:7 [INFO] [stderr] | [INFO] [stderr] 173 | let mut buffer = self.buffer.as_mut(); [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/ip/v4/packet.rs:174:7 [INFO] [stderr] | [INFO] [stderr] 174 | let mut buffer = if buffer.len() < header + payload { [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `packet` [INFO] [stderr] --> src/tcp/mod.rs:53:22 [INFO] [stderr] | [INFO] [stderr] 53 | ip::Packet::V6(ref packet) => { [INFO] [stderr] | ^^^^^^ help: consider using `_packet` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `packet` [INFO] [stderr] --> src/udp/mod.rs:45:22 [INFO] [stderr] | [INFO] [stderr] 45 | ip::Packet::V6(ref packet) => { [INFO] [stderr] | ^^^^^^ help: consider using `_packet` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/udp/packet.rs:154:7 [INFO] [stderr] | [INFO] [stderr] 154 | let mut buffer = self.buffer.as_mut(); [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/udp/packet.rs:155:7 [INFO] [stderr] | [INFO] [stderr] 155 | let mut buffer = if buffer.len() < header + payload { [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: field is never used: `buffer` [INFO] [stderr] --> src/ip/v6/builder.rs:24:2 [INFO] [stderr] | [INFO] [stderr] 24 | buffer: B, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/ip/v4/packet.rs:173:7 [INFO] [stderr] | [INFO] [stderr] 173 | let mut buffer = self.buffer.as_mut(); [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/ip/v4/packet.rs:174:7 [INFO] [stderr] | [INFO] [stderr] 174 | let mut buffer = if buffer.len() < header + payload { [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/ip/v4/option.rs:231:9 [INFO] [stderr] | [INFO] [stderr] 231 | match ((self.buffer.as_ref()[0] >> 5) & 0b011).into() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `((self.buffer.as_ref()[0] >> 5) & 0b011)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/ip/v4/mod.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | result += value as u32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(value)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/tcp/packet.rs:427:12 [INFO] [stderr] | [INFO] [stderr] 427 | let (ip, mut tcp) = ip.split_mut(); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/udp/packet.rs:154:7 [INFO] [stderr] | [INFO] [stderr] 154 | let mut buffer = self.buffer.as_mut(); [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/udp/packet.rs:155:7 [INFO] [stderr] | [INFO] [stderr] 155 | let mut buffer = if buffer.len() < header + payload { [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/udp/packet.rs:316:12 [INFO] [stderr] | [INFO] [stderr] 316 | let (ip, mut udp) = ip.split_mut(); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/icmp/mod.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | result += value as u32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: field is never used: `buffer` [INFO] [stderr] --> src/ip/v6/builder.rs:24:2 [INFO] [stderr] | [INFO] [stderr] 24 | buffer: B, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/tcp/packet.rs:238:28 [INFO] [stderr] | [INFO] [stderr] 238 | .write_u16::((old as u16) << 12 | value.bits())?; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(old)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/tcp/mod.rs:69:13 [INFO] [stderr] | [INFO] [stderr] 69 | result += value as u32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/tcp/mod.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | result += value as u32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/udp/mod.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | result += value as u32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/udp/mod.rs:74:13 [INFO] [stderr] | [INFO] [stderr] 74 | result += value as u32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/ip/v4/option.rs:231:9 [INFO] [stderr] | [INFO] [stderr] 231 | match ((self.buffer.as_ref()[0] >> 5) & 0b011).into() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `((self.buffer.as_ref()[0] >> 5) & 0b011)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/ip/v4/mod.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | result += value as u32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(value)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/icmp/mod.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | result += value as u32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/tcp/packet.rs:238:28 [INFO] [stderr] | [INFO] [stderr] 238 | .write_u16::((old as u16) << 12 | value.bits())?; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(old)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/tcp/mod.rs:69:13 [INFO] [stderr] | [INFO] [stderr] 69 | result += value as u32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/tcp/mod.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | result += value as u32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/udp/mod.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | result += value as u32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/udp/mod.rs:74:13 [INFO] [stderr] | [INFO] [stderr] 74 | result += value as u32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 53.03s [INFO] running `"docker" "inspect" "1af155d526f88cea5929b2926fb9dc919135686f730620daba1443710bb263d4"` [INFO] running `"docker" "rm" "-f" "1af155d526f88cea5929b2926fb9dc919135686f730620daba1443710bb263d4"` [INFO] [stdout] 1af155d526f88cea5929b2926fb9dc919135686f730620daba1443710bb263d4