[INFO] crate packageurl 0.2.0 is already in cache [INFO] extracting crate packageurl 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/packageurl/0.2.0 [INFO] extracting crate packageurl 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/packageurl/0.2.0 [INFO] validating manifest of packageurl-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of packageurl-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing packageurl-0.2.0 [INFO] finished frobbing packageurl-0.2.0 [INFO] frobbed toml for packageurl-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/packageurl/0.2.0/Cargo.toml [INFO] started frobbing packageurl-0.2.0 [INFO] finished frobbing packageurl-0.2.0 [INFO] frobbed toml for packageurl-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/packageurl/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting packageurl-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/packageurl/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4a3c9260dbe3dfe29f9094749b39ae9d7a4440f780f990088a7bfbfd050c37ca [INFO] running `"docker" "start" "-a" "4a3c9260dbe3dfe29f9094749b39ae9d7a4440f780f990088a7bfbfd050c37ca"` [INFO] [stderr] Checking error-chain v0.7.2 [INFO] [stderr] Checking packageurl v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/parser.rs:10:25 [INFO] [stderr] | [INFO] [stderr] 10 | pub fn parse_scheme<'a>(input: &str) -> errors::Result<(&str, String)> { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/parser.rs:28:26 [INFO] [stderr] | [INFO] [stderr] 28 | pub fn parse_subpath<'a>(input: &str) -> errors::Result<(&str, Option)> { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/parser.rs:42:29 [INFO] [stderr] | [INFO] [stderr] 42 | pub fn parse_qualifiers<'a>(input: &str) -> errors::Result<(&str, Vec<(String, String)>)> { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/parser.rs:56:26 [INFO] [stderr] | [INFO] [stderr] 56 | pub fn parse_version<'a>(input: &str) -> errors::Result<(&str, Option)> { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/parser.rs:58:35 [INFO] [stderr] | [INFO] [stderr] 58 | Ok((&input[..i], Some(input[i + 1..].to_string().into()))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `input[i + 1..].to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/parser.rs:64:23 [INFO] [stderr] | [INFO] [stderr] 64 | pub fn parse_type<'a>(input: &str) -> errors::Result<(&str, String)> { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/parser.rs:66:34 [INFO] [stderr] | [INFO] [stderr] 66 | Ok((&input[i + 1..], input[..i].to_lowercase().into())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `input[..i].to_lowercase()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/parser.rs:72:23 [INFO] [stderr] | [INFO] [stderr] 72 | pub fn parse_name<'a>(input: &str) -> errors::Result<(&str, String)> { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/parser.rs:84:28 [INFO] [stderr] | [INFO] [stderr] 84 | pub fn parse_namespace<'a>(input: &str) -> errors::Result<(&str, Option)> { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/purl.rs:100:24 [INFO] [stderr] | [INFO] [stderr] 100 | name = name.to_lowercase().into(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `name.to_lowercase()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/purl.rs:101:48 [INFO] [stderr] | [INFO] [stderr] 101 | namespace = namespace.map(|ns| ns.to_lowercase().into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `ns.to_lowercase()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/purl.rs:104:24 [INFO] [stderr] | [INFO] [stderr] 104 | name = name.replace('_', "-").to_lowercase().into(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `name.replace('_', "-").to_lowercase()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/purl.rs:168:17 [INFO] [stderr] | [INFO] [stderr] 168 | let ref mut it = items.iter().peekable(); [INFO] [stderr] | ----^^^^^^^^^^--------------------------- help: try: `let it = &mut items.iter().peekable();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/purl.rs:173:17 [INFO] [stderr] | [INFO] [stderr] 173 | &v.encode(USERINFO_ENCODE_SET).for_each(|s| url.push_str(s)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `v.encode(USERINFO_ENCODE_SET).for_each(|s| url.push_str(s));` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/purl.rs:190:17 [INFO] [stderr] | [INFO] [stderr] 190 | let ref mut it = components.peekable(); [INFO] [stderr] | ----^^^^^^^^^^------------------------- help: try: `let it = &mut components.peekable();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> tests/spec/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#![rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/parser.rs:10:25 [INFO] [stderr] | [INFO] [stderr] 10 | pub fn parse_scheme<'a>(input: &str) -> errors::Result<(&str, String)> { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/parser.rs:28:26 [INFO] [stderr] | [INFO] [stderr] 28 | pub fn parse_subpath<'a>(input: &str) -> errors::Result<(&str, Option)> { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/parser.rs:42:29 [INFO] [stderr] | [INFO] [stderr] 42 | pub fn parse_qualifiers<'a>(input: &str) -> errors::Result<(&str, Vec<(String, String)>)> { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/parser.rs:56:26 [INFO] [stderr] | [INFO] [stderr] 56 | pub fn parse_version<'a>(input: &str) -> errors::Result<(&str, Option)> { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/parser.rs:58:35 [INFO] [stderr] | [INFO] [stderr] 58 | Ok((&input[..i], Some(input[i + 1..].to_string().into()))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `input[i + 1..].to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/parser.rs:64:23 [INFO] [stderr] | [INFO] [stderr] 64 | pub fn parse_type<'a>(input: &str) -> errors::Result<(&str, String)> { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/parser.rs:66:34 [INFO] [stderr] | [INFO] [stderr] 66 | Ok((&input[i + 1..], input[..i].to_lowercase().into())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `input[..i].to_lowercase()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/parser.rs:72:23 [INFO] [stderr] | [INFO] [stderr] 72 | pub fn parse_name<'a>(input: &str) -> errors::Result<(&str, String)> { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/parser.rs:84:28 [INFO] [stderr] | [INFO] [stderr] 84 | pub fn parse_namespace<'a>(input: &str) -> errors::Result<(&str, Option)> { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/purl.rs:100:24 [INFO] [stderr] | [INFO] [stderr] 100 | name = name.to_lowercase().into(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `name.to_lowercase()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/purl.rs:101:48 [INFO] [stderr] | [INFO] [stderr] 101 | namespace = namespace.map(|ns| ns.to_lowercase().into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `ns.to_lowercase()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/purl.rs:104:24 [INFO] [stderr] | [INFO] [stderr] 104 | name = name.replace('_', "-").to_lowercase().into(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `name.replace('_', "-").to_lowercase()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/purl.rs:168:17 [INFO] [stderr] | [INFO] [stderr] 168 | let ref mut it = items.iter().peekable(); [INFO] [stderr] | ----^^^^^^^^^^--------------------------- help: try: `let it = &mut items.iter().peekable();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/purl.rs:173:17 [INFO] [stderr] | [INFO] [stderr] 173 | &v.encode(USERINFO_ENCODE_SET).for_each(|s| url.push_str(s)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `v.encode(USERINFO_ENCODE_SET).for_each(|s| url.push_str(s));` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/purl.rs:190:17 [INFO] [stderr] | [INFO] [stderr] 190 | let ref mut it = components.peekable(); [INFO] [stderr] | ----^^^^^^^^^^------------------------- help: try: `let it = &mut components.peekable();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/bench.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `packageurl`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "4a3c9260dbe3dfe29f9094749b39ae9d7a4440f780f990088a7bfbfd050c37ca"` [INFO] running `"docker" "rm" "-f" "4a3c9260dbe3dfe29f9094749b39ae9d7a4440f780f990088a7bfbfd050c37ca"` [INFO] [stdout] 4a3c9260dbe3dfe29f9094749b39ae9d7a4440f780f990088a7bfbfd050c37ca