[INFO] crate pack_2048 0.4.4 is already in cache [INFO] extracting crate pack_2048 0.4.4 into work/ex/clippy-test-run/sources/stable/reg/pack_2048/0.4.4 [INFO] extracting crate pack_2048 0.4.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pack_2048/0.4.4 [INFO] validating manifest of pack_2048-0.4.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pack_2048-0.4.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pack_2048-0.4.4 [INFO] finished frobbing pack_2048-0.4.4 [INFO] frobbed toml for pack_2048-0.4.4 written to work/ex/clippy-test-run/sources/stable/reg/pack_2048/0.4.4/Cargo.toml [INFO] started frobbing pack_2048-0.4.4 [INFO] finished frobbing pack_2048-0.4.4 [INFO] frobbed toml for pack_2048-0.4.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pack_2048/0.4.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pack_2048-0.4.4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/pack_2048/0.4.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b2d2b6f9201594e690adf161b51861c30127239eb238a4c8170a967f1bfd884d [INFO] running `"docker" "start" "-a" "b2d2b6f9201594e690adf161b51861c30127239eb238a4c8170a967f1bfd884d"` [INFO] [stderr] Checking pack_2048 v0.4.4 (/opt/crater/workdir) [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:94:34 [INFO] [stderr] | [INFO] [stderr] 94 | let mut copy_board = board.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*board` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:191:19 [INFO] [stderr] | [INFO] [stderr] 191 | fn digits(number: &usize) -> usize { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:94:34 [INFO] [stderr] | [INFO] [stderr] 94 | let mut copy_board = board.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*board` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:191:19 [INFO] [stderr] | [INFO] [stderr] 191 | fn digits(number: &usize) -> usize { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.61s [INFO] running `"docker" "inspect" "b2d2b6f9201594e690adf161b51861c30127239eb238a4c8170a967f1bfd884d"` [INFO] running `"docker" "rm" "-f" "b2d2b6f9201594e690adf161b51861c30127239eb238a4c8170a967f1bfd884d"` [INFO] [stdout] b2d2b6f9201594e690adf161b51861c30127239eb238a4c8170a967f1bfd884d