[INFO] crate oysterpack_built 0.3.2 is already in cache [INFO] extracting crate oysterpack_built 0.3.2 into work/ex/clippy-test-run/sources/stable/reg/oysterpack_built/0.3.2 [INFO] extracting crate oysterpack_built 0.3.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/oysterpack_built/0.3.2 [INFO] validating manifest of oysterpack_built-0.3.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of oysterpack_built-0.3.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing oysterpack_built-0.3.2 [INFO] finished frobbing oysterpack_built-0.3.2 [INFO] frobbed toml for oysterpack_built-0.3.2 written to work/ex/clippy-test-run/sources/stable/reg/oysterpack_built/0.3.2/Cargo.toml [INFO] started frobbing oysterpack_built-0.3.2 [INFO] finished frobbing oysterpack_built-0.3.2 [INFO] frobbed toml for oysterpack_built-0.3.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/oysterpack_built/0.3.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting oysterpack_built-0.3.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/oysterpack_built/0.3.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f3a7fc5a0fa31baa9827ac0488ad90d84ca26c9748eb58d1f74dfdd65f529a7e [INFO] running `"docker" "start" "-a" "f3a7fc5a0fa31baa9827ac0488ad90d84ca26c9748eb58d1f74dfdd65f529a7e"` [INFO] [stderr] Compiling libgit2-sys v0.7.11 [INFO] [stderr] Checking semver v0.9.0 [INFO] [stderr] Checking oysterpack_testing v0.1.2 [INFO] [stderr] Checking petgraph v0.4.13 [INFO] [stderr] Checking globset v0.4.2 [INFO] [stderr] Checking rand_pcg v0.1.1 [INFO] [stderr] Checking crates-io v0.18.0 [INFO] [stderr] Checking rustfix v0.4.4 [INFO] [stderr] Checking rand v0.6.5 [INFO] [stderr] Checking ignore v0.4.6 [INFO] [stderr] Checking tempfile v3.0.5 [INFO] [stderr] Checking git2 v0.7.5 [INFO] [stderr] Checking git2-curl v0.8.2 [INFO] [stderr] Checking built v0.3.0 [INFO] [stderr] Checking cargo v0.30.0 [INFO] [stderr] Checking oysterpack_built v0.3.2 (/opt/crater/workdir) [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/build_time/mod.rs:185:5 [INFO] [stderr] | [INFO] [stderr] 185 | writeln!(file, "{}", file_contents); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's keys [INFO] [stderr] --> src/build_time/mod.rs:488:26 [INFO] [stderr] | [INFO] [stderr] 488 | for (name, _) in package.summary().features() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::for_kv_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 488 | for name in package.summary().features().keys() { [INFO] [stderr] | ^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/build_time/mod.rs:508:28 [INFO] [stderr] | [INFO] [stderr] 508 | .map(|feature| available_features.get(feature).unwrap().clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&available_features[feature]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/build_time/mod.rs:185:5 [INFO] [stderr] | [INFO] [stderr] 185 | writeln!(file, "{}", file_contents); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's keys [INFO] [stderr] --> src/build_time/mod.rs:488:26 [INFO] [stderr] | [INFO] [stderr] 488 | for (name, _) in package.summary().features() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::for_kv_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 488 | for name in package.summary().features().keys() { [INFO] [stderr] | ^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/build_time/mod.rs:508:28 [INFO] [stderr] | [INFO] [stderr] 508 | .map(|feature| available_features.get(feature).unwrap().clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&available_features[feature]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 31s [INFO] running `"docker" "inspect" "f3a7fc5a0fa31baa9827ac0488ad90d84ca26c9748eb58d1f74dfdd65f529a7e"` [INFO] running `"docker" "rm" "-f" "f3a7fc5a0fa31baa9827ac0488ad90d84ca26c9748eb58d1f74dfdd65f529a7e"` [INFO] [stdout] f3a7fc5a0fa31baa9827ac0488ad90d84ca26c9748eb58d1f74dfdd65f529a7e