[INFO] crate oysterpack_app_metadata 0.3.1 is already in cache [INFO] extracting crate oysterpack_app_metadata 0.3.1 into work/ex/clippy-test-run/sources/stable/reg/oysterpack_app_metadata/0.3.1 [INFO] extracting crate oysterpack_app_metadata 0.3.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/oysterpack_app_metadata/0.3.1 [INFO] validating manifest of oysterpack_app_metadata-0.3.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of oysterpack_app_metadata-0.3.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing oysterpack_app_metadata-0.3.1 [INFO] finished frobbing oysterpack_app_metadata-0.3.1 [INFO] frobbed toml for oysterpack_app_metadata-0.3.1 written to work/ex/clippy-test-run/sources/stable/reg/oysterpack_app_metadata/0.3.1/Cargo.toml [INFO] started frobbing oysterpack_app_metadata-0.3.1 [INFO] finished frobbing oysterpack_app_metadata-0.3.1 [INFO] frobbed toml for oysterpack_app_metadata-0.3.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/oysterpack_app_metadata/0.3.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting oysterpack_app_metadata-0.3.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/oysterpack_app_metadata/0.3.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7f536678f0e89ff60dd761749bbc0922027ceff0796089e86dab128ac186c247 [INFO] running `"docker" "start" "-a" "7f536678f0e89ff60dd761749bbc0922027ceff0796089e86dab128ac186c247"` [INFO] [stderr] Compiling dot v0.1.4 [INFO] [stderr] Checking semver v0.9.0 [INFO] [stderr] Compiling syntex_syntax v0.58.1 [INFO] [stderr] Compiling mml v0.1.41 [INFO] [stderr] Compiling oysterpack_app_metadata v0.3.1 (/opt/crater/workdir) [INFO] [stderr] error: you should consider deriving a `Default` implementation for `metadata::BuildBuilder` [INFO] [stderr] --> src/metadata/mod.rs:78:5 [INFO] [stderr] | [INFO] [stderr] 78 | / pub fn new() -> BuildBuilder { [INFO] [stderr] 79 | | BuildBuilder { [INFO] [stderr] 80 | | timestamp: None, [INFO] [stderr] 81 | | target: None, [INFO] [stderr] ... | [INFO] [stderr] 86 | | } [INFO] [stderr] 87 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:25:54 [INFO] [stderr] | [INFO] [stderr] 25 | #![deny(missing_docs, missing_debug_implementations, warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::new_without_default_derive)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 67 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: you should consider deriving a `Default` implementation for `metadata::BuildBuilder` [INFO] [stderr] --> src/metadata/mod.rs:78:5 [INFO] [stderr] | [INFO] [stderr] 78 | / pub fn new() -> BuildBuilder { [INFO] [stderr] 79 | | BuildBuilder { [INFO] [stderr] 80 | | timestamp: None, [INFO] [stderr] 81 | | target: None, [INFO] [stderr] ... | [INFO] [stderr] 86 | | } [INFO] [stderr] 87 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:25:54 [INFO] [stderr] | [INFO] [stderr] 25 | #![deny(missing_docs, missing_debug_implementations, warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::new_without_default_derive)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 67 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: single-character string constant used as pattern [INFO] [stderr] --> src/metadata/tests.rs:79:66 [INFO] [stderr] | [INFO] [stderr] 79 | .filter(|line| !line.contains("->") && line.contains("[")) [INFO] [stderr] | ^^^ help: try using a char instead: `'['` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:25:54 [INFO] [stderr] | [INFO] [stderr] 25 | #![deny(missing_docs, missing_debug_implementations, warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::single_char_pattern)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: single-character string constant used as pattern [INFO] [stderr] --> src/metadata/tests.rs:84:52 [INFO] [stderr] | [INFO] [stderr] 84 | let tokens: Vec<&str> = line.split("=").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'='` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/metadata/tests.rs:86:21 [INFO] [stderr] | [INFO] [stderr] 86 | tokens.get(0).unwrap().to_string(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&tokens[0]` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:25:54 [INFO] [stderr] | [INFO] [stderr] 25 | #![deny(missing_docs, missing_debug_implementations, warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::get_unwrap)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] error: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/metadata/tests.rs:87:44 [INFO] [stderr] | [INFO] [stderr] 87 | semver::Version::parse(tokens.get(1).unwrap()).unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&tokens[1]` [INFO] [stderr] error: Could not compile `oysterpack_app_metadata`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] error: aborting due to 5 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `oysterpack_app_metadata`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "7f536678f0e89ff60dd761749bbc0922027ceff0796089e86dab128ac186c247"` [INFO] running `"docker" "rm" "-f" "7f536678f0e89ff60dd761749bbc0922027ceff0796089e86dab128ac186c247"` [INFO] [stdout] 7f536678f0e89ff60dd761749bbc0922027ceff0796089e86dab128ac186c247