[INFO] crate oyashio 0.0.4 is already in cache [INFO] extracting crate oyashio 0.0.4 into work/ex/clippy-test-run/sources/stable/reg/oyashio/0.0.4 [INFO] extracting crate oyashio 0.0.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/oyashio/0.0.4 [INFO] validating manifest of oyashio-0.0.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of oyashio-0.0.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing oyashio-0.0.4 [INFO] finished frobbing oyashio-0.0.4 [INFO] frobbed toml for oyashio-0.0.4 written to work/ex/clippy-test-run/sources/stable/reg/oyashio/0.0.4/Cargo.toml [INFO] started frobbing oyashio-0.0.4 [INFO] finished frobbing oyashio-0.0.4 [INFO] frobbed toml for oyashio-0.0.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/oyashio/0.0.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting oyashio-0.0.4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/oyashio/0.0.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5929444dde4fcba985ac575d9e25c9f013a62a6d27f6c8c9a37f0d0361d63fbb [INFO] running `"docker" "start" "-a" "5929444dde4fcba985ac575d9e25c9f013a62a6d27f6c8c9a37f0d0361d63fbb"` [INFO] [stderr] Checking promiser v0.0.5 [INFO] [stderr] Checking oyashio v0.0.4 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:307:18 [INFO] [stderr] | [INFO] [stderr] 307 | else { [INFO] [stderr] | __________________^ [INFO] [stderr] 308 | | if self.eidx == self.streams.len() { break; } [INFO] [stderr] 309 | | } [INFO] [stderr] | |_____________^ help: try: `if self.eidx == self.streams.len() { break; }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:307:18 [INFO] [stderr] | [INFO] [stderr] 307 | else { [INFO] [stderr] | __________________^ [INFO] [stderr] 308 | | if self.eidx == self.streams.len() { break; } [INFO] [stderr] 309 | | } [INFO] [stderr] | |_____________^ help: try: `if self.eidx == self.streams.len() { break; }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | / match rv { [INFO] [stderr] 43 | | Ok(v) => {r=v}, [INFO] [stderr] 44 | | Err(_) => (), [INFO] [stderr] 45 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Ok(v) = rv {r=v}` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:96:29 [INFO] [stderr] | [INFO] [stderr] 96 | / match v { [INFO] [stderr] 97 | | &NodeKind::End => break, [INFO] [stderr] 98 | | _=> continue, [INFO] [stderr] 99 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 96 | match *v { [INFO] [stderr] 97 | NodeKind::End => break, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | / match rv { [INFO] [stderr] 43 | | Ok(v) => {r=v}, [INFO] [stderr] 44 | | Err(_) => (), [INFO] [stderr] 45 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Ok(v) = rv {r=v}` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:96:29 [INFO] [stderr] | [INFO] [stderr] 96 | / match v { [INFO] [stderr] 97 | | &NodeKind::End => break, [INFO] [stderr] 98 | | _=> continue, [INFO] [stderr] 99 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 96 | match *v { [INFO] [stderr] 97 | NodeKind::End => break, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.95s [INFO] running `"docker" "inspect" "5929444dde4fcba985ac575d9e25c9f013a62a6d27f6c8c9a37f0d0361d63fbb"` [INFO] running `"docker" "rm" "-f" "5929444dde4fcba985ac575d9e25c9f013a62a6d27f6c8c9a37f0d0361d63fbb"` [INFO] [stdout] 5929444dde4fcba985ac575d9e25c9f013a62a6d27f6c8c9a37f0d0361d63fbb