[INFO] crate oxidant 0.1.0 is already in cache
[INFO] extracting crate oxidant 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/oxidant/0.1.0
[INFO] extracting crate oxidant 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/oxidant/0.1.0
[INFO] validating manifest of oxidant-0.1.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of oxidant-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing oxidant-0.1.0
[INFO] finished frobbing oxidant-0.1.0
[INFO] frobbed toml for oxidant-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/oxidant/0.1.0/Cargo.toml
[INFO] started frobbing oxidant-0.1.0
[INFO] finished frobbing oxidant-0.1.0
[INFO] frobbed toml for oxidant-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/oxidant/0.1.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting oxidant-0.1.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/oxidant/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 4fab1c1679960904c34ecebbf5276778bccadc429d2fbfd1837f7421430530d5
[INFO] running `"docker" "start" "-a" "4fab1c1679960904c34ecebbf5276778bccadc429d2fbfd1837f7421430530d5"`
[INFO] [stderr]     Checking oxidant v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: lint name `pedantic` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore
[INFO] [stderr]  --> src/bencode/mod.rs:3:44
[INFO] [stderr]   |
[INFO] [stderr] 3 | #![cfg_attr(feature = "cargo-clippy", deny(pedantic))]
[INFO] [stderr]   |                                            ^^^^^^^^ help: change it to: `clippy::pedantic`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(renamed_and_removed_lints)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/bencode/mod.rs:139:9
[INFO] [stderr]     |
[INFO] [stderr] 139 |         return Err("tried to parse a list - not a list".to_string());
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err("tried to parse a list - not a list".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/bencode/mod.rs:239:17
[INFO] [stderr]     |
[INFO] [stderr] 239 |                 return Ok(BCObject::String(buff));
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(BCObject::String(buff))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/bencode/mod.rs:248:20
[INFO] [stderr]     |
[INFO] [stderr] 248 |             'i' => return Self::parse_integer(iter),
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Self::parse_integer(iter)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/bencode/mod.rs:249:20
[INFO] [stderr]     |
[INFO] [stderr] 249 |             'd' => return Self::parse_dictionary(iter),
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Self::parse_dictionary(iter)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/bencode/mod.rs:250:20
[INFO] [stderr]     |
[INFO] [stderr] 250 |             'l' => return Self::parse_list(iter),
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Self::parse_list(iter)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/bencode/mod.rs:251:26
[INFO] [stderr]     |
[INFO] [stderr] 251 |             '0'...'9' => return Self::parse_string(iter),
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Self::parse_string(iter)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/bencode/mod.rs:252:18
[INFO] [stderr]     |
[INFO] [stderr] 252 |             c => return Err(format!("not implemented: {}", c)),
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format!("not implemented: {}", c))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: lint name `pedantic` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore
[INFO] [stderr]  --> src/bencode/mod.rs:3:44
[INFO] [stderr]   |
[INFO] [stderr] 3 | #![cfg_attr(feature = "cargo-clippy", deny(pedantic))]
[INFO] [stderr]   |                                            ^^^^^^^^ help: change it to: `clippy::pedantic`
[INFO] [stderr] 
[INFO] [stderr] warning: lint name `pedantic` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore
[INFO] [stderr]  --> src/bencode/mod.rs:3:44
[INFO] [stderr]   |
[INFO] [stderr] 3 | #![cfg_attr(feature = "cargo-clippy", deny(pedantic))]
[INFO] [stderr]   |                                            ^^^^^^^^ help: change it to: `clippy::pedantic`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(renamed_and_removed_lints)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/bencode/mod.rs:139:9
[INFO] [stderr]     |
[INFO] [stderr] 139 |         return Err("tried to parse a list - not a list".to_string());
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err("tried to parse a list - not a list".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/bencode/mod.rs:239:17
[INFO] [stderr]     |
[INFO] [stderr] 239 |                 return Ok(BCObject::String(buff));
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(BCObject::String(buff))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/bencode/mod.rs:248:20
[INFO] [stderr]     |
[INFO] [stderr] 248 |             'i' => return Self::parse_integer(iter),
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Self::parse_integer(iter)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/bencode/mod.rs:249:20
[INFO] [stderr]     |
[INFO] [stderr] 249 |             'd' => return Self::parse_dictionary(iter),
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Self::parse_dictionary(iter)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/bencode/mod.rs:250:20
[INFO] [stderr]     |
[INFO] [stderr] 250 |             'l' => return Self::parse_list(iter),
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Self::parse_list(iter)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/bencode/mod.rs:251:26
[INFO] [stderr]     |
[INFO] [stderr] 251 |             '0'...'9' => return Self::parse_string(iter),
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Self::parse_string(iter)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/bencode/mod.rs:252:18
[INFO] [stderr]     |
[INFO] [stderr] 252 |             c => return Err(format!("not implemented: {}", c)),
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format!("not implemented: {}", c))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/bencode/mod.rs:246:17
[INFO] [stderr]     |
[INFO] [stderr] 246 |         let c = iter.peek().unwrap().clone();
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*iter.peek().unwrap()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice
[INFO] [stderr]   --> src/lib.rs:39:28
[INFO] [stderr]    |
[INFO] [stderr] 39 |         let mut iter = cmd.into_iter();
[INFO] [stderr]    |                            ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::into_iter_on_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: lint name `pedantic` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore
[INFO] [stderr]  --> src/bencode/mod.rs:3:44
[INFO] [stderr]   |
[INFO] [stderr] 3 | #![cfg_attr(feature = "cargo-clippy", deny(pedantic))]
[INFO] [stderr]   |                                            ^^^^^^^^ help: change it to: `clippy::pedantic`
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/bencode/mod.rs:246:17
[INFO] [stderr]     |
[INFO] [stderr] 246 |         let c = iter.peek().unwrap().clone();
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*iter.peek().unwrap()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice
[INFO] [stderr]   --> src/lib.rs:39:28
[INFO] [stderr]    |
[INFO] [stderr] 39 |         let mut iter = cmd.into_iter();
[INFO] [stderr]    |                            ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::into_iter_on_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.35s
[INFO] running `"docker" "inspect" "4fab1c1679960904c34ecebbf5276778bccadc429d2fbfd1837f7421430530d5"`
[INFO] running `"docker" "rm" "-f" "4fab1c1679960904c34ecebbf5276778bccadc429d2fbfd1837f7421430530d5"`
[INFO] [stdout] 4fab1c1679960904c34ecebbf5276778bccadc429d2fbfd1837f7421430530d5