[INFO] crate owasm-utils-cli 0.6.0 is already in cache [INFO] extracting crate owasm-utils-cli 0.6.0 into work/ex/clippy-test-run/sources/stable/reg/owasm-utils-cli/0.6.0 [INFO] extracting crate owasm-utils-cli 0.6.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/owasm-utils-cli/0.6.0 [INFO] validating manifest of owasm-utils-cli-0.6.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of owasm-utils-cli-0.6.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing owasm-utils-cli-0.6.0 [INFO] finished frobbing owasm-utils-cli-0.6.0 [INFO] frobbed toml for owasm-utils-cli-0.6.0 written to work/ex/clippy-test-run/sources/stable/reg/owasm-utils-cli/0.6.0/Cargo.toml [INFO] started frobbing owasm-utils-cli-0.6.0 [INFO] finished frobbing owasm-utils-cli-0.6.0 [INFO] frobbed toml for owasm-utils-cli-0.6.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/owasm-utils-cli/0.6.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting owasm-utils-cli-0.6.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/owasm-utils-cli/0.6.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 12be3bfd29c659a11df7d766b21ebbd8bf0260001392ad9383fc758d3d074d18 [INFO] running `"docker" "start" "-a" "12be3bfd29c659a11df7d766b21ebbd8bf0260001392ad9383fc758d3d074d18"` [INFO] [stderr] Checking parity-wasm v0.31.3 [INFO] [stderr] Checking owasm-utils v0.6.0 [INFO] [stderr] Checking owasm-utils-cli v0.6.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> build/source.rs:20:4 [INFO] [stderr] | [INFO] [stderr] 20 | target_dir: target_dir, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `target_dir` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> build/source.rs:21:4 [INFO] [stderr] | [INFO] [stderr] 21 | bin_name: bin_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `bin_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> build/source.rs:20:4 [INFO] [stderr] | [INFO] [stderr] 20 | target_dir: target_dir, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `target_dir` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> build/source.rs:21:4 [INFO] [stderr] | [INFO] [stderr] 21 | bin_name: bin_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `bin_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> build/main.rs:163:27 [INFO] [stderr] | [INFO] [stderr] 163 | let public_api_entries = matches.value_of("public_api") [INFO] [stderr] | ______________________________^ [INFO] [stderr] 164 | | .map(|val| val.split(",").collect()) [INFO] [stderr] 165 | | .unwrap_or(Vec::new()); [INFO] [stderr] | |______________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 163 | let public_api_entries = matches.value_of("public_api") [INFO] [stderr] 164 | .map(|val| val.split(",").collect()).unwrap_or_default(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> build/main.rs:164:24 [INFO] [stderr] | [INFO] [stderr] 164 | .map(|val| val.split(",").collect()) [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> build/main.rs:163:27 [INFO] [stderr] | [INFO] [stderr] 163 | let public_api_entries = matches.value_of("public_api") [INFO] [stderr] | ______________________________^ [INFO] [stderr] 164 | | .map(|val| val.split(",").collect()) [INFO] [stderr] 165 | | .unwrap_or(Vec::new()); [INFO] [stderr] | |______________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 163 | let public_api_entries = matches.value_of("public_api") [INFO] [stderr] 164 | .map(|val| val.split(",").collect()).unwrap_or_default(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> build/main.rs:164:24 [INFO] [stderr] | [INFO] [stderr] 164 | .map(|val| val.split(",").collect()) [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> build/main.rs:229:4 [INFO] [stderr] | [INFO] [stderr] 229 | f.write(b"\0asm").expect("write file failed"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> check/main.rs:14:25 [INFO] [stderr] | [INFO] [stderr] 14 | const ALLOWED_IMPORTS: &'static [&'static str] = &[ [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> check/main.rs:14:35 [INFO] [stderr] | [INFO] [stderr] 14 | const ALLOWED_IMPORTS: &'static [&'static str] = &[ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] error: Could not compile `owasm-utils-cli`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> check/main.rs:14:25 [INFO] [stderr] | [INFO] [stderr] 14 | const ALLOWED_IMPORTS: &'static [&'static str] = &[ [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> check/main.rs:14:35 [INFO] [stderr] | [INFO] [stderr] 14 | const ALLOWED_IMPORTS: &'static [&'static str] = &[ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "12be3bfd29c659a11df7d766b21ebbd8bf0260001392ad9383fc758d3d074d18"` [INFO] running `"docker" "rm" "-f" "12be3bfd29c659a11df7d766b21ebbd8bf0260001392ad9383fc758d3d074d18"` [INFO] [stdout] 12be3bfd29c659a11df7d766b21ebbd8bf0260001392ad9383fc758d3d074d18