[INFO] crate overbot 0.3.3 is already in cache [INFO] extracting crate overbot 0.3.3 into work/ex/clippy-test-run/sources/stable/reg/overbot/0.3.3 [INFO] extracting crate overbot 0.3.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/overbot/0.3.3 [INFO] validating manifest of overbot-0.3.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of overbot-0.3.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing overbot-0.3.3 [INFO] finished frobbing overbot-0.3.3 [INFO] frobbed toml for overbot-0.3.3 written to work/ex/clippy-test-run/sources/stable/reg/overbot/0.3.3/Cargo.toml [INFO] started frobbing overbot-0.3.3 [INFO] finished frobbing overbot-0.3.3 [INFO] frobbed toml for overbot-0.3.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/overbot/0.3.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting overbot-0.3.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/overbot/0.3.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a2fbb67c833b0abe2068b3e74a4259ac51eda57a13a636722a7e0492a9463943 [INFO] running `"docker" "start" "-a" "a2fbb67c833b0abe2068b3e74a4259ac51eda57a13a636722a7e0492a9463943"` [INFO] [stderr] Compiling structopt-derive v0.0.5 [INFO] [stderr] Checking structopt v0.0.5 [INFO] [stderr] Checking telegram-bot-types v0.1.4 [INFO] [stderr] Checking telegram-bot-types v0.2.1 [INFO] [stderr] Checking tokio-signal v0.1.5 [INFO] [stderr] Checking telegram-bot-client v0.2.1 [INFO] [stderr] Checking tokio-process v0.1.6 [INFO] [stderr] Checking overbot v0.3.3 (/opt/crater/workdir) [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/main.rs:60:16 [INFO] [stderr] | [INFO] [stderr] 60 | let text = msg.text.clone().unwrap_or(String::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `msg.text.clone().unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:108:17 [INFO] [stderr] | [INFO] [stderr] 108 | / let work; [INFO] [stderr] 109 | | if cmd.output == config::OutputType::Json { [INFO] [stderr] 110 | | let json: Result = serde_json::from_str(&out); [INFO] [stderr] 111 | | let json = match json { [INFO] [stderr] ... | [INFO] [stderr] 131 | | ); [INFO] [stderr] 132 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] help: it is more idiomatic to write [INFO] [stderr] | [INFO] [stderr] 108 | let work = if cmd.output == config::OutputType::Json { ..; bot.request::<_, serde_json::Value>("sendMessage", &json) } else { ..; bot.request::<_, serde_json::Value>( [INFO] [stderr] 109 | "sendMessage", [INFO] [stderr] 110 | &serde_json::to_value( [INFO] [stderr] 111 | types::request::Message::new(msg.chat.id, out).parse_mode( [INFO] [stderr] 112 | parse_mode, [INFO] [stderr] 113 | ), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in results.enumerate()` or similar iterators [INFO] [stderr] --> src/main.rs:230:26 [INFO] [stderr] | [INFO] [stderr] 230 | for r in results { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/main.rs:60:16 [INFO] [stderr] | [INFO] [stderr] 60 | let text = msg.text.clone().unwrap_or(String::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `msg.text.clone().unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:108:17 [INFO] [stderr] | [INFO] [stderr] 108 | / let work; [INFO] [stderr] 109 | | if cmd.output == config::OutputType::Json { [INFO] [stderr] 110 | | let json: Result = serde_json::from_str(&out); [INFO] [stderr] 111 | | let json = match json { [INFO] [stderr] ... | [INFO] [stderr] 131 | | ); [INFO] [stderr] 132 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] help: it is more idiomatic to write [INFO] [stderr] | [INFO] [stderr] 108 | let work = if cmd.output == config::OutputType::Json { ..; bot.request::<_, serde_json::Value>("sendMessage", &json) } else { ..; bot.request::<_, serde_json::Value>( [INFO] [stderr] 109 | "sendMessage", [INFO] [stderr] 110 | &serde_json::to_value( [INFO] [stderr] 111 | types::request::Message::new(msg.chat.id, out).parse_mode( [INFO] [stderr] 112 | parse_mode, [INFO] [stderr] 113 | ), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in results.enumerate()` or similar iterators [INFO] [stderr] --> src/main.rs:230:26 [INFO] [stderr] | [INFO] [stderr] 230 | for r in results { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 19.24s [INFO] running `"docker" "inspect" "a2fbb67c833b0abe2068b3e74a4259ac51eda57a13a636722a7e0492a9463943"` [INFO] running `"docker" "rm" "-f" "a2fbb67c833b0abe2068b3e74a4259ac51eda57a13a636722a7e0492a9463943"` [INFO] [stdout] a2fbb67c833b0abe2068b3e74a4259ac51eda57a13a636722a7e0492a9463943