[INFO] crate output 0.6.2 is already in cache [INFO] extracting crate output 0.6.2 into work/ex/clippy-test-run/sources/stable/reg/output/0.6.2 [INFO] extracting crate output 0.6.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/output/0.6.2 [INFO] validating manifest of output-0.6.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of output-0.6.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing output-0.6.2 [INFO] finished frobbing output-0.6.2 [INFO] frobbed toml for output-0.6.2 written to work/ex/clippy-test-run/sources/stable/reg/output/0.6.2/Cargo.toml [INFO] started frobbing output-0.6.2 [INFO] finished frobbing output-0.6.2 [INFO] frobbed toml for output-0.6.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/output/0.6.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting output-0.6.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/output/0.6.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8ce8d0fe816263f33e3dfc9f87623b1754f4d529b7afcbd5d2d0a628ce86231c [INFO] running `"docker" "start" "-a" "8ce8d0fe816263f33e3dfc9f87623b1754f4d529b7afcbd5d2d0a628ce86231c"` [INFO] [stderr] Checking output v0.6.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/console.rs:35:4 [INFO] [stderr] | [INFO] [stderr] 35 | status_tick_sequence: status_tick_sequence, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `status_tick_sequence` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/console.rs:36:4 [INFO] [stderr] | [INFO] [stderr] 36 | error_handler: error_handler, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `error_handler` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/console.rs:37:4 [INFO] [stderr] | [INFO] [stderr] 37 | columns: columns, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `columns` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/console.rs:49:3 [INFO] [stderr] | [INFO] [stderr] 49 | write! ( [INFO] [stderr] | _________^ [INFO] [stderr] 50 | | target, [INFO] [stderr] 51 | | "{}{}\r\n", [INFO] [stderr] 52 | | if message.len () <= self.columns as usize { [INFO] [stderr] ... | [INFO] [stderr] 57 | | termion::clear::AfterCursor, [INFO] [stderr] 58 | | ).unwrap (); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/console.rs:71:4 [INFO] [stderr] | [INFO] [stderr] 71 | write! ( [INFO] [stderr] | _____________^ [INFO] [stderr] 72 | | target, [INFO] [stderr] 73 | | "{} ... {}{}\r\n", [INFO] [stderr] 74 | | if message.len () <= self.columns as usize - status.len () - 5 { [INFO] [stderr] ... | [INFO] [stderr] 80 | | termion::clear::AfterCursor, [INFO] [stderr] 81 | | ).unwrap (); [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/console.rs:85:4 [INFO] [stderr] | [INFO] [stderr] 85 | write! ( [INFO] [stderr] | _____________^ [INFO] [stderr] 86 | | target, [INFO] [stderr] 87 | | "{} ...{}\r\n", [INFO] [stderr] 88 | | if message.len () <= self.columns as usize - 4 { [INFO] [stderr] ... | [INFO] [stderr] 93 | | termion::clear::AfterCursor, [INFO] [stderr] 94 | | ).unwrap (); [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/console.rs:210:5 [INFO] [stderr] | [INFO] [stderr] 210 | write! ( [INFO] [stderr] | _________________^ [INFO] [stderr] 211 | | buffer, [INFO] [stderr] 212 | | "{}\n", [INFO] [stderr] 213 | | termion::clear::CurrentLine, [INFO] [stderr] 214 | | ).unwrap (); [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/output_log.rs:39:4 [INFO] [stderr] | [INFO] [stderr] 39 | output_state: output_state, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `output_state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/output_log.rs:40:4 [INFO] [stderr] | [INFO] [stderr] 40 | log_id: log_id, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `log_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/output_log.rs:327:4 [INFO] [stderr] | [INFO] [stderr] 327 | log_id: log_id, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `log_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/output_log.rs:332:4 [INFO] [stderr] | [INFO] [stderr] 332 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/output_state.rs:36:4 [INFO] [stderr] | [INFO] [stderr] 36 | backend: backend, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `backend` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pipe.rs:18:4 [INFO] [stderr] | [INFO] [stderr] 18 | error_handler: error_handler, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `error_handler` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/pipe.rs:38:4 [INFO] [stderr] | [INFO] [stderr] 38 | write! ( [INFO] [stderr] | _____________^ [INFO] [stderr] 39 | | io::stderr (), [INFO] [stderr] 40 | | "{}\n", [INFO] [stderr] 41 | | log.message (), [INFO] [stderr] 42 | | ).unwrap_or_else ( [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rawconsole.rs:67:5 [INFO] [stderr] | [INFO] [stderr] 67 | error_handler: error_handler, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `error_handler` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rawconsole.rs:70:5 [INFO] [stderr] | [INFO] [stderr] 70 | columns: columns, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `columns` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rawconsole.rs:76:5 [INFO] [stderr] | [INFO] [stderr] 76 | status_tick_sequence: status_tick_sequence, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `status_tick_sequence` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/rawconsole.rs:137:3 [INFO] [stderr] | [INFO] [stderr] 137 | write! ( [INFO] [stderr] | _________^ [INFO] [stderr] 138 | | target, [INFO] [stderr] 139 | | "{}{}\r\n", [INFO] [stderr] 140 | | if message.len () <= self.columns as usize { [INFO] [stderr] ... | [INFO] [stderr] 145 | | termion::clear::AfterCursor, [INFO] [stderr] 146 | | ).unwrap (); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/rawconsole.rs:159:4 [INFO] [stderr] | [INFO] [stderr] 159 | write! ( [INFO] [stderr] | _____________^ [INFO] [stderr] 160 | | target, [INFO] [stderr] 161 | | "{} ... {}{}\r\n", [INFO] [stderr] 162 | | if message.len () <= self.columns as usize - status.len () - 5 { [INFO] [stderr] ... | [INFO] [stderr] 168 | | termion::clear::AfterCursor, [INFO] [stderr] 169 | | ).unwrap (); [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/rawconsole.rs:173:4 [INFO] [stderr] | [INFO] [stderr] 173 | write! ( [INFO] [stderr] | _____________^ [INFO] [stderr] 174 | | target, [INFO] [stderr] 175 | | "{} ...{}\r\n", [INFO] [stderr] 176 | | if message.len () <= self.columns as usize - 4 { [INFO] [stderr] ... | [INFO] [stderr] 181 | | termion::clear::AfterCursor, [INFO] [stderr] 182 | | ).unwrap (); [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/rawconsole.rs:298:5 [INFO] [stderr] | [INFO] [stderr] 298 | write! ( [INFO] [stderr] | _________________^ [INFO] [stderr] 299 | | buffer, [INFO] [stderr] 300 | | "{}\n", [INFO] [stderr] 301 | | termion::clear::CurrentLine, [INFO] [stderr] 302 | | ).unwrap (); [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/console.rs:35:4 [INFO] [stderr] | [INFO] [stderr] 35 | status_tick_sequence: status_tick_sequence, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `status_tick_sequence` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/console.rs:36:4 [INFO] [stderr] | [INFO] [stderr] 36 | error_handler: error_handler, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `error_handler` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/console.rs:37:4 [INFO] [stderr] | [INFO] [stderr] 37 | columns: columns, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `columns` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/console.rs:49:3 [INFO] [stderr] | [INFO] [stderr] 49 | write! ( [INFO] [stderr] | _________^ [INFO] [stderr] 50 | | target, [INFO] [stderr] 51 | | "{}{}\r\n", [INFO] [stderr] 52 | | if message.len () <= self.columns as usize { [INFO] [stderr] ... | [INFO] [stderr] 57 | | termion::clear::AfterCursor, [INFO] [stderr] 58 | | ).unwrap (); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/console.rs:71:4 [INFO] [stderr] | [INFO] [stderr] 71 | write! ( [INFO] [stderr] | _____________^ [INFO] [stderr] 72 | | target, [INFO] [stderr] 73 | | "{} ... {}{}\r\n", [INFO] [stderr] 74 | | if message.len () <= self.columns as usize - status.len () - 5 { [INFO] [stderr] ... | [INFO] [stderr] 80 | | termion::clear::AfterCursor, [INFO] [stderr] 81 | | ).unwrap (); [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/console.rs:85:4 [INFO] [stderr] | [INFO] [stderr] 85 | write! ( [INFO] [stderr] | _____________^ [INFO] [stderr] 86 | | target, [INFO] [stderr] 87 | | "{} ...{}\r\n", [INFO] [stderr] 88 | | if message.len () <= self.columns as usize - 4 { [INFO] [stderr] ... | [INFO] [stderr] 93 | | termion::clear::AfterCursor, [INFO] [stderr] 94 | | ).unwrap (); [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/console.rs:210:5 [INFO] [stderr] | [INFO] [stderr] 210 | write! ( [INFO] [stderr] | _________________^ [INFO] [stderr] 211 | | buffer, [INFO] [stderr] 212 | | "{}\n", [INFO] [stderr] 213 | | termion::clear::CurrentLine, [INFO] [stderr] 214 | | ).unwrap (); [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/output_log.rs:39:4 [INFO] [stderr] | [INFO] [stderr] 39 | output_state: output_state, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `output_state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/output_log.rs:40:4 [INFO] [stderr] | [INFO] [stderr] 40 | log_id: log_id, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `log_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/output_log.rs:327:4 [INFO] [stderr] | [INFO] [stderr] 327 | log_id: log_id, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `log_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/output_log.rs:332:4 [INFO] [stderr] | [INFO] [stderr] 332 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/output_state.rs:36:4 [INFO] [stderr] | [INFO] [stderr] 36 | backend: backend, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `backend` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pipe.rs:18:4 [INFO] [stderr] | [INFO] [stderr] 18 | error_handler: error_handler, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `error_handler` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/pipe.rs:38:4 [INFO] [stderr] | [INFO] [stderr] 38 | write! ( [INFO] [stderr] | _____________^ [INFO] [stderr] 39 | | io::stderr (), [INFO] [stderr] 40 | | "{}\n", [INFO] [stderr] 41 | | log.message (), [INFO] [stderr] 42 | | ).unwrap_or_else ( [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rawconsole.rs:67:5 [INFO] [stderr] | [INFO] [stderr] 67 | error_handler: error_handler, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `error_handler` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rawconsole.rs:70:5 [INFO] [stderr] | [INFO] [stderr] 70 | columns: columns, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `columns` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rawconsole.rs:76:5 [INFO] [stderr] | [INFO] [stderr] 76 | status_tick_sequence: status_tick_sequence, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `status_tick_sequence` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/rawconsole.rs:137:3 [INFO] [stderr] | [INFO] [stderr] 137 | write! ( [INFO] [stderr] | _________^ [INFO] [stderr] 138 | | target, [INFO] [stderr] 139 | | "{}{}\r\n", [INFO] [stderr] 140 | | if message.len () <= self.columns as usize { [INFO] [stderr] ... | [INFO] [stderr] 145 | | termion::clear::AfterCursor, [INFO] [stderr] 146 | | ).unwrap (); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/rawconsole.rs:159:4 [INFO] [stderr] | [INFO] [stderr] 159 | write! ( [INFO] [stderr] | _____________^ [INFO] [stderr] 160 | | target, [INFO] [stderr] 161 | | "{} ... {}{}\r\n", [INFO] [stderr] 162 | | if message.len () <= self.columns as usize - status.len () - 5 { [INFO] [stderr] ... | [INFO] [stderr] 168 | | termion::clear::AfterCursor, [INFO] [stderr] 169 | | ).unwrap (); [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/rawconsole.rs:173:4 [INFO] [stderr] | [INFO] [stderr] 173 | write! ( [INFO] [stderr] | _____________^ [INFO] [stderr] 174 | | target, [INFO] [stderr] 175 | | "{} ...{}\r\n", [INFO] [stderr] 176 | | if message.len () <= self.columns as usize - 4 { [INFO] [stderr] ... | [INFO] [stderr] 181 | | termion::clear::AfterCursor, [INFO] [stderr] 182 | | ).unwrap (); [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/rawconsole.rs:298:5 [INFO] [stderr] | [INFO] [stderr] 298 | write! ( [INFO] [stderr] | _________________^ [INFO] [stderr] 299 | | buffer, [INFO] [stderr] 300 | | "{}\n", [INFO] [stderr] 301 | | termion::clear::CurrentLine, [INFO] [stderr] 302 | | ).unwrap (); [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/console.rs:232:4 [INFO] [stderr] | [INFO] [stderr] 232 | |error| [INFO] [stderr] | _____________^ [INFO] [stderr] 233 | | [INFO] [stderr] 234 | | (self.error_handler) ( [INFO] [stderr] 235 | | error) [INFO] [stderr] | |______________________^ help: remove closure as shown: `(self.error_handler)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/output_log.rs:294:4 [INFO] [stderr] | [INFO] [stderr] 294 | { [INFO] [stderr] | _____________^ [INFO] [stderr] 295 | | [INFO] [stderr] 296 | | if let Some (log_internal) = [INFO] [stderr] 297 | | output_state.get_log_internal ( [INFO] [stderr] ... | [INFO] [stderr] 306 | | [INFO] [stderr] 307 | | }; [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] help: replace it with [INFO] [stderr] | [INFO] [stderr] 294 | if let Some (log_internal) = [INFO] [stderr] 295 | output_state.get_log_internal ( [INFO] [stderr] 296 | self.log_id, [INFO] [stderr] 297 | ) { [INFO] [stderr] 298 | [INFO] [stderr] 299 | if log_internal.state == OutputLogState::Running { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/output_state.rs:119:3 [INFO] [stderr] | [INFO] [stderr] 119 | self.logs.iter_mut ().filter ( [INFO] [stderr] | _________^ [INFO] [stderr] 120 | | |log_internal| [INFO] [stderr] 121 | | log_internal.log_id () == log_id [INFO] [stderr] 122 | | ).next () [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/pipe.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | |error| [INFO] [stderr] | _________________^ [INFO] [stderr] 44 | | [INFO] [stderr] 45 | | (self.error_handler) ( [INFO] [stderr] 46 | | error) [INFO] [stderr] | |__________________________^ help: remove closure as shown: `(self.error_handler)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/rawconsole.rs:62:5 [INFO] [stderr] | [INFO] [stderr] 62 | || Self::input_thread ()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Self::input_thread` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/rawconsole.rs:320:4 [INFO] [stderr] | [INFO] [stderr] 320 | |error| [INFO] [stderr] | _____________^ [INFO] [stderr] 321 | | [INFO] [stderr] 322 | | (self.error_handler) ( [INFO] [stderr] 323 | | error) [INFO] [stderr] | |______________________^ help: remove closure as shown: `(self.error_handler)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/console.rs:232:4 [INFO] [stderr] | [INFO] [stderr] 232 | |error| [INFO] [stderr] | _____________^ [INFO] [stderr] 233 | | [INFO] [stderr] 234 | | (self.error_handler) ( [INFO] [stderr] 235 | | error) [INFO] [stderr] | |______________________^ help: remove closure as shown: `(self.error_handler)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/output_log.rs:294:4 [INFO] [stderr] | [INFO] [stderr] 294 | { [INFO] [stderr] | _____________^ [INFO] [stderr] 295 | | [INFO] [stderr] 296 | | if let Some (log_internal) = [INFO] [stderr] 297 | | output_state.get_log_internal ( [INFO] [stderr] ... | [INFO] [stderr] 306 | | [INFO] [stderr] 307 | | }; [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] help: replace it with [INFO] [stderr] | [INFO] [stderr] 294 | if let Some (log_internal) = [INFO] [stderr] 295 | output_state.get_log_internal ( [INFO] [stderr] 296 | self.log_id, [INFO] [stderr] 297 | ) { [INFO] [stderr] 298 | [INFO] [stderr] 299 | if log_internal.state == OutputLogState::Running { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/output_state.rs:119:3 [INFO] [stderr] | [INFO] [stderr] 119 | self.logs.iter_mut ().filter ( [INFO] [stderr] | _________^ [INFO] [stderr] 120 | | |log_internal| [INFO] [stderr] 121 | | log_internal.log_id () == log_id [INFO] [stderr] 122 | | ).next () [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/pipe.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | |error| [INFO] [stderr] | _________________^ [INFO] [stderr] 44 | | [INFO] [stderr] 45 | | (self.error_handler) ( [INFO] [stderr] 46 | | error) [INFO] [stderr] | |__________________________^ help: remove closure as shown: `(self.error_handler)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/rawconsole.rs:62:5 [INFO] [stderr] | [INFO] [stderr] 62 | || Self::input_thread ()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Self::input_thread` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/rawconsole.rs:320:4 [INFO] [stderr] | [INFO] [stderr] 320 | |error| [INFO] [stderr] | _____________^ [INFO] [stderr] 321 | | [INFO] [stderr] 322 | | (self.error_handler) ( [INFO] [stderr] 323 | | error) [INFO] [stderr] | |______________________^ help: remove closure as shown: `(self.error_handler)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.00s [INFO] running `"docker" "inspect" "8ce8d0fe816263f33e3dfc9f87623b1754f4d529b7afcbd5d2d0a628ce86231c"` [INFO] running `"docker" "rm" "-f" "8ce8d0fe816263f33e3dfc9f87623b1754f4d529b7afcbd5d2d0a628ce86231c"` [INFO] [stdout] 8ce8d0fe816263f33e3dfc9f87623b1754f4d529b7afcbd5d2d0a628ce86231c