[INFO] crate otpauth 0.2.7 is already in cache [INFO] extracting crate otpauth 0.2.7 into work/ex/clippy-test-run/sources/stable/reg/otpauth/0.2.7 [INFO] extracting crate otpauth 0.2.7 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/otpauth/0.2.7 [INFO] validating manifest of otpauth-0.2.7 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of otpauth-0.2.7 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing otpauth-0.2.7 [INFO] finished frobbing otpauth-0.2.7 [INFO] frobbed toml for otpauth-0.2.7 written to work/ex/clippy-test-run/sources/stable/reg/otpauth/0.2.7/Cargo.toml [INFO] started frobbing otpauth-0.2.7 [INFO] finished frobbing otpauth-0.2.7 [INFO] frobbed toml for otpauth-0.2.7 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/otpauth/0.2.7/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting otpauth-0.2.7 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/otpauth/0.2.7:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3c212bfb729c342c30e887247ce01c8d0981162261833215883b0545068fdd59 [INFO] running `"docker" "start" "-a" "3c212bfb729c342c30e887247ce01c8d0981162261833215883b0545068fdd59"` [INFO] [stderr] Checking otpauth v0.2.7 (/opt/crater/workdir) [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/hotp.rs:71:18 [INFO] [stderr] | [INFO] [stderr] 71 | for i in last + 1..last + trials + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `last + 1..=last + trials` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/hotp.rs:71:18 [INFO] [stderr] | [INFO] [stderr] 71 | for i in last + 1..last + trials + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `last + 1..=last + trials` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/lib.rs:9:26 [INFO] [stderr] | [INFO] [stderr] 9 | assert!(!auth.verify(123456, 0, 100)); [INFO] [stderr] | ^^^^^^ help: consider: `123_456` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/lib.rs:10:26 [INFO] [stderr] | [INFO] [stderr] 10 | assert!(!auth.verify(1234567, 0, 100)); [INFO] [stderr] | ^^^^^^^ help: consider: `1_234_567` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/lib.rs:20:26 [INFO] [stderr] | [INFO] [stderr] 20 | assert!(!auth.verify(123456, 30, timestamp2)); [INFO] [stderr] | ^^^^^^ help: consider: `123_456` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/lib.rs:21:26 [INFO] [stderr] | [INFO] [stderr] 21 | assert!(!auth.verify(1234567, 30, timestamp2)); [INFO] [stderr] | ^^^^^^^ help: consider: `1_234_567` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.24s [INFO] running `"docker" "inspect" "3c212bfb729c342c30e887247ce01c8d0981162261833215883b0545068fdd59"` [INFO] running `"docker" "rm" "-f" "3c212bfb729c342c30e887247ce01c8d0981162261833215883b0545068fdd59"` [INFO] [stdout] 3c212bfb729c342c30e887247ce01c8d0981162261833215883b0545068fdd59