[INFO] crate otp 0.1.0 is already in cache
[INFO] extracting crate otp 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/otp/0.1.0
[INFO] extracting crate otp 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/otp/0.1.0
[INFO] validating manifest of otp-0.1.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of otp-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing otp-0.1.0
[INFO] finished frobbing otp-0.1.0
[INFO] frobbed toml for otp-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/otp/0.1.0/Cargo.toml
[INFO] started frobbing otp-0.1.0
[INFO] finished frobbing otp-0.1.0
[INFO] frobbed toml for otp-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/otp/0.1.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting otp-0.1.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/otp/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] ff8aba28aba6f25d8aa0b8b1f36246dc24ce16dcbe273620adbb842805e7f20a
[INFO] running `"docker" "start" "-a" "ff8aba28aba6f25d8aa0b8b1f36246dc24ce16dcbe273620adbb842805e7f20a"`
[INFO] [stderr]     Checking otp v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `counter`
[INFO] [stderr]   --> src/lib.rs:17:7
[INFO] [stderr]    |
[INFO] [stderr] 17 |     ( ( counter >> 0 ) & 0xff ) as u8,
[INFO] [stderr]    |       ^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_op)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/lib.rs:27:9
[INFO] [stderr]    |
[INFO] [stderr] 27 |     ( ( ( hash[dynamic_offset] as u32 ) & 0x7f ) << 24
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(hash[dynamic_offset])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/lib.rs:28:7
[INFO] [stderr]    |
[INFO] [stderr] 28 |     | ( hash[dynamic_offset+1] as u32 ) << 16
[INFO] [stderr]    |       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(hash[dynamic_offset+1])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/lib.rs:29:7
[INFO] [stderr]    |
[INFO] [stderr] 29 |     | ( hash[dynamic_offset+2] as u32 ) << 8
[INFO] [stderr]    |       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(hash[dynamic_offset+2])`
[INFO] [stderr]    |
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/lib.rs:60:30
[INFO] [stderr]    |
[INFO] [stderr] 60 |     const HOTP_TEST_SECRET: &'static[u8] = &[
[INFO] [stderr]    |                             -^^^^^^^---- help: consider removing `'static`: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/lib.rs:66:9
[INFO] [stderr]    |
[INFO] [stderr] 66 |         1284755224,
[INFO] [stderr]    |         ^^^^^^^^^^ help: consider: `1_284_755_224`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/lib.rs:67:9
[INFO] [stderr]    |
[INFO] [stderr] 67 |         1094287082,
[INFO] [stderr]    |         ^^^^^^^^^^ help: consider: `1_094_287_082`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/lib.rs:68:9
[INFO] [stderr]    |
[INFO] [stderr] 68 |         137359152,
[INFO] [stderr]    |         ^^^^^^^^^ help: consider: `137_359_152`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/lib.rs:69:9
[INFO] [stderr]    |
[INFO] [stderr] 69 |         1726969429,
[INFO] [stderr]    |         ^^^^^^^^^^ help: consider: `1_726_969_429`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/lib.rs:70:9
[INFO] [stderr]    |
[INFO] [stderr] 70 |         1640338314,
[INFO] [stderr]    |         ^^^^^^^^^^ help: consider: `1_640_338_314`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/lib.rs:71:9
[INFO] [stderr]    |
[INFO] [stderr] 71 |         868254676,
[INFO] [stderr]    |         ^^^^^^^^^ help: consider: `868_254_676`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/lib.rs:72:9
[INFO] [stderr]    |
[INFO] [stderr] 72 |         1918287922,
[INFO] [stderr]    |         ^^^^^^^^^^ help: consider: `1_918_287_922`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/lib.rs:73:9
[INFO] [stderr]    |
[INFO] [stderr] 73 |         82162583,
[INFO] [stderr]    |         ^^^^^^^^ help: consider: `82_162_583`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/lib.rs:74:9
[INFO] [stderr]    |
[INFO] [stderr] 74 |         673399871,
[INFO] [stderr]    |         ^^^^^^^^^ help: consider: `673_399_871`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/lib.rs:75:9
[INFO] [stderr]    |
[INFO] [stderr] 75 |         645520489,
[INFO] [stderr]    |         ^^^^^^^^^ help: consider: `645_520_489`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/lib.rs:30:7
[INFO] [stderr]    |
[INFO] [stderr] 30 |     | ( hash[dynamic_offset+3] as u32 )
[INFO] [stderr]    |       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(hash[dynamic_offset+3])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `counter`
[INFO] [stderr]   --> src/lib.rs:17:7
[INFO] [stderr]    |
[INFO] [stderr] 17 |     ( ( counter >> 0 ) & 0xff ) as u8,
[INFO] [stderr]    |       ^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_op)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/lib.rs:27:9
[INFO] [stderr]    |
[INFO] [stderr] 27 |     ( ( ( hash[dynamic_offset] as u32 ) & 0x7f ) << 24
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(hash[dynamic_offset])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/lib.rs:28:7
[INFO] [stderr]    |
[INFO] [stderr] 28 |     | ( hash[dynamic_offset+1] as u32 ) << 16
[INFO] [stderr]    |       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(hash[dynamic_offset+1])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/lib.rs:29:7
[INFO] [stderr]    |
[INFO] [stderr] 29 |     | ( hash[dynamic_offset+2] as u32 ) << 8
[INFO] [stderr]    |       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(hash[dynamic_offset+2])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/lib.rs:30:7
[INFO] [stderr]    |
[INFO] [stderr] 30 |     | ( hash[dynamic_offset+3] as u32 )
[INFO] [stderr]    |       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(hash[dynamic_offset+3])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `counter` is used to index `HOTP_TEST_VALUES`
[INFO] [stderr]   --> src/lib.rs:80:24
[INFO] [stderr]    |
[INFO] [stderr] 80 |         for counter in 0..10_usize {
[INFO] [stderr]    |                        ^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 80 |         for (counter, <item>) in HOTP_TEST_VALUES.iter().enumerate() {
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `counter` is used to index `HOTP_TEST_VALUES`
[INFO] [stderr]   --> src/lib.rs:90:24
[INFO] [stderr]    |
[INFO] [stderr] 90 |         for counter in 0..10_usize {
[INFO] [stderr]    |                        ^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 90 |         for (counter, <item>) in HOTP_TEST_VALUES.iter().enumerate() {
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `counter` is used to index `HOTP_TEST_VALUES`
[INFO] [stderr]   --> src/lib.rs:99:23
[INFO] [stderr]    |
[INFO] [stderr] 99 |        for counter in 0..10_usize {
[INFO] [stderr]    |                       ^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 99 |        for (counter, <item>) in HOTP_TEST_VALUES.iter().enumerate() {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `counter` is used to index `HOTP_TEST_VALUES`
[INFO] [stderr]    --> src/lib.rs:111:24
[INFO] [stderr]     |
[INFO] [stderr] 111 |         for counter in 0..10_usize {
[INFO] [stderr]     |                        ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 111 |         for (counter, <item>) in HOTP_TEST_VALUES.iter().enumerate() {
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.94s
[INFO] running `"docker" "inspect" "ff8aba28aba6f25d8aa0b8b1f36246dc24ce16dcbe273620adbb842805e7f20a"`
[INFO] running `"docker" "rm" "-f" "ff8aba28aba6f25d8aa0b8b1f36246dc24ce16dcbe273620adbb842805e7f20a"`
[INFO] [stdout] ff8aba28aba6f25d8aa0b8b1f36246dc24ce16dcbe273620adbb842805e7f20a