[INFO] crate osuparse 0.1.1 is already in cache [INFO] extracting crate osuparse 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/osuparse/0.1.1 [INFO] extracting crate osuparse 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/osuparse/0.1.1 [INFO] validating manifest of osuparse-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of osuparse-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing osuparse-0.1.1 [INFO] finished frobbing osuparse-0.1.1 [INFO] frobbed toml for osuparse-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/osuparse/0.1.1/Cargo.toml [INFO] started frobbing osuparse-0.1.1 [INFO] finished frobbing osuparse-0.1.1 [INFO] frobbed toml for osuparse-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/osuparse/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting osuparse-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/osuparse/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] dc2f061aca891fa547a7b82f10e13356bae9be8f18e76923eabcaf01ea5f6a6e [INFO] running `"docker" "start" "-a" "dc2f061aca891fa547a7b82f10e13356bae9be8f18e76923eabcaf01ea5f6a6e"` [INFO] [stderr] Checking osuparse v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:603:46 [INFO] [stderr] | [INFO] [stderr] 603 | assert_eq!(map.general.preview_time, 239594); [INFO] [stderr] | ^^^^^^ help: consider: `239_594` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parse.rs:146:28 [INFO] [stderr] | [INFO] [stderr] 146 | let mut iter = s.split(","); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parse.rs:175:25 [INFO] [stderr] | [INFO] [stderr] 175 | let mut iter = s.split(":"); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parse.rs:180:25 [INFO] [stderr] | [INFO] [stderr] 180 | let mut iter = s.split("|"); [INFO] [stderr] | ^^^ help: try using a char instead: `'|'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parse.rs:190:25 [INFO] [stderr] | [INFO] [stderr] 190 | let mut iter = s.split(","); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `default` [INFO] [stderr] --> src/parse.rs:206:21 [INFO] [stderr] | [INFO] [stderr] 206 | extras: read_val!(iter, parse_extras) [INFO] [stderr] | _____________________^ [INFO] [stderr] 207 | | .unwrap_or(Default::default()), [INFO] [stderr] | |______________________________________________^ help: try this: `$iter.next().ok_or(Error::Parse).and_then($func).unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/parse.rs:219:21 [INFO] [stderr] | [INFO] [stderr] 219 | edge_hitsounds: read_list!("|", iter, parse_num) [INFO] [stderr] | _________________________________^ [INFO] [stderr] 220 | | .unwrap_or(Vec::new()), [INFO] [stderr] | |__________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 219 | edge_hitsounds: $iter.next().ok_or(Error::Parse) [INFO] [stderr] 220 | .and_then(|s| s.split($sep).map($func).collect()).unwrap_or_default(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/parse.rs:222:21 [INFO] [stderr] | [INFO] [stderr] 222 | edge_additions: read_list!("|", iter, parse_coord) [INFO] [stderr] | _________________________________^ [INFO] [stderr] 223 | | .unwrap_or(Vec::new()), [INFO] [stderr] | |__________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 222 | edge_additions: $iter.next().ok_or(Error::Parse) [INFO] [stderr] 223 | .and_then(|s| s.split($sep).map($func).collect()).unwrap_or_default(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `default` [INFO] [stderr] --> src/parse.rs:225:13 [INFO] [stderr] | [INFO] [stderr] 225 | extras: read_val!(iter, parse_extras) [INFO] [stderr] | _________________________^ [INFO] [stderr] 226 | | .unwrap_or(Default::default()), [INFO] [stderr] | |__________________________________________________^ help: try this: `$iter.next().ok_or(Error::Parse).and_then($func).unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `default` [INFO] [stderr] --> src/parse.rs:235:21 [INFO] [stderr] | [INFO] [stderr] 235 | extras: read_val!(iter, parse_extras) [INFO] [stderr] | _____________________^ [INFO] [stderr] 236 | | .unwrap_or(Default::default()), [INFO] [stderr] | |______________________________________________^ help: try this: `$iter.next().ok_or(Error::Parse).and_then($func).unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `default` [INFO] [stderr] --> src/parse.rs:244:21 [INFO] [stderr] | [INFO] [stderr] 244 | extras: read_val!(iter, parse_extras) [INFO] [stderr] | _____________________^ [INFO] [stderr] 245 | | .unwrap_or(Default::default()), [INFO] [stderr] | |______________________________________________^ help: try this: `$iter.next().ok_or(Error::Parse).and_then($func).unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:379:48 [INFO] [stderr] | [INFO] [stderr] 379 | parse_timing_points(state).map(|s| Section::TimingPoints(s)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Section::TimingPoints` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:381:49 [INFO] [stderr] | [INFO] [stderr] 381 | "HitObjects" => parse_hit_objects(state).map(|s| Section::HitObjects(s)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Section::HitObjects` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:383:51 [INFO] [stderr] | [INFO] [stderr] 383 | "Colours" => parse_colours(state).map(|s| Section::Colours(s)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Section::Colours` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parse.rs:146:28 [INFO] [stderr] | [INFO] [stderr] 146 | let mut iter = s.split(","); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parse.rs:175:25 [INFO] [stderr] | [INFO] [stderr] 175 | let mut iter = s.split(":"); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parse.rs:180:25 [INFO] [stderr] | [INFO] [stderr] 180 | let mut iter = s.split("|"); [INFO] [stderr] | ^^^ help: try using a char instead: `'|'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parse.rs:190:25 [INFO] [stderr] | [INFO] [stderr] 190 | let mut iter = s.split(","); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `default` [INFO] [stderr] --> src/parse.rs:206:21 [INFO] [stderr] | [INFO] [stderr] 206 | extras: read_val!(iter, parse_extras) [INFO] [stderr] | _____________________^ [INFO] [stderr] 207 | | .unwrap_or(Default::default()), [INFO] [stderr] | |______________________________________________^ help: try this: `$iter.next().ok_or(Error::Parse).and_then($func).unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/parse.rs:219:21 [INFO] [stderr] | [INFO] [stderr] 219 | edge_hitsounds: read_list!("|", iter, parse_num) [INFO] [stderr] | _________________________________^ [INFO] [stderr] 220 | | .unwrap_or(Vec::new()), [INFO] [stderr] | |__________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 219 | edge_hitsounds: $iter.next().ok_or(Error::Parse) [INFO] [stderr] 220 | .and_then(|s| s.split($sep).map($func).collect()).unwrap_or_default(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/parse.rs:222:21 [INFO] [stderr] | [INFO] [stderr] 222 | edge_additions: read_list!("|", iter, parse_coord) [INFO] [stderr] | _________________________________^ [INFO] [stderr] 223 | | .unwrap_or(Vec::new()), [INFO] [stderr] | |__________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 222 | edge_additions: $iter.next().ok_or(Error::Parse) [INFO] [stderr] 223 | .and_then(|s| s.split($sep).map($func).collect()).unwrap_or_default(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `default` [INFO] [stderr] --> src/parse.rs:225:13 [INFO] [stderr] | [INFO] [stderr] 225 | extras: read_val!(iter, parse_extras) [INFO] [stderr] | _________________________^ [INFO] [stderr] 226 | | .unwrap_or(Default::default()), [INFO] [stderr] | |__________________________________________________^ help: try this: `$iter.next().ok_or(Error::Parse).and_then($func).unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `default` [INFO] [stderr] --> src/parse.rs:235:21 [INFO] [stderr] | [INFO] [stderr] 235 | extras: read_val!(iter, parse_extras) [INFO] [stderr] | _____________________^ [INFO] [stderr] 236 | | .unwrap_or(Default::default()), [INFO] [stderr] | |______________________________________________^ help: try this: `$iter.next().ok_or(Error::Parse).and_then($func).unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `default` [INFO] [stderr] --> src/parse.rs:244:21 [INFO] [stderr] | [INFO] [stderr] 244 | extras: read_val!(iter, parse_extras) [INFO] [stderr] | _____________________^ [INFO] [stderr] 245 | | .unwrap_or(Default::default()), [INFO] [stderr] | |______________________________________________^ help: try this: `$iter.next().ok_or(Error::Parse).and_then($func).unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:379:48 [INFO] [stderr] | [INFO] [stderr] 379 | parse_timing_points(state).map(|s| Section::TimingPoints(s)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Section::TimingPoints` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:381:49 [INFO] [stderr] | [INFO] [stderr] 381 | "HitObjects" => parse_hit_objects(state).map(|s| Section::HitObjects(s)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Section::HitObjects` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:383:51 [INFO] [stderr] | [INFO] [stderr] 383 | "Colours" => parse_colours(state).map(|s| Section::Colours(s)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Section::Colours` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:604:9 [INFO] [stderr] | [INFO] [stderr] 604 | assert_eq!(map.general.stack_leniency, 0.7); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:604:9 [INFO] [stderr] | [INFO] [stderr] 604 | assert_eq!(map.general.stack_leniency, 0.7); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `osuparse`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "dc2f061aca891fa547a7b82f10e13356bae9be8f18e76923eabcaf01ea5f6a6e"` [INFO] running `"docker" "rm" "-f" "dc2f061aca891fa547a7b82f10e13356bae9be8f18e76923eabcaf01ea5f6a6e"` [INFO] [stdout] dc2f061aca891fa547a7b82f10e13356bae9be8f18e76923eabcaf01ea5f6a6e