[INFO] crate oss-rust-sdk 0.1.1 is already in cache
[INFO] extracting crate oss-rust-sdk 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/oss-rust-sdk/0.1.1
[INFO] extracting crate oss-rust-sdk 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/oss-rust-sdk/0.1.1
[INFO] validating manifest of oss-rust-sdk-0.1.1 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of oss-rust-sdk-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing oss-rust-sdk-0.1.1
[INFO] finished frobbing oss-rust-sdk-0.1.1
[INFO] frobbed toml for oss-rust-sdk-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/oss-rust-sdk/0.1.1/Cargo.toml
[INFO] started frobbing oss-rust-sdk-0.1.1
[INFO] finished frobbing oss-rust-sdk-0.1.1
[INFO] frobbed toml for oss-rust-sdk-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/oss-rust-sdk/0.1.1/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting oss-rust-sdk-0.1.1 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/oss-rust-sdk/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 62f1a11b252a600f0fc6b99446351bbfeca4d0759a57c5af9fdfbda10369c14a
[INFO] running `"docker" "start" "-a" "62f1a11b252a600f0fc6b99446351bbfeca4d0759a57c5af9fdfbda10369c14a"`
[INFO] [stderr]     Checking reqwest v0.9.9
[INFO] [stderr]     Checking oss-rust-sdk v0.1.1 (/opt/crater/workdir)
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/oss.rs:65:3
[INFO] [stderr]    |
[INFO] [stderr] 65 |         host
[INFO] [stderr]    |         ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/oss.rs:60:14
[INFO] [stderr]    |
[INFO] [stderr] 60 |           let host = if self.endpoint.starts_with("https") {
[INFO] [stderr]    |  ____________________^
[INFO] [stderr] 61 | |             format!("https://{}.{}/{}?{}", bucket, self.endpoint.replacen("https://", "", 1),object, resources_str)
[INFO] [stderr] 62 | |         } else {
[INFO] [stderr] 63 | |             format!("http://{}.{}/{}?{}", bucket, self.endpoint.replacen("http://", "", 1), object, resources_str)
[INFO] [stderr] 64 | |         };
[INFO] [stderr]    | |_________^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/oss.rs:65:3
[INFO] [stderr]    |
[INFO] [stderr] 65 |         host
[INFO] [stderr]    |         ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/oss.rs:60:14
[INFO] [stderr]    |
[INFO] [stderr] 60 |           let host = if self.endpoint.starts_with("https") {
[INFO] [stderr]    |  ____________________^
[INFO] [stderr] 61 | |             format!("https://{}.{}/{}?{}", bucket, self.endpoint.replacen("https://", "", 1),object, resources_str)
[INFO] [stderr] 62 | |         } else {
[INFO] [stderr] 63 | |             format!("http://{}.{}/{}?{}", bucket, self.endpoint.replacen("http://", "", 1), object, resources_str)
[INFO] [stderr] 64 | |         };
[INFO] [stderr]    | |_________^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/oss.rs:78:7
[INFO] [stderr]    |
[INFO] [stderr] 78 |             if result.len() > 0 {
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!result.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against true are unnecessary
[INFO] [stderr]   --> src/service.rs:45:9
[INFO] [stderr]    |
[INFO] [stderr] 45 |                     if flag == true {
[INFO] [stderr]    |                        ^^^^^^^^^^^^ help: try simplifying it as shown: `flag`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::bool_comparison)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: this function has too many arguments (8/7)
[INFO] [stderr]   --> src/auth.rs:12:2
[INFO] [stderr]    |
[INFO] [stderr] 12 |     fn oss_sign(&self, verb: &str, key_id: &str, key_secret: &str, bucket: &str, object: &str, oss_resources: &str, headers: &HeaderMap) -> String;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::too_many_arguments)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new`
[INFO] [stderr]   --> src/auth.rs:19:21
[INFO] [stderr]    |
[INFO] [stderr] 19 |         let content_md5 = headers.get("Content-MD5").and_then(|md5| Some(encode(md5.to_str().unwrap_or("")))).unwrap_or(String::new());
[INFO] [stderr]    |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `headers.get("Content-MD5").and_then(|md5| Some(encode(md5.to_str().unwrap_or("")))).unwrap_or_default()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/oss.rs:78:7
[INFO] [stderr]    |
[INFO] [stderr] 78 |             if result.len() > 0 {
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!result.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against true are unnecessary
[INFO] [stderr]   --> src/service.rs:45:9
[INFO] [stderr]    |
[INFO] [stderr] 45 |                     if flag == true {
[INFO] [stderr]    |                        ^^^^^^^^^^^^ help: try simplifying it as shown: `flag`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::bool_comparison)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: this function has too many arguments (8/7)
[INFO] [stderr]   --> src/auth.rs:12:2
[INFO] [stderr]    |
[INFO] [stderr] 12 |     fn oss_sign(&self, verb: &str, key_id: &str, key_secret: &str, bucket: &str, object: &str, oss_resources: &str, headers: &HeaderMap) -> String;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::too_many_arguments)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new`
[INFO] [stderr]   --> src/auth.rs:19:21
[INFO] [stderr]    |
[INFO] [stderr] 19 |         let content_md5 = headers.get("Content-MD5").and_then(|md5| Some(encode(md5.to_str().unwrap_or("")))).unwrap_or(String::new());
[INFO] [stderr]    |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `headers.get("Content-MD5").and_then(|md5| Some(encode(md5.to_str().unwrap_or("")))).unwrap_or_default()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 19.42s
[INFO] running `"docker" "inspect" "62f1a11b252a600f0fc6b99446351bbfeca4d0759a57c5af9fdfbda10369c14a"`
[INFO] running `"docker" "rm" "-f" "62f1a11b252a600f0fc6b99446351bbfeca4d0759a57c5af9fdfbda10369c14a"`
[INFO] [stdout] 62f1a11b252a600f0fc6b99446351bbfeca4d0759a57c5af9fdfbda10369c14a