[INFO] crate osmpbf 0.1.11 is already in cache [INFO] extracting crate osmpbf 0.1.11 into work/ex/clippy-test-run/sources/stable/reg/osmpbf/0.1.11 [INFO] extracting crate osmpbf 0.1.11 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/osmpbf/0.1.11 [INFO] validating manifest of osmpbf-0.1.11 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of osmpbf-0.1.11 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing osmpbf-0.1.11 [INFO] finished frobbing osmpbf-0.1.11 [INFO] frobbed toml for osmpbf-0.1.11 written to work/ex/clippy-test-run/sources/stable/reg/osmpbf/0.1.11/Cargo.toml [INFO] started frobbing osmpbf-0.1.11 [INFO] finished frobbing osmpbf-0.1.11 [INFO] frobbed toml for osmpbf-0.1.11 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/osmpbf/0.1.11/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting osmpbf-0.1.11 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/osmpbf/0.1.11:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b60cb24e5419cc0ec08a4906ae5310ca063e60dd7a85deabb461a3e58d5c7182 [INFO] running `"docker" "start" "-a" "b60cb24e5419cc0ec08a4906ae5310ca063e60dd7a85deabb461a3e58d5c7182"` [INFO] [stderr] Checking osmpbf v0.1.11 (/opt/crater/workdir) [INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/proto/fileformat.rs:6:10 [INFO] [stderr] | [INFO] [stderr] 6 | #![allow(clippy)] [INFO] [stderr] | ^^^^^^ help: change it to: `clippy::all` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/proto/osmformat.rs:6:10 [INFO] [stderr] | [INFO] [stderr] 6 | #![allow(clippy)] [INFO] [stderr] | ^^^^^^ help: change it to: `clippy::all` [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/proto/fileformat.rs:6:10 [INFO] [stderr] | [INFO] [stderr] 6 | #![allow(clippy)] [INFO] [stderr] | ^^^^^^ help: change it to: `clippy::all` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/proto/osmformat.rs:6:10 [INFO] [stderr] | [INFO] [stderr] 6 | #![allow(clippy)] [INFO] [stderr] | ^^^^^^ help: change it to: `clippy::all` [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/proto/fileformat.rs:6:10 [INFO] [stderr] | [INFO] [stderr] 6 | #![allow(clippy)] [INFO] [stderr] | ^^^^^^ help: change it to: `clippy::all` [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/proto/fileformat.rs:6:10 [INFO] [stderr] | [INFO] [stderr] 6 | #![allow(clippy)] [INFO] [stderr] | ^^^^^^ help: change it to: `clippy::all` [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/reader.rs:134:47 [INFO] [stderr] | [INFO] [stderr] 134 | .fold(identity(), |a, b| reduce_op(a, b))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `reduce_op` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/reader.rs:133:34 [INFO] [stderr] | [INFO] [stderr] 133 | .map(|e| map_op(e)) [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove closure as shown: `map_op` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/block.rs:156:27 [INFO] [stderr] | [INFO] [stderr] 156 | fn step(&mut self) -> Option>> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_option)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/reader.rs:134:47 [INFO] [stderr] | [INFO] [stderr] 134 | .fold(identity(), |a, b| reduce_op(a, b))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `reduce_op` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/reader.rs:133:34 [INFO] [stderr] | [INFO] [stderr] 133 | .map(|e| map_op(e)) [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove closure as shown: `map_op` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/block.rs:156:27 [INFO] [stderr] | [INFO] [stderr] 156 | fn step(&mut self) -> Option>> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_option)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/read.rs:31:43 [INFO] [stderr] | [INFO] [stderr] 31 | assert!(approx_eq(nodes[1].lat(), 52.11992359584)); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `52.119_923_595_84` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/read.rs:32:43 [INFO] [stderr] | [INFO] [stderr] 32 | assert!(approx_eq(nodes[1].lon(), 11.62564468943)); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `11.625_644_689_43` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/read.rs:34:43 [INFO] [stderr] | [INFO] [stderr] 34 | assert!(approx_eq(nodes[2].lat(), 52.11989910567)); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `52.119_899_105_67` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/read.rs:35:43 [INFO] [stderr] | [INFO] [stderr] 35 | assert!(approx_eq(nodes[2].lon(), 11.63101926915)); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `11.631_019_269_15` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/read.rs:50:49 [INFO] [stderr] | [INFO] [stderr] 50 | assert!(approx_eq(dense_nodes[1].lat(), 52.11992359584)); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `52.119_923_595_84` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/read.rs:51:49 [INFO] [stderr] | [INFO] [stderr] 51 | assert!(approx_eq(dense_nodes[1].lon(), 11.62564468943)); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `11.625_644_689_43` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/read.rs:53:49 [INFO] [stderr] | [INFO] [stderr] 53 | assert!(approx_eq(dense_nodes[2].lat(), 52.11989910567)); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `52.119_899_105_67` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/read.rs:54:49 [INFO] [stderr] | [INFO] [stderr] 54 | assert!(approx_eq(dense_nodes[2].lon(), 11.63101926915)); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `11.631_019_269_15` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 34 [INFO] [stderr] --> tests/read.rs:26:1 [INFO] [stderr] | [INFO] [stderr] 26 | / fn check_primitive_block_content(block: &PrimitiveBlock) { [INFO] [stderr] 27 | | let nodes: Vec<_> = block.groups().flat_map(|g| g.nodes()).collect(); [INFO] [stderr] 28 | | if !nodes.is_empty() { [INFO] [stderr] 29 | | assert_eq!(nodes.len(), 3); [INFO] [stderr] ... | [INFO] [stderr] 87 | | } [INFO] [stderr] 88 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 8.80s [INFO] running `"docker" "inspect" "b60cb24e5419cc0ec08a4906ae5310ca063e60dd7a85deabb461a3e58d5c7182"` [INFO] running `"docker" "rm" "-f" "b60cb24e5419cc0ec08a4906ae5310ca063e60dd7a85deabb461a3e58d5c7182"` [INFO] [stdout] b60cb24e5419cc0ec08a4906ae5310ca063e60dd7a85deabb461a3e58d5c7182