[INFO] crate osm_pbf_iter 0.1.0 is already in cache [INFO] extracting crate osm_pbf_iter 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/osm_pbf_iter/0.1.0 [INFO] extracting crate osm_pbf_iter 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/osm_pbf_iter/0.1.0 [INFO] validating manifest of osm_pbf_iter-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of osm_pbf_iter-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing osm_pbf_iter-0.1.0 [INFO] finished frobbing osm_pbf_iter-0.1.0 [INFO] frobbed toml for osm_pbf_iter-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/osm_pbf_iter/0.1.0/Cargo.toml [INFO] started frobbing osm_pbf_iter-0.1.0 [INFO] finished frobbing osm_pbf_iter-0.1.0 [INFO] frobbed toml for osm_pbf_iter-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/osm_pbf_iter/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting osm_pbf_iter-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/osm_pbf_iter/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ea09c7be68bc811dc1349a411ede40c9ceaa6a178336023f93a478e03d1b11bd [INFO] running `"docker" "start" "-a" "ea09c7be68bc811dc1349a411ede40c9ceaa6a178336023f93a478e03d1b11bd"` [INFO] [stderr] Checking num_cpus v1.2.1 [INFO] [stderr] Checking protobuf_iter v0.1.1 [INFO] [stderr] Checking osm_pbf_iter v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse/node.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse/node.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | lat: lat, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `lat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse/node.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | lon: lon, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `lon` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse/node.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | info: info, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse/tags.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | stringtable: stringtable, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `stringtable` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse/dense_nodes.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | primitive_block: primitive_block, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `primitive_block` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse/dense_nodes.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | info: info, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse/dense_nodes.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | tags: tags, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse/dense_info.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | primitive_block: primitive_block, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `primitive_block` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse/node.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse/node.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | lat: lat, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `lat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse/node.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | lon: lon, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `lon` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse/node.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | info: info, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse/tags.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | stringtable: stringtable, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `stringtable` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse/dense_nodes.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | primitive_block: primitive_block, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `primitive_block` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse/dense_nodes.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | info: info, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse/dense_nodes.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | tags: tags, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse/dense_info.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | primitive_block: primitive_block, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `primitive_block` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parse/primitive_block.rs:108:37 [INFO] [stderr] | [INFO] [stderr] 108 | None => return None [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parse/primitive_block.rs:108:37 [INFO] [stderr] | [INFO] [stderr] 108 | None => return None [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/parse/tags.rs:34:41 [INFO] [stderr] | [INFO] [stderr] 34 | opt_iter.as_mut().and_then(|mut iter| iter.next()); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/blob_reader.rs:20:21 [INFO] [stderr] | [INFO] [stderr] 20 | pub fn to_inner(self) -> R { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/parse/primitive_block.rs:56:35 [INFO] [stderr] | [INFO] [stderr] 56 | NANO * (self.lat_offset + self.granularity as i64 * lat) as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.granularity)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/parse/primitive_block.rs:60:35 [INFO] [stderr] | [INFO] [stderr] 60 | NANO * (self.lon_offset + self.granularity as i64 * lon) as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.granularity)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/parse/dense_nodes.rs:78:9 [INFO] [stderr] | [INFO] [stderr] 78 | / loop { [INFO] [stderr] 79 | | let k = match keys_vals.next() { [INFO] [stderr] 80 | | Some(k) => [INFO] [stderr] 81 | | self.primitive_block.stringtable[k as usize], [INFO] [stderr] ... | [INFO] [stderr] 89 | | tags.push((k, v)); [INFO] [stderr] 90 | | } [INFO] [stderr] | |_________^ help: try: `while let Some(k) = keys_vals.next() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/parse/tags.rs:34:41 [INFO] [stderr] | [INFO] [stderr] 34 | opt_iter.as_mut().and_then(|mut iter| iter.next()); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/blob_reader.rs:20:21 [INFO] [stderr] | [INFO] [stderr] 20 | pub fn to_inner(self) -> R { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/parse/primitive_block.rs:56:35 [INFO] [stderr] | [INFO] [stderr] 56 | NANO * (self.lat_offset + self.granularity as i64 * lat) as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.granularity)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/parse/primitive_block.rs:60:35 [INFO] [stderr] | [INFO] [stderr] 60 | NANO * (self.lon_offset + self.granularity as i64 * lon) as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.granularity)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/parse/dense_nodes.rs:78:9 [INFO] [stderr] | [INFO] [stderr] 78 | / loop { [INFO] [stderr] 79 | | let k = match keys_vals.next() { [INFO] [stderr] 80 | | Some(k) => [INFO] [stderr] 81 | | self.primitive_block.stringtable[k as usize], [INFO] [stderr] ... | [INFO] [stderr] 89 | | tags.push((k, v)); [INFO] [stderr] 90 | | } [INFO] [stderr] | |_________^ help: try: `while let Some(k) = keys_vals.next() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/bin/count.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | / loop { [INFO] [stderr] 19 | | let blob = match req_rx.recv() { [INFO] [stderr] 20 | | Ok(blob) => blob, [INFO] [stderr] 21 | | Err(_) => break, [INFO] [stderr] ... | [INFO] [stderr] 35 | | } [INFO] [stderr] 36 | | } [INFO] [stderr] | |_____^ help: try: `while let Ok(blob) = req_rx.recv() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/bin/count.rs:79:53 [INFO] [stderr] | [INFO] [stderr] 79 | let duration = duration.as_secs() as f64 + (duration.subsec_nanos() as f64 / 1e9); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(duration.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/bin/count.rs:81:9 [INFO] [stderr] | [INFO] [stderr] 81 | / match f.seek(SeekFrom::Current(0)) { [INFO] [stderr] 82 | | Ok(pos) => { [INFO] [stderr] 83 | | let rate = pos as f64 / 1024f64 / 1024f64 / duration; [INFO] [stderr] 84 | | println!("Processed {} MB in {:.2} seconds ({:.2} MB/s)", [INFO] [stderr] ... | [INFO] [stderr] 87 | | Err(_) => (), [INFO] [stderr] 88 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 81 | if let Ok(pos) = f.seek(SeekFrom::Current(0)) { [INFO] [stderr] 82 | let rate = pos as f64 / 1024f64 / 1024f64 / duration; [INFO] [stderr] 83 | println!("Processed {} MB in {:.2} seconds ({:.2} MB/s)", [INFO] [stderr] 84 | pos / 1024 / 1024, duration, rate); [INFO] [stderr] 85 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/bin/count.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | / loop { [INFO] [stderr] 19 | | let blob = match req_rx.recv() { [INFO] [stderr] 20 | | Ok(blob) => blob, [INFO] [stderr] 21 | | Err(_) => break, [INFO] [stderr] ... | [INFO] [stderr] 35 | | } [INFO] [stderr] 36 | | } [INFO] [stderr] | |_____^ help: try: `while let Ok(blob) = req_rx.recv() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/bin/count.rs:79:53 [INFO] [stderr] | [INFO] [stderr] 79 | let duration = duration.as_secs() as f64 + (duration.subsec_nanos() as f64 / 1e9); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(duration.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/bin/count.rs:81:9 [INFO] [stderr] | [INFO] [stderr] 81 | / match f.seek(SeekFrom::Current(0)) { [INFO] [stderr] 82 | | Ok(pos) => { [INFO] [stderr] 83 | | let rate = pos as f64 / 1024f64 / 1024f64 / duration; [INFO] [stderr] 84 | | println!("Processed {} MB in {:.2} seconds ({:.2} MB/s)", [INFO] [stderr] ... | [INFO] [stderr] 87 | | Err(_) => (), [INFO] [stderr] 88 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 81 | if let Ok(pos) = f.seek(SeekFrom::Current(0)) { [INFO] [stderr] 82 | let rate = pos as f64 / 1024f64 / 1024f64 / duration; [INFO] [stderr] 83 | println!("Processed {} MB in {:.2} seconds ({:.2} MB/s)", [INFO] [stderr] 84 | pos / 1024 / 1024, duration, rate); [INFO] [stderr] 85 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.49s [INFO] running `"docker" "inspect" "ea09c7be68bc811dc1349a411ede40c9ceaa6a178336023f93a478e03d1b11bd"` [INFO] running `"docker" "rm" "-f" "ea09c7be68bc811dc1349a411ede40c9ceaa6a178336023f93a478e03d1b11bd"` [INFO] [stdout] ea09c7be68bc811dc1349a411ede40c9ceaa6a178336023f93a478e03d1b11bd