[INFO] crate osm_boundaries_utils 0.2.2 is already in cache [INFO] extracting crate osm_boundaries_utils 0.2.2 into work/ex/clippy-test-run/sources/stable/reg/osm_boundaries_utils/0.2.2 [INFO] extracting crate osm_boundaries_utils 0.2.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/osm_boundaries_utils/0.2.2 [INFO] validating manifest of osm_boundaries_utils-0.2.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of osm_boundaries_utils-0.2.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing osm_boundaries_utils-0.2.2 [INFO] finished frobbing osm_boundaries_utils-0.2.2 [INFO] frobbed toml for osm_boundaries_utils-0.2.2 written to work/ex/clippy-test-run/sources/stable/reg/osm_boundaries_utils/0.2.2/Cargo.toml [INFO] started frobbing osm_boundaries_utils-0.2.2 [INFO] finished frobbing osm_boundaries_utils-0.2.2 [INFO] frobbed toml for osm_boundaries_utils-0.2.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/osm_boundaries_utils/0.2.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting osm_boundaries_utils-0.2.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/osm_boundaries_utils/0.2.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e0f65e777529a11cdc52ff032a09aef863ad280682cf59cd493f6e77afc3b380 [INFO] running `"docker" "start" "-a" "e0f65e777529a11cdc52ff032a09aef863ad280682cf59cd493f6e77afc3b380"` [INFO] [stderr] Checking pub-iterator-type v0.1.1 [INFO] [stderr] Checking stable_deref_trait v1.1.1 [INFO] [stderr] Compiling syn v0.11.11 [INFO] [stderr] Checking flat_map v0.0.7 [INFO] [stderr] Checking geo v0.6.3 [INFO] [stderr] Checking par-map v0.1.4 [INFO] [stderr] Compiling rental-impl v0.4.15 [INFO] [stderr] Checking rental v0.4.16 [INFO] [stderr] Checking osmpbfreader v0.11.2 [INFO] [stderr] Checking osm_boundaries_utils v0.2.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/boundaries.rs:18:24 [INFO] [stderr] | [INFO] [stderr] 18 | BoundaryPart { nodes: nodes } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `nodes` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/osm_builder.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/osm_builder.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/osm_builder.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | nodes: nodes, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `nodes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/osm_builder.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/boundaries.rs:18:24 [INFO] [stderr] | [INFO] [stderr] 18 | BoundaryPart { nodes: nodes } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `nodes` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/osm_builder.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/osm_builder.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/osm_builder.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | nodes: nodes, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `nodes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/osm_builder.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/boundaries.rs:111:9 [INFO] [stderr] | [INFO] [stderr] 111 | / inner_polys.map(|inners| { [INFO] [stderr] 112 | | inners.into_iter().for_each(|inner| { [INFO] [stderr] 113 | | /* [INFO] [stderr] 114 | | It's assumed here that the 'inner' ring is contained into [INFO] [stderr] ... | [INFO] [stderr] 130 | | }) [INFO] [stderr] 131 | | }); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 111 | if let Some(inners) = inner_polys { inners.into_iter().for_each(|inner| { [INFO] [stderr] 112 | /* [INFO] [stderr] 113 | It's assumed here that the 'inner' ring is contained into [INFO] [stderr] 114 | exactly ONE outer ring. To find it among all 'outers', all [INFO] [stderr] 115 | we need is to find a candidate 'outer' area that shares a point [INFO] [stderr] 116 | point with (i.e 'intersects') all 'inner' segments. [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/boundaries.rs:124:21 [INFO] [stderr] | [INFO] [stderr] 124 | for ref mut outer in outers.0.iter_mut() { [INFO] [stderr] | ^^^^^^^^^^^^^ ------------------- help: try: `let outer = &mut outers.0.iter_mut();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/osm_builder.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | / if let &mut osmpbfreader::OsmObj::Relation(ref mut rel) = self [INFO] [stderr] 18 | | .builder [INFO] [stderr] 19 | | .objects [INFO] [stderr] 20 | | .get_mut(&self.relation_id.into()) [INFO] [stderr] ... | [INFO] [stderr] 26 | | }); [INFO] [stderr] 27 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 17 | if let osmpbfreader::OsmObj::Relation(ref mut rel) = *self [INFO] [stderr] 18 | .builder [INFO] [stderr] 19 | .objects [INFO] [stderr] 20 | .get_mut(&self.relation_id.into()) [INFO] [stderr] 21 | .unwrap() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/osm_builder.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | / if let &mut osmpbfreader::OsmObj::Relation(ref mut rel) = self [INFO] [stderr] 36 | | .builder [INFO] [stderr] 37 | | .objects [INFO] [stderr] 38 | | .get_mut(&self.relation_id.into()) [INFO] [stderr] ... | [INFO] [stderr] 44 | | }); [INFO] [stderr] 45 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 35 | if let osmpbfreader::OsmObj::Relation(ref mut rel) = *self [INFO] [stderr] 36 | .builder [INFO] [stderr] 37 | .objects [INFO] [stderr] 38 | .get_mut(&self.relation_id.into()) [INFO] [stderr] 39 | .unwrap() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `osm_builder::OsmBuilder` [INFO] [stderr] --> src/osm_builder.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | / pub fn new() -> OsmBuilder { [INFO] [stderr] 60 | | OsmBuilder { [INFO] [stderr] 61 | | node_id: 0, [INFO] [stderr] 62 | | way_id: 0, [INFO] [stderr] ... | [INFO] [stderr] 66 | | } [INFO] [stderr] 67 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 50 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/boundaries.rs:59:24 [INFO] [stderr] | [INFO] [stderr] 59 | decimicro_lat: 12000000, [INFO] [stderr] | ^^^^^^^^ help: consider: `12_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/boundaries.rs:60:24 [INFO] [stderr] | [INFO] [stderr] 60 | decimicro_lon: 37000000, [INFO] [stderr] | ^^^^^^^^ help: consider: `37_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/boundaries.rs:66:24 [INFO] [stderr] | [INFO] [stderr] 66 | decimicro_lat: 15000000, [INFO] [stderr] | ^^^^^^^^ help: consider: `15_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/boundaries.rs:67:24 [INFO] [stderr] | [INFO] [stderr] 67 | decimicro_lon: 35000000, [INFO] [stderr] | ^^^^^^^^ help: consider: `35_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/boundaries.rs:73:24 [INFO] [stderr] | [INFO] [stderr] 73 | decimicro_lat: 75000000, [INFO] [stderr] | ^^^^^^^^ help: consider: `75_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/boundaries.rs:74:24 [INFO] [stderr] | [INFO] [stderr] 74 | decimicro_lon: 135000000, [INFO] [stderr] | ^^^^^^^^^ help: consider: `135_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/boundaries.rs:80:24 [INFO] [stderr] | [INFO] [stderr] 80 | decimicro_lat: 55000000, [INFO] [stderr] | ^^^^^^^^ help: consider: `55_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/boundaries.rs:81:24 [INFO] [stderr] | [INFO] [stderr] 81 | decimicro_lon: 635000000, [INFO] [stderr] | ^^^^^^^^^ help: consider: `635_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/boundaries.rs:87:24 [INFO] [stderr] | [INFO] [stderr] 87 | decimicro_lat: 455000000, [INFO] [stderr] | ^^^^^^^^^ help: consider: `455_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/boundaries.rs:88:24 [INFO] [stderr] | [INFO] [stderr] 88 | decimicro_lon: 535000000, [INFO] [stderr] | ^^^^^^^^^ help: consider: `535_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/boundaries.rs:111:9 [INFO] [stderr] | [INFO] [stderr] 111 | / inner_polys.map(|inners| { [INFO] [stderr] 112 | | inners.into_iter().for_each(|inner| { [INFO] [stderr] 113 | | /* [INFO] [stderr] 114 | | It's assumed here that the 'inner' ring is contained into [INFO] [stderr] ... | [INFO] [stderr] 130 | | }) [INFO] [stderr] 131 | | }); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 111 | if let Some(inners) = inner_polys { inners.into_iter().for_each(|inner| { [INFO] [stderr] 112 | /* [INFO] [stderr] 113 | It's assumed here that the 'inner' ring is contained into [INFO] [stderr] 114 | exactly ONE outer ring. To find it among all 'outers', all [INFO] [stderr] 115 | we need is to find a candidate 'outer' area that shares a point [INFO] [stderr] 116 | point with (i.e 'intersects') all 'inner' segments. [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/boundaries.rs:124:21 [INFO] [stderr] | [INFO] [stderr] 124 | for ref mut outer in outers.0.iter_mut() { [INFO] [stderr] | ^^^^^^^^^^^^^ ------------------- help: try: `let outer = &mut outers.0.iter_mut();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/boundaries.rs:387:9 [INFO] [stderr] | [INFO] [stderr] 387 | assert_eq!(centroid.lng(), 0.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/boundaries.rs:387:9 [INFO] [stderr] | [INFO] [stderr] 387 | assert_eq!(centroid.lng(), 0.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/boundaries.rs:388:9 [INFO] [stderr] | [INFO] [stderr] 388 | assert_eq!(centroid.lat(), 0.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/boundaries.rs:388:9 [INFO] [stderr] | [INFO] [stderr] 388 | assert_eq!(centroid.lat(), 0.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/boundaries.rs:450:9 [INFO] [stderr] | [INFO] [stderr] 450 | assert_eq!(multipolygon.area(), 15.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/boundaries.rs:450:9 [INFO] [stderr] | [INFO] [stderr] 450 | assert_eq!(multipolygon.area(), 15.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/boundaries.rs:490:9 [INFO] [stderr] | [INFO] [stderr] 490 | assert_eq!(multipolygon.area(), 31.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/boundaries.rs:490:9 [INFO] [stderr] | [INFO] [stderr] 490 | assert_eq!(multipolygon.area(), 31.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/boundaries.rs:530:9 [INFO] [stderr] | [INFO] [stderr] 530 | assert_eq!(multipolygon.area(), 23.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/boundaries.rs:530:9 [INFO] [stderr] | [INFO] [stderr] 530 | assert_eq!(multipolygon.area(), 23.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/boundaries.rs:578:9 [INFO] [stderr] | [INFO] [stderr] 578 | assert_eq!(multipolygon.area(), 30.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/boundaries.rs:578:9 [INFO] [stderr] | [INFO] [stderr] 578 | assert_eq!(multipolygon.area(), 30.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/boundaries.rs:617:9 [INFO] [stderr] | [INFO] [stderr] 617 | assert_eq!(multipolygon.area(), 14.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/boundaries.rs:617:9 [INFO] [stderr] | [INFO] [stderr] 617 | assert_eq!(multipolygon.area(), 14.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/osm_builder.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | / if let &mut osmpbfreader::OsmObj::Relation(ref mut rel) = self [INFO] [stderr] 18 | | .builder [INFO] [stderr] 19 | | .objects [INFO] [stderr] 20 | | .get_mut(&self.relation_id.into()) [INFO] [stderr] ... | [INFO] [stderr] 26 | | }); [INFO] [stderr] 27 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 17 | if let osmpbfreader::OsmObj::Relation(ref mut rel) = *self [INFO] [stderr] 18 | .builder [INFO] [stderr] 19 | .objects [INFO] [stderr] 20 | .get_mut(&self.relation_id.into()) [INFO] [stderr] 21 | .unwrap() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/osm_builder.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | / if let &mut osmpbfreader::OsmObj::Relation(ref mut rel) = self [INFO] [stderr] 36 | | .builder [INFO] [stderr] 37 | | .objects [INFO] [stderr] 38 | | .get_mut(&self.relation_id.into()) [INFO] [stderr] ... | [INFO] [stderr] 44 | | }); [INFO] [stderr] 45 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 35 | if let osmpbfreader::OsmObj::Relation(ref mut rel) = *self [INFO] [stderr] 36 | .builder [INFO] [stderr] 37 | .objects [INFO] [stderr] 38 | .get_mut(&self.relation_id.into()) [INFO] [stderr] 39 | .unwrap() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `osm_builder::OsmBuilder` [INFO] [stderr] --> src/osm_builder.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | / pub fn new() -> OsmBuilder { [INFO] [stderr] 60 | | OsmBuilder { [INFO] [stderr] 61 | | node_id: 0, [INFO] [stderr] 62 | | way_id: 0, [INFO] [stderr] ... | [INFO] [stderr] 66 | | } [INFO] [stderr] 67 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 50 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to 7 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `osm_boundaries_utils`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "e0f65e777529a11cdc52ff032a09aef863ad280682cf59cd493f6e77afc3b380"` [INFO] running `"docker" "rm" "-f" "e0f65e777529a11cdc52ff032a09aef863ad280682cf59cd493f6e77afc3b380"` [INFO] [stdout] e0f65e777529a11cdc52ff032a09aef863ad280682cf59cd493f6e77afc3b380