[INFO] crate osm4routing 0.2.0 is already in cache [INFO] extracting crate osm4routing 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/osm4routing/0.2.0 [INFO] extracting crate osm4routing 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/osm4routing/0.2.0 [INFO] validating manifest of osm4routing-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of osm4routing-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing osm4routing-0.2.0 [INFO] finished frobbing osm4routing-0.2.0 [INFO] frobbed toml for osm4routing-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/osm4routing/0.2.0/Cargo.toml [INFO] started frobbing osm4routing-0.2.0 [INFO] finished frobbing osm4routing-0.2.0 [INFO] frobbed toml for osm4routing-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/osm4routing/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting osm4routing-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/osm4routing/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 35635bc7244f3ef9b9cd1fb4bd13b2220491c6abd403b9a4ab83567a5ccaf8b6 [INFO] running `"docker" "start" "-a" "35635bc7244f3ef9b9cd1fb4bd13b2220491c6abd403b9a4ab83567a5ccaf8b6"` [INFO] [stderr] Checking osmpbfreader v0.3.2 [INFO] [stderr] Checking osm4routing v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/osm4routing/reader.rs:63:25 [INFO] [stderr] | [INFO] [stderr] 63 | source: source, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `source` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/osm4routing/reader.rs:65:25 [INFO] [stderr] | [INFO] [stderr] 65 | geometry: geometry, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `geometry` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/osm4routing/reader.rs:94:29 [INFO] [stderr] | [INFO] [stderr] 94 | properties: properties, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `properties` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/osm4routing/reader.rs:171:9 [INFO] [stderr] | [INFO] [stderr] 171 | ways: ways, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `ways` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/osm4routing/reader.rs:172:9 [INFO] [stderr] | [INFO] [stderr] 172 | nodes: nodes, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `nodes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/osm4routing/reader.rs:202:9 [INFO] [stderr] | [INFO] [stderr] 202 | nodes: nodes, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `nodes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/osm4routing/reader.rs:203:9 [INFO] [stderr] | [INFO] [stderr] 203 | ways: ways, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `ways` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/osm4routing/reader.rs:63:25 [INFO] [stderr] | [INFO] [stderr] 63 | source: source, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `source` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/osm4routing/reader.rs:65:25 [INFO] [stderr] | [INFO] [stderr] 65 | geometry: geometry, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `geometry` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/osm4routing/reader.rs:94:29 [INFO] [stderr] | [INFO] [stderr] 94 | properties: properties, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `properties` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/osm4routing/reader.rs:171:9 [INFO] [stderr] | [INFO] [stderr] 171 | ways: ways, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `ways` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/osm4routing/reader.rs:172:9 [INFO] [stderr] | [INFO] [stderr] 172 | nodes: nodes, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `nodes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/osm4routing/reader.rs:202:9 [INFO] [stderr] | [INFO] [stderr] 202 | nodes: nodes, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `nodes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/osm4routing/reader.rs:203:9 [INFO] [stderr] | [INFO] [stderr] 203 | ways: ways, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `ways` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/osm4routing/models.rs:66:5 [INFO] [stderr] | [INFO] [stderr] 66 | return r * c; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `r * c` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/osm4routing/models.rs:55:18 [INFO] [stderr] | [INFO] [stderr] 55 | let r: f64 = 6378100.0; [INFO] [stderr] | ^^^^^^^^^ help: consider: `6_378_100.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/osm4routing/models.rs:66:5 [INFO] [stderr] | [INFO] [stderr] 66 | return r * c; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `r * c` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/osm4routing/models.rs:55:18 [INFO] [stderr] | [INFO] [stderr] 55 | let r: f64 = 6378100.0; [INFO] [stderr] | ^^^^^^^^^ help: consider: `6_378_100.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/osm4routing/reader.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | / match obj { [INFO] [stderr] 81 | | osmpbfreader::OsmObj::Way(way) => { [INFO] [stderr] 82 | | let mut properties = EdgeProperties::new(); [INFO] [stderr] 83 | | for (key, val) in way.tags { [INFO] [stderr] ... | [INFO] [stderr] 99 | | _ => {} [INFO] [stderr] 100 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 80 | if let osmpbfreader::OsmObj::Way(way) = obj { [INFO] [stderr] 81 | let mut properties = EdgeProperties::new(); [INFO] [stderr] 82 | for (key, val) in way.tags { [INFO] [stderr] 83 | properties.update(key, val); [INFO] [stderr] 84 | } [INFO] [stderr] 85 | properties.normalize(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/osm4routing/reader.rs:108:13 [INFO] [stderr] | [INFO] [stderr] 108 | / match obj { [INFO] [stderr] 109 | | osmpbfreader::OsmObj::Node(node) => { [INFO] [stderr] 110 | | if self.nodes_to_keep.contains(&node.id) { [INFO] [stderr] 111 | | self.nodes_to_keep.remove(&node.id); [INFO] [stderr] ... | [INFO] [stderr] 121 | | _ => {} [INFO] [stderr] 122 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 108 | if let osmpbfreader::OsmObj::Node(node) = obj { [INFO] [stderr] 109 | if self.nodes_to_keep.contains(&node.id) { [INFO] [stderr] 110 | self.nodes_to_keep.remove(&node.id); [INFO] [stderr] 111 | let mut n = Node::new(); [INFO] [stderr] 112 | n.id = node.id; [INFO] [stderr] 113 | n.coord = Coord { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `models::Node` [INFO] [stderr] --> src/osm4routing/models.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | / pub fn new() -> Node { [INFO] [stderr] 20 | | Node { [INFO] [stderr] 21 | | id: 0, [INFO] [stderr] 22 | | coord: Coord { lon: 0., lat: 0. }, [INFO] [stderr] 23 | | uses: 0, [INFO] [stderr] 24 | | } [INFO] [stderr] 25 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 18 | impl Default for models::Node { [INFO] [stderr] 19 | fn default() -> Self { [INFO] [stderr] 20 | Self::new() [INFO] [stderr] 21 | } [INFO] [stderr] 22 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `categorize::EdgeProperties` [INFO] [stderr] --> src/osm4routing/categorize.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | / pub fn new() -> EdgeProperties { [INFO] [stderr] 48 | | EdgeProperties { [INFO] [stderr] 49 | | foot: UNKNOWN, [INFO] [stderr] 50 | | car_forward: UNKNOWN, [INFO] [stderr] ... | [INFO] [stderr] 54 | | } [INFO] [stderr] 55 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 38 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/osm4routing/categorize.rs:83:23 [INFO] [stderr] | [INFO] [stderr] 83 | pub fn accessible(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/osm4routing/categorize.rs:181:17 [INFO] [stderr] | [INFO] [stderr] 181 | / match val { [INFO] [stderr] 182 | | "roundabout" => { [INFO] [stderr] 183 | | self.car_backward = CAR_FORBIDDEN; [INFO] [stderr] 184 | | if self.bike_backward == UNKNOWN { [INFO] [stderr] ... | [INFO] [stderr] 188 | | _ => {} [INFO] [stderr] 189 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 181 | if let "roundabout" = val { [INFO] [stderr] 182 | self.car_backward = CAR_FORBIDDEN; [INFO] [stderr] 183 | if self.bike_backward == UNKNOWN { [INFO] [stderr] 184 | self.bike_backward = BIKE_FORBIDDEN; [INFO] [stderr] 185 | } [INFO] [stderr] 186 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/osm4routing/reader.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | / match obj { [INFO] [stderr] 81 | | osmpbfreader::OsmObj::Way(way) => { [INFO] [stderr] 82 | | let mut properties = EdgeProperties::new(); [INFO] [stderr] 83 | | for (key, val) in way.tags { [INFO] [stderr] ... | [INFO] [stderr] 99 | | _ => {} [INFO] [stderr] 100 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 80 | if let osmpbfreader::OsmObj::Way(way) = obj { [INFO] [stderr] 81 | let mut properties = EdgeProperties::new(); [INFO] [stderr] 82 | for (key, val) in way.tags { [INFO] [stderr] 83 | properties.update(key, val); [INFO] [stderr] 84 | } [INFO] [stderr] 85 | properties.normalize(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/osm4routing/reader.rs:108:13 [INFO] [stderr] | [INFO] [stderr] 108 | / match obj { [INFO] [stderr] 109 | | osmpbfreader::OsmObj::Node(node) => { [INFO] [stderr] 110 | | if self.nodes_to_keep.contains(&node.id) { [INFO] [stderr] 111 | | self.nodes_to_keep.remove(&node.id); [INFO] [stderr] ... | [INFO] [stderr] 121 | | _ => {} [INFO] [stderr] 122 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 108 | if let osmpbfreader::OsmObj::Node(node) = obj { [INFO] [stderr] 109 | if self.nodes_to_keep.contains(&node.id) { [INFO] [stderr] 110 | self.nodes_to_keep.remove(&node.id); [INFO] [stderr] 111 | let mut n = Node::new(); [INFO] [stderr] 112 | n.id = node.id; [INFO] [stderr] 113 | n.coord = Coord { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `models::Node` [INFO] [stderr] --> src/osm4routing/models.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | / pub fn new() -> Node { [INFO] [stderr] 20 | | Node { [INFO] [stderr] 21 | | id: 0, [INFO] [stderr] 22 | | coord: Coord { lon: 0., lat: 0. }, [INFO] [stderr] 23 | | uses: 0, [INFO] [stderr] 24 | | } [INFO] [stderr] 25 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 18 | impl Default for models::Node { [INFO] [stderr] 19 | fn default() -> Self { [INFO] [stderr] 20 | Self::new() [INFO] [stderr] 21 | } [INFO] [stderr] 22 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `categorize::EdgeProperties` [INFO] [stderr] --> src/osm4routing/categorize.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | / pub fn new() -> EdgeProperties { [INFO] [stderr] 48 | | EdgeProperties { [INFO] [stderr] 49 | | foot: UNKNOWN, [INFO] [stderr] 50 | | car_forward: UNKNOWN, [INFO] [stderr] ... | [INFO] [stderr] 54 | | } [INFO] [stderr] 55 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 38 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/osm4routing/categorize.rs:83:23 [INFO] [stderr] | [INFO] [stderr] 83 | pub fn accessible(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/osm4routing/categorize.rs:181:17 [INFO] [stderr] | [INFO] [stderr] 181 | / match val { [INFO] [stderr] 182 | | "roundabout" => { [INFO] [stderr] 183 | | self.car_backward = CAR_FORBIDDEN; [INFO] [stderr] 184 | | if self.bike_backward == UNKNOWN { [INFO] [stderr] ... | [INFO] [stderr] 188 | | _ => {} [INFO] [stderr] 189 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 181 | if let "roundabout" = val { [INFO] [stderr] 182 | self.car_backward = CAR_FORBIDDEN; [INFO] [stderr] 183 | if self.bike_backward == UNKNOWN { [INFO] [stderr] 184 | self.bike_backward = BIKE_FORBIDDEN; [INFO] [stderr] 185 | } [INFO] [stderr] 186 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 27 [INFO] [stderr] --> src/osm4routing/categorize.rs:223:1 [INFO] [stderr] | [INFO] [stderr] 223 | / fn test_update() { [INFO] [stderr] 224 | | let mut p = EdgeProperties::new(); [INFO] [stderr] 225 | | p.update_with_str("highway", "secondary"); [INFO] [stderr] 226 | | assert_eq!(CAR_SECONDARY, p.car_forward); [INFO] [stderr] ... | [INFO] [stderr] 299 | | assert_eq!(BIKE_FORBIDDEN, p.bike_backward); [INFO] [stderr] 300 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:7:19 [INFO] [stderr] | [INFO] [stderr] 7 | const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:7:19 [INFO] [stderr] | [INFO] [stderr] 7 | const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.33s [INFO] running `"docker" "inspect" "35635bc7244f3ef9b9cd1fb4bd13b2220491c6abd403b9a4ab83567a5ccaf8b6"` [INFO] running `"docker" "rm" "-f" "35635bc7244f3ef9b9cd1fb4bd13b2220491c6abd403b9a4ab83567a5ccaf8b6"` [INFO] [stdout] 35635bc7244f3ef9b9cd1fb4bd13b2220491c6abd403b9a4ab83567a5ccaf8b6