[INFO] crate os_type 2.2.0 is already in cache
[INFO] extracting crate os_type 2.2.0 into work/ex/clippy-test-run/sources/stable/reg/os_type/2.2.0
[INFO] extracting crate os_type 2.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/os_type/2.2.0
[INFO] validating manifest of os_type-2.2.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of os_type-2.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing os_type-2.2.0
[INFO] finished frobbing os_type-2.2.0
[INFO] frobbed toml for os_type-2.2.0 written to work/ex/clippy-test-run/sources/stable/reg/os_type/2.2.0/Cargo.toml
[INFO] started frobbing os_type-2.2.0
[INFO] finished frobbing os_type-2.2.0
[INFO] frobbed toml for os_type-2.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/os_type/2.2.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting os_type-2.2.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/os_type/2.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 2b6fb45b20fd0a9fe8424fd8bc11218fea8a1afbc92eeec678cd0c2bfc3955aa
[INFO] running `"docker" "start" "-a" "2b6fb45b20fd0a9fe8424fd8bc11218fea8a1afbc92eeec678cd0c2bfc3955aa"`
[INFO] [stderr]     Checking os_type v2.2.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lsb_release.rs:52:9
[INFO] [stderr]    |
[INFO] [stderr] 52 |         distro: distro,
[INFO] [stderr]    |         ^^^^^^^^^^^^^^ help: replace it with: `distro`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lsb_release.rs:53:9
[INFO] [stderr]    |
[INFO] [stderr] 53 |         version: version
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^ help: replace it with: `version`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/windows_ver.rs:29:18
[INFO] [stderr]    |
[INFO] [stderr] 29 |     WindowsVer { version: version }
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^ help: replace it with: `version`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/rhel_release.rs:64:9
[INFO] [stderr]    |
[INFO] [stderr] 64 |         distro: distro,
[INFO] [stderr]    |         ^^^^^^^^^^^^^^ help: replace it with: `distro`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/rhel_release.rs:65:9
[INFO] [stderr]    |
[INFO] [stderr] 65 |         version: version
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^ help: replace it with: `version`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lsb_release.rs:52:9
[INFO] [stderr]    |
[INFO] [stderr] 52 |         distro: distro,
[INFO] [stderr]    |         ^^^^^^^^^^^^^^ help: replace it with: `distro`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lsb_release.rs:53:9
[INFO] [stderr]    |
[INFO] [stderr] 53 |         version: version
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^ help: replace it with: `version`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/windows_ver.rs:29:18
[INFO] [stderr]    |
[INFO] [stderr] 29 |     WindowsVer { version: version }
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^ help: replace it with: `version`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/rhel_release.rs:64:9
[INFO] [stderr]    |
[INFO] [stderr] 64 |         distro: distro,
[INFO] [stderr]    |         ^^^^^^^^^^^^^^ help: replace it with: `distro`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/rhel_release.rs:65:9
[INFO] [stderr]    |
[INFO] [stderr] 65 |         version: version
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^ help: replace it with: `version`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/os_release.rs:27:12
[INFO] [stderr]    |
[INFO] [stderr] 27 |       } else {
[INFO] [stderr]    |  ____________^
[INFO] [stderr] 28 | |         if let Ok(release) = read_file("/usr/lib/os-release") {
[INFO] [stderr] 29 | |             Some(parse(release))
[INFO] [stderr] 30 | |         } else {
[INFO] [stderr] 31 | |             None
[INFO] [stderr] 32 | |         }
[INFO] [stderr] 33 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 27 |     } else if let Ok(release) = read_file("/usr/lib/os-release") {
[INFO] [stderr] 28 |     Some(parse(release))
[INFO] [stderr] 29 | } else {
[INFO] [stderr] 30 |     None
[INFO] [stderr] 31 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `super::*`
[INFO] [stderr]   --> src/os_release.rs:60:9
[INFO] [stderr]    |
[INFO] [stderr] 60 |     use super::*;
[INFO] [stderr]    |         ^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/rhel_release.rs:26:12
[INFO] [stderr]    |
[INFO] [stderr] 26 |       } else {
[INFO] [stderr]    |  ____________^
[INFO] [stderr] 27 | |         if let Ok(release) = read_file("/etc/centos-release") {
[INFO] [stderr] 28 | |             Some(parse(release))
[INFO] [stderr] 29 | |         } else {
[INFO] [stderr] 30 | |             None
[INFO] [stderr] 31 | |         }
[INFO] [stderr] 32 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 26 |     } else if let Ok(release) = read_file("/etc/centos-release") {
[INFO] [stderr] 27 |     Some(parse(release))
[INFO] [stderr] 28 | } else {
[INFO] [stderr] 29 |     None
[INFO] [stderr] 30 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/os_release.rs:27:12
[INFO] [stderr]    |
[INFO] [stderr] 27 |       } else {
[INFO] [stderr]    |  ____________^
[INFO] [stderr] 28 | |         if let Ok(release) = read_file("/usr/lib/os-release") {
[INFO] [stderr] 29 | |             Some(parse(release))
[INFO] [stderr] 30 | |         } else {
[INFO] [stderr] 31 | |             None
[INFO] [stderr] 32 | |         }
[INFO] [stderr] 33 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 27 |     } else if let Ok(release) = read_file("/usr/lib/os-release") {
[INFO] [stderr] 28 |     Some(parse(release))
[INFO] [stderr] 29 | } else {
[INFO] [stderr] 30 |     None
[INFO] [stderr] 31 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/rhel_release.rs:26:12
[INFO] [stderr]    |
[INFO] [stderr] 26 |       } else {
[INFO] [stderr]    |  ____________^
[INFO] [stderr] 27 | |         if let Ok(release) = read_file("/etc/centos-release") {
[INFO] [stderr] 28 | |             Some(parse(release))
[INFO] [stderr] 29 | |         } else {
[INFO] [stderr] 30 | |             None
[INFO] [stderr] 31 | |         }
[INFO] [stderr] 32 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 26 |     } else if let Ok(release) = read_file("/etc/centos-release") {
[INFO] [stderr] 27 |     Some(parse(release))
[INFO] [stderr] 28 | } else {
[INFO] [stderr] 29 |     None
[INFO] [stderr] 30 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: struct is never constructed: `WindowsVer`
[INFO] [stderr]  --> src/windows_ver.rs:4:1
[INFO] [stderr]   |
[INFO] [stderr] 4 | pub struct WindowsVer {
[INFO] [stderr]   | ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `retrieve`
[INFO] [stderr]  --> src/windows_ver.rs:8:1
[INFO] [stderr]   |
[INFO] [stderr] 8 | pub fn retrieve() -> Option<WindowsVer> {
[INFO] [stderr]   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `parse`
[INFO] [stderr]   --> src/windows_ver.rs:17:1
[INFO] [stderr]    |
[INFO] [stderr] 17 | pub fn parse(output: String) -> WindowsVer {
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `is_os_x`
[INFO] [stderr]   --> src/sw_vers.rs:27:1
[INFO] [stderr]    |
[INFO] [stderr] 27 | pub fn is_os_x() -> bool {
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()`
[INFO] [stderr]   --> src/lsb_release.rs:19:5
[INFO] [stderr]    |
[INFO] [stderr] 19 | /     match Command::new("lsb_release").output() {
[INFO] [stderr] 20 | |         Ok(_) => true,
[INFO] [stderr] 21 | |         Err(_) => false
[INFO] [stderr] 22 | |     }
[INFO] [stderr]    | |_____^ help: try this: `Command::new("lsb_release").output().is_ok()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/sw_vers.rs:13:31
[INFO] [stderr]    |
[INFO] [stderr] 13 | fn extract_from_regex(stdout: &String, regex: Regex) -> Option<String> {
[INFO] [stderr]    |                               ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/lib.rs:59:47
[INFO] [stderr]    |
[INFO] [stderr] 59 |             version: osx_info.product_version.unwrap_or(default_version())
[INFO] [stderr]    |                                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(default_version)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/lib.rs:72:46
[INFO] [stderr]    |
[INFO] [stderr] 72 |                     version: release.version.unwrap_or(default_version())
[INFO] [stderr]    |                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(default_version)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/lib.rs:78:46
[INFO] [stderr]    |
[INFO] [stderr] 78 |                     version: release.version.unwrap_or(default_version())
[INFO] [stderr]    |                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(default_version)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/lib.rs:83:46
[INFO] [stderr]    |
[INFO] [stderr] 83 |                     version: release.version.unwrap_or(default_version())
[INFO] [stderr]    |                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(default_version)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/lib.rs:88:46
[INFO] [stderr]    |
[INFO] [stderr] 88 |                     version: release.version.unwrap_or(default_version())
[INFO] [stderr]    |                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(default_version)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: struct is never constructed: `WindowsVer`
[INFO] [stderr]  --> src/windows_ver.rs:4:1
[INFO] [stderr]   |
[INFO] [stderr] 4 | pub struct WindowsVer {
[INFO] [stderr]   | ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/lib.rs:94:46
[INFO] [stderr]    |
[INFO] [stderr] 94 |                     version: release.version.unwrap_or(default_version())
[INFO] [stderr]    |                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(default_version)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `retrieve`
[INFO] [stderr]  --> src/windows_ver.rs:8:1
[INFO] [stderr]   |
[INFO] [stderr] 8 | pub fn retrieve() -> Option<WindowsVer> {
[INFO] [stderr]   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `parse`
[INFO] [stderr]   --> src/windows_ver.rs:17:1
[INFO] [stderr]    |
[INFO] [stderr] 17 | pub fn parse(output: String) -> WindowsVer {
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/lib.rs:100:46
[INFO] [stderr]     |
[INFO] [stderr] 100 |                     version: release.version.unwrap_or(default_version())
[INFO] [stderr]     |                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(default_version)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `is_os_x`
[INFO] [stderr]   --> src/sw_vers.rs:27:1
[INFO] [stderr]    |
[INFO] [stderr] 27 | pub fn is_os_x() -> bool {
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/lib.rs:117:46
[INFO] [stderr]     |
[INFO] [stderr] 117 |                     version: release.version.unwrap_or(default_version()),
[INFO] [stderr]     |                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(default_version)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/lib.rs:122:46
[INFO] [stderr]     |
[INFO] [stderr] 122 |                     version: release.version.unwrap_or(default_version()),
[INFO] [stderr]     |                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(default_version)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/lib.rs:137:50
[INFO] [stderr]     |
[INFO] [stderr] 137 |                         version: release.version.unwrap_or(default_version()),
[INFO] [stderr]     |                                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(default_version)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/lib.rs:142:50
[INFO] [stderr]     |
[INFO] [stderr] 142 |                         version: release.version.unwrap_or(default_version()),
[INFO] [stderr]     |                                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(default_version)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/lib.rs:147:50
[INFO] [stderr]     |
[INFO] [stderr] 147 |                         version: release.version.unwrap_or(default_version()),
[INFO] [stderr]     |                                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(default_version)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/lib.rs:152:50
[INFO] [stderr]     |
[INFO] [stderr] 152 |                         version: release.version.unwrap_or(default_version()),
[INFO] [stderr]     |                                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(default_version)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/lib.rs:157:50
[INFO] [stderr]     |
[INFO] [stderr] 157 |                         version: release.version.unwrap_or(default_version()),
[INFO] [stderr]     |                                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(default_version)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()`
[INFO] [stderr]   --> src/lsb_release.rs:19:5
[INFO] [stderr]    |
[INFO] [stderr] 19 | /     match Command::new("lsb_release").output() {
[INFO] [stderr] 20 | |         Ok(_) => true,
[INFO] [stderr] 21 | |         Err(_) => false
[INFO] [stderr] 22 | |     }
[INFO] [stderr]    | |_____^ help: try this: `Command::new("lsb_release").output().is_ok()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/sw_vers.rs:13:31
[INFO] [stderr]    |
[INFO] [stderr] 13 | fn extract_from_regex(stdout: &String, regex: Regex) -> Option<String> {
[INFO] [stderr]    |                               ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/lib.rs:59:47
[INFO] [stderr]    |
[INFO] [stderr] 59 |             version: osx_info.product_version.unwrap_or(default_version())
[INFO] [stderr]    |                                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(default_version)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/lib.rs:72:46
[INFO] [stderr]    |
[INFO] [stderr] 72 |                     version: release.version.unwrap_or(default_version())
[INFO] [stderr]    |                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(default_version)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/lib.rs:78:46
[INFO] [stderr]    |
[INFO] [stderr] 78 |                     version: release.version.unwrap_or(default_version())
[INFO] [stderr]    |                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(default_version)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/lib.rs:83:46
[INFO] [stderr]    |
[INFO] [stderr] 83 |                     version: release.version.unwrap_or(default_version())
[INFO] [stderr]    |                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(default_version)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/lib.rs:88:46
[INFO] [stderr]    |
[INFO] [stderr] 88 |                     version: release.version.unwrap_or(default_version())
[INFO] [stderr]    |                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(default_version)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/lib.rs:94:46
[INFO] [stderr]    |
[INFO] [stderr] 94 |                     version: release.version.unwrap_or(default_version())
[INFO] [stderr]    |                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(default_version)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/lib.rs:100:46
[INFO] [stderr]     |
[INFO] [stderr] 100 |                     version: release.version.unwrap_or(default_version())
[INFO] [stderr]     |                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(default_version)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/lib.rs:117:46
[INFO] [stderr]     |
[INFO] [stderr] 117 |                     version: release.version.unwrap_or(default_version()),
[INFO] [stderr]     |                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(default_version)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/lib.rs:122:46
[INFO] [stderr]     |
[INFO] [stderr] 122 |                     version: release.version.unwrap_or(default_version()),
[INFO] [stderr]     |                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(default_version)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/lib.rs:137:50
[INFO] [stderr]     |
[INFO] [stderr] 137 |                         version: release.version.unwrap_or(default_version()),
[INFO] [stderr]     |                                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(default_version)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/lib.rs:142:50
[INFO] [stderr]     |
[INFO] [stderr] 142 |                         version: release.version.unwrap_or(default_version()),
[INFO] [stderr]     |                                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(default_version)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/lib.rs:147:50
[INFO] [stderr]     |
[INFO] [stderr] 147 |                         version: release.version.unwrap_or(default_version()),
[INFO] [stderr]     |                                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(default_version)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/lib.rs:152:50
[INFO] [stderr]     |
[INFO] [stderr] 152 |                         version: release.version.unwrap_or(default_version()),
[INFO] [stderr]     |                                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(default_version)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/lib.rs:157:50
[INFO] [stderr]     |
[INFO] [stderr] 157 |                         version: release.version.unwrap_or(default_version()),
[INFO] [stderr]     |                                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(default_version)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> tests/../src/rhel_release.rs:64:9
[INFO] [stderr]    |
[INFO] [stderr] 64 |         distro: distro,
[INFO] [stderr]    |         ^^^^^^^^^^^^^^ help: replace it with: `distro`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> tests/../src/rhel_release.rs:65:9
[INFO] [stderr]    |
[INFO] [stderr] 65 |         version: version
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^ help: replace it with: `version`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> tests/../src/lsb_release.rs:52:9
[INFO] [stderr]    |
[INFO] [stderr] 52 |         distro: distro,
[INFO] [stderr]    |         ^^^^^^^^^^^^^^ help: replace it with: `distro`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> tests/../src/lsb_release.rs:53:9
[INFO] [stderr]    |
[INFO] [stderr] 53 |         version: version
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^ help: replace it with: `version`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> tests/../src/rhel_release.rs:26:12
[INFO] [stderr]    |
[INFO] [stderr] 26 |       } else {
[INFO] [stderr]    |  ____________^
[INFO] [stderr] 27 | |         if let Ok(release) = read_file("/etc/centos-release") {
[INFO] [stderr] 28 | |             Some(parse(release))
[INFO] [stderr] 29 | |         } else {
[INFO] [stderr] 30 | |             None
[INFO] [stderr] 31 | |         }
[INFO] [stderr] 32 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 26 |     } else if let Ok(release) = read_file("/etc/centos-release") {
[INFO] [stderr] 27 |     Some(parse(release))
[INFO] [stderr] 28 | } else {
[INFO] [stderr] 29 |     None
[INFO] [stderr] 30 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `read_file`
[INFO] [stderr]   --> tests/../src/rhel_release.rs:12:1
[INFO] [stderr]    |
[INFO] [stderr] 12 | fn read_file(filename: &str) -> Result<String, Error> {
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `retrieve`
[INFO] [stderr]   --> tests/../src/rhel_release.rs:19:1
[INFO] [stderr]    |
[INFO] [stderr] 19 | pub fn retrieve() -> Option<RHELRelease> {
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `file_exists`
[INFO] [stderr]  --> tests/../src/utils.rs:5:1
[INFO] [stderr]   |
[INFO] [stderr] 5 | pub fn file_exists<P: AsRef<Path>>(path: P) -> bool {
[INFO] [stderr]   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `is_os_x`
[INFO] [stderr]   --> tests/../src/sw_vers.rs:27:1
[INFO] [stderr]    |
[INFO] [stderr] 27 | pub fn is_os_x() -> bool {
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `retrieve`
[INFO] [stderr]   --> tests/../src/sw_vers.rs:34:1
[INFO] [stderr]    |
[INFO] [stderr] 34 | pub fn retrieve() -> Option<SwVers> {
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `file_exists`
[INFO] [stderr]  --> tests/../src/utils.rs:5:1
[INFO] [stderr]   |
[INFO] [stderr] 5 | pub fn file_exists<P: AsRef<Path>>(path: P) -> bool {
[INFO] [stderr]   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> tests/../src/sw_vers.rs:13:31
[INFO] [stderr]    |
[INFO] [stderr] 13 | fn extract_from_regex(stdout: &String, regex: Regex) -> Option<String> {
[INFO] [stderr]    |                               ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `retrieve`
[INFO] [stderr]  --> tests/../src/lsb_release.rs:9:1
[INFO] [stderr]   |
[INFO] [stderr] 9 | pub fn retrieve() -> Option<LsbRelease> {
[INFO] [stderr]   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `is_available`
[INFO] [stderr]   --> tests/../src/lsb_release.rs:18:1
[INFO] [stderr]    |
[INFO] [stderr] 18 | pub fn is_available() -> bool {
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `file_exists`
[INFO] [stderr]  --> tests/../src/utils.rs:5:1
[INFO] [stderr]   |
[INFO] [stderr] 5 | pub fn file_exists<P: AsRef<Path>>(path: P) -> bool {
[INFO] [stderr]   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()`
[INFO] [stderr]   --> tests/../src/lsb_release.rs:19:5
[INFO] [stderr]    |
[INFO] [stderr] 19 | /     match Command::new("lsb_release").output() {
[INFO] [stderr] 20 | |         Ok(_) => true,
[INFO] [stderr] 21 | |         Err(_) => false
[INFO] [stderr] 22 | |     }
[INFO] [stderr]    | |_____^ help: try this: `Command::new("lsb_release").output().is_ok()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 3.01s
[INFO] running `"docker" "inspect" "2b6fb45b20fd0a9fe8424fd8bc11218fea8a1afbc92eeec678cd0c2bfc3955aa"`
[INFO] running `"docker" "rm" "-f" "2b6fb45b20fd0a9fe8424fd8bc11218fea8a1afbc92eeec678cd0c2bfc3955aa"`
[INFO] [stdout] 2b6fb45b20fd0a9fe8424fd8bc11218fea8a1afbc92eeec678cd0c2bfc3955aa