[INFO] crate os_socketaddr 0.1.0 is already in cache [INFO] extracting crate os_socketaddr 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/os_socketaddr/0.1.0 [INFO] extracting crate os_socketaddr 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/os_socketaddr/0.1.0 [INFO] validating manifest of os_socketaddr-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of os_socketaddr-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing os_socketaddr-0.1.0 [INFO] finished frobbing os_socketaddr-0.1.0 [INFO] frobbed toml for os_socketaddr-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/os_socketaddr/0.1.0/Cargo.toml [INFO] started frobbing os_socketaddr-0.1.0 [INFO] finished frobbing os_socketaddr-0.1.0 [INFO] frobbed toml for os_socketaddr-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/os_socketaddr/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting os_socketaddr-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/os_socketaddr/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 78ca96ebecf83a84ea50003bd398c4957d97e0d1fb588a419b9f2073e01f3789 [INFO] running `"docker" "start" "-a" "78ca96ebecf83a84ea50003bd398c4957d97e0d1fb588a419b9f2073e01f3789"` [INFO] [stderr] Checking os_socketaddr v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: item `OsSocketAddr` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lib.rs:71:1 [INFO] [stderr] | [INFO] [stderr] 71 | / impl OsSocketAddr { [INFO] [stderr] 72 | | [INFO] [stderr] 73 | | /// Create a new empty socket address [INFO] [stderr] 74 | | pub fn new() -> Self [INFO] [stderr] ... | [INFO] [stderr] 141 | | [INFO] [stderr] 142 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `OsSocketAddr` [INFO] [stderr] --> src/lib.rs:74:5 [INFO] [stderr] | [INFO] [stderr] 74 | / pub fn new() -> Self [INFO] [stderr] 75 | | { [INFO] [stderr] 76 | | OsSocketAddr{sa6: unsafe { std::mem::zeroed() }} [INFO] [stderr] 77 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 71 | impl Default for OsSocketAddr { [INFO] [stderr] 72 | fn default() -> Self { [INFO] [stderr] 73 | Self::new() [INFO] [stderr] 74 | } [INFO] [stderr] 75 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:119:16 [INFO] [stderr] | [INFO] [stderr] 119 | (match self.sa6.sin6_family as i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.sa6.sin6_family)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:179:24 [INFO] [stderr] | [INFO] [stderr] 179 | unsafe { match self.sa6.sin6_family as i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.sa6.sin6_family)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: casting from `*const libc::sockaddr` to a more-strictly-aligned pointer (`*const std::net::SocketAddrV4`) [INFO] [stderr] --> src/lib.rs:180:57 [INFO] [stderr] | [INFO] [stderr] 180 | libc::AF_INET => Some(SocketAddr::V4(*(self.as_ptr() as *const _))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const libc::sockaddr` to a more-strictly-aligned pointer (`*const std::net::SocketAddrV6`) [INFO] [stderr] --> src/lib.rs:181:57 [INFO] [stderr] | [INFO] [stderr] 181 | libc::AF_INET6 => Some(SocketAddr::V6(*(self.as_ptr() as *const _))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `os_socketaddr`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:292:25 [INFO] [stderr] | [INFO] [stderr] 292 | 0x11223344, 0x55667788)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1122_3344` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:292:37 [INFO] [stderr] | [INFO] [stderr] 292 | 0x11223344, 0x55667788)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x5566_7788` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:298:32 [INFO] [stderr] | [INFO] [stderr] 298 | sin6_flowinfo: 0x11223344, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1122_3344` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:299:32 [INFO] [stderr] | [INFO] [stderr] 299 | sin6_scope_id: 0x55667788, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x5566_7788` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: item `OsSocketAddr` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lib.rs:71:1 [INFO] [stderr] | [INFO] [stderr] 71 | / impl OsSocketAddr { [INFO] [stderr] 72 | | [INFO] [stderr] 73 | | /// Create a new empty socket address [INFO] [stderr] 74 | | pub fn new() -> Self [INFO] [stderr] ... | [INFO] [stderr] 141 | | [INFO] [stderr] 142 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `OsSocketAddr` [INFO] [stderr] --> src/lib.rs:74:5 [INFO] [stderr] | [INFO] [stderr] 74 | / pub fn new() -> Self [INFO] [stderr] 75 | | { [INFO] [stderr] 76 | | OsSocketAddr{sa6: unsafe { std::mem::zeroed() }} [INFO] [stderr] 77 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 71 | impl Default for OsSocketAddr { [INFO] [stderr] 72 | fn default() -> Self { [INFO] [stderr] 73 | Self::new() [INFO] [stderr] 74 | } [INFO] [stderr] 75 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:119:16 [INFO] [stderr] | [INFO] [stderr] 119 | (match self.sa6.sin6_family as i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.sa6.sin6_family)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:179:24 [INFO] [stderr] | [INFO] [stderr] 179 | unsafe { match self.sa6.sin6_family as i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.sa6.sin6_family)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: casting from `*const libc::sockaddr` to a more-strictly-aligned pointer (`*const std::net::SocketAddrV4`) [INFO] [stderr] --> src/lib.rs:180:57 [INFO] [stderr] | [INFO] [stderr] 180 | libc::AF_INET => Some(SocketAddr::V4(*(self.as_ptr() as *const _))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const libc::sockaddr` to a more-strictly-aligned pointer (`*const std::net::SocketAddrV6`) [INFO] [stderr] --> src/lib.rs:181:57 [INFO] [stderr] | [INFO] [stderr] 181 | libc::AF_INET6 => Some(SocketAddr::V6(*(self.as_ptr() as *const _))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const [u8; 4]` to a more-strictly-aligned pointer (`*const libc::in_addr`) [INFO] [stderr] --> src/lib.rs:268:28 [INFO] [stderr] | [INFO] [stderr] 268 | sin_addr: *(&[12u8,34,56,78] as *const _ as *const libc::in_addr), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const [u8; 16]` to a more-strictly-aligned pointer (`*const libc::in6_addr`) [INFO] [stderr] --> src/lib.rs:296:29 [INFO] [stderr] | [INFO] [stderr] 296 | sin6_addr: *(&ip as *const _ as *const libc::in6_addr), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `os_socketaddr`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "78ca96ebecf83a84ea50003bd398c4957d97e0d1fb588a419b9f2073e01f3789"` [INFO] running `"docker" "rm" "-f" "78ca96ebecf83a84ea50003bd398c4957d97e0d1fb588a419b9f2073e01f3789"` [INFO] [stdout] 78ca96ebecf83a84ea50003bd398c4957d97e0d1fb588a419b9f2073e01f3789