[INFO] crate ordermap 0.4.2 is already in cache [INFO] extracting crate ordermap 0.4.2 into work/ex/clippy-test-run/sources/stable/reg/ordermap/0.4.2 [INFO] extracting crate ordermap 0.4.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ordermap/0.4.2 [INFO] validating manifest of ordermap-0.4.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ordermap-0.4.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ordermap-0.4.2 [INFO] finished frobbing ordermap-0.4.2 [INFO] frobbed toml for ordermap-0.4.2 written to work/ex/clippy-test-run/sources/stable/reg/ordermap/0.4.2/Cargo.toml [INFO] started frobbing ordermap-0.4.2 [INFO] finished frobbing ordermap-0.4.2 [INFO] frobbed toml for ordermap-0.4.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ordermap/0.4.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ordermap-0.4.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/ordermap/0.4.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5d7652dffe7c64cff7c148dfb2adc00bc6a75d4dfb50cd00b00ccbfc7a8861c3 [INFO] running `"docker" "start" "-a" "5d7652dffe7c64cff7c148dfb2adc00bc6a75d4dfb50cd00b00ccbfc7a8861c3"` [INFO] [stderr] Checking ordermap v0.4.2 (/opt/crater/workdir) [INFO] [stderr] Checking quickcheck v0.6.2 [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/set.rs:183:13 [INFO] [stderr] | [INFO] [stderr] 183 | other: other, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `other` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/set.rs:209:13 [INFO] [stderr] | [INFO] [stderr] 209 | other: other, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `other` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/map.rs:392:17 [INFO] [stderr] | [INFO] [stderr] 392 | hash_builder: hash_builder, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `hash_builder` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/map.rs:403:17 [INFO] [stderr] | [INFO] [stderr] 403 | hash_builder: hash_builder, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `hash_builder` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/map.rs:633:72 [INFO] [stderr] | [INFO] [stderr] 633 | self.map.entries.push(Bucket { hash: self.hash, key: self.key, value: value }); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/map.rs:1199:36 [INFO] [stderr] | [INFO] [stderr] 1199 | self.entries.push(Bucket { hash: hash, key: key, value: value }); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `hash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/map.rs:1199:48 [INFO] [stderr] | [INFO] [stderr] 1199 | self.entries.push(Bucket { hash: hash, key: key, value: value }); [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/map.rs:1199:58 [INFO] [stderr] | [INFO] [stderr] 1199 | self.entries.push(Bucket { hash: hash, key: key, value: value }); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/map.rs:170:16 [INFO] [stderr] | [INFO] [stderr] 170 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 171 | | if !self.is_none() { [INFO] [stderr] 172 | | let (i, hash) = split_lo_hi(self.index); [INFO] [stderr] 173 | | Some((i as usize, ShortHashProxy::new(hash as usize))) [INFO] [stderr] ... | [INFO] [stderr] 176 | | } [INFO] [stderr] 177 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 170 | } else if !self.is_none() { [INFO] [stderr] 171 | let (i, hash) = split_lo_hi(self.index); [INFO] [stderr] 172 | Some((i as usize, ShortHashProxy::new(hash as usize))) [INFO] [stderr] 173 | } else { [INFO] [stderr] 174 | None [INFO] [stderr] 175 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/set.rs:517:20 [INFO] [stderr] | [INFO] [stderr] 517 | let iter = iterable.into_iter().map(|&x| x); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `iterable.into_iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/map.rs:120:16 [INFO] [stderr] | [INFO] [stderr] 120 | fn is_none(&self) -> bool { self.index == !0 } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/map.rs:125:12 [INFO] [stderr] | [INFO] [stderr] 125 | fn pos(&self) -> Option { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/map.rs:161:20 [INFO] [stderr] | [INFO] [stderr] 161 | fn resolve(&self) -> Option<(usize, ShortHashProxy)> [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/map.rs:182:35 [INFO] [stderr] | [INFO] [stderr] 182 | fn resolve_existing_index(&self) -> usize [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/map.rs:835:12 [INFO] [stderr] | [INFO] [stderr] 835 | if self.len() == 0 { return None; } [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/map.rs:1094:24 [INFO] [stderr] | [INFO] [stderr] 1094 | if let Some(_) = self.indices[probe].resolve::() { [INFO] [stderr] | _________________- ^^^^^^^ [INFO] [stderr] 1095 | | /* nothing */ [INFO] [stderr] 1096 | | } else { [INFO] [stderr] 1097 | | // empty bucket, insert here [INFO] [stderr] 1098 | | self.indices[probe] = Pos::with_hash::(i, entry_hash); [INFO] [stderr] 1099 | | return; [INFO] [stderr] 1100 | | } [INFO] [stderr] | |_________________- help: try this: `if self.indices[probe].resolve::().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/set.rs:183:13 [INFO] [stderr] | [INFO] [stderr] 183 | other: other, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `other` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/set.rs:209:13 [INFO] [stderr] | [INFO] [stderr] 209 | other: other, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `other` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/map.rs:392:17 [INFO] [stderr] | [INFO] [stderr] 392 | hash_builder: hash_builder, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `hash_builder` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/map.rs:403:17 [INFO] [stderr] | [INFO] [stderr] 403 | hash_builder: hash_builder, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `hash_builder` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/map.rs:633:72 [INFO] [stderr] | [INFO] [stderr] 633 | self.map.entries.push(Bucket { hash: self.hash, key: self.key, value: value }); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/map.rs:1199:36 [INFO] [stderr] | [INFO] [stderr] 1199 | self.entries.push(Bucket { hash: hash, key: key, value: value }); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `hash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/map.rs:1199:48 [INFO] [stderr] | [INFO] [stderr] 1199 | self.entries.push(Bucket { hash: hash, key: key, value: value }); [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/map.rs:1199:58 [INFO] [stderr] | [INFO] [stderr] 1199 | self.entries.push(Bucket { hash: hash, key: key, value: value }); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/bench.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `ordermap`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/faststring.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `ordermap`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: use of deprecated item 'ordermap::OrderMap': the crate ordermap has been renamed with no change in functionality to indexmap; please update your dependencies [INFO] [stderr] --> tests/tests.rs:9:13 [INFO] [stderr] | [INFO] [stderr] 9 | let m = ordermap! { [INFO] [stderr] | _____________^ [INFO] [stderr] 10 | | 1 => 2, [INFO] [stderr] 11 | | 7 => 1, [INFO] [stderr] 12 | | 2 => 2, [INFO] [stderr] 13 | | 3 => 3, [INFO] [stderr] 14 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'ordermap::OrderSet': the crate ordermap has been renamed with no change in functionality to indexmap; please update your dependencies [INFO] [stderr] --> tests/tests.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | let s = orderset! { [INFO] [stderr] | _____________^ [INFO] [stderr] 24 | | 1, [INFO] [stderr] 25 | | 7, [INFO] [stderr] 26 | | 2, [INFO] [stderr] 27 | | 3, [INFO] [stderr] 28 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> tests/quick.rs:329:18 [INFO] [stderr] | [INFO] [stderr] 329 | const ALPHABET: &'static [u8] = b"abcdefghijklmnopqrstuvwxyz"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'ordermap::OrderMap': the crate ordermap has been renamed with no change in functionality to indexmap; please update your dependencies [INFO] [stderr] --> tests/quick.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | use ordermap::OrderMap; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'ordermap::OrderMap': the crate ordermap has been renamed with no change in functionality to indexmap; please update your dependencies [INFO] [stderr] --> tests/quick.rs:18:26 [INFO] [stderr] | [INFO] [stderr] 18 | type OrderMapFnv = OrderMap; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'ordermap::OrderMap': the crate ordermap has been renamed with no change in functionality to indexmap; please update your dependencies [INFO] [stderr] --> tests/quick.rs:40:39 [INFO] [stderr] | [INFO] [stderr] 40 | fn ordermap<'a, T: 'a, I>(iter: I) -> OrderMap [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'ordermap::OrderMap': the crate ordermap has been renamed with no change in functionality to indexmap; please update your dependencies [INFO] [stderr] --> tests/quick.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | OrderMap::from_iter(iter.into_iter().cloned().map(|k| (k, ()))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'ordermap::OrderMap': the crate ordermap has been renamed with no change in functionality to indexmap; please update your dependencies [INFO] [stderr] --> tests/quick.rs:145:46 [INFO] [stderr] | [INFO] [stderr] 145 | fn do_ops(ops: &[Op], a: &mut OrderMap, b: &mut HashMap) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'ordermap::OrderMap': the crate ordermap has been renamed with no change in functionality to indexmap; please update your dependencies [INFO] [stderr] --> tests/quick.rs:179:37 [INFO] [stderr] | [INFO] [stderr] 179 | fn assert_maps_equivalent(a: &OrderMap, b: &HashMap) -> bool [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'ordermap::OrderMap': the crate ordermap has been renamed with no change in functionality to indexmap; please update your dependencies [INFO] [stderr] --> tests/quick.rs:49:23 [INFO] [stderr] | [INFO] [stderr] 49 | let mut map = OrderMap::new(); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'ordermap::OrderMap': the crate ordermap has been renamed with no change in functionality to indexmap; please update your dependencies [INFO] [stderr] --> tests/quick.rs:57:23 [INFO] [stderr] | [INFO] [stderr] 57 | let mut map = OrderMap::new(); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'ordermap::OrderMap': the crate ordermap has been renamed with no change in functionality to indexmap; please update your dependencies [INFO] [stderr] --> tests/quick.rs:66:23 [INFO] [stderr] | [INFO] [stderr] 66 | let mut map = OrderMap::new(); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'ordermap::OrderMap': the crate ordermap has been renamed with no change in functionality to indexmap; please update your dependencies [INFO] [stderr] --> tests/quick.rs:79:23 [INFO] [stderr] | [INFO] [stderr] 79 | let mut map = OrderMap::new(); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'ordermap::OrderMap': the crate ordermap has been renamed with no change in functionality to indexmap; please update your dependencies [INFO] [stderr] --> tests/quick.rs:88:23 [INFO] [stderr] | [INFO] [stderr] 88 | let mut map = OrderMap::new(); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'ordermap::OrderMap': the crate ordermap has been renamed with no change in functionality to indexmap; please update your dependencies [INFO] [stderr] --> tests/quick.rs:103:37 [INFO] [stderr] | [INFO] [stderr] 103 | let map: OrderMap = OrderMap::with_capacity(cap); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'ordermap::OrderMap': the crate ordermap has been renamed with no change in functionality to indexmap; please update your dependencies [INFO] [stderr] --> tests/quick.rs:103:18 [INFO] [stderr] | [INFO] [stderr] 103 | let map: OrderMap = OrderMap::with_capacity(cap); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'ordermap::OrderMap': the crate ordermap has been renamed with no change in functionality to indexmap; please update your dependencies [INFO] [stderr] --> tests/quick.rs:109:23 [INFO] [stderr] | [INFO] [stderr] 109 | let mut map = OrderMap::new(); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'ordermap::OrderMap': the crate ordermap has been renamed with no change in functionality to indexmap; please update your dependencies [INFO] [stderr] --> tests/quick.rs:199:23 [INFO] [stderr] | [INFO] [stderr] 199 | let mut map = OrderMap::new(); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'ordermap::OrderMap': the crate ordermap has been renamed with no change in functionality to indexmap; please update your dependencies [INFO] [stderr] --> tests/quick.rs:206:23 [INFO] [stderr] | [INFO] [stderr] 206 | let mut map = OrderMap::new(); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'ordermap::OrderMap': the crate ordermap has been renamed with no change in functionality to indexmap; please update your dependencies [INFO] [stderr] --> tests/quick.rs:213:23 [INFO] [stderr] | [INFO] [stderr] 213 | let mut map = OrderMap::new(); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'ordermap::OrderMap': the crate ordermap has been renamed with no change in functionality to indexmap; please update your dependencies [INFO] [stderr] --> tests/quick.rs:216:25 [INFO] [stderr] | [INFO] [stderr] 216 | let mut visit = OrderMap::new(); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'ordermap::OrderMap': the crate ordermap has been renamed with no change in functionality to indexmap; please update your dependencies [INFO] [stderr] --> tests/quick.rs:227:23 [INFO] [stderr] | [INFO] [stderr] 227 | let mut map = OrderMap::new(); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'ordermap::OrderMap': the crate ordermap has been renamed with no change in functionality to indexmap; please update your dependencies [INFO] [stderr] --> tests/quick.rs:230:25 [INFO] [stderr] | [INFO] [stderr] 230 | let mut visit = OrderMap::new(); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'ordermap::OrderMap': the crate ordermap has been renamed with no change in functionality to indexmap; please update your dependencies [INFO] [stderr] --> tests/quick.rs:242:23 [INFO] [stderr] | [INFO] [stderr] 242 | let mut map = OrderMap::new(); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'ordermap::OrderMap': the crate ordermap has been renamed with no change in functionality to indexmap; please update your dependencies [INFO] [stderr] --> tests/quick.rs:278:39 [INFO] [stderr] | [INFO] [stderr] 278 | let mut map: OrderMap<_, _> = OrderMap::from_iter(keyvals.to_vec()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'ordermap::OrderMap': the crate ordermap has been renamed with no change in functionality to indexmap; please update your dependencies [INFO] [stderr] --> tests/quick.rs:278:22 [INFO] [stderr] | [INFO] [stderr] 278 | let mut map: OrderMap<_, _> = OrderMap::from_iter(keyvals.to_vec()); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'ordermap::OrderMap': the crate ordermap has been renamed with no change in functionality to indexmap; please update your dependencies [INFO] [stderr] --> tests/quick.rs:303:39 [INFO] [stderr] | [INFO] [stderr] 303 | let mut map: OrderMap<_, _> = OrderMap::from_iter(keyvals.to_vec()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'ordermap::OrderMap': the crate ordermap has been renamed with no change in functionality to indexmap; please update your dependencies [INFO] [stderr] --> tests/quick.rs:303:22 [INFO] [stderr] | [INFO] [stderr] 303 | let mut map: OrderMap<_, _> = OrderMap::from_iter(keyvals.to_vec()); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'ordermap::OrderMap': the crate ordermap has been renamed with no change in functionality to indexmap; please update your dependencies [INFO] [stderr] --> tests/equivalent_trait.rs:35:15 [INFO] [stderr] | [INFO] [stderr] 35 | let map = ordermap! { [INFO] [stderr] | _______________^ [INFO] [stderr] 36 | | (s("a"), s("b")) => 1, [INFO] [stderr] 37 | | (s("a"), s("x")) => 2, [INFO] [stderr] 38 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'ordermap::OrderMap': the crate ordermap has been renamed with no change in functionality to indexmap; please update your dependencies [INFO] [stderr] --> tests/equivalent_trait.rs:47:19 [INFO] [stderr] | [INFO] [stderr] 47 | let mut map = ordermap! { [INFO] [stderr] | ___________________^ [INFO] [stderr] 48 | | s("a") => 1, s("b") => 2, [INFO] [stderr] 49 | | s("x") => 3, s("y") => 4, [INFO] [stderr] 50 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> tests/equivalent_trait.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | / self.0 == rhs.0 && [INFO] [stderr] 17 | | self.1 == rhs.1 && [INFO] [stderr] 18 | | true [INFO] [stderr] | |____________^ help: try: `self.0 == rhs.0 && self.1 == rhs.1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/map.rs:170:16 [INFO] [stderr] | [INFO] [stderr] 170 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 171 | | if !self.is_none() { [INFO] [stderr] 172 | | let (i, hash) = split_lo_hi(self.index); [INFO] [stderr] 173 | | Some((i as usize, ShortHashProxy::new(hash as usize))) [INFO] [stderr] ... | [INFO] [stderr] 176 | | } [INFO] [stderr] 177 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 170 | } else if !self.is_none() { [INFO] [stderr] 171 | let (i, hash) = split_lo_hi(self.index); [INFO] [stderr] 172 | Some((i as usize, ShortHashProxy::new(hash as usize))) [INFO] [stderr] 173 | } else { [INFO] [stderr] 174 | None [INFO] [stderr] 175 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> tests/quick.rs:158:36 [INFO] [stderr] | [INFO] [stderr] 158 | b.entry(k.clone()).or_insert(v.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| v.clone())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> tests/quick.rs:165:17 [INFO] [stderr] | [INFO] [stderr] 165 | / match a.entry(k.clone()) { [INFO] [stderr] 166 | | OEntry::Occupied(ent) => { ent.remove_entry(); }, [INFO] [stderr] 167 | | _ => { } [INFO] [stderr] 168 | | } [INFO] [stderr] | |_________________^ help: try this: `if let OEntry::Occupied(ent) = a.entry(k.clone()) { ent.remove_entry(); }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> tests/quick.rs:169:17 [INFO] [stderr] | [INFO] [stderr] 169 | / match b.entry(k.clone()) { [INFO] [stderr] 170 | | HEntry::Occupied(ent) => { ent.remove_entry(); }, [INFO] [stderr] 171 | | _ => { } [INFO] [stderr] 172 | | } [INFO] [stderr] | |_________________^ help: try this: `if let HEntry::Occupied(ent) = b.entry(k.clone()) { ent.remove_entry(); }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/set.rs:517:20 [INFO] [stderr] | [INFO] [stderr] 517 | let iter = iterable.into_iter().map(|&x| x); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `iterable.into_iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/set.rs:850:20 [INFO] [stderr] | [INFO] [stderr] 850 | if !set.get(value).is_some() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `set.get(value).is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 29 [INFO] [stderr] --> src/set.rs:1099:5 [INFO] [stderr] | [INFO] [stderr] 1099 | / fn ops() { [INFO] [stderr] 1100 | | let empty = OrderSet::::new(); [INFO] [stderr] 1101 | | let set_a: OrderSet<_> = (0..3).collect(); [INFO] [stderr] 1102 | | let set_b: OrderSet<_> = (3..6).collect(); [INFO] [stderr] ... | [INFO] [stderr] 1136 | | assert_eq!(&set_d - &set_c, &set_d - &set_b); [INFO] [stderr] 1137 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `&` [INFO] [stderr] --> src/set.rs:1106:20 [INFO] [stderr] | [INFO] [stderr] 1106 | assert_eq!(&set_a & &set_a, set_a); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::eq_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `|` [INFO] [stderr] --> src/set.rs:1107:20 [INFO] [stderr] | [INFO] [stderr] 1107 | assert_eq!(&set_a | &set_a, set_a); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `^` [INFO] [stderr] --> src/set.rs:1108:20 [INFO] [stderr] | [INFO] [stderr] 1108 | assert_eq!(&set_a ^ &set_a, empty); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `-` [INFO] [stderr] --> src/set.rs:1109:20 [INFO] [stderr] | [INFO] [stderr] 1109 | assert_eq!(&set_a - &set_a, empty); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/map.rs:120:16 [INFO] [stderr] | [INFO] [stderr] 120 | fn is_none(&self) -> bool { self.index == !0 } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/map.rs:125:12 [INFO] [stderr] | [INFO] [stderr] 125 | fn pos(&self) -> Option { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/map.rs:161:20 [INFO] [stderr] | [INFO] [stderr] 161 | fn resolve(&self) -> Option<(usize, ShortHashProxy)> [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/map.rs:182:35 [INFO] [stderr] | [INFO] [stderr] 182 | fn resolve_existing_index(&self) -> usize [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/map.rs:835:12 [INFO] [stderr] | [INFO] [stderr] 835 | if self.len() == 0 { return None; } [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/map.rs:1094:24 [INFO] [stderr] | [INFO] [stderr] 1094 | if let Some(_) = self.indices[probe].resolve::() { [INFO] [stderr] | _________________- ^^^^^^^ [INFO] [stderr] 1095 | | /* nothing */ [INFO] [stderr] 1096 | | } else { [INFO] [stderr] 1097 | | // empty bucket, insert here [INFO] [stderr] 1098 | | self.indices[probe] = Pos::with_hash::(i, entry_hash); [INFO] [stderr] 1099 | | return; [INFO] [stderr] 1100 | | } [INFO] [stderr] | |_________________- help: try this: `if self.indices[probe].resolve::().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/map.rs:1769:20 [INFO] [stderr] | [INFO] [stderr] 1769 | if !map.get(key).is_some() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `map.get(key).is_none()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `ordermap`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "5d7652dffe7c64cff7c148dfb2adc00bc6a75d4dfb50cd00b00ccbfc7a8861c3"` [INFO] running `"docker" "rm" "-f" "5d7652dffe7c64cff7c148dfb2adc00bc6a75d4dfb50cd00b00ccbfc7a8861c3"` [INFO] [stdout] 5d7652dffe7c64cff7c148dfb2adc00bc6a75d4dfb50cd00b00ccbfc7a8861c3