[INFO] crate ord_subset 3.1.1 is already in cache [INFO] extracting crate ord_subset 3.1.1 into work/ex/clippy-test-run/sources/stable/reg/ord_subset/3.1.1 [INFO] extracting crate ord_subset 3.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ord_subset/3.1.1 [INFO] validating manifest of ord_subset-3.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ord_subset-3.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ord_subset-3.1.1 [INFO] finished frobbing ord_subset-3.1.1 [INFO] frobbed toml for ord_subset-3.1.1 written to work/ex/clippy-test-run/sources/stable/reg/ord_subset/3.1.1/Cargo.toml [INFO] started frobbing ord_subset-3.1.1 [INFO] finished frobbing ord_subset-3.1.1 [INFO] frobbed toml for ord_subset-3.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ord_subset/3.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ord_subset-3.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/ord_subset/3.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7dfb3ec9f4ea223647e6a944226c55e18b1e6fc5bf191a737abb0402f61a184c [INFO] running `"docker" "start" "-a" "7dfb3ec9f4ea223647e6a944226c55e18b1e6fc5bf191a737abb0402f61a184c"` [INFO] [stderr] Checking ord_subset v3.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: lint name `inline_always` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:1:45 [INFO] [stderr] | [INFO] [stderr] 1 | #![cfg_attr(feature = "cargo-clippy", allow(inline_always, match_bool))] [INFO] [stderr] | ^^^^^^^^^^^^^ help: change it to: `clippy::inline_always` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `match_bool` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:1:60 [INFO] [stderr] | [INFO] [stderr] 1 | #![cfg_attr(feature = "cargo-clippy", allow(inline_always, match_bool))] [INFO] [stderr] | ^^^^^^^^^^ help: change it to: `clippy::match_bool` [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/ord_var.rs:102:5 [INFO] [stderr] | [INFO] [stderr] 102 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/ord_subset_trait.rs:74:1 [INFO] [stderr] | [INFO] [stderr] 74 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/ord_subset_trait.rs:90:1 [INFO] [stderr] | [INFO] [stderr] 90 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/ord_subset_trait.rs:252:9 [INFO] [stderr] | [INFO] [stderr] 252 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/ord_subset_trait.rs:258:5 [INFO] [stderr] | [INFO] [stderr] 258 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: lint name `inline_always` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:1:45 [INFO] [stderr] | [INFO] [stderr] 1 | #![cfg_attr(feature = "cargo-clippy", allow(inline_always, match_bool))] [INFO] [stderr] | ^^^^^^^^^^^^^ help: change it to: `clippy::inline_always` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `match_bool` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:1:60 [INFO] [stderr] | [INFO] [stderr] 1 | #![cfg_attr(feature = "cargo-clippy", allow(inline_always, match_bool))] [INFO] [stderr] | ^^^^^^^^^^ help: change it to: `clippy::match_bool` [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/ord_var.rs:102:5 [INFO] [stderr] | [INFO] [stderr] 102 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/ord_subset_trait.rs:74:1 [INFO] [stderr] | [INFO] [stderr] 74 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/ord_subset_trait.rs:90:1 [INFO] [stderr] | [INFO] [stderr] 90 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/ord_subset_trait.rs:252:9 [INFO] [stderr] | [INFO] [stderr] 252 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/ord_subset_trait.rs:258:5 [INFO] [stderr] | [INFO] [stderr] 258 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: lint name `inline_always` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:1:45 [INFO] [stderr] | [INFO] [stderr] 1 | #![cfg_attr(feature = "cargo-clippy", allow(inline_always, match_bool))] [INFO] [stderr] | ^^^^^^^^^^^^^ help: change it to: `clippy::inline_always` [INFO] [stderr] [INFO] [stderr] warning: lint name `inline_always` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:1:45 [INFO] [stderr] | [INFO] [stderr] 1 | #![cfg_attr(feature = "cargo-clippy", allow(inline_always, match_bool))] [INFO] [stderr] | ^^^^^^^^^^^^^ help: change it to: `clippy::inline_always` [INFO] [stderr] [INFO] [stderr] warning: lint name `float_cmp` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/ord_subset_trait.rs:36:44 [INFO] [stderr] | [INFO] [stderr] 36 | #[cfg_attr(feature = "cargo-clippy", allow(float_cmp, eq_op))] [INFO] [stderr] | ^^^^^^^^^ help: change it to: `clippy::float_cmp` [INFO] [stderr] [INFO] [stderr] warning: lint name `eq_op` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/ord_subset_trait.rs:36:55 [INFO] [stderr] | [INFO] [stderr] 36 | #[cfg_attr(feature = "cargo-clippy", allow(float_cmp, eq_op))] [INFO] [stderr] | ^^^^^ help: change it to: `clippy::eq_op` [INFO] [stderr] [INFO] [stderr] warning: lint name `float_cmp` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/ord_subset_trait.rs:45:44 [INFO] [stderr] | [INFO] [stderr] 45 | #[cfg_attr(feature = "cargo-clippy", allow(float_cmp, eq_op))] [INFO] [stderr] | ^^^^^^^^^ help: change it to: `clippy::float_cmp` [INFO] [stderr] [INFO] [stderr] warning: lint name `eq_op` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/ord_subset_trait.rs:45:55 [INFO] [stderr] | [INFO] [stderr] 45 | #[cfg_attr(feature = "cargo-clippy", allow(float_cmp, eq_op))] [INFO] [stderr] | ^^^^^ help: change it to: `clippy::eq_op` [INFO] [stderr] [INFO] [stderr] warning: lint name `float_cmp` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/ord_subset_trait.rs:36:44 [INFO] [stderr] | [INFO] [stderr] 36 | #[cfg_attr(feature = "cargo-clippy", allow(float_cmp, eq_op))] [INFO] [stderr] | ^^^^^^^^^ help: change it to: `clippy::float_cmp` [INFO] [stderr] [INFO] [stderr] warning: lint name `eq_op` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/ord_subset_trait.rs:36:55 [INFO] [stderr] | [INFO] [stderr] 36 | #[cfg_attr(feature = "cargo-clippy", allow(float_cmp, eq_op))] [INFO] [stderr] | ^^^^^ help: change it to: `clippy::eq_op` [INFO] [stderr] [INFO] [stderr] warning: lint name `float_cmp` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/ord_subset_trait.rs:45:44 [INFO] [stderr] | [INFO] [stderr] 45 | #[cfg_attr(feature = "cargo-clippy", allow(float_cmp, eq_op))] [INFO] [stderr] | ^^^^^^^^^ help: change it to: `clippy::float_cmp` [INFO] [stderr] [INFO] [stderr] warning: lint name `eq_op` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/ord_subset_trait.rs:45:55 [INFO] [stderr] | [INFO] [stderr] 45 | #[cfg_attr(feature = "cargo-clippy", allow(float_cmp, eq_op))] [INFO] [stderr] | ^^^^^ help: change it to: `clippy::eq_op` [INFO] [stderr] [INFO] [stderr] warning: lint name `float_cmp` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> tests/lib.rs:1:45 [INFO] [stderr] | [INFO] [stderr] 1 | #![cfg_attr(feature = "cargo-clippy", allow(float_cmp, match_wild_err_arm))] [INFO] [stderr] | ^^^^^^^^^ help: change it to: `clippy::float_cmp` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `match_wild_err_arm` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> tests/lib.rs:1:56 [INFO] [stderr] | [INFO] [stderr] 1 | #![cfg_attr(feature = "cargo-clippy", allow(float_cmp, match_wild_err_arm))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::match_wild_err_arm` [INFO] [stderr] [INFO] [stderr] warning: lint name `float_cmp` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> tests/lib.rs:1:45 [INFO] [stderr] | [INFO] [stderr] 1 | #![cfg_attr(feature = "cargo-clippy", allow(float_cmp, match_wild_err_arm))] [INFO] [stderr] | ^^^^^^^^^ help: change it to: `clippy::float_cmp` [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> tests/lib.rs:118:22 [INFO] [stderr] | [INFO] [stderr] 118 | fn key_function(el: &f64) -> f64 { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `f64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> tests/lib.rs:150:22 [INFO] [stderr] | [INFO] [stderr] 150 | fn key_function(el: &f64) -> f64 { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `f64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> tests/lib.rs:181:22 [INFO] [stderr] | [INFO] [stderr] 181 | fn key_function(el: &f64) -> f64 { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `f64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> tests/lib.rs:224:22 [INFO] [stderr] | [INFO] [stderr] 224 | fn key_function(el: &f64) -> f64 { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `f64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.26s [INFO] running `"docker" "inspect" "7dfb3ec9f4ea223647e6a944226c55e18b1e6fc5bf191a737abb0402f61a184c"` [INFO] running `"docker" "rm" "-f" "7dfb3ec9f4ea223647e6a944226c55e18b1e6fc5bf191a737abb0402f61a184c"` [INFO] [stdout] 7dfb3ec9f4ea223647e6a944226c55e18b1e6fc5bf191a737abb0402f61a184c