[INFO] crate oracle 0.2.0 is already in cache [INFO] extracting crate oracle 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/oracle/0.2.0 [INFO] extracting crate oracle 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/oracle/0.2.0 [INFO] validating manifest of oracle-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of oracle-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing oracle-0.2.0 [INFO] finished frobbing oracle-0.2.0 [INFO] frobbed toml for oracle-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/oracle/0.2.0/Cargo.toml [INFO] started frobbing oracle-0.2.0 [INFO] finished frobbing oracle-0.2.0 [INFO] frobbed toml for oracle-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/oracle/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting oracle-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/oracle/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d74092da280cf244a60f3445707c9d932ba572c23d9784dda3a58229f6fa64cb [INFO] running `"docker" "start" "-a" "d74092da280cf244a60f3445707c9d932ba572c23d9784dda3a58229f6fa64cb"` [INFO] [stderr] Compiling oracle v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | typename: typename, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `typename` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:140:13 [INFO] [stderr] | [INFO] [stderr] 140 | code: code, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:141:13 [INFO] [stderr] | [INFO] [stderr] 141 | offset: offset, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:142:13 [INFO] [stderr] | [INFO] [stderr] 142 | message: message, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `message` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:143:13 [INFO] [stderr] | [INFO] [stderr] 143 | fn_name: fn_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `fn_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:144:13 [INFO] [stderr] | [INFO] [stderr] 144 | action: action, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `action` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/connection.rs:409:13 [INFO] [stderr] | [INFO] [stderr] 409 | ctxt: ctxt, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `ctxt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/connection.rs:410:13 [INFO] [stderr] | [INFO] [stderr] 410 | handle: handle, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `handle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/row.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | column_names: column_names, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `column_names` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/row.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | column_values: column_values, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `column_values` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/row.rs:249:13 [INFO] [stderr] | [INFO] [stderr] 249 | column_values: column_values, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `column_values` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/statement.rs:228:13 [INFO] [stderr] | [INFO] [stderr] 228 | conn: conn, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `conn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/statement.rs:229:13 [INFO] [stderr] | [INFO] [stderr] 229 | handle: handle, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `handle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/statement.rs:235:13 [INFO] [stderr] | [INFO] [stderr] 235 | bind_count: bind_count, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bind_count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/statement.rs:236:13 [INFO] [stderr] | [INFO] [stderr] 236 | bind_names: bind_names, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bind_names` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/statement.rs:237:13 [INFO] [stderr] | [INFO] [stderr] 237 | bind_values: bind_values, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bind_values` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/statement.rs:238:13 [INFO] [stderr] | [INFO] [stderr] 238 | fetch_array_size: fetch_array_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `fetch_array_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sql_value.rs:145:13 [INFO] [stderr] | [INFO] [stderr] 145 | ctxt: ctxt, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `ctxt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sql_value.rs:161:13 [INFO] [stderr] | [INFO] [stderr] 161 | ctxt: ctxt, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `ctxt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sql_value.rs:164:13 [INFO] [stderr] | [INFO] [stderr] 164 | native_type: native_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `native_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/interval_ds.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | lfprec: lfprec, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `lfprec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/interval_ds.rs:117:13 [INFO] [stderr] | [INFO] [stderr] 117 | fsprec: fsprec, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `fsprec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/interval_ds.rs:137:13 [INFO] [stderr] | [INFO] [stderr] 137 | days: days, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `days` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/interval_ds.rs:138:13 [INFO] [stderr] | [INFO] [stderr] 138 | hours: hours, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `hours` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/interval_ds.rs:139:13 [INFO] [stderr] | [INFO] [stderr] 139 | minutes: minutes, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `minutes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/interval_ds.rs:140:13 [INFO] [stderr] | [INFO] [stderr] 140 | seconds: seconds, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `seconds` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/interval_ds.rs:141:13 [INFO] [stderr] | [INFO] [stderr] 141 | nanoseconds: nanoseconds, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `nanoseconds` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/interval_ds.rs:155:13 [INFO] [stderr] | [INFO] [stderr] 155 | lfprec: lfprec, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `lfprec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/interval_ds.rs:156:13 [INFO] [stderr] | [INFO] [stderr] 156 | fsprec: fsprec, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `fsprec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/interval_ym.rs:117:13 [INFO] [stderr] | [INFO] [stderr] 117 | years: years, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `years` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/interval_ym.rs:118:13 [INFO] [stderr] | [INFO] [stderr] 118 | months: months, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `months` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/interval_ym.rs:129:13 [INFO] [stderr] | [INFO] [stderr] 129 | precision: precision, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `precision` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/object.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | ctxt: ctxt, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `ctxt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/object.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | handle: handle, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `handle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/object.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | objtype: objtype, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `objtype` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/object.rs:316:13 [INFO] [stderr] | [INFO] [stderr] 316 | ctxt: ctxt, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `ctxt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/object.rs:317:13 [INFO] [stderr] | [INFO] [stderr] 317 | handle: handle, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `handle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/object.rs:318:13 [INFO] [stderr] | [INFO] [stderr] 318 | objtype: objtype, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `objtype` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | typename: typename, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `typename` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:140:13 [INFO] [stderr] | [INFO] [stderr] 140 | code: code, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:141:13 [INFO] [stderr] | [INFO] [stderr] 141 | offset: offset, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:142:13 [INFO] [stderr] | [INFO] [stderr] 142 | message: message, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `message` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:143:13 [INFO] [stderr] | [INFO] [stderr] 143 | fn_name: fn_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `fn_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/object.rs:588:13 [INFO] [stderr] | [INFO] [stderr] 588 | ctxt: ctxt, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `ctxt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/object.rs:589:13 [INFO] [stderr] | [INFO] [stderr] 589 | handle: handle, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `handle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/object.rs:677:13 [INFO] [stderr] | [INFO] [stderr] 677 | ctxt: ctxt, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `ctxt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/object.rs:678:13 [INFO] [stderr] | [INFO] [stderr] 678 | handle: handle, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `handle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/object.rs:681:13 [INFO] [stderr] | [INFO] [stderr] 681 | elem_oratype: elem_oratype, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `elem_oratype` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/object.rs:682:13 [INFO] [stderr] | [INFO] [stderr] 682 | attrs: attrs, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `attrs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/timestamp.rs:129:13 [INFO] [stderr] | [INFO] [stderr] 129 | precision: precision, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `precision` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/timestamp.rs:130:13 [INFO] [stderr] | [INFO] [stderr] 130 | with_tz: with_tz, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `with_tz` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/timestamp.rs:151:13 [INFO] [stderr] | [INFO] [stderr] 151 | year: year, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `year` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/timestamp.rs:152:13 [INFO] [stderr] | [INFO] [stderr] 152 | month: month, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `month` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/timestamp.rs:153:13 [INFO] [stderr] | [INFO] [stderr] 153 | day: day, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `day` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/timestamp.rs:154:13 [INFO] [stderr] | [INFO] [stderr] 154 | hour: hour, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `hour` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/timestamp.rs:155:13 [INFO] [stderr] | [INFO] [stderr] 155 | minute: minute, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `minute` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/timestamp.rs:156:13 [INFO] [stderr] | [INFO] [stderr] 156 | second: second, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `second` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/timestamp.rs:157:13 [INFO] [stderr] | [INFO] [stderr] 157 | nanosecond: nanosecond, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `nanosecond` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/timestamp.rs:200:13 [INFO] [stderr] | [INFO] [stderr] 200 | precision: precision, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `precision` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/version.rs:52:19 [INFO] [stderr] | [INFO] [stderr] 52 | Version { major: major, minor: minor, update: update, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `major` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/version.rs:52:33 [INFO] [stderr] | [INFO] [stderr] 52 | Version { major: major, minor: minor, update: update, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `minor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/version.rs:52:47 [INFO] [stderr] | [INFO] [stderr] 52 | Version { major: major, minor: minor, update: update, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `update` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/version.rs:53:19 [INFO] [stderr] | [INFO] [stderr] 53 | patch: patch, port_update: port_update } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `patch` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/version.rs:53:33 [INFO] [stderr] | [INFO] [stderr] 53 | patch: patch, port_update: port_update } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `port_update` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/util.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | chars: chars, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `chars` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/util.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | char: char, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:144:13 [INFO] [stderr] | [INFO] [stderr] 144 | action: action, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `action` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/connection.rs:409:13 [INFO] [stderr] | [INFO] [stderr] 409 | ctxt: ctxt, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `ctxt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/connection.rs:410:13 [INFO] [stderr] | [INFO] [stderr] 410 | handle: handle, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `handle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/row.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | column_names: column_names, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `column_names` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/row.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | column_values: column_values, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `column_values` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/row.rs:249:13 [INFO] [stderr] | [INFO] [stderr] 249 | column_values: column_values, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `column_values` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/statement.rs:228:13 [INFO] [stderr] | [INFO] [stderr] 228 | conn: conn, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `conn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/statement.rs:229:13 [INFO] [stderr] | [INFO] [stderr] 229 | handle: handle, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `handle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/statement.rs:235:13 [INFO] [stderr] | [INFO] [stderr] 235 | bind_count: bind_count, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bind_count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/statement.rs:236:13 [INFO] [stderr] | [INFO] [stderr] 236 | bind_names: bind_names, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bind_names` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/statement.rs:237:13 [INFO] [stderr] | [INFO] [stderr] 237 | bind_values: bind_values, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bind_values` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/statement.rs:238:13 [INFO] [stderr] | [INFO] [stderr] 238 | fetch_array_size: fetch_array_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `fetch_array_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sql_value.rs:145:13 [INFO] [stderr] | [INFO] [stderr] 145 | ctxt: ctxt, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `ctxt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sql_value.rs:161:13 [INFO] [stderr] | [INFO] [stderr] 161 | ctxt: ctxt, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `ctxt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sql_value.rs:164:13 [INFO] [stderr] | [INFO] [stderr] 164 | native_type: native_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `native_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/interval_ds.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | lfprec: lfprec, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `lfprec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/interval_ds.rs:117:13 [INFO] [stderr] | [INFO] [stderr] 117 | fsprec: fsprec, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `fsprec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/interval_ds.rs:137:13 [INFO] [stderr] | [INFO] [stderr] 137 | days: days, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `days` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/interval_ds.rs:138:13 [INFO] [stderr] | [INFO] [stderr] 138 | hours: hours, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `hours` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/interval_ds.rs:139:13 [INFO] [stderr] | [INFO] [stderr] 139 | minutes: minutes, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `minutes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/interval_ds.rs:140:13 [INFO] [stderr] | [INFO] [stderr] 140 | seconds: seconds, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `seconds` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/interval_ds.rs:141:13 [INFO] [stderr] | [INFO] [stderr] 141 | nanoseconds: nanoseconds, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `nanoseconds` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/interval_ds.rs:155:13 [INFO] [stderr] | [INFO] [stderr] 155 | lfprec: lfprec, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `lfprec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/interval_ds.rs:156:13 [INFO] [stderr] | [INFO] [stderr] 156 | fsprec: fsprec, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `fsprec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/interval_ym.rs:117:13 [INFO] [stderr] | [INFO] [stderr] 117 | years: years, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `years` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/interval_ym.rs:118:13 [INFO] [stderr] | [INFO] [stderr] 118 | months: months, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `months` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/interval_ym.rs:129:13 [INFO] [stderr] | [INFO] [stderr] 129 | precision: precision, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `precision` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/object.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | ctxt: ctxt, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `ctxt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/object.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | handle: handle, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `handle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/object.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | objtype: objtype, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `objtype` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/object.rs:316:13 [INFO] [stderr] | [INFO] [stderr] 316 | ctxt: ctxt, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `ctxt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/object.rs:317:13 [INFO] [stderr] | [INFO] [stderr] 317 | handle: handle, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `handle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/object.rs:318:13 [INFO] [stderr] | [INFO] [stderr] 318 | objtype: objtype, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `objtype` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/object.rs:588:13 [INFO] [stderr] | [INFO] [stderr] 588 | ctxt: ctxt, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `ctxt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/object.rs:589:13 [INFO] [stderr] | [INFO] [stderr] 589 | handle: handle, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `handle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/object.rs:677:13 [INFO] [stderr] | [INFO] [stderr] 677 | ctxt: ctxt, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `ctxt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/object.rs:678:13 [INFO] [stderr] | [INFO] [stderr] 678 | handle: handle, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `handle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/object.rs:681:13 [INFO] [stderr] | [INFO] [stderr] 681 | elem_oratype: elem_oratype, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `elem_oratype` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/object.rs:682:13 [INFO] [stderr] | [INFO] [stderr] 682 | attrs: attrs, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `attrs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/timestamp.rs:129:13 [INFO] [stderr] | [INFO] [stderr] 129 | precision: precision, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `precision` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/timestamp.rs:130:13 [INFO] [stderr] | [INFO] [stderr] 130 | with_tz: with_tz, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `with_tz` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/timestamp.rs:151:13 [INFO] [stderr] | [INFO] [stderr] 151 | year: year, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `year` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/timestamp.rs:152:13 [INFO] [stderr] | [INFO] [stderr] 152 | month: month, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `month` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/timestamp.rs:153:13 [INFO] [stderr] | [INFO] [stderr] 153 | day: day, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `day` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/timestamp.rs:154:13 [INFO] [stderr] | [INFO] [stderr] 154 | hour: hour, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `hour` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/timestamp.rs:155:13 [INFO] [stderr] | [INFO] [stderr] 155 | minute: minute, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `minute` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/timestamp.rs:156:13 [INFO] [stderr] | [INFO] [stderr] 156 | second: second, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `second` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/timestamp.rs:157:13 [INFO] [stderr] | [INFO] [stderr] 157 | nanosecond: nanosecond, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `nanosecond` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/timestamp.rs:200:13 [INFO] [stderr] | [INFO] [stderr] 200 | precision: precision, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `precision` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/version.rs:52:19 [INFO] [stderr] | [INFO] [stderr] 52 | Version { major: major, minor: minor, update: update, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `major` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/version.rs:52:33 [INFO] [stderr] | [INFO] [stderr] 52 | Version { major: major, minor: minor, update: update, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `minor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/version.rs:52:47 [INFO] [stderr] | [INFO] [stderr] 52 | Version { major: major, minor: minor, update: update, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `update` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/version.rs:53:19 [INFO] [stderr] | [INFO] [stderr] 53 | patch: patch, port_update: port_update } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `patch` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/version.rs:53:33 [INFO] [stderr] | [INFO] [stderr] 53 | patch: patch, port_update: port_update } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `port_update` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/util.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | chars: chars, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `chars` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/util.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | char: char, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/binding.rs:24:39 [INFO] [stderr] | [INFO] [stderr] 24 | pub const DPI_MODE_AUTH_SYSBKP: u32 = 131072; [INFO] [stderr] | ^^^^^^ help: consider: `131_072` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/binding.rs:25:39 [INFO] [stderr] | [INFO] [stderr] 25 | pub const DPI_MODE_AUTH_SYSDGD: u32 = 262144; [INFO] [stderr] | ^^^^^^ help: consider: `262_144` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/binding.rs:26:39 [INFO] [stderr] | [INFO] [stderr] 26 | pub const DPI_MODE_AUTH_SYSKMT: u32 = 524288; [INFO] [stderr] | ^^^^^^ help: consider: `524_288` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/binding.rs:27:39 [INFO] [stderr] | [INFO] [stderr] 27 | pub const DPI_MODE_AUTH_SYSRAC: u32 = 1048576; [INFO] [stderr] | ^^^^^^^ help: consider: `1_048_576` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/binding.rs:55:52 [INFO] [stderr] | [INFO] [stderr] 55 | pub const DPI_MODE_EXEC_ARRAY_DML_ROWCOUNTS: u32 = 1048576; [INFO] [stderr] | ^^^^^^^ help: consider: `1_048_576` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/statement.rs:400:16 [INFO] [stderr] | [INFO] [stderr] 400 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 401 | | if self.statement_type != StatementType::Select { [INFO] [stderr] 402 | | Ok(()) [INFO] [stderr] 403 | | } else { [INFO] [stderr] 404 | | Err(Error::InvalidOperation(format!("Could not use the `{}` method for select statements", method_name))) [INFO] [stderr] 405 | | } [INFO] [stderr] 406 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 400 | } else if self.statement_type != StatementType::Select { [INFO] [stderr] 401 | Ok(()) [INFO] [stderr] 402 | } else { [INFO] [stderr] 403 | Err(Error::InvalidOperation(format!("Could not use the `{}` method for select statements", method_name))) [INFO] [stderr] 404 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/statement.rs:435:9 [INFO] [stderr] | [INFO] [stderr] 435 | / if self.statement_type == StatementType::Select { [INFO] [stderr] 436 | | if self.row.is_none() { [INFO] [stderr] 437 | | let num_cols = num_query_columns as usize; [INFO] [stderr] 438 | | let mut column_names = Vec::with_capacity(num_cols); [INFO] [stderr] ... | [INFO] [stderr] 466 | | } [INFO] [stderr] 467 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 435 | if self.statement_type == StatementType::Select && self.row.is_none() { [INFO] [stderr] 436 | let num_cols = num_query_columns as usize; [INFO] [stderr] 437 | let mut column_names = Vec::with_capacity(num_cols); [INFO] [stderr] 438 | let mut column_values = Vec::with_capacity(num_cols); [INFO] [stderr] 439 | self.column_info = Vec::with_capacity(num_cols); [INFO] [stderr] 440 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sql_value.rs:1071:17 [INFO] [stderr] | [INFO] [stderr] 1071 | return self.set_object_unchecked(val.handle), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.set_object_unchecked(val.handle)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sql_value.rs:1081:17 [INFO] [stderr] | [INFO] [stderr] 1081 | return self.set_object_unchecked(val.handle), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.set_object_unchecked(val.handle)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types/interval_ds.rs:229:45 [INFO] [stderr] | [INFO] [stderr] 229 | 1 => write!(f, ".{:01}", nsec / 100000000), [INFO] [stderr] | ^^^^^^^^^ help: consider: `100_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types/interval_ds.rs:230:45 [INFO] [stderr] | [INFO] [stderr] 230 | 2 => write!(f, ".{:02}", nsec / 10000000), [INFO] [stderr] | ^^^^^^^^ help: consider: `10_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types/interval_ds.rs:231:45 [INFO] [stderr] | [INFO] [stderr] 231 | 3 => write!(f, ".{:03}", nsec / 1000000), [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types/interval_ds.rs:232:45 [INFO] [stderr] | [INFO] [stderr] 232 | 4 => write!(f, ".{:04}", nsec / 100000), [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types/timestamp.rs:285:56 [INFO] [stderr] | [INFO] [stderr] 285 | 1 => write!(f, ".{:01}", self.nanosecond / 100000000)?, [INFO] [stderr] | ^^^^^^^^^ help: consider: `100_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types/timestamp.rs:286:56 [INFO] [stderr] | [INFO] [stderr] 286 | 2 => write!(f, ".{:02}", self.nanosecond / 10000000)?, [INFO] [stderr] | ^^^^^^^^ help: consider: `10_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types/timestamp.rs:287:56 [INFO] [stderr] | [INFO] [stderr] 287 | 3 => write!(f, ".{:03}", self.nanosecond / 1000000)?, [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types/timestamp.rs:288:56 [INFO] [stderr] | [INFO] [stderr] 288 | 4 => write!(f, ".{:04}", self.nanosecond / 100000)?, [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/binding.rs:24:39 [INFO] [stderr] | [INFO] [stderr] 24 | pub const DPI_MODE_AUTH_SYSBKP: u32 = 131072; [INFO] [stderr] | ^^^^^^ help: consider: `131_072` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/binding.rs:25:39 [INFO] [stderr] | [INFO] [stderr] 25 | pub const DPI_MODE_AUTH_SYSDGD: u32 = 262144; [INFO] [stderr] | ^^^^^^ help: consider: `262_144` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/binding.rs:26:39 [INFO] [stderr] | [INFO] [stderr] 26 | pub const DPI_MODE_AUTH_SYSKMT: u32 = 524288; [INFO] [stderr] | ^^^^^^ help: consider: `524_288` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/binding.rs:27:39 [INFO] [stderr] | [INFO] [stderr] 27 | pub const DPI_MODE_AUTH_SYSRAC: u32 = 1048576; [INFO] [stderr] | ^^^^^^^ help: consider: `1_048_576` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/binding.rs:55:52 [INFO] [stderr] | [INFO] [stderr] 55 | pub const DPI_MODE_EXEC_ARRAY_DML_ROWCOUNTS: u32 = 1048576; [INFO] [stderr] | ^^^^^^^ help: consider: `1_048_576` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/statement.rs:400:16 [INFO] [stderr] | [INFO] [stderr] 400 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 401 | | if self.statement_type != StatementType::Select { [INFO] [stderr] 402 | | Ok(()) [INFO] [stderr] 403 | | } else { [INFO] [stderr] 404 | | Err(Error::InvalidOperation(format!("Could not use the `{}` method for select statements", method_name))) [INFO] [stderr] 405 | | } [INFO] [stderr] 406 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 400 | } else if self.statement_type != StatementType::Select { [INFO] [stderr] 401 | Ok(()) [INFO] [stderr] 402 | } else { [INFO] [stderr] 403 | Err(Error::InvalidOperation(format!("Could not use the `{}` method for select statements", method_name))) [INFO] [stderr] 404 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/statement.rs:435:9 [INFO] [stderr] | [INFO] [stderr] 435 | / if self.statement_type == StatementType::Select { [INFO] [stderr] 436 | | if self.row.is_none() { [INFO] [stderr] 437 | | let num_cols = num_query_columns as usize; [INFO] [stderr] 438 | | let mut column_names = Vec::with_capacity(num_cols); [INFO] [stderr] ... | [INFO] [stderr] 466 | | } [INFO] [stderr] 467 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 435 | if self.statement_type == StatementType::Select && self.row.is_none() { [INFO] [stderr] 436 | let num_cols = num_query_columns as usize; [INFO] [stderr] 437 | let mut column_names = Vec::with_capacity(num_cols); [INFO] [stderr] 438 | let mut column_values = Vec::with_capacity(num_cols); [INFO] [stderr] 439 | self.column_info = Vec::with_capacity(num_cols); [INFO] [stderr] 440 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sql_value.rs:1071:17 [INFO] [stderr] | [INFO] [stderr] 1071 | return self.set_object_unchecked(val.handle), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.set_object_unchecked(val.handle)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sql_value.rs:1081:17 [INFO] [stderr] | [INFO] [stderr] 1081 | return self.set_object_unchecked(val.handle), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.set_object_unchecked(val.handle)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types/interval_ds.rs:229:45 [INFO] [stderr] | [INFO] [stderr] 229 | 1 => write!(f, ".{:01}", nsec / 100000000), [INFO] [stderr] | ^^^^^^^^^ help: consider: `100_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types/interval_ds.rs:230:45 [INFO] [stderr] | [INFO] [stderr] 230 | 2 => write!(f, ".{:02}", nsec / 10000000), [INFO] [stderr] | ^^^^^^^^ help: consider: `10_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types/interval_ds.rs:231:45 [INFO] [stderr] | [INFO] [stderr] 231 | 3 => write!(f, ".{:03}", nsec / 1000000), [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types/interval_ds.rs:232:45 [INFO] [stderr] | [INFO] [stderr] 232 | 4 => write!(f, ".{:04}", nsec / 100000), [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types/interval_ds.rs:315:50 [INFO] [stderr] | [INFO] [stderr] 315 | let mut it = IntervalDS::new(1, 2, 3, 4, 123456789); [INFO] [stderr] | ^^^^^^^^^ help: consider: `123_456_789` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types/interval_ds.rs:337:55 [INFO] [stderr] | [INFO] [stderr] 337 | let mut it = IntervalDS::new(-1, -2, -3, -4, -123456789); [INFO] [stderr] | ^^^^^^^^^ help: consider: `123_456_789` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types/interval_ds.rs:402:41 [INFO] [stderr] | [INFO] [stderr] 402 | it.fsprec = 1; it.nanoseconds = 100000000; [INFO] [stderr] | ^^^^^^^^^ help: consider: `100_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types/interval_ds.rs:409:42 [INFO] [stderr] | [INFO] [stderr] 409 | it.fsprec = 1; it.nanoseconds = -100000000; [INFO] [stderr] | ^^^^^^^^^ help: consider: `100_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types/interval_ds.rs:411:42 [INFO] [stderr] | [INFO] [stderr] 411 | it.fsprec = 2; it.nanoseconds = -120000000; [INFO] [stderr] | ^^^^^^^^^ help: consider: `120_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types/interval_ds.rs:413:42 [INFO] [stderr] | [INFO] [stderr] 413 | it.fsprec = 3; it.nanoseconds = -123000000; [INFO] [stderr] | ^^^^^^^^^ help: consider: `123_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types/interval_ds.rs:415:42 [INFO] [stderr] | [INFO] [stderr] 415 | it.fsprec = 4; it.nanoseconds = -123400000; [INFO] [stderr] | ^^^^^^^^^ help: consider: `123_400_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types/interval_ds.rs:417:42 [INFO] [stderr] | [INFO] [stderr] 417 | it.fsprec = 5; it.nanoseconds = -123450000; [INFO] [stderr] | ^^^^^^^^^ help: consider: `123_450_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types/interval_ds.rs:419:42 [INFO] [stderr] | [INFO] [stderr] 419 | it.fsprec = 6; it.nanoseconds = -123456000; [INFO] [stderr] | ^^^^^^^^^ help: consider: `123_456_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types/interval_ds.rs:421:42 [INFO] [stderr] | [INFO] [stderr] 421 | it.fsprec = 7; it.nanoseconds = -123456700; [INFO] [stderr] | ^^^^^^^^^ help: consider: `123_456_700` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types/interval_ds.rs:423:42 [INFO] [stderr] | [INFO] [stderr] 423 | it.fsprec = 8; it.nanoseconds = -123456780; [INFO] [stderr] | ^^^^^^^^^ help: consider: `123_456_780` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types/interval_ds.rs:425:42 [INFO] [stderr] | [INFO] [stderr] 425 | it.fsprec = 9; it.nanoseconds = -123456789; [INFO] [stderr] | ^^^^^^^^^ help: consider: `123_456_789` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types/timestamp.rs:285:56 [INFO] [stderr] | [INFO] [stderr] 285 | 1 => write!(f, ".{:01}", self.nanosecond / 100000000)?, [INFO] [stderr] | ^^^^^^^^^ help: consider: `100_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types/timestamp.rs:286:56 [INFO] [stderr] | [INFO] [stderr] 286 | 2 => write!(f, ".{:02}", self.nanosecond / 10000000)?, [INFO] [stderr] | ^^^^^^^^ help: consider: `10_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types/timestamp.rs:287:56 [INFO] [stderr] | [INFO] [stderr] 287 | 3 => write!(f, ".{:03}", self.nanosecond / 1000000)?, [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types/timestamp.rs:288:56 [INFO] [stderr] | [INFO] [stderr] 288 | 4 => write!(f, ".{:04}", self.nanosecond / 100000)?, [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types/timestamp.rs:442:58 [INFO] [stderr] | [INFO] [stderr] 442 | let mut ts = Timestamp::new(2012, 3, 4, 5, 6, 7, 890123456).and_tz_hm_offset(8, 45); [INFO] [stderr] | ^^^^^^^^^ help: consider: `890_123_456` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types/timestamp.rs:497:25 [INFO] [stderr] | [INFO] [stderr] 497 | ts.nanosecond = 800000000; ts.precision = 1; [INFO] [stderr] | ^^^^^^^^^ help: consider: `800_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types/timestamp.rs:499:25 [INFO] [stderr] | [INFO] [stderr] 499 | ts.nanosecond = 890000000; ts.precision = 2; [INFO] [stderr] | ^^^^^^^^^ help: consider: `890_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types/timestamp.rs:501:25 [INFO] [stderr] | [INFO] [stderr] 501 | ts.nanosecond = 890000000; ts.precision = 3; [INFO] [stderr] | ^^^^^^^^^ help: consider: `890_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types/timestamp.rs:503:25 [INFO] [stderr] | [INFO] [stderr] 503 | ts.nanosecond = 890100000; ts.precision = 4; [INFO] [stderr] | ^^^^^^^^^ help: consider: `890_100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types/timestamp.rs:505:25 [INFO] [stderr] | [INFO] [stderr] 505 | ts.nanosecond = 890120000; ts.precision = 5; [INFO] [stderr] | ^^^^^^^^^ help: consider: `890_120_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types/timestamp.rs:507:25 [INFO] [stderr] | [INFO] [stderr] 507 | ts.nanosecond = 890123000; ts.precision = 6; [INFO] [stderr] | ^^^^^^^^^ help: consider: `890_123_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types/timestamp.rs:509:25 [INFO] [stderr] | [INFO] [stderr] 509 | ts.nanosecond = 890123400; ts.precision = 7; [INFO] [stderr] | ^^^^^^^^^ help: consider: `890_123_400` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types/timestamp.rs:511:25 [INFO] [stderr] | [INFO] [stderr] 511 | ts.nanosecond = 890123450; ts.precision = 8; [INFO] [stderr] | ^^^^^^^^^ help: consider: `890_123_450` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types/timestamp.rs:513:25 [INFO] [stderr] | [INFO] [stderr] 513 | ts.nanosecond = 890123456; ts.precision = 9; [INFO] [stderr] | ^^^^^^^^^ help: consider: `890_123_456` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types/timestamp.rs:534:25 [INFO] [stderr] | [INFO] [stderr] 534 | ts.nanosecond = 123000000; ts.precision = 3; [INFO] [stderr] | ^^^^^^^^^ help: consider: `123_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util.rs:202:42 [INFO] [stderr] | [INFO] [stderr] 202 | assert_eq!(s.read_digits(), Some(4567890)); [INFO] [stderr] | ^^^^^^^ help: consider: `4_567_890` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/connection.rs:305:13 [INFO] [stderr] | [INFO] [stderr] 305 | / if let &ConnParam::AppContext(_, _, _) = param { [INFO] [stderr] 306 | | num_app_context += 1; [INFO] [stderr] 307 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 305 | if let ConnParam::AppContext(_, _, _) = *param { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/connection.rs:312:13 [INFO] [stderr] | [INFO] [stderr] 312 | / match param { [INFO] [stderr] 313 | | &ConnParam::Sysdba => { [INFO] [stderr] 314 | | conn_params.authMode |= DPI_MODE_AUTH_SYSDBA; [INFO] [stderr] 315 | | }, [INFO] [stderr] ... | [INFO] [stderr] 390 | | }, [INFO] [stderr] 391 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 312 | match *param { [INFO] [stderr] 313 | ConnParam::Sysdba => { [INFO] [stderr] 314 | conn_params.authMode |= DPI_MODE_AUTH_SYSDBA; [INFO] [stderr] 315 | }, [INFO] [stderr] 316 | ConnParam::Sysoper => { [INFO] [stderr] 317 | conn_params.authMode |= DPI_MODE_AUTH_SYSOPER; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/connection.rs:393:12 [INFO] [stderr] | [INFO] [stderr] 393 | if app_context.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!app_context.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/connection.rs:1027:12 [INFO] [stderr] | [INFO] [stderr] 1027 | if self.tag.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.tag.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/statement.rs:122:15 [INFO] [stderr] | [INFO] [stderr] 122 | match num as u32 { [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(num)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/statement.rs:144:9 [INFO] [stderr] | [INFO] [stderr] 144 | / match self { [INFO] [stderr] 145 | | &StatementType::Select => write!(f, "select"), [INFO] [stderr] 146 | | &StatementType::Insert => write!(f, "insert"), [INFO] [stderr] 147 | | &StatementType::Update => write!(f, "update"), [INFO] [stderr] ... | [INFO] [stderr] 159 | | &StatementType::Unknown => write!(f, "unknown"), [INFO] [stderr] 160 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 144 | match *self { [INFO] [stderr] 145 | StatementType::Select => write!(f, "select"), [INFO] [stderr] 146 | StatementType::Insert => write!(f, "insert"), [INFO] [stderr] 147 | StatementType::Update => write!(f, "update"), [INFO] [stderr] 148 | StatementType::Delete => write!(f, "delete"), [INFO] [stderr] 149 | StatementType::Merge => write!(f, "merge"), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/statement.rs:187:13 [INFO] [stderr] | [INFO] [stderr] 187 | / match param { [INFO] [stderr] 188 | | &StmtParam::FetchArraySize(size) => { [INFO] [stderr] 189 | | fetch_array_size = size; [INFO] [stderr] 190 | | }, [INFO] [stderr] ... | [INFO] [stderr] 196 | | }, [INFO] [stderr] 197 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 187 | match *param { [INFO] [stderr] 188 | StmtParam::FetchArraySize(size) => { [INFO] [stderr] 189 | fetch_array_size = size; [INFO] [stderr] 190 | }, [INFO] [stderr] 191 | StmtParam::Scrollable => { [INFO] [stderr] 192 | scrollable = 1; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `params` [INFO] [stderr] --> src/statement.rs:411:18 [INFO] [stderr] | [INFO] [stderr] 411 | for i in 0..params.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 411 | for (i, ) in params.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `params`. [INFO] [stderr] --> src/statement.rs:419:18 [INFO] [stderr] | [INFO] [stderr] 419 | for i in 0..params.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 419 | for in ¶ms { [INFO] [stderr] | ^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/statement.rs:632:19 [INFO] [stderr] | [INFO] [stderr] 632 | if rows > sqlval.array_size as u64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(sqlval.array_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/statement.rs:633:20 [INFO] [stderr] | [INFO] [stderr] 633 | rows = sqlval.array_size as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(sqlval.array_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/statement.rs:725:12 [INFO] [stderr] | [INFO] [stderr] 725 | if self.column_info.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.column_info.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/statement.rs:875:33 [INFO] [stderr] | [INFO] [stderr] 875 | fn idx(&self, column_names: &Vec) -> Result; [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/sql_value.rs:49:16 [INFO] [stderr] | [INFO] [stderr] 49 | if $dest_type::min_value() as $src_type <= src_val && src_val <= $dest_type::max_value() as $src_type { [INFO] [stderr] | ________________^ [INFO] [stderr] 50 | | Ok(src_val as $dest_type) [INFO] [stderr] 51 | | } else { [INFO] [stderr] 52 | | Err(Error::OutOfRange(format!("{} overflow: {}", stringify!($dest_type), src_val.to_string(), ))) [INFO] [stderr] ... | [INFO] [stderr] 67 | | NativeType::Float => [INFO] [stderr] 68 | | flt_to_int!(self.get_f32_unchecked()?, f32, $type), [INFO] [stderr] | |______________________________________________________________^ help: try: `f32::from($dest_type::min_value())` [INFO] [stderr] ... [INFO] [stderr] 686 | / define_fn_to_int!( [INFO] [stderr] 687 | | /// Gets the SQL value as i8. The Oracle type must be [INFO] [stderr] 688 | | /// numeric or string (excluding LOB) types. [INFO] [stderr] 689 | | : to_i8, i8); [INFO] [stderr] | |_____________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/sql_value.rs:49:78 [INFO] [stderr] | [INFO] [stderr] 49 | if $dest_type::min_value() as $src_type <= src_val && src_val <= $dest_type::max_value() as $src_type { [INFO] [stderr] | ______________________________________________________________________________^ [INFO] [stderr] 50 | | Ok(src_val as $dest_type) [INFO] [stderr] 51 | | } else { [INFO] [stderr] 52 | | Err(Error::OutOfRange(format!("{} overflow: {}", stringify!($dest_type), src_val.to_string(), ))) [INFO] [stderr] ... | [INFO] [stderr] 67 | | NativeType::Float => [INFO] [stderr] 68 | | flt_to_int!(self.get_f32_unchecked()?, f32, $type), [INFO] [stderr] | |______________________________________________________________^ help: try: `f32::from($dest_type::max_value())` [INFO] [stderr] ... [INFO] [stderr] 686 | / define_fn_to_int!( [INFO] [stderr] 687 | | /// Gets the SQL value as i8. The Oracle type must be [INFO] [stderr] 688 | | /// numeric or string (excluding LOB) types. [INFO] [stderr] 689 | | : to_i8, i8); [INFO] [stderr] | |_____________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sql_value.rs:49:16 [INFO] [stderr] | [INFO] [stderr] 49 | if $dest_type::min_value() as $src_type <= src_val && src_val <= $dest_type::max_value() as $src_type { [INFO] [stderr] | ________________^ [INFO] [stderr] 50 | | Ok(src_val as $dest_type) [INFO] [stderr] 51 | | } else { [INFO] [stderr] 52 | | Err(Error::OutOfRange(format!("{} overflow: {}", stringify!($dest_type), src_val.to_string(), ))) [INFO] [stderr] ... | [INFO] [stderr] 69 | | NativeType::Double => [INFO] [stderr] 70 | | flt_to_int!(self.get_f64_unchecked()?, f64, $type), [INFO] [stderr] | |______________________________________________________________^ help: try: `f64::from($dest_type::min_value())` [INFO] [stderr] ... [INFO] [stderr] 686 | / define_fn_to_int!( [INFO] [stderr] 687 | | /// Gets the SQL value as i8. The Oracle type must be [INFO] [stderr] 688 | | /// numeric or string (excluding LOB) types. [INFO] [stderr] 689 | | : to_i8, i8); [INFO] [stderr] | |_____________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sql_value.rs:49:78 [INFO] [stderr] | [INFO] [stderr] 49 | if $dest_type::min_value() as $src_type <= src_val && src_val <= $dest_type::max_value() as $src_type { [INFO] [stderr] | ______________________________________________________________________________^ [INFO] [stderr] 50 | | Ok(src_val as $dest_type) [INFO] [stderr] 51 | | } else { [INFO] [stderr] 52 | | Err(Error::OutOfRange(format!("{} overflow: {}", stringify!($dest_type), src_val.to_string(), ))) [INFO] [stderr] ... | [INFO] [stderr] 69 | | NativeType::Double => [INFO] [stderr] 70 | | flt_to_int!(self.get_f64_unchecked()?, f64, $type), [INFO] [stderr] | |______________________________________________________________^ help: try: `f64::from($dest_type::max_value())` [INFO] [stderr] ... [INFO] [stderr] 686 | / define_fn_to_int!( [INFO] [stderr] 687 | | /// Gets the SQL value as i8. The Oracle type must be [INFO] [stderr] 688 | | /// numeric or string (excluding LOB) types. [INFO] [stderr] 689 | | : to_i8, i8); [INFO] [stderr] | |_____________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/sql_value.rs:49:16 [INFO] [stderr] | [INFO] [stderr] 49 | if $dest_type::min_value() as $src_type <= src_val && src_val <= $dest_type::max_value() as $src_type { [INFO] [stderr] | ________________^ [INFO] [stderr] 50 | | Ok(src_val as $dest_type) [INFO] [stderr] 51 | | } else { [INFO] [stderr] 52 | | Err(Error::OutOfRange(format!("{} overflow: {}", stringify!($dest_type), src_val.to_string(), ))) [INFO] [stderr] ... | [INFO] [stderr] 67 | | NativeType::Float => [INFO] [stderr] 68 | | flt_to_int!(self.get_f32_unchecked()?, f32, $type), [INFO] [stderr] | |______________________________________________________________^ help: try: `f32::from($dest_type::min_value())` [INFO] [stderr] ... [INFO] [stderr] 690 | / define_fn_to_int!( [INFO] [stderr] 691 | | /// Gets the SQL value as i16. The Oracle type must be [INFO] [stderr] 692 | | /// numeric or string (excluding LOB) types. [INFO] [stderr] 693 | | : to_i16, i16); [INFO] [stderr] | |_______________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/sql_value.rs:49:78 [INFO] [stderr] | [INFO] [stderr] 49 | if $dest_type::min_value() as $src_type <= src_val && src_val <= $dest_type::max_value() as $src_type { [INFO] [stderr] | ______________________________________________________________________________^ [INFO] [stderr] 50 | | Ok(src_val as $dest_type) [INFO] [stderr] 51 | | } else { [INFO] [stderr] 52 | | Err(Error::OutOfRange(format!("{} overflow: {}", stringify!($dest_type), src_val.to_string(), ))) [INFO] [stderr] ... | [INFO] [stderr] 67 | | NativeType::Float => [INFO] [stderr] 68 | | flt_to_int!(self.get_f32_unchecked()?, f32, $type), [INFO] [stderr] | |______________________________________________________________^ help: try: `f32::from($dest_type::max_value())` [INFO] [stderr] ... [INFO] [stderr] 690 | / define_fn_to_int!( [INFO] [stderr] 691 | | /// Gets the SQL value as i16. The Oracle type must be [INFO] [stderr] 692 | | /// numeric or string (excluding LOB) types. [INFO] [stderr] 693 | | : to_i16, i16); [INFO] [stderr] | |_______________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sql_value.rs:49:16 [INFO] [stderr] | [INFO] [stderr] 49 | if $dest_type::min_value() as $src_type <= src_val && src_val <= $dest_type::max_value() as $src_type { [INFO] [stderr] | ________________^ [INFO] [stderr] 50 | | Ok(src_val as $dest_type) [INFO] [stderr] 51 | | } else { [INFO] [stderr] 52 | | Err(Error::OutOfRange(format!("{} overflow: {}", stringify!($dest_type), src_val.to_string(), ))) [INFO] [stderr] ... | [INFO] [stderr] 69 | | NativeType::Double => [INFO] [stderr] 70 | | flt_to_int!(self.get_f64_unchecked()?, f64, $type), [INFO] [stderr] | |______________________________________________________________^ help: try: `f64::from($dest_type::min_value())` [INFO] [stderr] ... [INFO] [stderr] 690 | / define_fn_to_int!( [INFO] [stderr] 691 | | /// Gets the SQL value as i16. The Oracle type must be [INFO] [stderr] 692 | | /// numeric or string (excluding LOB) types. [INFO] [stderr] 693 | | : to_i16, i16); [INFO] [stderr] | |_______________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sql_value.rs:49:78 [INFO] [stderr] | [INFO] [stderr] 49 | if $dest_type::min_value() as $src_type <= src_val && src_val <= $dest_type::max_value() as $src_type { [INFO] [stderr] | ______________________________________________________________________________^ [INFO] [stderr] 50 | | Ok(src_val as $dest_type) [INFO] [stderr] 51 | | } else { [INFO] [stderr] 52 | | Err(Error::OutOfRange(format!("{} overflow: {}", stringify!($dest_type), src_val.to_string(), ))) [INFO] [stderr] ... | [INFO] [stderr] 69 | | NativeType::Double => [INFO] [stderr] 70 | | flt_to_int!(self.get_f64_unchecked()?, f64, $type), [INFO] [stderr] | |______________________________________________________________^ help: try: `f64::from($dest_type::max_value())` [INFO] [stderr] ... [INFO] [stderr] 690 | / define_fn_to_int!( [INFO] [stderr] 691 | | /// Gets the SQL value as i16. The Oracle type must be [INFO] [stderr] 692 | | /// numeric or string (excluding LOB) types. [INFO] [stderr] 693 | | : to_i16, i16); [INFO] [stderr] | |_______________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sql_value.rs:49:16 [INFO] [stderr] | [INFO] [stderr] 49 | if $dest_type::min_value() as $src_type <= src_val && src_val <= $dest_type::max_value() as $src_type { [INFO] [stderr] | ________________^ [INFO] [stderr] 50 | | Ok(src_val as $dest_type) [INFO] [stderr] 51 | | } else { [INFO] [stderr] 52 | | Err(Error::OutOfRange(format!("{} overflow: {}", stringify!($dest_type), src_val.to_string(), ))) [INFO] [stderr] ... | [INFO] [stderr] 69 | | NativeType::Double => [INFO] [stderr] 70 | | flt_to_int!(self.get_f64_unchecked()?, f64, $type), [INFO] [stderr] | |______________________________________________________________^ help: try: `f64::from($dest_type::min_value())` [INFO] [stderr] ... [INFO] [stderr] 694 | / define_fn_to_int!( [INFO] [stderr] 695 | | /// Gets the SQL value as i32. The Oracle type must be [INFO] [stderr] 696 | | /// numeric or string (excluding LOB) types. [INFO] [stderr] 697 | | : to_i32, i32); [INFO] [stderr] | |_______________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sql_value.rs:49:78 [INFO] [stderr] | [INFO] [stderr] 49 | if $dest_type::min_value() as $src_type <= src_val && src_val <= $dest_type::max_value() as $src_type { [INFO] [stderr] | ______________________________________________________________________________^ [INFO] [stderr] 50 | | Ok(src_val as $dest_type) [INFO] [stderr] 51 | | } else { [INFO] [stderr] 52 | | Err(Error::OutOfRange(format!("{} overflow: {}", stringify!($dest_type), src_val.to_string(), ))) [INFO] [stderr] ... | [INFO] [stderr] 69 | | NativeType::Double => [INFO] [stderr] 70 | | flt_to_int!(self.get_f64_unchecked()?, f64, $type), [INFO] [stderr] | |______________________________________________________________^ help: try: `f64::from($dest_type::max_value())` [INFO] [stderr] ... [INFO] [stderr] 694 | / define_fn_to_int!( [INFO] [stderr] 695 | | /// Gets the SQL value as i32. The Oracle type must be [INFO] [stderr] 696 | | /// numeric or string (excluding LOB) types. [INFO] [stderr] 697 | | : to_i32, i32); [INFO] [stderr] | |_______________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/sql_value.rs:49:16 [INFO] [stderr] | [INFO] [stderr] 49 | if $dest_type::min_value() as $src_type <= src_val && src_val <= $dest_type::max_value() as $src_type { [INFO] [stderr] | ________________^ [INFO] [stderr] 50 | | Ok(src_val as $dest_type) [INFO] [stderr] 51 | | } else { [INFO] [stderr] 52 | | Err(Error::OutOfRange(format!("{} overflow: {}", stringify!($dest_type), src_val.to_string(), ))) [INFO] [stderr] ... | [INFO] [stderr] 67 | | NativeType::Float => [INFO] [stderr] 68 | | flt_to_int!(self.get_f32_unchecked()?, f32, $type), [INFO] [stderr] | |______________________________________________________________^ help: try: `f32::from($dest_type::min_value())` [INFO] [stderr] ... [INFO] [stderr] 724 | / define_fn_to_int!( [INFO] [stderr] 725 | | /// Gets the SQL value as u8. The Oracle type must be [INFO] [stderr] 726 | | /// numeric or string (excluding LOB) types. [INFO] [stderr] 727 | | : to_u8, u8); [INFO] [stderr] | |_____________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/sql_value.rs:49:78 [INFO] [stderr] | [INFO] [stderr] 49 | if $dest_type::min_value() as $src_type <= src_val && src_val <= $dest_type::max_value() as $src_type { [INFO] [stderr] | ______________________________________________________________________________^ [INFO] [stderr] 50 | | Ok(src_val as $dest_type) [INFO] [stderr] 51 | | } else { [INFO] [stderr] 52 | | Err(Error::OutOfRange(format!("{} overflow: {}", stringify!($dest_type), src_val.to_string(), ))) [INFO] [stderr] ... | [INFO] [stderr] 67 | | NativeType::Float => [INFO] [stderr] 68 | | flt_to_int!(self.get_f32_unchecked()?, f32, $type), [INFO] [stderr] | |______________________________________________________________^ help: try: `f32::from($dest_type::max_value())` [INFO] [stderr] ... [INFO] [stderr] 724 | / define_fn_to_int!( [INFO] [stderr] 725 | | /// Gets the SQL value as u8. The Oracle type must be [INFO] [stderr] 726 | | /// numeric or string (excluding LOB) types. [INFO] [stderr] 727 | | : to_u8, u8); [INFO] [stderr] | |_____________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sql_value.rs:49:16 [INFO] [stderr] | [INFO] [stderr] 49 | if $dest_type::min_value() as $src_type <= src_val && src_val <= $dest_type::max_value() as $src_type { [INFO] [stderr] | ________________^ [INFO] [stderr] 50 | | Ok(src_val as $dest_type) [INFO] [stderr] 51 | | } else { [INFO] [stderr] 52 | | Err(Error::OutOfRange(format!("{} overflow: {}", stringify!($dest_type), src_val.to_string(), ))) [INFO] [stderr] ... | [INFO] [stderr] 69 | | NativeType::Double => [INFO] [stderr] 70 | | flt_to_int!(self.get_f64_unchecked()?, f64, $type), [INFO] [stderr] | |______________________________________________________________^ help: try: `f64::from($dest_type::min_value())` [INFO] [stderr] ... [INFO] [stderr] 724 | / define_fn_to_int!( [INFO] [stderr] 725 | | /// Gets the SQL value as u8. The Oracle type must be [INFO] [stderr] 726 | | /// numeric or string (excluding LOB) types. [INFO] [stderr] 727 | | : to_u8, u8); [INFO] [stderr] | |_____________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sql_value.rs:49:78 [INFO] [stderr] | [INFO] [stderr] 49 | if $dest_type::min_value() as $src_type <= src_val && src_val <= $dest_type::max_value() as $src_type { [INFO] [stderr] | ______________________________________________________________________________^ [INFO] [stderr] 50 | | Ok(src_val as $dest_type) [INFO] [stderr] 51 | | } else { [INFO] [stderr] 52 | | Err(Error::OutOfRange(format!("{} overflow: {}", stringify!($dest_type), src_val.to_string(), ))) [INFO] [stderr] ... | [INFO] [stderr] 69 | | NativeType::Double => [INFO] [stderr] 70 | | flt_to_int!(self.get_f64_unchecked()?, f64, $type), [INFO] [stderr] | |______________________________________________________________^ help: try: `f64::from($dest_type::max_value())` [INFO] [stderr] ... [INFO] [stderr] 724 | / define_fn_to_int!( [INFO] [stderr] 725 | | /// Gets the SQL value as u8. The Oracle type must be [INFO] [stderr] 726 | | /// numeric or string (excluding LOB) types. [INFO] [stderr] 727 | | : to_u8, u8); [INFO] [stderr] | |_____________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/sql_value.rs:49:16 [INFO] [stderr] | [INFO] [stderr] 49 | if $dest_type::min_value() as $src_type <= src_val && src_val <= $dest_type::max_value() as $src_type { [INFO] [stderr] | ________________^ [INFO] [stderr] 50 | | Ok(src_val as $dest_type) [INFO] [stderr] 51 | | } else { [INFO] [stderr] 52 | | Err(Error::OutOfRange(format!("{} overflow: {}", stringify!($dest_type), src_val.to_string(), ))) [INFO] [stderr] ... | [INFO] [stderr] 67 | | NativeType::Float => [INFO] [stderr] 68 | | flt_to_int!(self.get_f32_unchecked()?, f32, $type), [INFO] [stderr] | |______________________________________________________________^ help: try: `f32::from($dest_type::min_value())` [INFO] [stderr] ... [INFO] [stderr] 728 | / define_fn_to_int!( [INFO] [stderr] 729 | | /// Gets the SQL value as u16. The Oracle type must be [INFO] [stderr] 730 | | /// numeric or string (excluding LOB) types. [INFO] [stderr] 731 | | : to_u16, u16); [INFO] [stderr] | |_______________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/sql_value.rs:49:78 [INFO] [stderr] | [INFO] [stderr] 49 | if $dest_type::min_value() as $src_type <= src_val && src_val <= $dest_type::max_value() as $src_type { [INFO] [stderr] | ______________________________________________________________________________^ [INFO] [stderr] 50 | | Ok(src_val as $dest_type) [INFO] [stderr] 51 | | } else { [INFO] [stderr] 52 | | Err(Error::OutOfRange(format!("{} overflow: {}", stringify!($dest_type), src_val.to_string(), ))) [INFO] [stderr] ... | [INFO] [stderr] 67 | | NativeType::Float => [INFO] [stderr] 68 | | flt_to_int!(self.get_f32_unchecked()?, f32, $type), [INFO] [stderr] | |______________________________________________________________^ help: try: `f32::from($dest_type::max_value())` [INFO] [stderr] ... [INFO] [stderr] 728 | / define_fn_to_int!( [INFO] [stderr] 729 | | /// Gets the SQL value as u16. The Oracle type must be [INFO] [stderr] 730 | | /// numeric or string (excluding LOB) types. [INFO] [stderr] 731 | | : to_u16, u16); [INFO] [stderr] | |_______________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sql_value.rs:49:16 [INFO] [stderr] | [INFO] [stderr] 49 | if $dest_type::min_value() as $src_type <= src_val && src_val <= $dest_type::max_value() as $src_type { [INFO] [stderr] | ________________^ [INFO] [stderr] 50 | | Ok(src_val as $dest_type) [INFO] [stderr] 51 | | } else { [INFO] [stderr] 52 | | Err(Error::OutOfRange(format!("{} overflow: {}", stringify!($dest_type), src_val.to_string(), ))) [INFO] [stderr] ... | [INFO] [stderr] 69 | | NativeType::Double => [INFO] [stderr] 70 | | flt_to_int!(self.get_f64_unchecked()?, f64, $type), [INFO] [stderr] | |______________________________________________________________^ help: try: `f64::from($dest_type::min_value())` [INFO] [stderr] ... [INFO] [stderr] 728 | / define_fn_to_int!( [INFO] [stderr] 729 | | /// Gets the SQL value as u16. The Oracle type must be [INFO] [stderr] 730 | | /// numeric or string (excluding LOB) types. [INFO] [stderr] 731 | | : to_u16, u16); [INFO] [stderr] | |_______________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sql_value.rs:49:78 [INFO] [stderr] | [INFO] [stderr] 49 | if $dest_type::min_value() as $src_type <= src_val && src_val <= $dest_type::max_value() as $src_type { [INFO] [stderr] | ______________________________________________________________________________^ [INFO] [stderr] 50 | | Ok(src_val as $dest_type) [INFO] [stderr] 51 | | } else { [INFO] [stderr] 52 | | Err(Error::OutOfRange(format!("{} overflow: {}", stringify!($dest_type), src_val.to_string(), ))) [INFO] [stderr] ... | [INFO] [stderr] 69 | | NativeType::Double => [INFO] [stderr] 70 | | flt_to_int!(self.get_f64_unchecked()?, f64, $type), [INFO] [stderr] | |______________________________________________________________^ help: try: `f64::from($dest_type::max_value())` [INFO] [stderr] ... [INFO] [stderr] 728 | / define_fn_to_int!( [INFO] [stderr] 729 | | /// Gets the SQL value as u16. The Oracle type must be [INFO] [stderr] 730 | | /// numeric or string (excluding LOB) types. [INFO] [stderr] 731 | | : to_u16, u16); [INFO] [stderr] | |_______________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sql_value.rs:49:16 [INFO] [stderr] | [INFO] [stderr] 49 | if $dest_type::min_value() as $src_type <= src_val && src_val <= $dest_type::max_value() as $src_type { [INFO] [stderr] | ________________^ [INFO] [stderr] 50 | | Ok(src_val as $dest_type) [INFO] [stderr] 51 | | } else { [INFO] [stderr] 52 | | Err(Error::OutOfRange(format!("{} overflow: {}", stringify!($dest_type), src_val.to_string(), ))) [INFO] [stderr] ... | [INFO] [stderr] 69 | | NativeType::Double => [INFO] [stderr] 70 | | flt_to_int!(self.get_f64_unchecked()?, f64, $type), [INFO] [stderr] | |______________________________________________________________^ help: try: `f64::from($dest_type::min_value())` [INFO] [stderr] ... [INFO] [stderr] 732 | / define_fn_to_int!( [INFO] [stderr] 733 | | /// Gets the SQL value as u32. The Oracle type must be [INFO] [stderr] 734 | | /// numeric or string (excluding LOB) types. [INFO] [stderr] 735 | | : to_u32, u32); [INFO] [stderr] | |_______________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sql_value.rs:49:78 [INFO] [stderr] | [INFO] [stderr] 49 | if $dest_type::min_value() as $src_type <= src_val && src_val <= $dest_type::max_value() as $src_type { [INFO] [stderr] | ______________________________________________________________________________^ [INFO] [stderr] 50 | | Ok(src_val as $dest_type) [INFO] [stderr] 51 | | } else { [INFO] [stderr] 52 | | Err(Error::OutOfRange(format!("{} overflow: {}", stringify!($dest_type), src_val.to_string(), ))) [INFO] [stderr] ... | [INFO] [stderr] 69 | | NativeType::Double => [INFO] [stderr] 70 | | flt_to_int!(self.get_f64_unchecked()?, f64, $type), [INFO] [stderr] | |______________________________________________________________^ help: try: `f64::from($dest_type::max_value())` [INFO] [stderr] ... [INFO] [stderr] 732 | / define_fn_to_int!( [INFO] [stderr] 733 | | /// Gets the SQL value as u32. The Oracle type must be [INFO] [stderr] 734 | | /// numeric or string (excluding LOB) types. [INFO] [stderr] 735 | | : to_u32, u32); [INFO] [stderr] | |_______________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sql_value.rs:792:20 [INFO] [stderr] | [INFO] [stderr] 792 | Ok(self.get_f32_unchecked()? as f64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.get_f32_unchecked()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/sql_value.rs:88:44 [INFO] [stderr] | [INFO] [stderr] 88 | self.set_i64_unchecked(*val as i64), [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i64::from(*val)` [INFO] [stderr] ... [INFO] [stderr] 939 | / define_fn_set_int!( [INFO] [stderr] 940 | | /// Sets i8 to the SQL value. The Oracle type must be [INFO] [stderr] 941 | | /// numeric or string (excluding LOB) types. [INFO] [stderr] 942 | | : set_i8, i8); [INFO] [stderr] | |______________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/sql_value.rs:92:44 [INFO] [stderr] | [INFO] [stderr] 92 | self.set_f32_unchecked(*val as f32), [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f32::from(*val)` [INFO] [stderr] ... [INFO] [stderr] 939 | / define_fn_set_int!( [INFO] [stderr] 940 | | /// Sets i8 to the SQL value. The Oracle type must be [INFO] [stderr] 941 | | /// numeric or string (excluding LOB) types. [INFO] [stderr] 942 | | : set_i8, i8); [INFO] [stderr] | |______________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sql_value.rs:94:44 [INFO] [stderr] | [INFO] [stderr] 94 | self.set_f64_unchecked(*val as f64), [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(*val)` [INFO] [stderr] ... [INFO] [stderr] 939 | / define_fn_set_int!( [INFO] [stderr] 940 | | /// Sets i8 to the SQL value. The Oracle type must be [INFO] [stderr] 941 | | /// numeric or string (excluding LOB) types. [INFO] [stderr] 942 | | : set_i8, i8); [INFO] [stderr] | |______________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/sql_value.rs:88:44 [INFO] [stderr] | [INFO] [stderr] 88 | self.set_i64_unchecked(*val as i64), [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i64::from(*val)` [INFO] [stderr] ... [INFO] [stderr] 943 | / define_fn_set_int!( [INFO] [stderr] 944 | | /// Sets i16 to the SQL value. The Oracle type must be [INFO] [stderr] 945 | | /// numeric or string (excluding LOB) types. [INFO] [stderr] 946 | | : set_i16, i16); [INFO] [stderr] | |________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/sql_value.rs:92:44 [INFO] [stderr] | [INFO] [stderr] 92 | self.set_f32_unchecked(*val as f32), [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f32::from(*val)` [INFO] [stderr] ... [INFO] [stderr] 943 | / define_fn_set_int!( [INFO] [stderr] 944 | | /// Sets i16 to the SQL value. The Oracle type must be [INFO] [stderr] 945 | | /// numeric or string (excluding LOB) types. [INFO] [stderr] 946 | | : set_i16, i16); [INFO] [stderr] | |________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sql_value.rs:94:44 [INFO] [stderr] | [INFO] [stderr] 94 | self.set_f64_unchecked(*val as f64), [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(*val)` [INFO] [stderr] ... [INFO] [stderr] 943 | / define_fn_set_int!( [INFO] [stderr] 944 | | /// Sets i16 to the SQL value. The Oracle type must be [INFO] [stderr] 945 | | /// numeric or string (excluding LOB) types. [INFO] [stderr] 946 | | : set_i16, i16); [INFO] [stderr] | |________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/sql_value.rs:88:44 [INFO] [stderr] | [INFO] [stderr] 88 | self.set_i64_unchecked(*val as i64), [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i64::from(*val)` [INFO] [stderr] ... [INFO] [stderr] 947 | / define_fn_set_int!( [INFO] [stderr] 948 | | /// Sets i32 to the SQL value. The Oracle type must be [INFO] [stderr] 949 | | /// numeric or string (excluding LOB) types. [INFO] [stderr] 950 | | : set_i32, i32); [INFO] [stderr] | |________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sql_value.rs:94:44 [INFO] [stderr] | [INFO] [stderr] 94 | self.set_f64_unchecked(*val as f64), [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(*val)` [INFO] [stderr] ... [INFO] [stderr] 947 | / define_fn_set_int!( [INFO] [stderr] 948 | | /// Sets i32 to the SQL value. The Oracle type must be [INFO] [stderr] 949 | | /// numeric or string (excluding LOB) types. [INFO] [stderr] 950 | | : set_i32, i32); [INFO] [stderr] | |________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/sql_value.rs:88:44 [INFO] [stderr] | [INFO] [stderr] 88 | self.set_i64_unchecked(*val as i64), [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i64::from(*val)` [INFO] [stderr] ... [INFO] [stderr] 959 | / define_fn_set_int!( [INFO] [stderr] 960 | | /// Sets u8 to the SQL value. The Oracle type must be [INFO] [stderr] 961 | | /// numeric or string (excluding LOB) types. [INFO] [stderr] 962 | | : set_u8, u8); [INFO] [stderr] | |______________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sql_value.rs:90:44 [INFO] [stderr] | [INFO] [stderr] 90 | self.set_u64_unchecked(*val as u64), [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(*val)` [INFO] [stderr] ... [INFO] [stderr] 959 | / define_fn_set_int!( [INFO] [stderr] 960 | | /// Sets u8 to the SQL value. The Oracle type must be [INFO] [stderr] 961 | | /// numeric or string (excluding LOB) types. [INFO] [stderr] 962 | | : set_u8, u8); [INFO] [stderr] | |______________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/sql_value.rs:92:44 [INFO] [stderr] | [INFO] [stderr] 92 | self.set_f32_unchecked(*val as f32), [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f32::from(*val)` [INFO] [stderr] ... [INFO] [stderr] 959 | / define_fn_set_int!( [INFO] [stderr] 960 | | /// Sets u8 to the SQL value. The Oracle type must be [INFO] [stderr] 961 | | /// numeric or string (excluding LOB) types. [INFO] [stderr] 962 | | : set_u8, u8); [INFO] [stderr] | |______________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sql_value.rs:94:44 [INFO] [stderr] | [INFO] [stderr] 94 | self.set_f64_unchecked(*val as f64), [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(*val)` [INFO] [stderr] ... [INFO] [stderr] 959 | / define_fn_set_int!( [INFO] [stderr] 960 | | /// Sets u8 to the SQL value. The Oracle type must be [INFO] [stderr] 961 | | /// numeric or string (excluding LOB) types. [INFO] [stderr] 962 | | : set_u8, u8); [INFO] [stderr] | |______________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/sql_value.rs:88:44 [INFO] [stderr] | [INFO] [stderr] 88 | self.set_i64_unchecked(*val as i64), [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i64::from(*val)` [INFO] [stderr] ... [INFO] [stderr] 963 | / define_fn_set_int!( [INFO] [stderr] 964 | | /// Sets u16 to the SQL value. The Oracle type must be [INFO] [stderr] 965 | | /// numeric or string (excluding LOB) types. [INFO] [stderr] 966 | | : set_u16, u16); [INFO] [stderr] | |________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sql_value.rs:90:44 [INFO] [stderr] | [INFO] [stderr] 90 | self.set_u64_unchecked(*val as u64), [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(*val)` [INFO] [stderr] ... [INFO] [stderr] 963 | / define_fn_set_int!( [INFO] [stderr] 964 | | /// Sets u16 to the SQL value. The Oracle type must be [INFO] [stderr] 965 | | /// numeric or string (excluding LOB) types. [INFO] [stderr] 966 | | : set_u16, u16); [INFO] [stderr] | |________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/sql_value.rs:92:44 [INFO] [stderr] | [INFO] [stderr] 92 | self.set_f32_unchecked(*val as f32), [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f32::from(*val)` [INFO] [stderr] ... [INFO] [stderr] 963 | / define_fn_set_int!( [INFO] [stderr] 964 | | /// Sets u16 to the SQL value. The Oracle type must be [INFO] [stderr] 965 | | /// numeric or string (excluding LOB) types. [INFO] [stderr] 966 | | : set_u16, u16); [INFO] [stderr] | |________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sql_value.rs:94:44 [INFO] [stderr] | [INFO] [stderr] 94 | self.set_f64_unchecked(*val as f64), [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(*val)` [INFO] [stderr] ... [INFO] [stderr] 963 | / define_fn_set_int!( [INFO] [stderr] 964 | | /// Sets u16 to the SQL value. The Oracle type must be [INFO] [stderr] 965 | | /// numeric or string (excluding LOB) types. [INFO] [stderr] 966 | | : set_u16, u16); [INFO] [stderr] | |________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/sql_value.rs:88:44 [INFO] [stderr] | [INFO] [stderr] 88 | self.set_i64_unchecked(*val as i64), [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i64::from(*val)` [INFO] [stderr] ... [INFO] [stderr] 967 | / define_fn_set_int!( [INFO] [stderr] 968 | | /// Sets u32 to the SQL value. The Oracle type must be [INFO] [stderr] 969 | | /// numeric or string (excluding LOB) types. [INFO] [stderr] 970 | | : set_u32, u32); [INFO] [stderr] | |________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sql_value.rs:90:44 [INFO] [stderr] | [INFO] [stderr] 90 | self.set_u64_unchecked(*val as u64), [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(*val)` [INFO] [stderr] ... [INFO] [stderr] 967 | / define_fn_set_int!( [INFO] [stderr] 968 | | /// Sets u32 to the SQL value. The Oracle type must be [INFO] [stderr] 969 | | /// numeric or string (excluding LOB) types. [INFO] [stderr] 970 | | : set_u32, u32); [INFO] [stderr] | |________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sql_value.rs:94:44 [INFO] [stderr] | [INFO] [stderr] 94 | self.set_f64_unchecked(*val as f64), [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(*val)` [INFO] [stderr] ... [INFO] [stderr] 967 | / define_fn_set_int!( [INFO] [stderr] 968 | | /// Sets u32 to the SQL value. The Oracle type must be [INFO] [stderr] 969 | | /// numeric or string (excluding LOB) types. [INFO] [stderr] 970 | | : set_u32, u32); [INFO] [stderr] | |________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sql_value.rs:94:44 [INFO] [stderr] | [INFO] [stderr] 94 | self.set_f64_unchecked(*val as f64), [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(*val)` [INFO] [stderr] ... [INFO] [stderr] 979 | / define_fn_set_int!( [INFO] [stderr] 980 | | /// Sets f32 to the SQL value. The Oracle type must be [INFO] [stderr] 981 | | /// numeric or string (excluding LOB) types. [INFO] [stderr] 982 | | : set_f32, f32); [INFO] [stderr] | |________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/sql_value.rs:1089:44 [INFO] [stderr] | [INFO] [stderr] 1089 | pub(crate) fn set_bool(&mut self, val: &bool) -> Result<()> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `bool` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/types/interval_ds.rs:260:36 [INFO] [stderr] | [INFO] [stderr] 260 | let days = s.read_digits().ok_or(err())? as i32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try this: `ok_or_else(err)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/types/interval_ds.rs:267:37 [INFO] [stderr] | [INFO] [stderr] 267 | let hours = s.read_digits().ok_or(err())? as i32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try this: `ok_or_else(err)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/types/interval_ds.rs:273:39 [INFO] [stderr] | [INFO] [stderr] 273 | let minutes = s.read_digits().ok_or(err())? as i32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try this: `ok_or_else(err)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/types/interval_ds.rs:279:39 [INFO] [stderr] | [INFO] [stderr] 279 | let seconds = s.read_digits().ok_or(err())? as i32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try this: `ok_or_else(err)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/types/interval_ds.rs:284:37 [INFO] [stderr] | [INFO] [stderr] 284 | nsecs = s.read_digits().ok_or(err())? as i32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try this: `ok_or_else(err)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/types/interval_ym.rs:92:44 [INFO] [stderr] | [INFO] [stderr] 92 | pub(crate) fn from_dpi_interval_ym(it: &dpiIntervalYM, oratype: &OracleType) -> IntervalYM { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider passing by value instead: `dpiIntervalYM` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/types/interval_ym.rs:196:37 [INFO] [stderr] | [INFO] [stderr] 196 | let years = s.read_digits().ok_or(err())? as i32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try this: `ok_or_else(err)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/types/interval_ym.rs:203:38 [INFO] [stderr] | [INFO] [stderr] 203 | let months = s.read_digits().ok_or(err())? as i32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try this: `ok_or_else(err)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is only used to index `attr_handles`. [INFO] [stderr] --> src/types/object.rs:666:34 [INFO] [stderr] | [INFO] [stderr] 666 | for j in i..attrnum { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 666 | for in attr_handles.iter().take(attrnum).skip(i) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/types/timestamp.rs:120:19 [INFO] [stderr] | [INFO] [stderr] 120 | year: ts.year as i32, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i32::from(ts.year)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/types/timestamp.rs:121:20 [INFO] [stderr] | [INFO] [stderr] 121 | month: ts.month as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(ts.month)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/types/timestamp.rs:122:18 [INFO] [stderr] | [INFO] [stderr] 122 | day: ts.day as u32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(ts.day)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/types/timestamp.rs:123:19 [INFO] [stderr] | [INFO] [stderr] 123 | hour: ts.hour as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u32::from(ts.hour)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/types/timestamp.rs:124:21 [INFO] [stderr] | [INFO] [stderr] 124 | minute: ts.minute as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(ts.minute)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/types/timestamp.rs:125:21 [INFO] [stderr] | [INFO] [stderr] 125 | second: ts.second as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(ts.second)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/types/timestamp.rs:127:29 [INFO] [stderr] | [INFO] [stderr] 127 | tz_hour_offset: ts.tzHourOffset as i32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(ts.tzHourOffset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/types/timestamp.rs:128:31 [INFO] [stderr] | [INFO] [stderr] 128 | tz_minute_offset: ts.tzMinuteOffset as i32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(ts.tzMinuteOffset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/types/timestamp.rs:321:40 [INFO] [stderr] | [INFO] [stderr] 321 | let mut year = s.read_digits().ok_or(err())?; [INFO] [stderr] | ^^^^^^^^^^^^ help: try this: `ok_or_else(err)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/types/timestamp.rs:334:41 [INFO] [stderr] | [INFO] [stderr] 334 | month = s.read_digits().ok_or(err())?; [INFO] [stderr] | ^^^^^^^^^^^^ help: try this: `ok_or_else(err)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/types/timestamp.rs:337:43 [INFO] [stderr] | [INFO] [stderr] 337 | day = s.read_digits().ok_or(err())? [INFO] [stderr] | ^^^^^^^^^^^^ help: try this: `ok_or_else(err)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/types/timestamp.rs:354:44 [INFO] [stderr] | [INFO] [stderr] 354 | hour = s.read_digits().ok_or(err())?; [INFO] [stderr] | ^^^^^^^^^^^^ help: try this: `ok_or_else(err)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/types/timestamp.rs:357:47 [INFO] [stderr] | [INFO] [stderr] 357 | min = s.read_digits().ok_or(err())?; [INFO] [stderr] | ^^^^^^^^^^^^ help: try this: `ok_or_else(err)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/types/timestamp.rs:360:51 [INFO] [stderr] | [INFO] [stderr] 360 | sec = s.read_digits().ok_or(err())?; [INFO] [stderr] | ^^^^^^^^^^^^ help: try this: `ok_or_else(err)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/types/timestamp.rs:375:40 [INFO] [stderr] | [INFO] [stderr] 375 | nsec = s.read_digits().ok_or(err())?; [INFO] [stderr] | ^^^^^^^^^^^^ help: try this: `ok_or_else(err)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/types/timestamp.rs:391:47 [INFO] [stderr] | [INFO] [stderr] 391 | tz_hour = s.read_digits().ok_or(err())? as i32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try this: `ok_or_else(err)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/types/timestamp.rs:394:50 [INFO] [stderr] | [INFO] [stderr] 394 | tz_min = s.read_digits().ok_or(err())? as i32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try this: `ok_or_else(err)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/types/timestamp.rs:403:47 [INFO] [stderr] | [INFO] [stderr] 403 | tz_hour = s.read_digits().ok_or(err())? as i32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try this: `ok_or_else(err)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/types/timestamp.rs:406:50 [INFO] [stderr] | [INFO] [stderr] 406 | tz_min = s.read_digits().ok_or(err())? as i32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try this: `ok_or_else(err)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/util.rs:119:12 [INFO] [stderr] | [INFO] [stderr] 119 | if let Some(_) = s.char() { [INFO] [stderr] | _____- ^^^^^^^ [INFO] [stderr] 120 | | return Err(err()); [INFO] [stderr] 121 | | } [INFO] [stderr] | |_____- help: try this: `if s.char().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/lib.rs:365:5 [INFO] [stderr] | [INFO] [stderr] 365 | Ok(Context), [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 365 | Ok(Box), [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:630:8 [INFO] [stderr] | [INFO] [stderr] 630 | if s.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `s.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> examples/scott-emp.rs:27:51 [INFO] [stderr] | [INFO] [stderr] 27 | println!(" {:-30} {:-8} {}", "Name", "Null?", "Type"); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> examples/scott-emp.rs:28:80 [INFO] [stderr] | [INFO] [stderr] 28 | println!(" {:-30} {:-8} {}", "------------------------------", "--------", "----------------------------"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> examples/scott-emp.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/from_to_sql.rs:61:34 [INFO] [stderr] | [INFO] [stderr] 61 | chk_num_from!(conn, 0x10000, 0x7fffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7fff_ffff` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/from_to_sql.rs:61:34 [INFO] [stderr] | [INFO] [stderr] 61 | chk_num_from!(conn, 0x10000, 0x7fffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/from_to_sql.rs:65:29 [INFO] [stderr] | [INFO] [stderr] 65 | chk_num_from!(conn, 0x80000000u32, 0xffffffffu32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x8000_0000u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/from_to_sql.rs:65:44 [INFO] [stderr] | [INFO] [stderr] 65 | chk_num_from!(conn, 0x80000000u32, 0xffffffffu32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0xffff_ffffu32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/from_to_sql.rs:68:29 [INFO] [stderr] | [INFO] [stderr] 68 | chk_num_from!(conn, 0x100000000u64, 0x7fffffffffffffffu64, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0x0001_0000_0000u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/from_to_sql.rs:68:45 [INFO] [stderr] | [INFO] [stderr] 68 | chk_num_from!(conn, 0x100000000u64, 0x7fffffffffffffffu64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `0x7fff_ffff_ffff_ffffu64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/from_to_sql.rs:71:29 [INFO] [stderr] | [INFO] [stderr] 71 | chk_num_from!(conn, 0x8000000000000000u64, 0xffffffffffffffffu64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `0x8000_0000_0000_0000u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/from_to_sql.rs:71:52 [INFO] [stderr] | [INFO] [stderr] 71 | chk_num_from!(conn, 0x8000000000000000u64, 0xffffffffffffffffu64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `0xffff_ffff_ffff_ffffu64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/from_to_sql.rs:75:29 [INFO] [stderr] | [INFO] [stderr] 75 | chk_num_from!(conn, 0x80000000u32, 0xffffffffu32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x8000_0000u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/from_to_sql.rs:75:44 [INFO] [stderr] | [INFO] [stderr] 75 | chk_num_from!(conn, 0x80000000u32, 0xffffffffu32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0xffff_ffffu32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/from_to_sql.rs:78:29 [INFO] [stderr] | [INFO] [stderr] 78 | chk_num_from!(conn, 0x100000000u64, 0x7fffffffffffffffu64, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0x0001_0000_0000u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/from_to_sql.rs:78:45 [INFO] [stderr] | [INFO] [stderr] 78 | chk_num_from!(conn, 0x100000000u64, 0x7fffffffffffffffu64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `0x7fff_ffff_ffff_ffffu64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/from_to_sql.rs:81:29 [INFO] [stderr] | [INFO] [stderr] 81 | chk_num_from!(conn, 0x8000000000000000u64, 0xffffffffffffffffu64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `0x8000_0000_0000_0000u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/from_to_sql.rs:81:52 [INFO] [stderr] | [INFO] [stderr] 81 | chk_num_from!(conn, 0x8000000000000000u64, 0xffffffffffffffffu64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `0xffff_ffff_ffff_ffffu64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/from_to_sql.rs:92:35 [INFO] [stderr] | [INFO] [stderr] 92 | chk_num_from!(conn, -0x8001, -0x80000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/from_to_sql.rs:96:30 [INFO] [stderr] | [INFO] [stderr] 96 | chk_num_from!(conn, -0x80000001i64, -0x8000000000000000i64, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x8000_0001i64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/from_to_sql.rs:96:46 [INFO] [stderr] | [INFO] [stderr] 96 | chk_num_from!(conn, -0x80000001i64, -0x8000000000000000i64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `0x8000_0000_0000_0000i64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/from_to_sql.rs:100:30 [INFO] [stderr] | [INFO] [stderr] 100 | chk_num_from!(conn, -0x80000001i64, -0x8000000000000000i64, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x8000_0001i64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/from_to_sql.rs:100:46 [INFO] [stderr] | [INFO] [stderr] 100 | chk_num_from!(conn, -0x80000001i64, -0x8000000000000000i64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `0x8000_0000_0000_0000i64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/from_to_sql.rs:183:50 [INFO] [stderr] | [INFO] [stderr] 183 | let ts = Timestamp::new(2012, 3, 4, 5, 6, 7, 123456789); [INFO] [stderr] | ^^^^^^^^^ help: consider: `123_456_789` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/from_to_sql.rs:187:50 [INFO] [stderr] | [INFO] [stderr] 187 | let ts = Timestamp::new(2012, 3, 4, 5, 6, 7, 123456000); [INFO] [stderr] | ^^^^^^^^^ help: consider: `123_456_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/from_to_sql.rs:191:50 [INFO] [stderr] | [INFO] [stderr] 191 | let ts = Timestamp::new(2012, 3, 4, 5, 6, 7, 123000000); [INFO] [stderr] | ^^^^^^^^^ help: consider: `123_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/from_to_sql.rs:242:50 [INFO] [stderr] | [INFO] [stderr] 242 | let ts = Timestamp::new(2012, 3, 4, 5, 6, 7, 123456789); [INFO] [stderr] | ^^^^^^^^^ help: consider: `123_456_789` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/from_to_sql.rs:246:50 [INFO] [stderr] | [INFO] [stderr] 246 | let ts = Timestamp::new(2012, 3, 4, 5, 6, 7, 123456000); [INFO] [stderr] | ^^^^^^^^^ help: consider: `123_456_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/from_to_sql.rs:250:50 [INFO] [stderr] | [INFO] [stderr] 250 | let ts = Timestamp::new(2012, 3, 4, 5, 6, 7, 123000000); [INFO] [stderr] | ^^^^^^^^^ help: consider: `123_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/from_to_sql.rs:282:42 [INFO] [stderr] | [INFO] [stderr] 282 | let it = IntervalDS::new(1, 2, 3, 4, 123456789); [INFO] [stderr] | ^^^^^^^^^ help: consider: `123_456_789` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/from_to_sql.rs:287:30 [INFO] [stderr] | [INFO] [stderr] 287 | let it = IntervalDS::new(123456789, 2, 3, 4, 123456789); [INFO] [stderr] | ^^^^^^^^^ help: consider: `123_456_789` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/from_to_sql.rs:287:50 [INFO] [stderr] | [INFO] [stderr] 287 | let it = IntervalDS::new(123456789, 2, 3, 4, 123456789); [INFO] [stderr] | ^^^^^^^^^ help: consider: `123_456_789` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/from_to_sql.rs:297:47 [INFO] [stderr] | [INFO] [stderr] 297 | let it = IntervalDS::new(-1, -2, -3, -4, -123456789); [INFO] [stderr] | ^^^^^^^^^ help: consider: `123_456_789` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/from_to_sql.rs:302:31 [INFO] [stderr] | [INFO] [stderr] 302 | let it = IntervalDS::new(-123456789, -2, -3, -4, -123456789); [INFO] [stderr] | ^^^^^^^^^ help: consider: `123_456_789` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/from_to_sql.rs:302:55 [INFO] [stderr] | [INFO] [stderr] 302 | let it = IntervalDS::new(-123456789, -2, -3, -4, -123456789); [INFO] [stderr] | ^^^^^^^^^ help: consider: `123_456_789` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/from_to_sql.rs:317:42 [INFO] [stderr] | [INFO] [stderr] 317 | let it = IntervalDS::new(1, 2, 3, 4, 123456789); [INFO] [stderr] | ^^^^^^^^^ help: consider: `123_456_789` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/from_to_sql.rs:322:30 [INFO] [stderr] | [INFO] [stderr] 322 | let it = IntervalDS::new(123456789, 2, 3, 4, 123456789); [INFO] [stderr] | ^^^^^^^^^ help: consider: `123_456_789` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/from_to_sql.rs:322:50 [INFO] [stderr] | [INFO] [stderr] 322 | let it = IntervalDS::new(123456789, 2, 3, 4, 123456789); [INFO] [stderr] | ^^^^^^^^^ help: consider: `123_456_789` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/from_to_sql.rs:332:47 [INFO] [stderr] | [INFO] [stderr] 332 | let it = IntervalDS::new(-1, -2, -3, -4, -123456789); [INFO] [stderr] | ^^^^^^^^^ help: consider: `123_456_789` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/from_to_sql.rs:337:31 [INFO] [stderr] | [INFO] [stderr] 337 | let it = IntervalDS::new(-123456789, -2, -3, -4, -123456789); [INFO] [stderr] | ^^^^^^^^^ help: consider: `123_456_789` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/from_to_sql.rs:337:55 [INFO] [stderr] | [INFO] [stderr] 337 | let it = IntervalDS::new(-123456789, -2, -3, -4, -123456789); [INFO] [stderr] | ^^^^^^^^^ help: consider: `123_456_789` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/from_to_sql.rs:356:30 [INFO] [stderr] | [INFO] [stderr] 356 | let it = IntervalYM::new(123456789, 2); [INFO] [stderr] | ^^^^^^^^^ help: consider: `123_456_789` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/from_to_sql.rs:366:31 [INFO] [stderr] | [INFO] [stderr] 366 | let it = IntervalYM::new(-123456789, -2); [INFO] [stderr] | ^^^^^^^^^ help: consider: `123_456_789` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/from_to_sql.rs:380:30 [INFO] [stderr] | [INFO] [stderr] 380 | let it = IntervalYM::new(123456789, 2); [INFO] [stderr] | ^^^^^^^^^ help: consider: `123_456_789` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/from_to_sql.rs:390:31 [INFO] [stderr] | [INFO] [stderr] 390 | let it = IntervalYM::new(-123456789, -2); [INFO] [stderr] | ^^^^^^^^^ help: consider: `123_456_789` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/object.rs:99:35 [INFO] [stderr] | [INFO] [stderr] 99 | subobj.set("SUBNUMBERVALUE", &1234.5679999f64).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `1_234.567_999_9f64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/object.rs:149:68 [INFO] [stderr] | [INFO] [stderr] 149 | obj.set("TIMESTAMPVALUE", &Timestamp::new(2017, 2, 3, 4, 5, 6, 123456789)).unwrap(); [INFO] [stderr] | ^^^^^^^^^ help: consider: `123_456_789` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/object.rs:157:101 [INFO] [stderr] | [INFO] [stderr] 157 | assert_eq!(obj.get::("TIMESTAMPVALUE").unwrap(), Timestamp::new(2017, 2, 3, 4, 5, 6, 123456789)); [INFO] [stderr] | ^^^^^^^^^ help: consider: `123_456_789` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/object.rs:182:22 [INFO] [stderr] | [INFO] [stderr] 182 | assert_eq!(idx, -1048576); [INFO] [stderr] | ^^^^^^^ help: consider: `1_048_576` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/object.rs:200:21 [INFO] [stderr] | [INFO] [stderr] 200 | assert_eq!(idx, 8388608); [INFO] [stderr] | ^^^^^^^ help: consider: `8_388_608` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/object.rs:210:21 [INFO] [stderr] | [INFO] [stderr] 210 | assert_eq!(idx, 8388608); [INFO] [stderr] | ^^^^^^^ help: consider: `8_388_608` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/object.rs:216:22 [INFO] [stderr] | [INFO] [stderr] 216 | assert_eq!(idx, -1048576); [INFO] [stderr] | ^^^^^^^ help: consider: `1_048_576` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> tests/common/mod.rs:68:40 [INFO] [stderr] | [INFO] [stderr] 68 | let rows = stmt.query_as::(&[]).expect(format!("error at {}:{}", file, line).as_str()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("error at {}:{}", file))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> tests/common/mod.rs:86:23 [INFO] [stderr] | [INFO] [stderr] 86 | stmt.execute(&[]).expect(format!("error at {}:{}", file, line).as_str()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("error at {}:{}", file))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> tests/common/mod.rs:114:31 [INFO] [stderr] | [INFO] [stderr] 114 | const VALUES_IN_TEST_STRINGS: [(i32, &str, &[u8], &str, Option<&str>); 11] = [ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> tests/common/mod.rs:68:40 [INFO] [stderr] | [INFO] [stderr] 68 | let rows = stmt.query_as::(&[]).expect(format!("error at {}:{}", file, line).as_str()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("error at {}:{}", file))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> tests/common/mod.rs:86:23 [INFO] [stderr] | [INFO] [stderr] 86 | stmt.execute(&[]).expect(format!("error at {}:{}", file, line).as_str()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("error at {}:{}", file))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> tests/common/mod.rs:114:31 [INFO] [stderr] | [INFO] [stderr] 114 | const VALUES_IN_TEST_STRINGS: [(i32, &str, &[u8], &str, Option<&str>); 11] = [ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/connection.rs:305:13 [INFO] [stderr] | [INFO] [stderr] 305 | / if let &ConnParam::AppContext(_, _, _) = param { [INFO] [stderr] 306 | | num_app_context += 1; [INFO] [stderr] 307 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 305 | if let ConnParam::AppContext(_, _, _) = *param { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/connection.rs:312:13 [INFO] [stderr] | [INFO] [stderr] 312 | / match param { [INFO] [stderr] 313 | | &ConnParam::Sysdba => { [INFO] [stderr] 314 | | conn_params.authMode |= DPI_MODE_AUTH_SYSDBA; [INFO] [stderr] 315 | | }, [INFO] [stderr] ... | [INFO] [stderr] 390 | | }, [INFO] [stderr] 391 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 312 | match *param { [INFO] [stderr] 313 | ConnParam::Sysdba => { [INFO] [stderr] 314 | conn_params.authMode |= DPI_MODE_AUTH_SYSDBA; [INFO] [stderr] 315 | }, [INFO] [stderr] 316 | ConnParam::Sysoper => { [INFO] [stderr] 317 | conn_params.authMode |= DPI_MODE_AUTH_SYSOPER; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/connection.rs:393:12 [INFO] [stderr] | [INFO] [stderr] 393 | if app_context.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!app_context.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> examples/select.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> examples/select.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/connection.rs:1027:12 [INFO] [stderr] | [INFO] [stderr] 1027 | if self.tag.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.tag.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> tests/common/mod.rs:68:40 [INFO] [stderr] | [INFO] [stderr] 68 | let rows = stmt.query_as::(&[]).expect(format!("error at {}:{}", file, line).as_str()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("error at {}:{}", file))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> tests/common/mod.rs:86:23 [INFO] [stderr] | [INFO] [stderr] 86 | stmt.execute(&[]).expect(format!("error at {}:{}", file, line).as_str()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("error at {}:{}", file))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> tests/common/mod.rs:114:31 [INFO] [stderr] | [INFO] [stderr] 114 | const VALUES_IN_TEST_STRINGS: [(i32, &str, &[u8], &str, Option<&str>); 11] = [ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 38 [INFO] [stderr] --> tests/object.rs:21:1 [INFO] [stderr] | [INFO] [stderr] 21 | / fn collection_udt_nestedarray() { [INFO] [stderr] 22 | | let conn = common::connect().unwrap(); [INFO] [stderr] 23 | | let objtype = conn.object_type("UDT_NESTEDARRAY").unwrap(); [INFO] [stderr] 24 | | let subobjtype = conn.object_type("UDT_SUBOBJECT").unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 106 | | assert_eq!(obj2.size().unwrap(), 2); [INFO] [stderr] 107 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> tests/common/mod.rs:68:40 [INFO] [stderr] | [INFO] [stderr] 68 | let rows = stmt.query_as::(&[]).expect(format!("error at {}:{}", file, line).as_str()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("error at {}:{}", file))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> tests/common/mod.rs:86:23 [INFO] [stderr] | [INFO] [stderr] 86 | stmt.execute(&[]).expect(format!("error at {}:{}", file, line).as_str()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("error at {}:{}", file))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> tests/common/mod.rs:114:31 [INFO] [stderr] | [INFO] [stderr] 114 | const VALUES_IN_TEST_STRINGS: [(i32, &str, &[u8], &str, Option<&str>); 11] = [ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> tests/object_type.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | / match rows.column_info()[0].oracle_type() { [INFO] [stderr] 46 | | &OracleType::Object(ref objtype) => [INFO] [stderr] 47 | | assert_udt_objectdatatypes(objtype), [INFO] [stderr] 48 | | _ => assert!(false), [INFO] [stderr] 49 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 45 | match *rows.column_info()[0].oracle_type() { [INFO] [stderr] 46 | OracleType::Object(ref objtype) => [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 33 [INFO] [stderr] --> tests/object_type.rs:52:1 [INFO] [stderr] | [INFO] [stderr] 52 | / fn assert_udt_objectdatatypes(objtype: &ObjectType) { [INFO] [stderr] 53 | | let username = common::main_user().to_uppercase(); [INFO] [stderr] 54 | | [INFO] [stderr] 55 | | assert_eq!(objtype.schema(), username); [INFO] [stderr] ... | [INFO] [stderr] 100 | | assert_eq!(attrs[12].oracle_type(), &OracleType::Int64); [INFO] [stderr] 101 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> tests/object_type.rs:115:5 [INFO] [stderr] | [INFO] [stderr] 115 | / match rows.column_info()[0].oracle_type() { [INFO] [stderr] 116 | | &OracleType::Object(ref objtype) => [INFO] [stderr] 117 | | assert_udt_object(objtype), [INFO] [stderr] 118 | | _ => assert!(false), [INFO] [stderr] 119 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 115 | match *rows.column_info()[0].oracle_type() { [INFO] [stderr] 116 | OracleType::Object(ref objtype) => [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 28 [INFO] [stderr] --> tests/object_type.rs:122:1 [INFO] [stderr] | [INFO] [stderr] 122 | / fn assert_udt_object(objtype: &ObjectType) { [INFO] [stderr] 123 | | let username = common::main_user().to_uppercase(); [INFO] [stderr] 124 | | [INFO] [stderr] 125 | | assert_eq!(objtype.schema(), username); [INFO] [stderr] ... | [INFO] [stderr] 165 | | } [INFO] [stderr] 166 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/bind.rs:27:30 [INFO] [stderr] | [INFO] [stderr] 27 | test_in_out!(stmt, i32, -1234567i32); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_234_567i32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/bind.rs:27:30 [INFO] [stderr] | [INFO] [stderr] 27 | test_in_out!(stmt, i32, -1234567i32); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_234_567i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/bind.rs:28:30 [INFO] [stderr] | [INFO] [stderr] 28 | test_in_out!(stmt, i64, -123456789i64); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `123_456_789i64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/bind.rs:31:29 [INFO] [stderr] | [INFO] [stderr] 31 | test_in_out!(stmt, u32, 1234567u32); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_234_567u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/bind.rs:32:29 [INFO] [stderr] | [INFO] [stderr] 32 | test_in_out!(stmt, u64, 123456789u64); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `123_456_789u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/bind.rs:34:29 [INFO] [stderr] | [INFO] [stderr] 34 | test_in_out!(stmt, f64, 123456789123.5f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `123_456_789_123.5f64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/bind.rs:39:71 [INFO] [stderr] | [INFO] [stderr] 39 | test_in_out!(stmt, Timestamp, Timestamp::new(2012, 3, 4, 5, 6, 7, 123456789)); [INFO] [stderr] | ^^^^^^^^^ help: consider: `123_456_789` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/bind.rs:40:64 [INFO] [stderr] | [INFO] [stderr] 40 | test_in_out!(stmt, IntervalDS, IntervalDS::new(1, 2, 3, 4, 123456789)); [INFO] [stderr] | ^^^^^^^^^ help: consider: `123_456_789` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/bind.rs:81:29 [INFO] [stderr] | [INFO] [stderr] 81 | test_to_string!(stmt, &-1234567i32); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_234_567i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/bind.rs:82:29 [INFO] [stderr] | [INFO] [stderr] 82 | test_to_string!(stmt, &-123456789i64); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `123_456_789i64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/bind.rs:85:28 [INFO] [stderr] | [INFO] [stderr] 85 | test_to_string!(stmt, &1234567u32); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_234_567u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/bind.rs:86:28 [INFO] [stderr] | [INFO] [stderr] 86 | test_to_string!(stmt, &123456789u64); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `123_456_789u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/bind.rs:88:28 [INFO] [stderr] | [INFO] [stderr] 88 | test_to_string!(stmt, &123456789123.5f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `123_456_789_123.5f64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/bind.rs:91:64 [INFO] [stderr] | [INFO] [stderr] 91 | test_to_string!(stmt, &Timestamp::new(2012, 3, 4, 5, 6, 7, 123456789)); [INFO] [stderr] | ^^^^^^^^^ help: consider: `123_456_789` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/bind.rs:92:56 [INFO] [stderr] | [INFO] [stderr] 92 | test_to_string!(stmt, &IntervalDS::new(1, 2, 3, 4, 123456789)); [INFO] [stderr] | ^^^^^^^^^ help: consider: `123_456_789` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/bind.rs:101:30 [INFO] [stderr] | [INFO] [stderr] 101 | test_to_string!(stmt, &(&123456789123.5f64, &OracleType::BinaryDouble), "123456789123.5"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `123_456_789_123.5f64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/bind.rs:134:35 [INFO] [stderr] | [INFO] [stderr] 134 | test_from_string!(stmt, i32, -1234567i32); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_234_567i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/bind.rs:135:35 [INFO] [stderr] | [INFO] [stderr] 135 | test_from_string!(stmt, i64, -123456789i64); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `123_456_789i64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/bind.rs:138:34 [INFO] [stderr] | [INFO] [stderr] 138 | test_from_string!(stmt, u32, 1234567u32); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_234_567u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/bind.rs:139:34 [INFO] [stderr] | [INFO] [stderr] 139 | test_from_string!(stmt, u64, 123456789u64); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `123_456_789u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/bind.rs:141:34 [INFO] [stderr] | [INFO] [stderr] 141 | test_from_string!(stmt, f64, 123456789123.5f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `123_456_789_123.5f64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/bind.rs:144:76 [INFO] [stderr] | [INFO] [stderr] 144 | test_from_string!(stmt, Timestamp, Timestamp::new(2012, 3, 4, 5, 6, 7, 123456789)); [INFO] [stderr] | ^^^^^^^^^ help: consider: `123_456_789` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/bind.rs:145:69 [INFO] [stderr] | [INFO] [stderr] 145 | test_from_string!(stmt, IntervalDS, IntervalDS::new(1, 2, 3, 4, 123456789)); [INFO] [stderr] | ^^^^^^^^^ help: consider: `123_456_789` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/bind.rs:149:56 [INFO] [stderr] | [INFO] [stderr] 149 | test_from_string!(stmt, f64, 123456789123.5f64, &(&123456789123.5f64, &OracleType::BinaryDouble)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `123_456_789_123.5f64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/bind.rs:149:34 [INFO] [stderr] | [INFO] [stderr] 149 | test_from_string!(stmt, f64, 123456789123.5f64, &(&123456789123.5f64, &OracleType::BinaryDouble)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `123_456_789_123.5f64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> tests/common/mod.rs:68:40 [INFO] [stderr] | [INFO] [stderr] 68 | let rows = stmt.query_as::(&[]).expect(format!("error at {}:{}", file, line).as_str()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("error at {}:{}", file))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> tests/common/mod.rs:86:23 [INFO] [stderr] | [INFO] [stderr] 86 | stmt.execute(&[]).expect(format!("error at {}:{}", file, line).as_str()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("error at {}:{}", file))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> tests/common/mod.rs:114:31 [INFO] [stderr] | [INFO] [stderr] 114 | const VALUES_IN_TEST_STRINGS: [(i32, &str, &[u8], &str, Option<&str>); 11] = [ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 323 [INFO] [stderr] --> tests/from_to_sql.rs:46:1 [INFO] [stderr] | [INFO] [stderr] 46 | / fn numeric_from_sql() { [INFO] [stderr] 47 | | let conn = common::connect().unwrap(); [INFO] [stderr] 48 | | [INFO] [stderr] 49 | | chk_num_from!(conn, 0, 0x7f, [INFO] [stderr] ... | [INFO] [stderr] 103 | | } [INFO] [stderr] 104 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> tests/from_to_sql.rs:34:20 [INFO] [stderr] | [INFO] [stderr] 34 | assert_eq!($val as $T, $row.get_as::<$T>().unwrap()); [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(0x80000000u32)` [INFO] [stderr] ... [INFO] [stderr] 65 | / chk_num_from!(conn, 0x80000000u32, 0xffffffffu32, [INFO] [stderr] 66 | | (i8, false), (i16, false), (i32, false), (i64, true), (isize, true), [INFO] [stderr] 67 | | (u8, false), (u16, false), (u32, true), (u64, true), (usize, true)); [INFO] [stderr] | |__________________________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting to the same type is unnecessary (`u32` -> `u32`) [INFO] [stderr] --> tests/from_to_sql.rs:34:20 [INFO] [stderr] | [INFO] [stderr] 34 | assert_eq!($val as $T, $row.get_as::<$T>().unwrap()); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 65 | / chk_num_from!(conn, 0x80000000u32, 0xffffffffu32, [INFO] [stderr] 66 | | (i8, false), (i16, false), (i32, false), (i64, true), (isize, true), [INFO] [stderr] 67 | | (u8, false), (u16, false), (u32, true), (u64, true), (usize, true)); [INFO] [stderr] | |__________________________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> tests/from_to_sql.rs:34:20 [INFO] [stderr] | [INFO] [stderr] 34 | assert_eq!($val as $T, $row.get_as::<$T>().unwrap()); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(0x80000000u32)` [INFO] [stderr] ... [INFO] [stderr] 65 | / chk_num_from!(conn, 0x80000000u32, 0xffffffffu32, [INFO] [stderr] 66 | | (i8, false), (i16, false), (i32, false), (i64, true), (isize, true), [INFO] [stderr] 67 | | (u8, false), (u16, false), (u32, true), (u64, true), (usize, true)); [INFO] [stderr] | |__________________________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> tests/from_to_sql.rs:34:20 [INFO] [stderr] | [INFO] [stderr] 34 | assert_eq!($val as $T, $row.get_as::<$T>().unwrap()); [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(0xffffffffu32)` [INFO] [stderr] ... [INFO] [stderr] 65 | / chk_num_from!(conn, 0x80000000u32, 0xffffffffu32, [INFO] [stderr] 66 | | (i8, false), (i16, false), (i32, false), (i64, true), (isize, true), [INFO] [stderr] 67 | | (u8, false), (u16, false), (u32, true), (u64, true), (usize, true)); [INFO] [stderr] | |__________________________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting to the same type is unnecessary (`u32` -> `u32`) [INFO] [stderr] --> tests/from_to_sql.rs:34:20 [INFO] [stderr] | [INFO] [stderr] 34 | assert_eq!($val as $T, $row.get_as::<$T>().unwrap()); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 65 | / chk_num_from!(conn, 0x80000000u32, 0xffffffffu32, [INFO] [stderr] 66 | | (i8, false), (i16, false), (i32, false), (i64, true), (isize, true), [INFO] [stderr] 67 | | (u8, false), (u16, false), (u32, true), (u64, true), (usize, true)); [INFO] [stderr] | |__________________________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> tests/from_to_sql.rs:34:20 [INFO] [stderr] | [INFO] [stderr] 34 | assert_eq!($val as $T, $row.get_as::<$T>().unwrap()); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(0xffffffffu32)` [INFO] [stderr] ... [INFO] [stderr] 65 | / chk_num_from!(conn, 0x80000000u32, 0xffffffffu32, [INFO] [stderr] 66 | | (i8, false), (i16, false), (i32, false), (i64, true), (isize, true), [INFO] [stderr] 67 | | (u8, false), (u16, false), (u32, true), (u64, true), (usize, true)); [INFO] [stderr] | |__________________________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stderr] --> tests/from_to_sql.rs:34:20 [INFO] [stderr] | [INFO] [stderr] 34 | assert_eq!($val as $T, $row.get_as::<$T>().unwrap()); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 68 | / chk_num_from!(conn, 0x100000000u64, 0x7fffffffffffffffu64, [INFO] [stderr] 69 | | (i8, false), (i16, false), (i32, false), (i64, true), (isize, true), [INFO] [stderr] 70 | | (u8, false), (u16, false), (u32, false), (u64, true), (usize, true)); [INFO] [stderr] | |___________________________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stderr] [INFO] [stderr] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stderr] --> tests/from_to_sql.rs:34:20 [INFO] [stderr] | [INFO] [stderr] 34 | assert_eq!($val as $T, $row.get_as::<$T>().unwrap()); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 68 | / chk_num_from!(conn, 0x100000000u64, 0x7fffffffffffffffu64, [INFO] [stderr] 69 | | (i8, false), (i16, false), (i32, false), (i64, true), (isize, true), [INFO] [stderr] 70 | | (u8, false), (u16, false), (u32, false), (u64, true), (usize, true)); [INFO] [stderr] | |___________________________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stderr] [INFO] [stderr] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stderr] --> tests/from_to_sql.rs:34:20 [INFO] [stderr] | [INFO] [stderr] 34 | assert_eq!($val as $T, $row.get_as::<$T>().unwrap()); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 71 | / chk_num_from!(conn, 0x8000000000000000u64, 0xffffffffffffffffu64, [INFO] [stderr] 72 | | (i8, false), (i16, false), (i32, false), (i64, false), (isize, false), [INFO] [stderr] 73 | | (u8, false), (u16, false), (u32, false), (u64, true), (usize, true)); [INFO] [stderr] | |___________________________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stderr] [INFO] [stderr] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stderr] --> tests/from_to_sql.rs:34:20 [INFO] [stderr] | [INFO] [stderr] 34 | assert_eq!($val as $T, $row.get_as::<$T>().unwrap()); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 71 | / chk_num_from!(conn, 0x8000000000000000u64, 0xffffffffffffffffu64, [INFO] [stderr] 72 | | (i8, false), (i16, false), (i32, false), (i64, false), (isize, false), [INFO] [stderr] 73 | | (u8, false), (u16, false), (u32, false), (u64, true), (usize, true)); [INFO] [stderr] | |___________________________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> tests/from_to_sql.rs:34:20 [INFO] [stderr] | [INFO] [stderr] 34 | assert_eq!($val as $T, $row.get_as::<$T>().unwrap()); [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(0x80000000u32)` [INFO] [stderr] ... [INFO] [stderr] 75 | / chk_num_from!(conn, 0x80000000u32, 0xffffffffu32, [INFO] [stderr] 76 | | (i8, false), (i16, false), (i32, false), (i64, true), (isize, false), [INFO] [stderr] 77 | | (u8, false), (u16, false), (u32, true), (u64, true), (usize, true)); [INFO] [stderr] | |__________________________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting to the same type is unnecessary (`u32` -> `u32`) [INFO] [stderr] --> tests/from_to_sql.rs:34:20 [INFO] [stderr] | [INFO] [stderr] 34 | assert_eq!($val as $T, $row.get_as::<$T>().unwrap()); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 75 | / chk_num_from!(conn, 0x80000000u32, 0xffffffffu32, [INFO] [stderr] 76 | | (i8, false), (i16, false), (i32, false), (i64, true), (isize, false), [INFO] [stderr] 77 | | (u8, false), (u16, false), (u32, true), (u64, true), (usize, true)); [INFO] [stderr] | |__________________________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> tests/from_to_sql.rs:34:20 [INFO] [stderr] | [INFO] [stderr] 34 | assert_eq!($val as $T, $row.get_as::<$T>().unwrap()); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(0x80000000u32)` [INFO] [stderr] ... [INFO] [stderr] 75 | / chk_num_from!(conn, 0x80000000u32, 0xffffffffu32, [INFO] [stderr] 76 | | (i8, false), (i16, false), (i32, false), (i64, true), (isize, false), [INFO] [stderr] 77 | | (u8, false), (u16, false), (u32, true), (u64, true), (usize, true)); [INFO] [stderr] | |__________________________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> tests/from_to_sql.rs:34:20 [INFO] [stderr] | [INFO] [stderr] 34 | assert_eq!($val as $T, $row.get_as::<$T>().unwrap()); [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(0xffffffffu32)` [INFO] [stderr] ... [INFO] [stderr] 75 | / chk_num_from!(conn, 0x80000000u32, 0xffffffffu32, [INFO] [stderr] 76 | | (i8, false), (i16, false), (i32, false), (i64, true), (isize, false), [INFO] [stderr] 77 | | (u8, false), (u16, false), (u32, true), (u64, true), (usize, true)); [INFO] [stderr] | |__________________________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting to the same type is unnecessary (`u32` -> `u32`) [INFO] [stderr] --> tests/from_to_sql.rs:34:20 [INFO] [stderr] | [INFO] [stderr] 34 | assert_eq!($val as $T, $row.get_as::<$T>().unwrap()); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 75 | / chk_num_from!(conn, 0x80000000u32, 0xffffffffu32, [INFO] [stderr] 76 | | (i8, false), (i16, false), (i32, false), (i64, true), (isize, false), [INFO] [stderr] 77 | | (u8, false), (u16, false), (u32, true), (u64, true), (usize, true)); [INFO] [stderr] | |__________________________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> tests/from_to_sql.rs:34:20 [INFO] [stderr] | [INFO] [stderr] 34 | assert_eq!($val as $T, $row.get_as::<$T>().unwrap()); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(0xffffffffu32)` [INFO] [stderr] ... [INFO] [stderr] 75 | / chk_num_from!(conn, 0x80000000u32, 0xffffffffu32, [INFO] [stderr] 76 | | (i8, false), (i16, false), (i32, false), (i64, true), (isize, false), [INFO] [stderr] 77 | | (u8, false), (u16, false), (u32, true), (u64, true), (usize, true)); [INFO] [stderr] | |__________________________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stderr] --> tests/from_to_sql.rs:34:20 [INFO] [stderr] | [INFO] [stderr] 34 | assert_eq!($val as $T, $row.get_as::<$T>().unwrap()); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 78 | / chk_num_from!(conn, 0x100000000u64, 0x7fffffffffffffffu64, [INFO] [stderr] 79 | | (i8, false), (i16, false), (i32, false), (i64, true), (isize, false), [INFO] [stderr] 80 | | (u8, false), (u16, false), (u32, false), (u64, true), (usize, false)); [INFO] [stderr] | |____________________________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stderr] [INFO] [stderr] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stderr] --> tests/from_to_sql.rs:34:20 [INFO] [stderr] | [INFO] [stderr] 34 | assert_eq!($val as $T, $row.get_as::<$T>().unwrap()); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 78 | / chk_num_from!(conn, 0x100000000u64, 0x7fffffffffffffffu64, [INFO] [stderr] 79 | | (i8, false), (i16, false), (i32, false), (i64, true), (isize, false), [INFO] [stderr] 80 | | (u8, false), (u16, false), (u32, false), (u64, true), (usize, false)); [INFO] [stderr] | |____________________________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stderr] [INFO] [stderr] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stderr] --> tests/from_to_sql.rs:34:20 [INFO] [stderr] | [INFO] [stderr] 34 | assert_eq!($val as $T, $row.get_as::<$T>().unwrap()); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 81 | / chk_num_from!(conn, 0x8000000000000000u64, 0xffffffffffffffffu64, [INFO] [stderr] 82 | | (i8, false), (i16, false), (i32, false), (i64, false), (isize, false), [INFO] [stderr] 83 | | (u8, false), (u16, false), (u32, false), (u64, true), (usize, false)); [INFO] [stderr] | |____________________________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stderr] [INFO] [stderr] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stderr] --> tests/from_to_sql.rs:34:20 [INFO] [stderr] | [INFO] [stderr] 34 | assert_eq!($val as $T, $row.get_as::<$T>().unwrap()); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 81 | / chk_num_from!(conn, 0x8000000000000000u64, 0xffffffffffffffffu64, [INFO] [stderr] 82 | | (i8, false), (i16, false), (i32, false), (i64, false), (isize, false), [INFO] [stderr] 83 | | (u8, false), (u16, false), (u32, false), (u64, true), (usize, false)); [INFO] [stderr] | |____________________________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> tests/common/mod.rs:68:40 [INFO] [stderr] | [INFO] [stderr] 68 | let rows = stmt.query_as::(&[]).expect(format!("error at {}:{}", file, line).as_str()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("error at {}:{}", file))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> tests/common/mod.rs:86:23 [INFO] [stderr] | [INFO] [stderr] 86 | stmt.execute(&[]).expect(format!("error at {}:{}", file, line).as_str()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("error at {}:{}", file))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> tests/common/mod.rs:114:31 [INFO] [stderr] | [INFO] [stderr] 114 | const VALUES_IN_TEST_STRINGS: [(i32, &str, &[u8], &str, Option<&str>); 11] = [ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/bind.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | test_in_out!(stmt, f32, -123.5f32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/bind.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | test_in_out!(stmt, f32, -123.5f32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/bind.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | test_in_out!(stmt, f64, 123456789123.5f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/bind.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | test_in_out!(stmt, f64, 123456789123.5f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/bind.rs:140:5 [INFO] [stderr] | [INFO] [stderr] 140 | test_from_string!(stmt, f32, -123.5f32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/bind.rs:140:5 [INFO] [stderr] | [INFO] [stderr] 140 | test_from_string!(stmt, f32, -123.5f32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/bind.rs:141:5 [INFO] [stderr] | [INFO] [stderr] 141 | test_from_string!(stmt, f64, 123456789123.5f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/bind.rs:141:5 [INFO] [stderr] | [INFO] [stderr] 141 | test_from_string!(stmt, f64, 123456789123.5f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/bind.rs:148:5 [INFO] [stderr] | [INFO] [stderr] 148 | test_from_string!(stmt, f32, -123.5f32, &(&-123.5f32, &OracleType::BinaryDouble)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/bind.rs:148:5 [INFO] [stderr] | [INFO] [stderr] 148 | test_from_string!(stmt, f32, -123.5f32, &(&-123.5f32, &OracleType::BinaryDouble)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/bind.rs:149:5 [INFO] [stderr] | [INFO] [stderr] 149 | test_from_string!(stmt, f64, 123456789123.5f64, &(&123456789123.5f64, &OracleType::BinaryDouble)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/bind.rs:149:5 [INFO] [stderr] | [INFO] [stderr] 149 | test_from_string!(stmt, f64, 123456789123.5f64, &(&123456789123.5f64, &OracleType::BinaryDouble)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to 6 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `oracle`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> tests/common/mod.rs:68:40 [INFO] [stderr] | [INFO] [stderr] 68 | let rows = stmt.query_as::(&[]).expect(format!("error at {}:{}", file, line).as_str()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("error at {}:{}", file))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> tests/common/mod.rs:86:23 [INFO] [stderr] | [INFO] [stderr] 86 | stmt.execute(&[]).expect(format!("error at {}:{}", file, line).as_str()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("error at {}:{}", file))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> tests/common/mod.rs:114:31 [INFO] [stderr] | [INFO] [stderr] 114 | const VALUES_IN_TEST_STRINGS: [(i32, &str, &[u8], &str, Option<&str>); 11] = [ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 79 [INFO] [stderr] --> tests/statement.rs:22:1 [INFO] [stderr] | [INFO] [stderr] 22 | / fn statement_type() { [INFO] [stderr] 23 | | let conn = common::connect().unwrap(); [INFO] [stderr] 24 | | [INFO] [stderr] 25 | | let stmt = conn.prepare("SELECT ...", &[]).unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 140 | | assert_eq!(stmt.is_dml(), false); [INFO] [stderr] 141 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 31 [INFO] [stderr] --> tests/statement.rs:264:1 [INFO] [stderr] | [INFO] [stderr] 264 | / fn insert_and_fetch() { [INFO] [stderr] 265 | | let conn = common::connect().unwrap(); [INFO] [stderr] 266 | | let char_data = "Hello, Guten Tag"; [INFO] [stderr] 267 | | let nchar_data = "Hello, こんにちは, 你好"; [INFO] [stderr] ... | [INFO] [stderr] 357 | | assert_eq!(row.2, None); [INFO] [stderr] 358 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/statement.rs:277:5 [INFO] [stderr] | [INFO] [stderr] 277 | assert_eq!(row.1, 9.2); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/statement.rs:277:5 [INFO] [stderr] | [INFO] [stderr] 277 | assert_eq!(row.1, 9.2); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/statement.rs:278:5 [INFO] [stderr] | [INFO] [stderr] 278 | assert_eq!(row.2, 10.14); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/statement.rs:278:5 [INFO] [stderr] | [INFO] [stderr] 278 | assert_eq!(row.2, 10.14); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/statement.rs:279:5 [INFO] [stderr] | [INFO] [stderr] 279 | assert_eq!(row.3, 7.14); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/statement.rs:279:5 [INFO] [stderr] | [INFO] [stderr] 279 | assert_eq!(row.3, 7.14); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `oracle`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/statement.rs:122:15 [INFO] [stderr] | [INFO] [stderr] 122 | match num as u32 { [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(num)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/statement.rs:144:9 [INFO] [stderr] | [INFO] [stderr] 144 | / match self { [INFO] [stderr] 145 | | &StatementType::Select => write!(f, "select"), [INFO] [stderr] 146 | | &StatementType::Insert => write!(f, "insert"), [INFO] [stderr] 147 | | &StatementType::Update => write!(f, "update"), [INFO] [stderr] ... | [INFO] [stderr] 159 | | &StatementType::Unknown => write!(f, "unknown"), [INFO] [stderr] 160 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 144 | match *self { [INFO] [stderr] 145 | StatementType::Select => write!(f, "select"), [INFO] [stderr] 146 | StatementType::Insert => write!(f, "insert"), [INFO] [stderr] 147 | StatementType::Update => write!(f, "update"), [INFO] [stderr] 148 | StatementType::Delete => write!(f, "delete"), [INFO] [stderr] 149 | StatementType::Merge => write!(f, "merge"), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/statement.rs:187:13 [INFO] [stderr] | [INFO] [stderr] 187 | / match param { [INFO] [stderr] 188 | | &StmtParam::FetchArraySize(size) => { [INFO] [stderr] 189 | | fetch_array_size = size; [INFO] [stderr] 190 | | }, [INFO] [stderr] ... | [INFO] [stderr] 196 | | }, [INFO] [stderr] 197 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 187 | match *param { [INFO] [stderr] 188 | StmtParam::FetchArraySize(size) => { [INFO] [stderr] 189 | fetch_array_size = size; [INFO] [stderr] 190 | }, [INFO] [stderr] 191 | StmtParam::Scrollable => { [INFO] [stderr] 192 | scrollable = 1; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `params` [INFO] [stderr] --> src/statement.rs:411:18 [INFO] [stderr] | [INFO] [stderr] 411 | for i in 0..params.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 411 | for (i, ) in params.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `params`. [INFO] [stderr] --> src/statement.rs:419:18 [INFO] [stderr] | [INFO] [stderr] 419 | for i in 0..params.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 419 | for in ¶ms { [INFO] [stderr] | ^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/statement.rs:632:19 [INFO] [stderr] | [INFO] [stderr] 632 | if rows > sqlval.array_size as u64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(sqlval.array_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/statement.rs:633:20 [INFO] [stderr] | [INFO] [stderr] 633 | rows = sqlval.array_size as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(sqlval.array_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/statement.rs:725:12 [INFO] [stderr] | [INFO] [stderr] 725 | if self.column_info.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.column_info.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/statement.rs:875:33 [INFO] [stderr] | [INFO] [stderr] 875 | fn idx(&self, column_names: &Vec) -> Result; [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/sql_value.rs:49:16 [INFO] [stderr] | [INFO] [stderr] 49 | if $dest_type::min_value() as $src_type <= src_val && src_val <= $dest_type::max_value() as $src_type { [INFO] [stderr] | ________________^ [INFO] [stderr] 50 | | Ok(src_val as $dest_type) [INFO] [stderr] 51 | | } else { [INFO] [stderr] 52 | | Err(Error::OutOfRange(format!("{} overflow: {}", stringify!($dest_type), src_val.to_string(), ))) [INFO] [stderr] ... | [INFO] [stderr] 67 | | NativeType::Float => [INFO] [stderr] 68 | | flt_to_int!(self.get_f32_unchecked()?, f32, $type), [INFO] [stderr] | |______________________________________________________________^ help: try: `f32::from($dest_type::min_value())` [INFO] [stderr] ... [INFO] [stderr] 686 | / define_fn_to_int!( [INFO] [stderr] 687 | | /// Gets the SQL value as i8. The Oracle type must be [INFO] [stderr] 688 | | /// numeric or string (excluding LOB) types. [INFO] [stderr] 689 | | : to_i8, i8); [INFO] [stderr] | |_____________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/sql_value.rs:49:78 [INFO] [stderr] | [INFO] [stderr] 49 | if $dest_type::min_value() as $src_type <= src_val && src_val <= $dest_type::max_value() as $src_type { [INFO] [stderr] | ______________________________________________________________________________^ [INFO] [stderr] 50 | | Ok(src_val as $dest_type) [INFO] [stderr] 51 | | } else { [INFO] [stderr] 52 | | Err(Error::OutOfRange(format!("{} overflow: {}", stringify!($dest_type), src_val.to_string(), ))) [INFO] [stderr] ... | [INFO] [stderr] 67 | | NativeType::Float => [INFO] [stderr] 68 | | flt_to_int!(self.get_f32_unchecked()?, f32, $type), [INFO] [stderr] | |______________________________________________________________^ help: try: `f32::from($dest_type::max_value())` [INFO] [stderr] ... [INFO] [stderr] 686 | / define_fn_to_int!( [INFO] [stderr] 687 | | /// Gets the SQL value as i8. The Oracle type must be [INFO] [stderr] 688 | | /// numeric or string (excluding LOB) types. [INFO] [stderr] 689 | | : to_i8, i8); [INFO] [stderr] | |_____________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sql_value.rs:49:16 [INFO] [stderr] | [INFO] [stderr] 49 | if $dest_type::min_value() as $src_type <= src_val && src_val <= $dest_type::max_value() as $src_type { [INFO] [stderr] | ________________^ [INFO] [stderr] 50 | | Ok(src_val as $dest_type) [INFO] [stderr] 51 | | } else { [INFO] [stderr] 52 | | Err(Error::OutOfRange(format!("{} overflow: {}", stringify!($dest_type), src_val.to_string(), ))) [INFO] [stderr] ... | [INFO] [stderr] 69 | | NativeType::Double => [INFO] [stderr] 70 | | flt_to_int!(self.get_f64_unchecked()?, f64, $type), [INFO] [stderr] | |______________________________________________________________^ help: try: `f64::from($dest_type::min_value())` [INFO] [stderr] ... [INFO] [stderr] 686 | / define_fn_to_int!( [INFO] [stderr] 687 | | /// Gets the SQL value as i8. The Oracle type must be [INFO] [stderr] 688 | | /// numeric or string (excluding LOB) types. [INFO] [stderr] 689 | | : to_i8, i8); [INFO] [stderr] | |_____________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sql_value.rs:49:78 [INFO] [stderr] | [INFO] [stderr] 49 | if $dest_type::min_value() as $src_type <= src_val && src_val <= $dest_type::max_value() as $src_type { [INFO] [stderr] | ______________________________________________________________________________^ [INFO] [stderr] 50 | | Ok(src_val as $dest_type) [INFO] [stderr] 51 | | } else { [INFO] [stderr] 52 | | Err(Error::OutOfRange(format!("{} overflow: {}", stringify!($dest_type), src_val.to_string(), ))) [INFO] [stderr] ... | [INFO] [stderr] 69 | | NativeType::Double => [INFO] [stderr] 70 | | flt_to_int!(self.get_f64_unchecked()?, f64, $type), [INFO] [stderr] | |______________________________________________________________^ help: try: `f64::from($dest_type::max_value())` [INFO] [stderr] ... [INFO] [stderr] 686 | / define_fn_to_int!( [INFO] [stderr] 687 | | /// Gets the SQL value as i8. The Oracle type must be [INFO] [stderr] 688 | | /// numeric or string (excluding LOB) types. [INFO] [stderr] 689 | | : to_i8, i8); [INFO] [stderr] | |_____________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/sql_value.rs:49:16 [INFO] [stderr] | [INFO] [stderr] 49 | if $dest_type::min_value() as $src_type <= src_val && src_val <= $dest_type::max_value() as $src_type { [INFO] [stderr] | ________________^ [INFO] [stderr] 50 | | Ok(src_val as $dest_type) [INFO] [stderr] 51 | | } else { [INFO] [stderr] 52 | | Err(Error::OutOfRange(format!("{} overflow: {}", stringify!($dest_type), src_val.to_string(), ))) [INFO] [stderr] ... | [INFO] [stderr] 67 | | NativeType::Float => [INFO] [stderr] 68 | | flt_to_int!(self.get_f32_unchecked()?, f32, $type), [INFO] [stderr] | |______________________________________________________________^ help: try: `f32::from($dest_type::min_value())` [INFO] [stderr] ... [INFO] [stderr] 690 | / define_fn_to_int!( [INFO] [stderr] 691 | | /// Gets the SQL value as i16. The Oracle type must be [INFO] [stderr] 692 | | /// numeric or string (excluding LOB) types. [INFO] [stderr] 693 | | : to_i16, i16); [INFO] [stderr] | |_______________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/sql_value.rs:49:78 [INFO] [stderr] | [INFO] [stderr] 49 | if $dest_type::min_value() as $src_type <= src_val && src_val <= $dest_type::max_value() as $src_type { [INFO] [stderr] | ______________________________________________________________________________^ [INFO] [stderr] 50 | | Ok(src_val as $dest_type) [INFO] [stderr] 51 | | } else { [INFO] [stderr] 52 | | Err(Error::OutOfRange(format!("{} overflow: {}", stringify!($dest_type), src_val.to_string(), ))) [INFO] [stderr] ... | [INFO] [stderr] 67 | | NativeType::Float => [INFO] [stderr] 68 | | flt_to_int!(self.get_f32_unchecked()?, f32, $type), [INFO] [stderr] | |______________________________________________________________^ help: try: `f32::from($dest_type::max_value())` [INFO] [stderr] ... [INFO] [stderr] 690 | / define_fn_to_int!( [INFO] [stderr] 691 | | /// Gets the SQL value as i16. The Oracle type must be [INFO] [stderr] 692 | | /// numeric or string (excluding LOB) types. [INFO] [stderr] 693 | | : to_i16, i16); [INFO] [stderr] | |_______________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sql_value.rs:49:16 [INFO] [stderr] | [INFO] [stderr] 49 | if $dest_type::min_value() as $src_type <= src_val && src_val <= $dest_type::max_value() as $src_type { [INFO] [stderr] | ________________^ [INFO] [stderr] 50 | | Ok(src_val as $dest_type) [INFO] [stderr] 51 | | } else { [INFO] [stderr] 52 | | Err(Error::OutOfRange(format!("{} overflow: {}", stringify!($dest_type), src_val.to_string(), ))) [INFO] [stderr] ... | [INFO] [stderr] 69 | | NativeType::Double => [INFO] [stderr] 70 | | flt_to_int!(self.get_f64_unchecked()?, f64, $type), [INFO] [stderr] | |______________________________________________________________^ help: try: `f64::from($dest_type::min_value())` [INFO] [stderr] ... [INFO] [stderr] 690 | / define_fn_to_int!( [INFO] [stderr] 691 | | /// Gets the SQL value as i16. The Oracle type must be [INFO] [stderr] 692 | | /// numeric or string (excluding LOB) types. [INFO] [stderr] 693 | | : to_i16, i16); [INFO] [stderr] | |_______________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sql_value.rs:49:78 [INFO] [stderr] | [INFO] [stderr] 49 | if $dest_type::min_value() as $src_type <= src_val && src_val <= $dest_type::max_value() as $src_type { [INFO] [stderr] | ______________________________________________________________________________^ [INFO] [stderr] 50 | | Ok(src_val as $dest_type) [INFO] [stderr] 51 | | } else { [INFO] [stderr] 52 | | Err(Error::OutOfRange(format!("{} overflow: {}", stringify!($dest_type), src_val.to_string(), ))) [INFO] [stderr] ... | [INFO] [stderr] 69 | | NativeType::Double => [INFO] [stderr] 70 | | flt_to_int!(self.get_f64_unchecked()?, f64, $type), [INFO] [stderr] | |______________________________________________________________^ help: try: `f64::from($dest_type::max_value())` [INFO] [stderr] ... [INFO] [stderr] 690 | / define_fn_to_int!( [INFO] [stderr] 691 | | /// Gets the SQL value as i16. The Oracle type must be [INFO] [stderr] 692 | | /// numeric or string (excluding LOB) types. [INFO] [stderr] 693 | | : to_i16, i16); [INFO] [stderr] | |_______________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sql_value.rs:49:16 [INFO] [stderr] | [INFO] [stderr] 49 | if $dest_type::min_value() as $src_type <= src_val && src_val <= $dest_type::max_value() as $src_type { [INFO] [stderr] | ________________^ [INFO] [stderr] 50 | | Ok(src_val as $dest_type) [INFO] [stderr] 51 | | } else { [INFO] [stderr] 52 | | Err(Error::OutOfRange(format!("{} overflow: {}", stringify!($dest_type), src_val.to_string(), ))) [INFO] [stderr] ... | [INFO] [stderr] 69 | | NativeType::Double => [INFO] [stderr] 70 | | flt_to_int!(self.get_f64_unchecked()?, f64, $type), [INFO] [stderr] | |______________________________________________________________^ help: try: `f64::from($dest_type::min_value())` [INFO] [stderr] ... [INFO] [stderr] 694 | / define_fn_to_int!( [INFO] [stderr] 695 | | /// Gets the SQL value as i32. The Oracle type must be [INFO] [stderr] 696 | | /// numeric or string (excluding LOB) types. [INFO] [stderr] 697 | | : to_i32, i32); [INFO] [stderr] | |_______________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sql_value.rs:49:78 [INFO] [stderr] | [INFO] [stderr] 49 | if $dest_type::min_value() as $src_type <= src_val && src_val <= $dest_type::max_value() as $src_type { [INFO] [stderr] | ______________________________________________________________________________^ [INFO] [stderr] 50 | | Ok(src_val as $dest_type) [INFO] [stderr] 51 | | } else { [INFO] [stderr] 52 | | Err(Error::OutOfRange(format!("{} overflow: {}", stringify!($dest_type), src_val.to_string(), ))) [INFO] [stderr] ... | [INFO] [stderr] 69 | | NativeType::Double => [INFO] [stderr] 70 | | flt_to_int!(self.get_f64_unchecked()?, f64, $type), [INFO] [stderr] | |______________________________________________________________^ help: try: `f64::from($dest_type::max_value())` [INFO] [stderr] ... [INFO] [stderr] 694 | / define_fn_to_int!( [INFO] [stderr] 695 | | /// Gets the SQL value as i32. The Oracle type must be [INFO] [stderr] 696 | | /// numeric or string (excluding LOB) types. [INFO] [stderr] 697 | | : to_i32, i32); [INFO] [stderr] | |_______________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/sql_value.rs:49:16 [INFO] [stderr] | [INFO] [stderr] 49 | if $dest_type::min_value() as $src_type <= src_val && src_val <= $dest_type::max_value() as $src_type { [INFO] [stderr] | ________________^ [INFO] [stderr] 50 | | Ok(src_val as $dest_type) [INFO] [stderr] 51 | | } else { [INFO] [stderr] 52 | | Err(Error::OutOfRange(format!("{} overflow: {}", stringify!($dest_type), src_val.to_string(), ))) [INFO] [stderr] ... | [INFO] [stderr] 67 | | NativeType::Float => [INFO] [stderr] 68 | | flt_to_int!(self.get_f32_unchecked()?, f32, $type), [INFO] [stderr] | |______________________________________________________________^ help: try: `f32::from($dest_type::min_value())` [INFO] [stderr] ... [INFO] [stderr] 724 | / define_fn_to_int!( [INFO] [stderr] 725 | | /// Gets the SQL value as u8. The Oracle type must be [INFO] [stderr] 726 | | /// numeric or string (excluding LOB) types. [INFO] [stderr] 727 | | : to_u8, u8); [INFO] [stderr] | |_____________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/sql_value.rs:49:78 [INFO] [stderr] | [INFO] [stderr] 49 | if $dest_type::min_value() as $src_type <= src_val && src_val <= $dest_type::max_value() as $src_type { [INFO] [stderr] | ______________________________________________________________________________^ [INFO] [stderr] 50 | | Ok(src_val as $dest_type) [INFO] [stderr] 51 | | } else { [INFO] [stderr] 52 | | Err(Error::OutOfRange(format!("{} overflow: {}", stringify!($dest_type), src_val.to_string(), ))) [INFO] [stderr] ... | [INFO] [stderr] 67 | | NativeType::Float => [INFO] [stderr] 68 | | flt_to_int!(self.get_f32_unchecked()?, f32, $type), [INFO] [stderr] | |______________________________________________________________^ help: try: `f32::from($dest_type::max_value())` [INFO] [stderr] ... [INFO] [stderr] 724 | / define_fn_to_int!( [INFO] [stderr] 725 | | /// Gets the SQL value as u8. The Oracle type must be [INFO] [stderr] 726 | | /// numeric or string (excluding LOB) types. [INFO] [stderr] 727 | | : to_u8, u8); [INFO] [stderr] | |_____________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sql_value.rs:49:16 [INFO] [stderr] | [INFO] [stderr] 49 | if $dest_type::min_value() as $src_type <= src_val && src_val <= $dest_type::max_value() as $src_type { [INFO] [stderr] | ________________^ [INFO] [stderr] 50 | | Ok(src_val as $dest_type) [INFO] [stderr] 51 | | } else { [INFO] [stderr] 52 | | Err(Error::OutOfRange(format!("{} overflow: {}", stringify!($dest_type), src_val.to_string(), ))) [INFO] [stderr] ... | [INFO] [stderr] 69 | | NativeType::Double => [INFO] [stderr] 70 | | flt_to_int!(self.get_f64_unchecked()?, f64, $type), [INFO] [stderr] | |______________________________________________________________^ help: try: `f64::from($dest_type::min_value())` [INFO] [stderr] ... [INFO] [stderr] 724 | / define_fn_to_int!( [INFO] [stderr] 725 | | /// Gets the SQL value as u8. The Oracle type must be [INFO] [stderr] 726 | | /// numeric or string (excluding LOB) types. [INFO] [stderr] 727 | | : to_u8, u8); [INFO] [stderr] | |_____________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sql_value.rs:49:78 [INFO] [stderr] | [INFO] [stderr] 49 | if $dest_type::min_value() as $src_type <= src_val && src_val <= $dest_type::max_value() as $src_type { [INFO] [stderr] | ______________________________________________________________________________^ [INFO] [stderr] 50 | | Ok(src_val as $dest_type) [INFO] [stderr] 51 | | } else { [INFO] [stderr] 52 | | Err(Error::OutOfRange(format!("{} overflow: {}", stringify!($dest_type), src_val.to_string(), ))) [INFO] [stderr] ... | [INFO] [stderr] 69 | | NativeType::Double => [INFO] [stderr] 70 | | flt_to_int!(self.get_f64_unchecked()?, f64, $type), [INFO] [stderr] | |______________________________________________________________^ help: try: `f64::from($dest_type::max_value())` [INFO] [stderr] ... [INFO] [stderr] 724 | / define_fn_to_int!( [INFO] [stderr] 725 | | /// Gets the SQL value as u8. The Oracle type must be [INFO] [stderr] 726 | | /// numeric or string (excluding LOB) types. [INFO] [stderr] 727 | | : to_u8, u8); [INFO] [stderr] | |_____________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/sql_value.rs:49:16 [INFO] [stderr] | [INFO] [stderr] 49 | if $dest_type::min_value() as $src_type <= src_val && src_val <= $dest_type::max_value() as $src_type { [INFO] [stderr] | ________________^ [INFO] [stderr] 50 | | Ok(src_val as $dest_type) [INFO] [stderr] 51 | | } else { [INFO] [stderr] 52 | | Err(Error::OutOfRange(format!("{} overflow: {}", stringify!($dest_type), src_val.to_string(), ))) [INFO] [stderr] ... | [INFO] [stderr] 67 | | NativeType::Float => [INFO] [stderr] 68 | | flt_to_int!(self.get_f32_unchecked()?, f32, $type), [INFO] [stderr] | |______________________________________________________________^ help: try: `f32::from($dest_type::min_value())` [INFO] [stderr] ... [INFO] [stderr] 728 | / define_fn_to_int!( [INFO] [stderr] 729 | | /// Gets the SQL value as u16. The Oracle type must be [INFO] [stderr] 730 | | /// numeric or string (excluding LOB) types. [INFO] [stderr] 731 | | : to_u16, u16); [INFO] [stderr] | |_______________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/sql_value.rs:49:78 [INFO] [stderr] | [INFO] [stderr] 49 | if $dest_type::min_value() as $src_type <= src_val && src_val <= $dest_type::max_value() as $src_type { [INFO] [stderr] | ______________________________________________________________________________^ [INFO] [stderr] 50 | | Ok(src_val as $dest_type) [INFO] [stderr] 51 | | } else { [INFO] [stderr] 52 | | Err(Error::OutOfRange(format!("{} overflow: {}", stringify!($dest_type), src_val.to_string(), ))) [INFO] [stderr] ... | [INFO] [stderr] 67 | | NativeType::Float => [INFO] [stderr] 68 | | flt_to_int!(self.get_f32_unchecked()?, f32, $type), [INFO] [stderr] | |______________________________________________________________^ help: try: `f32::from($dest_type::max_value())` [INFO] [stderr] ... [INFO] [stderr] 728 | / define_fn_to_int!( [INFO] [stderr] 729 | | /// Gets the SQL value as u16. The Oracle type must be [INFO] [stderr] 730 | | /// numeric or string (excluding LOB) types. [INFO] [stderr] 731 | | : to_u16, u16); [INFO] [stderr] | |_______________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sql_value.rs:49:16 [INFO] [stderr] | [INFO] [stderr] 49 | if $dest_type::min_value() as $src_type <= src_val && src_val <= $dest_type::max_value() as $src_type { [INFO] [stderr] | ________________^ [INFO] [stderr] 50 | | Ok(src_val as $dest_type) [INFO] [stderr] 51 | | } else { [INFO] [stderr] 52 | | Err(Error::OutOfRange(format!("{} overflow: {}", stringify!($dest_type), src_val.to_string(), ))) [INFO] [stderr] ... | [INFO] [stderr] 69 | | NativeType::Double => [INFO] [stderr] 70 | | flt_to_int!(self.get_f64_unchecked()?, f64, $type), [INFO] [stderr] | |______________________________________________________________^ help: try: `f64::from($dest_type::min_value())` [INFO] [stderr] ... [INFO] [stderr] 728 | / define_fn_to_int!( [INFO] [stderr] 729 | | /// Gets the SQL value as u16. The Oracle type must be [INFO] [stderr] 730 | | /// numeric or string (excluding LOB) types. [INFO] [stderr] 731 | | : to_u16, u16); [INFO] [stderr] | |_______________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sql_value.rs:49:78 [INFO] [stderr] | [INFO] [stderr] 49 | if $dest_type::min_value() as $src_type <= src_val && src_val <= $dest_type::max_value() as $src_type { [INFO] [stderr] | ______________________________________________________________________________^ [INFO] [stderr] 50 | | Ok(src_val as $dest_type) [INFO] [stderr] 51 | | } else { [INFO] [stderr] 52 | | Err(Error::OutOfRange(format!("{} overflow: {}", stringify!($dest_type), src_val.to_string(), ))) [INFO] [stderr] ... | [INFO] [stderr] 69 | | NativeType::Double => [INFO] [stderr] 70 | | flt_to_int!(self.get_f64_unchecked()?, f64, $type), [INFO] [stderr] | |______________________________________________________________^ help: try: `f64::from($dest_type::max_value())` [INFO] [stderr] ... [INFO] [stderr] 728 | / define_fn_to_int!( [INFO] [stderr] 729 | | /// Gets the SQL value as u16. The Oracle type must be [INFO] [stderr] 730 | | /// numeric or string (excluding LOB) types. [INFO] [stderr] 731 | | : to_u16, u16); [INFO] [stderr] | |_______________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sql_value.rs:49:16 [INFO] [stderr] | [INFO] [stderr] 49 | if $dest_type::min_value() as $src_type <= src_val && src_val <= $dest_type::max_value() as $src_type { [INFO] [stderr] | ________________^ [INFO] [stderr] 50 | | Ok(src_val as $dest_type) [INFO] [stderr] 51 | | } else { [INFO] [stderr] 52 | | Err(Error::OutOfRange(format!("{} overflow: {}", stringify!($dest_type), src_val.to_string(), ))) [INFO] [stderr] ... | [INFO] [stderr] 69 | | NativeType::Double => [INFO] [stderr] 70 | | flt_to_int!(self.get_f64_unchecked()?, f64, $type), [INFO] [stderr] | |______________________________________________________________^ help: try: `f64::from($dest_type::min_value())` [INFO] [stderr] ... [INFO] [stderr] 732 | / define_fn_to_int!( [INFO] [stderr] 733 | | /// Gets the SQL value as u32. The Oracle type must be [INFO] [stderr] 734 | | /// numeric or string (excluding LOB) types. [INFO] [stderr] 735 | | : to_u32, u32); [INFO] [stderr] | |_______________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sql_value.rs:49:78 [INFO] [stderr] | [INFO] [stderr] 49 | if $dest_type::min_value() as $src_type <= src_val && src_val <= $dest_type::max_value() as $src_type { [INFO] [stderr] | ______________________________________________________________________________^ [INFO] [stderr] 50 | | Ok(src_val as $dest_type) [INFO] [stderr] 51 | | } else { [INFO] [stderr] 52 | | Err(Error::OutOfRange(format!("{} overflow: {}", stringify!($dest_type), src_val.to_string(), ))) [INFO] [stderr] ... | [INFO] [stderr] 69 | | NativeType::Double => [INFO] [stderr] 70 | | flt_to_int!(self.get_f64_unchecked()?, f64, $type), [INFO] [stderr] | |______________________________________________________________^ help: try: `f64::from($dest_type::max_value())` [INFO] [stderr] ... [INFO] [stderr] 732 | / define_fn_to_int!( [INFO] [stderr] 733 | | /// Gets the SQL value as u32. The Oracle type must be [INFO] [stderr] 734 | | /// numeric or string (excluding LOB) types. [INFO] [stderr] 735 | | : to_u32, u32); [INFO] [stderr] | |_______________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sql_value.rs:792:20 [INFO] [stderr] | [INFO] [stderr] 792 | Ok(self.get_f32_unchecked()? as f64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.get_f32_unchecked()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/sql_value.rs:88:44 [INFO] [stderr] | [INFO] [stderr] 88 | self.set_i64_unchecked(*val as i64), [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i64::from(*val)` [INFO] [stderr] ... [INFO] [stderr] 939 | / define_fn_set_int!( [INFO] [stderr] 940 | | /// Sets i8 to the SQL value. The Oracle type must be [INFO] [stderr] 941 | | /// numeric or string (excluding LOB) types. [INFO] [stderr] 942 | | : set_i8, i8); [INFO] [stderr] | |______________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/sql_value.rs:92:44 [INFO] [stderr] | [INFO] [stderr] 92 | self.set_f32_unchecked(*val as f32), [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f32::from(*val)` [INFO] [stderr] ... [INFO] [stderr] 939 | / define_fn_set_int!( [INFO] [stderr] 940 | | /// Sets i8 to the SQL value. The Oracle type must be [INFO] [stderr] 941 | | /// numeric or string (excluding LOB) types. [INFO] [stderr] 942 | | : set_i8, i8); [INFO] [stderr] | |______________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sql_value.rs:94:44 [INFO] [stderr] | [INFO] [stderr] 94 | self.set_f64_unchecked(*val as f64), [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(*val)` [INFO] [stderr] ... [INFO] [stderr] 939 | / define_fn_set_int!( [INFO] [stderr] 940 | | /// Sets i8 to the SQL value. The Oracle type must be [INFO] [stderr] 941 | | /// numeric or string (excluding LOB) types. [INFO] [stderr] 942 | | : set_i8, i8); [INFO] [stderr] | |______________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/sql_value.rs:88:44 [INFO] [stderr] | [INFO] [stderr] 88 | self.set_i64_unchecked(*val as i64), [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i64::from(*val)` [INFO] [stderr] ... [INFO] [stderr] 943 | / define_fn_set_int!( [INFO] [stderr] 944 | | /// Sets i16 to the SQL value. The Oracle type must be [INFO] [stderr] 945 | | /// numeric or string (excluding LOB) types. [INFO] [stderr] 946 | | : set_i16, i16); [INFO] [stderr] | |________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/sql_value.rs:92:44 [INFO] [stderr] | [INFO] [stderr] 92 | self.set_f32_unchecked(*val as f32), [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f32::from(*val)` [INFO] [stderr] ... [INFO] [stderr] 943 | / define_fn_set_int!( [INFO] [stderr] 944 | | /// Sets i16 to the SQL value. The Oracle type must be [INFO] [stderr] 945 | | /// numeric or string (excluding LOB) types. [INFO] [stderr] 946 | | : set_i16, i16); [INFO] [stderr] | |________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sql_value.rs:94:44 [INFO] [stderr] | [INFO] [stderr] 94 | self.set_f64_unchecked(*val as f64), [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(*val)` [INFO] [stderr] ... [INFO] [stderr] 943 | / define_fn_set_int!( [INFO] [stderr] 944 | | /// Sets i16 to the SQL value. The Oracle type must be [INFO] [stderr] 945 | | /// numeric or string (excluding LOB) types. [INFO] [stderr] 946 | | : set_i16, i16); [INFO] [stderr] | |________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/sql_value.rs:88:44 [INFO] [stderr] | [INFO] [stderr] 88 | self.set_i64_unchecked(*val as i64), [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i64::from(*val)` [INFO] [stderr] ... [INFO] [stderr] 947 | / define_fn_set_int!( [INFO] [stderr] 948 | | /// Sets i32 to the SQL value. The Oracle type must be [INFO] [stderr] 949 | | /// numeric or string (excluding LOB) types. [INFO] [stderr] 950 | | : set_i32, i32); [INFO] [stderr] | |________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sql_value.rs:94:44 [INFO] [stderr] | [INFO] [stderr] 94 | self.set_f64_unchecked(*val as f64), [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(*val)` [INFO] [stderr] ... [INFO] [stderr] 947 | / define_fn_set_int!( [INFO] [stderr] 948 | | /// Sets i32 to the SQL value. The Oracle type must be [INFO] [stderr] 949 | | /// numeric or string (excluding LOB) types. [INFO] [stderr] 950 | | : set_i32, i32); [INFO] [stderr] | |________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/sql_value.rs:88:44 [INFO] [stderr] | [INFO] [stderr] 88 | self.set_i64_unchecked(*val as i64), [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i64::from(*val)` [INFO] [stderr] ... [INFO] [stderr] 959 | / define_fn_set_int!( [INFO] [stderr] 960 | | /// Sets u8 to the SQL value. The Oracle type must be [INFO] [stderr] 961 | | /// numeric or string (excluding LOB) types. [INFO] [stderr] 962 | | : set_u8, u8); [INFO] [stderr] | |______________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sql_value.rs:90:44 [INFO] [stderr] | [INFO] [stderr] 90 | self.set_u64_unchecked(*val as u64), [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(*val)` [INFO] [stderr] ... [INFO] [stderr] 959 | / define_fn_set_int!( [INFO] [stderr] 960 | | /// Sets u8 to the SQL value. The Oracle type must be [INFO] [stderr] 961 | | /// numeric or string (excluding LOB) types. [INFO] [stderr] 962 | | : set_u8, u8); [INFO] [stderr] | |______________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/sql_value.rs:92:44 [INFO] [stderr] | [INFO] [stderr] 92 | self.set_f32_unchecked(*val as f32), [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f32::from(*val)` [INFO] [stderr] ... [INFO] [stderr] 959 | / define_fn_set_int!( [INFO] [stderr] 960 | | /// Sets u8 to the SQL value. The Oracle type must be [INFO] [stderr] 961 | | /// numeric or string (excluding LOB) types. [INFO] [stderr] 962 | | : set_u8, u8); [INFO] [stderr] | |______________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sql_value.rs:94:44 [INFO] [stderr] | [INFO] [stderr] 94 | self.set_f64_unchecked(*val as f64), [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(*val)` [INFO] [stderr] ... [INFO] [stderr] 959 | / define_fn_set_int!( [INFO] [stderr] 960 | | /// Sets u8 to the SQL value. The Oracle type must be [INFO] [stderr] 961 | | /// numeric or string (excluding LOB) types. [INFO] [stderr] 962 | | : set_u8, u8); [INFO] [stderr] | |______________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/sql_value.rs:88:44 [INFO] [stderr] | [INFO] [stderr] 88 | self.set_i64_unchecked(*val as i64), [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i64::from(*val)` [INFO] [stderr] ... [INFO] [stderr] 963 | / define_fn_set_int!( [INFO] [stderr] 964 | | /// Sets u16 to the SQL value. The Oracle type must be [INFO] [stderr] 965 | | /// numeric or string (excluding LOB) types. [INFO] [stderr] 966 | | : set_u16, u16); [INFO] [stderr] | |________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sql_value.rs:90:44 [INFO] [stderr] | [INFO] [stderr] 90 | self.set_u64_unchecked(*val as u64), [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(*val)` [INFO] [stderr] ... [INFO] [stderr] 963 | / define_fn_set_int!( [INFO] [stderr] 964 | | /// Sets u16 to the SQL value. The Oracle type must be [INFO] [stderr] 965 | | /// numeric or string (excluding LOB) types. [INFO] [stderr] 966 | | : set_u16, u16); [INFO] [stderr] | |________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/sql_value.rs:92:44 [INFO] [stderr] | [INFO] [stderr] 92 | self.set_f32_unchecked(*val as f32), [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f32::from(*val)` [INFO] [stderr] ... [INFO] [stderr] 963 | / define_fn_set_int!( [INFO] [stderr] 964 | | /// Sets u16 to the SQL value. The Oracle type must be [INFO] [stderr] 965 | | /// numeric or string (excluding LOB) types. [INFO] [stderr] 966 | | : set_u16, u16); [INFO] [stderr] | |________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sql_value.rs:94:44 [INFO] [stderr] | [INFO] [stderr] 94 | self.set_f64_unchecked(*val as f64), [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(*val)` [INFO] [stderr] ... [INFO] [stderr] 963 | / define_fn_set_int!( [INFO] [stderr] 964 | | /// Sets u16 to the SQL value. The Oracle type must be [INFO] [stderr] 965 | | /// numeric or string (excluding LOB) types. [INFO] [stderr] 966 | | : set_u16, u16); [INFO] [stderr] | |________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/sql_value.rs:88:44 [INFO] [stderr] | [INFO] [stderr] 88 | self.set_i64_unchecked(*val as i64), [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i64::from(*val)` [INFO] [stderr] ... [INFO] [stderr] 967 | / define_fn_set_int!( [INFO] [stderr] 968 | | /// Sets u32 to the SQL value. The Oracle type must be [INFO] [stderr] 969 | | /// numeric or string (excluding LOB) types. [INFO] [stderr] 970 | | : set_u32, u32); [INFO] [stderr] | |________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sql_value.rs:90:44 [INFO] [stderr] | [INFO] [stderr] 90 | self.set_u64_unchecked(*val as u64), [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(*val)` [INFO] [stderr] ... [INFO] [stderr] 967 | / define_fn_set_int!( [INFO] [stderr] 968 | | /// Sets u32 to the SQL value. The Oracle type must be [INFO] [stderr] 969 | | /// numeric or string (excluding LOB) types. [INFO] [stderr] 970 | | : set_u32, u32); [INFO] [stderr] | |________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sql_value.rs:94:44 [INFO] [stderr] | [INFO] [stderr] 94 | self.set_f64_unchecked(*val as f64), [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(*val)` [INFO] [stderr] ... [INFO] [stderr] 967 | / define_fn_set_int!( [INFO] [stderr] 968 | | /// Sets u32 to the SQL value. The Oracle type must be [INFO] [stderr] 969 | | /// numeric or string (excluding LOB) types. [INFO] [stderr] 970 | | : set_u32, u32); [INFO] [stderr] | |________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sql_value.rs:94:44 [INFO] [stderr] | [INFO] [stderr] 94 | self.set_f64_unchecked(*val as f64), [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(*val)` [INFO] [stderr] ... [INFO] [stderr] 979 | / define_fn_set_int!( [INFO] [stderr] 980 | | /// Sets f32 to the SQL value. The Oracle type must be [INFO] [stderr] 981 | | /// numeric or string (excluding LOB) types. [INFO] [stderr] 982 | | : set_f32, f32); [INFO] [stderr] | |________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/sql_value.rs:1089:44 [INFO] [stderr] | [INFO] [stderr] 1089 | pub(crate) fn set_bool(&mut self, val: &bool) -> Result<()> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `bool` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/types/interval_ds.rs:260:36 [INFO] [stderr] | [INFO] [stderr] 260 | let days = s.read_digits().ok_or(err())? as i32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try this: `ok_or_else(err)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/types/interval_ds.rs:267:37 [INFO] [stderr] | [INFO] [stderr] 267 | let hours = s.read_digits().ok_or(err())? as i32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try this: `ok_or_else(err)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/types/interval_ds.rs:273:39 [INFO] [stderr] | [INFO] [stderr] 273 | let minutes = s.read_digits().ok_or(err())? as i32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try this: `ok_or_else(err)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/types/interval_ds.rs:279:39 [INFO] [stderr] | [INFO] [stderr] 279 | let seconds = s.read_digits().ok_or(err())? as i32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try this: `ok_or_else(err)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/types/interval_ds.rs:284:37 [INFO] [stderr] | [INFO] [stderr] 284 | nsecs = s.read_digits().ok_or(err())? as i32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try this: `ok_or_else(err)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 30 [INFO] [stderr] --> src/types/interval_ds.rs:314:5 [INFO] [stderr] | [INFO] [stderr] 314 | / fn to_string() { [INFO] [stderr] 315 | | let mut it = IntervalDS::new(1, 2, 3, 4, 123456789); [INFO] [stderr] 316 | | it.lfprec = 0; it.fsprec = 0; [INFO] [stderr] 317 | | assert_eq!(it.to_string(), "+1 02:03:04"); [INFO] [stderr] ... | [INFO] [stderr] 376 | | assert_eq!(it.to_string(), "-000000001 02:03:04.123456789"); [INFO] [stderr] 377 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/types/interval_ym.rs:92:44 [INFO] [stderr] | [INFO] [stderr] 92 | pub(crate) fn from_dpi_interval_ym(it: &dpiIntervalYM, oratype: &OracleType) -> IntervalYM { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider passing by value instead: `dpiIntervalYM` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/types/interval_ym.rs:196:37 [INFO] [stderr] | [INFO] [stderr] 196 | let years = s.read_digits().ok_or(err())? as i32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try this: `ok_or_else(err)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/types/interval_ym.rs:203:38 [INFO] [stderr] | [INFO] [stderr] 203 | let months = s.read_digits().ok_or(err())? as i32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try this: `ok_or_else(err)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is only used to index `attr_handles`. [INFO] [stderr] --> src/types/object.rs:666:34 [INFO] [stderr] | [INFO] [stderr] 666 | for j in i..attrnum { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 666 | for in attr_handles.iter().take(attrnum).skip(i) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/types/timestamp.rs:120:19 [INFO] [stderr] | [INFO] [stderr] 120 | year: ts.year as i32, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i32::from(ts.year)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/types/timestamp.rs:121:20 [INFO] [stderr] | [INFO] [stderr] 121 | month: ts.month as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(ts.month)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/types/timestamp.rs:122:18 [INFO] [stderr] | [INFO] [stderr] 122 | day: ts.day as u32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(ts.day)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/types/timestamp.rs:123:19 [INFO] [stderr] | [INFO] [stderr] 123 | hour: ts.hour as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u32::from(ts.hour)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/types/timestamp.rs:124:21 [INFO] [stderr] | [INFO] [stderr] 124 | minute: ts.minute as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(ts.minute)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/types/timestamp.rs:125:21 [INFO] [stderr] | [INFO] [stderr] 125 | second: ts.second as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(ts.second)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/types/timestamp.rs:127:29 [INFO] [stderr] | [INFO] [stderr] 127 | tz_hour_offset: ts.tzHourOffset as i32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(ts.tzHourOffset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/types/timestamp.rs:128:31 [INFO] [stderr] | [INFO] [stderr] 128 | tz_minute_offset: ts.tzMinuteOffset as i32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(ts.tzMinuteOffset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/types/timestamp.rs:321:40 [INFO] [stderr] | [INFO] [stderr] 321 | let mut year = s.read_digits().ok_or(err())?; [INFO] [stderr] | ^^^^^^^^^^^^ help: try this: `ok_or_else(err)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/types/timestamp.rs:334:41 [INFO] [stderr] | [INFO] [stderr] 334 | month = s.read_digits().ok_or(err())?; [INFO] [stderr] | ^^^^^^^^^^^^ help: try this: `ok_or_else(err)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/types/timestamp.rs:337:43 [INFO] [stderr] | [INFO] [stderr] 337 | day = s.read_digits().ok_or(err())? [INFO] [stderr] | ^^^^^^^^^^^^ help: try this: `ok_or_else(err)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/types/timestamp.rs:354:44 [INFO] [stderr] | [INFO] [stderr] 354 | hour = s.read_digits().ok_or(err())?; [INFO] [stderr] | ^^^^^^^^^^^^ help: try this: `ok_or_else(err)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/types/timestamp.rs:357:47 [INFO] [stderr] | [INFO] [stderr] 357 | min = s.read_digits().ok_or(err())?; [INFO] [stderr] | ^^^^^^^^^^^^ help: try this: `ok_or_else(err)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/types/timestamp.rs:360:51 [INFO] [stderr] | [INFO] [stderr] 360 | sec = s.read_digits().ok_or(err())?; [INFO] [stderr] | ^^^^^^^^^^^^ help: try this: `ok_or_else(err)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/types/timestamp.rs:375:40 [INFO] [stderr] | [INFO] [stderr] 375 | nsec = s.read_digits().ok_or(err())?; [INFO] [stderr] | ^^^^^^^^^^^^ help: try this: `ok_or_else(err)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/types/timestamp.rs:391:47 [INFO] [stderr] | [INFO] [stderr] 391 | tz_hour = s.read_digits().ok_or(err())? as i32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try this: `ok_or_else(err)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/types/timestamp.rs:394:50 [INFO] [stderr] | [INFO] [stderr] 394 | tz_min = s.read_digits().ok_or(err())? as i32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try this: `ok_or_else(err)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/types/timestamp.rs:403:47 [INFO] [stderr] | [INFO] [stderr] 403 | tz_hour = s.read_digits().ok_or(err())? as i32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try this: `ok_or_else(err)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/types/timestamp.rs:406:50 [INFO] [stderr] | [INFO] [stderr] 406 | tz_min = s.read_digits().ok_or(err())? as i32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try this: `ok_or_else(err)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 36 [INFO] [stderr] --> src/types/timestamp.rs:485:5 [INFO] [stderr] | [INFO] [stderr] 485 | / fn parse() { [INFO] [stderr] 486 | | let mut ts = Timestamp::new(2012, 1, 1, // year, month, day, [INFO] [stderr] 487 | | 0, 0, 0, 0); // hour, minute, second, nanosecond, [INFO] [stderr] 488 | | ts.precision = 0; [INFO] [stderr] ... | [INFO] [stderr] 542 | | assert_eq!("-123-03-04 05:06:07.123 +00:45".parse(), Ok(ts)); [INFO] [stderr] 543 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/util.rs:119:12 [INFO] [stderr] | [INFO] [stderr] 119 | if let Some(_) = s.char() { [INFO] [stderr] | _____- ^^^^^^^ [INFO] [stderr] 120 | | return Err(err()); [INFO] [stderr] 121 | | } [INFO] [stderr] | |_____- help: try this: `if s.char().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/lib.rs:365:5 [INFO] [stderr] | [INFO] [stderr] 365 | Ok(Context), [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 365 | Ok(Box), [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:630:8 [INFO] [stderr] | [INFO] [stderr] 630 | if s.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `s.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "d74092da280cf244a60f3445707c9d932ba572c23d9784dda3a58229f6fa64cb"` [INFO] running `"docker" "rm" "-f" "d74092da280cf244a60f3445707c9d932ba572c23d9784dda3a58229f6fa64cb"` [INFO] [stdout] d74092da280cf244a60f3445707c9d932ba572c23d9784dda3a58229f6fa64cb