[INFO] crate options_results 0.1.1 is already in cache [INFO] extracting crate options_results 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/options_results/0.1.1 [INFO] extracting crate options_results 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/options_results/0.1.1 [INFO] validating manifest of options_results-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of options_results-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing options_results-0.1.1 [INFO] finished frobbing options_results-0.1.1 [INFO] frobbed toml for options_results-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/options_results/0.1.1/Cargo.toml [INFO] started frobbing options_results-0.1.1 [INFO] finished frobbing options_results-0.1.1 [INFO] frobbed toml for options_results-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/options_results/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting options_results-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/options_results/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0076b70d61f2513d7cba83c86ffdfe19410f914d683a030bd901e967404d64dc [INFO] running `"docker" "start" "-a" "0076b70d61f2513d7cba83c86ffdfe19410f914d683a030bd901e967404d64dc"` [INFO] [stderr] Checking options_results v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/optioniter.rs:16:32 [INFO] [stderr] | [INFO] [stderr] 16 | UnwrapOr { iter: self, def: def } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `def` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resultiter.rs:17:32 [INFO] [stderr] | [INFO] [stderr] 17 | UnwrapOr { iter: self, def: def, phantom: PhantomData } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `def` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/optioniter.rs:16:32 [INFO] [stderr] | [INFO] [stderr] 16 | UnwrapOr { iter: self, def: def } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `def` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resultiter.rs:17:32 [INFO] [stderr] | [INFO] [stderr] 17 | UnwrapOr { iter: self, def: def, phantom: PhantomData } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `def` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/optioniter.rs:88:36 [INFO] [stderr] | [INFO] [stderr] 88 | self.iter.next().map(|e| e.unwrap_or(self.def.clone())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| self.def.clone())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/resultiter.rs:35:29 [INFO] [stderr] | [INFO] [stderr] 35 | while let Some(e) = self.next() { [INFO] [stderr] | ^^^^^^^^^^^ help: try: `for e in self { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/resultiter.rs:45:29 [INFO] [stderr] | [INFO] [stderr] 45 | while let Some(e) = self.next() { [INFO] [stderr] | ^^^^^^^^^^^ help: try: `for e in self { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/resultiter.rs:140:36 [INFO] [stderr] | [INFO] [stderr] 140 | self.iter.next().map(|e| e.unwrap_or(self.def.clone())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| self.def.clone())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/optioniter.rs:88:36 [INFO] [stderr] | [INFO] [stderr] 88 | self.iter.next().map(|e| e.unwrap_or(self.def.clone())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| self.def.clone())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/resultiter.rs:35:29 [INFO] [stderr] | [INFO] [stderr] 35 | while let Some(e) = self.next() { [INFO] [stderr] | ^^^^^^^^^^^ help: try: `for e in self { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/resultiter.rs:45:29 [INFO] [stderr] | [INFO] [stderr] 45 | while let Some(e) = self.next() { [INFO] [stderr] | ^^^^^^^^^^^ help: try: `for e in self { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/resultiter.rs:140:36 [INFO] [stderr] | [INFO] [stderr] 140 | self.iter.next().map(|e| e.unwrap_or(self.def.clone())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| self.def.clone())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.27s [INFO] running `"docker" "inspect" "0076b70d61f2513d7cba83c86ffdfe19410f914d683a030bd901e967404d64dc"` [INFO] running `"docker" "rm" "-f" "0076b70d61f2513d7cba83c86ffdfe19410f914d683a030bd901e967404d64dc"` [INFO] [stdout] 0076b70d61f2513d7cba83c86ffdfe19410f914d683a030bd901e967404d64dc