[INFO] crate optimize 0.1.0 is already in cache [INFO] extracting crate optimize 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/optimize/0.1.0 [INFO] extracting crate optimize 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/optimize/0.1.0 [INFO] validating manifest of optimize-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of optimize-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing optimize-0.1.0 [INFO] finished frobbing optimize-0.1.0 [INFO] frobbed toml for optimize-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/optimize/0.1.0/Cargo.toml [INFO] started frobbing optimize-0.1.0 [INFO] finished frobbing optimize-0.1.0 [INFO] frobbed toml for optimize-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/optimize/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting optimize-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/optimize/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2b7733f9e27e51ce4a18331cd7cf1edd4cecfa0a41853fd0641781d462bb8c2a [INFO] running `"docker" "start" "-a" "2b7733f9e27e51ce4a18331cd7cf1edd4cecfa0a41853fd0641781d462bb8c2a"` [INFO] [stderr] Checking optimize v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:128:50 [INFO] [stderr] | [INFO] [stderr] 128 | let mut func = WrappedFunction { num: 0, func: func }; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `func` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:128:50 [INFO] [stderr] | [INFO] [stderr] 128 | let mut func = WrappedFunction { num: 0, func: func }; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `func` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/lib.rs:113:28 [INFO] [stderr] | [INFO] [stderr] 113 | _tmp.slice_mut(s![k, ..]).assign(&sim.slice(s![*s, ..])); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deref_addrof)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/lib.rs:113:57 [INFO] [stderr] | [INFO] [stderr] 113 | _tmp.slice_mut(s![k, ..]).assign(&sim.slice(s![*s, ..])); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/lib.rs:169:23 [INFO] [stderr] | [INFO] [stderr] 169 | sim.slice_mut(s![0, ..]).assign(&x0); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/lib.rs:176:27 [INFO] [stderr] | [INFO] [stderr] 176 | sim.slice_mut(s![k + 1, ..]).assign(&y); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/lib.rs:186:18 [INFO] [stderr] | [INFO] [stderr] 186 | let s0 = s![0, ..]; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/lib.rs:187:19 [INFO] [stderr] | [INFO] [stderr] 187 | let sm1 = s![-1, ..]; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/lib.rs:194:28 [INFO] [stderr] | [INFO] [stderr] 194 | if (&sim.slice(s![1.., ..]) - &sim.slice(s0)) [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/lib.rs:204:29 [INFO] [stderr] | [INFO] [stderr] 204 | if (&fsim.slice(s![1..]) - fsim[0]) [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/lib.rs:215:34 [INFO] [stderr] | [INFO] [stderr] 215 | let xbar = sim.slice(s![..-1, ..]) [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:236:20 [INFO] [stderr] | [INFO] [stderr] 236 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 237 | | if fxr.approx_lt_ulps(&fsim[n - 1], self.ulps) { [INFO] [stderr] 238 | | sim.slice_mut(sm1).assign(&xr); [INFO] [stderr] 239 | | fsim[n] = fxr; [INFO] [stderr] ... | [INFO] [stderr] 273 | | } [INFO] [stderr] 274 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 236 | } else if fxr.approx_lt_ulps(&fsim[n - 1], self.ulps) { [INFO] [stderr] 237 | sim.slice_mut(sm1).assign(&xr); [INFO] [stderr] 238 | fsim[n] = fxr; [INFO] [stderr] 239 | } else { [INFO] [stderr] 240 | if fxr.approx_lt_ulps(&fsim[n], self.ulps) { [INFO] [stderr] 241 | let xc = (1. + psi * rho) * &xbar - psi * rho * &sim.slice(sm1); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/lib.rs:265:38 [INFO] [stderr] | [INFO] [stderr] 265 | let sj = s![j, ..]; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/lib.rs:279:30 [INFO] [stderr] | [INFO] [stderr] 279 | x0.assign(&sim.slice(s![0, ..])); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/lib.rs:113:28 [INFO] [stderr] | [INFO] [stderr] 113 | _tmp.slice_mut(s![k, ..]).assign(&sim.slice(s![*s, ..])); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deref_addrof)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/lib.rs:113:57 [INFO] [stderr] | [INFO] [stderr] 113 | _tmp.slice_mut(s![k, ..]).assign(&sim.slice(s![*s, ..])); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/lib.rs:169:23 [INFO] [stderr] | [INFO] [stderr] 169 | sim.slice_mut(s![0, ..]).assign(&x0); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/lib.rs:176:27 [INFO] [stderr] | [INFO] [stderr] 176 | sim.slice_mut(s![k + 1, ..]).assign(&y); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/lib.rs:186:18 [INFO] [stderr] | [INFO] [stderr] 186 | let s0 = s![0, ..]; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/lib.rs:187:19 [INFO] [stderr] | [INFO] [stderr] 187 | let sm1 = s![-1, ..]; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/lib.rs:194:28 [INFO] [stderr] | [INFO] [stderr] 194 | if (&sim.slice(s![1.., ..]) - &sim.slice(s0)) [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/lib.rs:204:29 [INFO] [stderr] | [INFO] [stderr] 204 | if (&fsim.slice(s![1..]) - fsim[0]) [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/lib.rs:215:34 [INFO] [stderr] | [INFO] [stderr] 215 | let xbar = sim.slice(s![..-1, ..]) [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:236:20 [INFO] [stderr] | [INFO] [stderr] 236 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 237 | | if fxr.approx_lt_ulps(&fsim[n - 1], self.ulps) { [INFO] [stderr] 238 | | sim.slice_mut(sm1).assign(&xr); [INFO] [stderr] 239 | | fsim[n] = fxr; [INFO] [stderr] ... | [INFO] [stderr] 273 | | } [INFO] [stderr] 274 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 236 | } else if fxr.approx_lt_ulps(&fsim[n - 1], self.ulps) { [INFO] [stderr] 237 | sim.slice_mut(sm1).assign(&xr); [INFO] [stderr] 238 | fsim[n] = fxr; [INFO] [stderr] 239 | } else { [INFO] [stderr] 240 | if fxr.approx_lt_ulps(&fsim[n], self.ulps) { [INFO] [stderr] 241 | let xc = (1. + psi * rho) * &xbar - psi * rho * &sim.slice(sm1); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/lib.rs:265:38 [INFO] [stderr] | [INFO] [stderr] 265 | let sj = s![j, ..]; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/lib.rs:279:30 [INFO] [stderr] | [INFO] [stderr] 279 | x0.assign(&sim.slice(s![0, ..])); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/lib.rs:150:9 [INFO] [stderr] | [INFO] [stderr] 150 | / let sigma: f64; [INFO] [stderr] 151 | | [INFO] [stderr] 152 | | if adaptive { [INFO] [stderr] 153 | | let dim = n as f64; [INFO] [stderr] ... | [INFO] [stderr] 162 | | sigma = 0.5f64; [INFO] [stderr] 163 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let sigma = if adaptive { ..; 1. - 1. / dim } else { ..; 0.5f64 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:172:20 [INFO] [stderr] | [INFO] [stderr] 172 | y[k] = match y[k].approx_eq_ulps(&0., self.ulps) { [INFO] [stderr] | ____________________^ [INFO] [stderr] 173 | | true => zdelt, [INFO] [stderr] 174 | | _ => (1. + nonzdelt) * y[k], [INFO] [stderr] 175 | | }; [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if y[k].approx_eq_ulps(&0., self.ulps) { zdelt } else { (1. + nonzdelt) * y[k] }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:196:37 [INFO] [stderr] | [INFO] [stderr] 196 | .fold(0., |acc, &x| match acc.approx_gt_ulps(&x, self.ulps) { [INFO] [stderr] | _____________________________________^ [INFO] [stderr] 197 | | true => acc, [INFO] [stderr] 198 | | false => x, [INFO] [stderr] 199 | | }) [INFO] [stderr] | |_________________^ help: consider using an if/else expression: `if acc.approx_gt_ulps(&x, self.ulps) { acc } else { x }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:206:37 [INFO] [stderr] | [INFO] [stderr] 206 | .fold(0., |acc, &x| match acc.approx_gt_ulps(&x, self.ulps) { [INFO] [stderr] | _____________________________________^ [INFO] [stderr] 207 | | true => acc, [INFO] [stderr] 208 | | false => x, [INFO] [stderr] 209 | | }) [INFO] [stderr] | |_________________^ help: consider using an if/else expression: `if acc.approx_gt_ulps(&x, self.ulps) { acc } else { x }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `fsim` [INFO] [stderr] --> src/lib.rs:264:34 [INFO] [stderr] | [INFO] [stderr] 264 | for j in 1..n + 1 { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 264 | for (j, ) in fsim.iter_mut().enumerate().skip(1).take(n) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:264:34 [INFO] [stderr] | [INFO] [stderr] 264 | for j in 1..n + 1 { [INFO] [stderr] | ^^^^^^^^ help: use: `1..=n` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/lib.rs:150:9 [INFO] [stderr] | [INFO] [stderr] 150 | / let sigma: f64; [INFO] [stderr] 151 | | [INFO] [stderr] 152 | | if adaptive { [INFO] [stderr] 153 | | let dim = n as f64; [INFO] [stderr] ... | [INFO] [stderr] 162 | | sigma = 0.5f64; [INFO] [stderr] 163 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let sigma = if adaptive { ..; 1. - 1. / dim } else { ..; 0.5f64 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:172:20 [INFO] [stderr] | [INFO] [stderr] 172 | y[k] = match y[k].approx_eq_ulps(&0., self.ulps) { [INFO] [stderr] | ____________________^ [INFO] [stderr] 173 | | true => zdelt, [INFO] [stderr] 174 | | _ => (1. + nonzdelt) * y[k], [INFO] [stderr] 175 | | }; [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if y[k].approx_eq_ulps(&0., self.ulps) { zdelt } else { (1. + nonzdelt) * y[k] }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:196:37 [INFO] [stderr] | [INFO] [stderr] 196 | .fold(0., |acc, &x| match acc.approx_gt_ulps(&x, self.ulps) { [INFO] [stderr] | _____________________________________^ [INFO] [stderr] 197 | | true => acc, [INFO] [stderr] 198 | | false => x, [INFO] [stderr] 199 | | }) [INFO] [stderr] | |_________________^ help: consider using an if/else expression: `if acc.approx_gt_ulps(&x, self.ulps) { acc } else { x }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:206:37 [INFO] [stderr] | [INFO] [stderr] 206 | .fold(0., |acc, &x| match acc.approx_gt_ulps(&x, self.ulps) { [INFO] [stderr] | _____________________________________^ [INFO] [stderr] 207 | | true => acc, [INFO] [stderr] 208 | | false => x, [INFO] [stderr] 209 | | }) [INFO] [stderr] | |_________________^ help: consider using an if/else expression: `if acc.approx_gt_ulps(&x, self.ulps) { acc } else { x }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `fsim` [INFO] [stderr] --> src/lib.rs:264:34 [INFO] [stderr] | [INFO] [stderr] 264 | for j in 1..n + 1 { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 264 | for (j, ) in fsim.iter_mut().enumerate().skip(1).take(n) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:264:34 [INFO] [stderr] | [INFO] [stderr] 264 | for j in 1..n + 1 { [INFO] [stderr] | ^^^^^^^^ help: use: `1..=n` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.87s [INFO] running `"docker" "inspect" "2b7733f9e27e51ce4a18331cd7cf1edd4cecfa0a41853fd0641781d462bb8c2a"` [INFO] running `"docker" "rm" "-f" "2b7733f9e27e51ce4a18331cd7cf1edd4cecfa0a41853fd0641781d462bb8c2a"` [INFO] [stdout] 2b7733f9e27e51ce4a18331cd7cf1edd4cecfa0a41853fd0641781d462bb8c2a