[INFO] crate oprec 0.1.0 is already in cache [INFO] extracting crate oprec 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/oprec/0.1.0 [INFO] extracting crate oprec 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/oprec/0.1.0 [INFO] validating manifest of oprec-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of oprec-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing oprec-0.1.0 [INFO] finished frobbing oprec-0.1.0 [INFO] frobbed toml for oprec-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/oprec/0.1.0/Cargo.toml [INFO] started frobbing oprec-0.1.0 [INFO] finished frobbing oprec-0.1.0 [INFO] frobbed toml for oprec-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/oprec/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting oprec-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/oprec/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] dea722b796a5a7a0e009121637b5bcba2e3d1ef5be58d40109b8762f1780415e [INFO] running `"docker" "start" "-a" "dea722b796a5a7a0e009121637b5bcba2e3d1ef5be58d40109b8762f1780415e"` [INFO] [stderr] Checking oprec v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:235:33 [INFO] [stderr] | [INFO] [stderr] 235 | OpRec { vars: vec![id], id: id, graph: graph, roots: vec![RootIntersection { root: root, intersection: None }], last: root } [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:235:41 [INFO] [stderr] | [INFO] [stderr] 235 | OpRec { vars: vec![id], id: id, graph: graph, roots: vec![RootIntersection { root: root, intersection: None }], last: root } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `graph` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:235:33 [INFO] [stderr] | [INFO] [stderr] 235 | OpRec { vars: vec![id], id: id, graph: graph, roots: vec![RootIntersection { root: root, intersection: None }], last: root } [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:453:95 [INFO] [stderr] | [INFO] [stderr] 453 | OpRec { vars: rec.vars.clone(), id: rec.id, graph: new_graph, last: node_mapping[&start], roots: roots } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `roots` [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:235:41 [INFO] [stderr] | [INFO] [stderr] 235 | OpRec { vars: vec![id], id: id, graph: graph, roots: vec![RootIntersection { root: root, intersection: None }], last: root } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `graph` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:453:95 [INFO] [stderr] | [INFO] [stderr] 453 | OpRec { vars: rec.vars.clone(), id: rec.id, graph: new_graph, last: node_mapping[&start], roots: roots } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `roots` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:240:30 [INFO] [stderr] | [INFO] [stderr] 240 | pub fn functify(self) -> Box) -> Result> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:285:19 [INFO] [stderr] | [INFO] [stderr] 285 | self.powf((1/3) as f64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(1/3)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:290:19 [INFO] [stderr] | [INFO] [stderr] 290 | self.powf((1/2) as f64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(1/2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:70:17 [INFO] [stderr] | [INFO] [stderr] 70 | / match g { [INFO] [stderr] 71 | | $(&Ops::$upper => is_oprec_method_macro!($lower $(,$var, $upper)*)),* [INFO] [stderr] 72 | | ,_ => Err(g.clone()) [INFO] [stderr] 73 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 331 | / impl_oprec_method!( [INFO] [stderr] 332 | | (sin, Sin), (cos, Cos), (tan, Tan), [INFO] [stderr] 333 | | (asin, Asin), (acos, Acos), (atan, Atan), [INFO] [stderr] 334 | | (sinh, Sinh), (cosh, Cosh), (tanh, Tanh), [INFO] [stderr] ... | [INFO] [stderr] 337 | | (exp, Exp), (ln, Ln), (abs, Abs) [INFO] [stderr] 338 | | ); [INFO] [stderr] | |__- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:340:59 [INFO] [stderr] | [INFO] [stderr] 340 | fn oprec_to_function_check(x: &OpRec, last: NodeIndex) -> Box) -> Result> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:429:11 [INFO] [stderr] | [INFO] [stderr] 429 | while next_nodes.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!next_nodes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:480:31 [INFO] [stderr] | [INFO] [stderr] 480 | mergee.graph.add_edge(node_mappings[&edge.source()].clone(), node_mappings[&edge.target()].clone(), 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `node_mappings[&edge.source()]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:480:70 [INFO] [stderr] | [INFO] [stderr] 480 | mergee.graph.add_edge(node_mappings[&edge.source()].clone(), node_mappings[&edge.target()].clone(), 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `node_mappings[&edge.target()]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:482:27 [INFO] [stderr] | [INFO] [stderr] 482 | mergee.graph.add_edge(node_mappings[&merger.last].clone(), at, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `node_mappings[&merger.last]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:240:30 [INFO] [stderr] | [INFO] [stderr] 240 | pub fn functify(self) -> Box) -> Result> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:285:19 [INFO] [stderr] | [INFO] [stderr] 285 | self.powf((1/3) as f64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(1/3)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:290:19 [INFO] [stderr] | [INFO] [stderr] 290 | self.powf((1/2) as f64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(1/2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:70:17 [INFO] [stderr] | [INFO] [stderr] 70 | / match g { [INFO] [stderr] 71 | | $(&Ops::$upper => is_oprec_method_macro!($lower $(,$var, $upper)*)),* [INFO] [stderr] 72 | | ,_ => Err(g.clone()) [INFO] [stderr] 73 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 331 | / impl_oprec_method!( [INFO] [stderr] 332 | | (sin, Sin), (cos, Cos), (tan, Tan), [INFO] [stderr] 333 | | (asin, Asin), (acos, Acos), (atan, Atan), [INFO] [stderr] 334 | | (sinh, Sinh), (cosh, Cosh), (tanh, Tanh), [INFO] [stderr] ... | [INFO] [stderr] 337 | | (exp, Exp), (ln, Ln), (abs, Abs) [INFO] [stderr] 338 | | ); [INFO] [stderr] | |__- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:340:59 [INFO] [stderr] | [INFO] [stderr] 340 | fn oprec_to_function_check(x: &OpRec, last: NodeIndex) -> Box) -> Result> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:429:11 [INFO] [stderr] | [INFO] [stderr] 429 | while next_nodes.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!next_nodes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:480:31 [INFO] [stderr] | [INFO] [stderr] 480 | mergee.graph.add_edge(node_mappings[&edge.source()].clone(), node_mappings[&edge.target()].clone(), 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `node_mappings[&edge.source()]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:480:70 [INFO] [stderr] | [INFO] [stderr] 480 | mergee.graph.add_edge(node_mappings[&edge.source()].clone(), node_mappings[&edge.target()].clone(), 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `node_mappings[&edge.target()]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:482:27 [INFO] [stderr] | [INFO] [stderr] 482 | mergee.graph.add_edge(node_mappings[&merger.last].clone(), at, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `node_mappings[&merger.last]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.65s [INFO] running `"docker" "inspect" "dea722b796a5a7a0e009121637b5bcba2e3d1ef5be58d40109b8762f1780415e"` [INFO] running `"docker" "rm" "-f" "dea722b796a5a7a0e009121637b5bcba2e3d1ef5be58d40109b8762f1780415e"` [INFO] [stdout] dea722b796a5a7a0e009121637b5bcba2e3d1ef5be58d40109b8762f1780415e