[INFO] crate openvpn-parser 0.2.0 is already in cache [INFO] extracting crate openvpn-parser 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/openvpn-parser/0.2.0 [INFO] extracting crate openvpn-parser 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/openvpn-parser/0.2.0 [INFO] validating manifest of openvpn-parser-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of openvpn-parser-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing openvpn-parser-0.2.0 [INFO] finished frobbing openvpn-parser-0.2.0 [INFO] frobbed toml for openvpn-parser-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/openvpn-parser/0.2.0/Cargo.toml [INFO] started frobbing openvpn-parser-0.2.0 [INFO] finished frobbing openvpn-parser-0.2.0 [INFO] frobbed toml for openvpn-parser-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/openvpn-parser/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting openvpn-parser-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/openvpn-parser/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 688335e571314a5113265e6c42c9aa112048b4ead4515bbe019ec554027f40aa [INFO] running `"docker" "start" "-a" "688335e571314a5113265e6c42c9aa112048b4ead4515bbe019ec554027f40aa"` [INFO] [stderr] Checking rusticata-macros v0.4.1 [INFO] [stderr] Checking openvpn-parser v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | #[macro_use] extern crate nom; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | #[macro_use] extern crate nom; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/openvpn.rs:169:49 [INFO] [stderr] | [INFO] [stderr] 169 | map!(i, parse_openvpn_msg_pcontrol, |x| Payload::Control(x)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Payload::Control` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/openvpn.rs:172:45 [INFO] [stderr] | [INFO] [stderr] 172 | map!(i, parse_openvpn_msg_pack, |x| Payload::Ack(x)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Payload::Ack` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 27 [INFO] [stderr] --> src/openvpn.rs:178:1 [INFO] [stderr] | [INFO] [stderr] 178 | / pub fn parse_openvpn_msg_pcontrol(i:&[u8]) -> IResult<&[u8],PControl> { [INFO] [stderr] 179 | | do_parse!(i, [INFO] [stderr] 180 | | sid: be_u64 >> [INFO] [stderr] 181 | | hmac: take!(20) >> [INFO] [stderr] ... | [INFO] [stderr] 202 | | ) [INFO] [stderr] 203 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/openvpn.rs:169:49 [INFO] [stderr] | [INFO] [stderr] 169 | map!(i, parse_openvpn_msg_pcontrol, |x| Payload::Control(x)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Payload::Control` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/openvpn.rs:172:45 [INFO] [stderr] | [INFO] [stderr] 172 | map!(i, parse_openvpn_msg_pack, |x| Payload::Ack(x)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Payload::Ack` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 27 [INFO] [stderr] --> src/openvpn.rs:178:1 [INFO] [stderr] | [INFO] [stderr] 178 | / pub fn parse_openvpn_msg_pcontrol(i:&[u8]) -> IResult<&[u8],PControl> { [INFO] [stderr] 179 | | do_parse!(i, [INFO] [stderr] 180 | | sid: be_u64 >> [INFO] [stderr] 181 | | hmac: take!(20) >> [INFO] [stderr] ... | [INFO] [stderr] 202 | | ) [INFO] [stderr] 203 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.10s [INFO] running `"docker" "inspect" "688335e571314a5113265e6c42c9aa112048b4ead4515bbe019ec554027f40aa"` [INFO] running `"docker" "rm" "-f" "688335e571314a5113265e6c42c9aa112048b4ead4515bbe019ec554027f40aa"` [INFO] [stdout] 688335e571314a5113265e6c42c9aa112048b4ead4515bbe019ec554027f40aa