[INFO] crate opentracingrust_zipkin 0.1.2 is already in cache [INFO] extracting crate opentracingrust_zipkin 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/opentracingrust_zipkin/0.1.2 [INFO] extracting crate opentracingrust_zipkin 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/opentracingrust_zipkin/0.1.2 [INFO] validating manifest of opentracingrust_zipkin-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of opentracingrust_zipkin-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing opentracingrust_zipkin-0.1.2 [INFO] finished frobbing opentracingrust_zipkin-0.1.2 [INFO] frobbed toml for opentracingrust_zipkin-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/opentracingrust_zipkin/0.1.2/Cargo.toml [INFO] started frobbing opentracingrust_zipkin-0.1.2 [INFO] finished frobbing opentracingrust_zipkin-0.1.2 [INFO] frobbed toml for opentracingrust_zipkin-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/opentracingrust_zipkin/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting opentracingrust_zipkin-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/opentracingrust_zipkin/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e3389cd95f9f5645ba9b5182dc2c4f5d1cd8be4210aa735f1a7190c7dbd5e28b [INFO] running `"docker" "start" "-a" "e3389cd95f9f5645ba9b5182dc2c4f5d1cd8be4210aa735f1a7190c7dbd5e28b"` [INFO] [stderr] Checking ref_slice v1.1.1 [INFO] [stderr] Checking crossbeam-utils v0.3.2 [INFO] [stderr] Checking parking_lot v0.5.5 [INFO] [stderr] Checking thrift v0.0.4 [INFO] [stderr] Checking kafka v0.7.0 [INFO] [stderr] Checking crossbeam-epoch v0.4.3 [INFO] [stderr] Checking crossbeam-channel v0.1.3 [INFO] [stderr] Checking opentracingrust v0.3.1 [INFO] [stderr] Checking opentracingrust_zipkin v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/thrift_gen/binary_format.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | #![cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#![rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | #![cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#![rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/thrift_gen/binary_format.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | #![cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#![rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | #![cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#![rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/collectors/mod.rs:16:26 [INFO] [stderr] | [INFO] [stderr] 16 | const MICROSECOND: i64 = 1000000; [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: lint name `too_many_arguments` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/thrift_gen/binary_format.rs:6:45 [INFO] [stderr] | [INFO] [stderr] 6 | #![cfg_attr(feature = "cargo-clippy", allow(too_many_arguments, type_complexity))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::too_many_arguments` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `type_complexity` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/thrift_gen/binary_format.rs:6:65 [INFO] [stderr] | [INFO] [stderr] 6 | #![cfg_attr(feature = "cargo-clippy", allow(too_many_arguments, type_complexity))] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::type_complexity` [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/binary_format.rs:141:7 [INFO] [stderr] | [INFO] [stderr] 141 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/binary_format.rs:143:7 [INFO] [stderr] | [INFO] [stderr] 143 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/binary_format.rs:149:7 [INFO] [stderr] | [INFO] [stderr] 149 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/binary_format.rs:151:7 [INFO] [stderr] | [INFO] [stderr] 151 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/binary_format.rs:157:7 [INFO] [stderr] | [INFO] [stderr] 157 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/binary_format.rs:159:7 [INFO] [stderr] | [INFO] [stderr] 159 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/binary_format.rs:165:7 [INFO] [stderr] | [INFO] [stderr] 165 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/binary_format.rs:167:7 [INFO] [stderr] | [INFO] [stderr] 167 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/binary_format.rs:173:7 [INFO] [stderr] | [INFO] [stderr] 173 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/binary_format.rs:175:7 [INFO] [stderr] | [INFO] [stderr] 175 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/binary_format.rs:181:7 [INFO] [stderr] | [INFO] [stderr] 181 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/binary_format.rs:183:7 [INFO] [stderr] | [INFO] [stderr] 183 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/binary_format.rs:194:7 [INFO] [stderr] | [INFO] [stderr] 194 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/binary_format.rs:196:7 [INFO] [stderr] | [INFO] [stderr] 196 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: lint name `too_many_arguments` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:7:45 [INFO] [stderr] | [INFO] [stderr] 7 | #![cfg_attr(feature = "cargo-clippy", allow(too_many_arguments, type_complexity))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::too_many_arguments` [INFO] [stderr] [INFO] [stderr] warning: lint name `type_complexity` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:7:65 [INFO] [stderr] | [INFO] [stderr] 7 | #![cfg_attr(feature = "cargo-clippy", allow(too_many_arguments, type_complexity))] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::type_complexity` [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:182:7 [INFO] [stderr] | [INFO] [stderr] 182 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:184:7 [INFO] [stderr] | [INFO] [stderr] 184 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:190:7 [INFO] [stderr] | [INFO] [stderr] 190 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:192:7 [INFO] [stderr] | [INFO] [stderr] 192 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:198:7 [INFO] [stderr] | [INFO] [stderr] 198 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:200:7 [INFO] [stderr] | [INFO] [stderr] 200 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:206:7 [INFO] [stderr] | [INFO] [stderr] 206 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:208:7 [INFO] [stderr] | [INFO] [stderr] 208 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:299:7 [INFO] [stderr] | [INFO] [stderr] 299 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:301:7 [INFO] [stderr] | [INFO] [stderr] 301 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:307:7 [INFO] [stderr] | [INFO] [stderr] 307 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:309:7 [INFO] [stderr] | [INFO] [stderr] 309 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:315:7 [INFO] [stderr] | [INFO] [stderr] 315 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:317:7 [INFO] [stderr] | [INFO] [stderr] 317 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:431:7 [INFO] [stderr] | [INFO] [stderr] 431 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:433:7 [INFO] [stderr] | [INFO] [stderr] 433 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:439:7 [INFO] [stderr] | [INFO] [stderr] 439 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:441:7 [INFO] [stderr] | [INFO] [stderr] 441 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:447:7 [INFO] [stderr] | [INFO] [stderr] 447 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:449:7 [INFO] [stderr] | [INFO] [stderr] 449 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:455:7 [INFO] [stderr] | [INFO] [stderr] 455 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:457:7 [INFO] [stderr] | [INFO] [stderr] 457 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:669:7 [INFO] [stderr] | [INFO] [stderr] 669 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:671:7 [INFO] [stderr] | [INFO] [stderr] 671 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:677:7 [INFO] [stderr] | [INFO] [stderr] 677 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:679:7 [INFO] [stderr] | [INFO] [stderr] 679 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:685:7 [INFO] [stderr] | [INFO] [stderr] 685 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:687:7 [INFO] [stderr] | [INFO] [stderr] 687 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:693:7 [INFO] [stderr] | [INFO] [stderr] 693 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:695:7 [INFO] [stderr] | [INFO] [stderr] 695 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:705:7 [INFO] [stderr] | [INFO] [stderr] 705 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:707:7 [INFO] [stderr] | [INFO] [stderr] 707 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:717:7 [INFO] [stderr] | [INFO] [stderr] 717 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:719:7 [INFO] [stderr] | [INFO] [stderr] 719 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:725:7 [INFO] [stderr] | [INFO] [stderr] 725 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:727:7 [INFO] [stderr] | [INFO] [stderr] 727 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:733:7 [INFO] [stderr] | [INFO] [stderr] 733 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:735:7 [INFO] [stderr] | [INFO] [stderr] 735 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:741:7 [INFO] [stderr] | [INFO] [stderr] 741 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:743:7 [INFO] [stderr] | [INFO] [stderr] 743 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:749:7 [INFO] [stderr] | [INFO] [stderr] 749 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:751:7 [INFO] [stderr] | [INFO] [stderr] 751 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: lint name `too_many_arguments` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/thrift_gen/binary_format.rs:6:45 [INFO] [stderr] | [INFO] [stderr] 6 | #![cfg_attr(feature = "cargo-clippy", allow(too_many_arguments, type_complexity))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::too_many_arguments` [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/collectors/mod.rs:16:26 [INFO] [stderr] | [INFO] [stderr] 16 | const MICROSECOND: i64 = 1000000; [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/collectors/mod.rs:170:47 [INFO] [stderr] | [INFO] [stderr] 170 | let timestamp = timestamp.as_secs() * 1000000; [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: lint name `too_many_arguments` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/thrift_gen/binary_format.rs:6:45 [INFO] [stderr] | [INFO] [stderr] 6 | #![cfg_attr(feature = "cargo-clippy", allow(too_many_arguments, type_complexity))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::too_many_arguments` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `type_complexity` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/thrift_gen/binary_format.rs:6:65 [INFO] [stderr] | [INFO] [stderr] 6 | #![cfg_attr(feature = "cargo-clippy", allow(too_many_arguments, type_complexity))] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::type_complexity` [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/binary_format.rs:141:7 [INFO] [stderr] | [INFO] [stderr] 141 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/binary_format.rs:143:7 [INFO] [stderr] | [INFO] [stderr] 143 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/binary_format.rs:149:7 [INFO] [stderr] | [INFO] [stderr] 149 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/binary_format.rs:151:7 [INFO] [stderr] | [INFO] [stderr] 151 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/binary_format.rs:157:7 [INFO] [stderr] | [INFO] [stderr] 157 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/binary_format.rs:159:7 [INFO] [stderr] | [INFO] [stderr] 159 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/binary_format.rs:165:7 [INFO] [stderr] | [INFO] [stderr] 165 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/binary_format.rs:167:7 [INFO] [stderr] | [INFO] [stderr] 167 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/binary_format.rs:173:7 [INFO] [stderr] | [INFO] [stderr] 173 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/binary_format.rs:175:7 [INFO] [stderr] | [INFO] [stderr] 175 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/binary_format.rs:181:7 [INFO] [stderr] | [INFO] [stderr] 181 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/binary_format.rs:183:7 [INFO] [stderr] | [INFO] [stderr] 183 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/binary_format.rs:194:7 [INFO] [stderr] | [INFO] [stderr] 194 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/binary_format.rs:196:7 [INFO] [stderr] | [INFO] [stderr] 196 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: lint name `too_many_arguments` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:7:45 [INFO] [stderr] | [INFO] [stderr] 7 | #![cfg_attr(feature = "cargo-clippy", allow(too_many_arguments, type_complexity))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::too_many_arguments` [INFO] [stderr] [INFO] [stderr] warning: lint name `type_complexity` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:7:65 [INFO] [stderr] | [INFO] [stderr] 7 | #![cfg_attr(feature = "cargo-clippy", allow(too_many_arguments, type_complexity))] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::type_complexity` [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:182:7 [INFO] [stderr] | [INFO] [stderr] 182 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:184:7 [INFO] [stderr] | [INFO] [stderr] 184 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:190:7 [INFO] [stderr] | [INFO] [stderr] 190 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:192:7 [INFO] [stderr] | [INFO] [stderr] 192 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:198:7 [INFO] [stderr] | [INFO] [stderr] 198 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:200:7 [INFO] [stderr] | [INFO] [stderr] 200 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:206:7 [INFO] [stderr] | [INFO] [stderr] 206 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:208:7 [INFO] [stderr] | [INFO] [stderr] 208 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:299:7 [INFO] [stderr] | [INFO] [stderr] 299 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:301:7 [INFO] [stderr] | [INFO] [stderr] 301 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:307:7 [INFO] [stderr] | [INFO] [stderr] 307 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:309:7 [INFO] [stderr] | [INFO] [stderr] 309 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:315:7 [INFO] [stderr] | [INFO] [stderr] 315 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:317:7 [INFO] [stderr] | [INFO] [stderr] 317 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:431:7 [INFO] [stderr] | [INFO] [stderr] 431 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:433:7 [INFO] [stderr] | [INFO] [stderr] 433 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:439:7 [INFO] [stderr] | [INFO] [stderr] 439 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:441:7 [INFO] [stderr] | [INFO] [stderr] 441 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:447:7 [INFO] [stderr] | [INFO] [stderr] 447 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:449:7 [INFO] [stderr] | [INFO] [stderr] 449 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:455:7 [INFO] [stderr] | [INFO] [stderr] 455 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:457:7 [INFO] [stderr] | [INFO] [stderr] 457 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:669:7 [INFO] [stderr] | [INFO] [stderr] 669 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:671:7 [INFO] [stderr] | [INFO] [stderr] 671 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:677:7 [INFO] [stderr] | [INFO] [stderr] 677 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:679:7 [INFO] [stderr] | [INFO] [stderr] 679 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:685:7 [INFO] [stderr] | [INFO] [stderr] 685 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:687:7 [INFO] [stderr] | [INFO] [stderr] 687 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:693:7 [INFO] [stderr] | [INFO] [stderr] 693 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:695:7 [INFO] [stderr] | [INFO] [stderr] 695 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:705:7 [INFO] [stderr] | [INFO] [stderr] 705 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:707:7 [INFO] [stderr] | [INFO] [stderr] 707 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:717:7 [INFO] [stderr] | [INFO] [stderr] 717 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:719:7 [INFO] [stderr] | [INFO] [stderr] 719 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:725:7 [INFO] [stderr] | [INFO] [stderr] 725 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:727:7 [INFO] [stderr] | [INFO] [stderr] 727 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:733:7 [INFO] [stderr] | [INFO] [stderr] 733 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:735:7 [INFO] [stderr] | [INFO] [stderr] 735 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:741:7 [INFO] [stderr] | [INFO] [stderr] 741 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:743:7 [INFO] [stderr] | [INFO] [stderr] 743 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:749:7 [INFO] [stderr] | [INFO] [stderr] 749 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:751:7 [INFO] [stderr] | [INFO] [stderr] 751 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tracer/extract.rs:152:18 [INFO] [stderr] | [INFO] [stderr] 152 | Some(651345242494996240), // Trace ID [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `651_345_242_494_996_240` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tracer/extract.rs:153:18 [INFO] [stderr] | [INFO] [stderr] 153 | Some(72623859790382856), // Trace ID (High) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `72_623_859_790_382_856` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tracer/inject.rs:136:47 [INFO] [stderr] | [INFO] [stderr] 136 | assert_eq!(context.trace_id.unwrap(), 72623859790382856); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `72_623_859_790_382_856` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tracer/inject.rs:137:52 [INFO] [stderr] | [INFO] [stderr] 137 | assert_eq!(context.trace_id_high.unwrap(), 651345242494996240); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `651_345_242_494_996_240` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: lint name `too_many_arguments` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/thrift_gen/binary_format.rs:6:45 [INFO] [stderr] | [INFO] [stderr] 6 | #![cfg_attr(feature = "cargo-clippy", allow(too_many_arguments, type_complexity))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::too_many_arguments` [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/collectors/mod.rs:61:50 [INFO] [stderr] | [INFO] [stderr] 61 | let timestamp = compute_duration(UNIX_EPOCH, span.start_time().clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*span.start_time()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/collectors/mod.rs:62:37 [INFO] [stderr] | [INFO] [stderr] 62 | let duration = compute_duration(span.start_time().clone(), span.finish_time().clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*span.start_time()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/collectors/mod.rs:62:64 [INFO] [stderr] | [INFO] [stderr] 62 | let duration = compute_duration(span.start_time().clone(), span.finish_time().clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*span.finish_time()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/collectors/mod.rs:85:54 [INFO] [stderr] | [INFO] [stderr] 85 | let timestamp = compute_duration(UNIX_EPOCH, log.timestamp().unwrap().clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*log.timestamp().unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:50:32 [INFO] [stderr] | [INFO] [stderr] 50 | pub fn write_to_out_protocol(&self, o_prot: &mut TOutputProtocol) -> thrift::Result<()> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/tracer/extract.rs:30:41 [INFO] [stderr] | [INFO] [stderr] 30 | let trace_id_low = message.trace_id.ok_or( [INFO] [stderr] | _________________________________________^ [INFO] [stderr] 31 | | Error::Msg(String::from("Decoded context does not have a TraceID (low)")) [INFO] [stderr] 32 | | )?; [INFO] [stderr] | |_____^ help: try this: `ok_or_else(|| Error::Msg(String::from("Decoded context does not have a TraceID (low)")))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/tracer/extract.rs:33:47 [INFO] [stderr] | [INFO] [stderr] 33 | let trace_id_high = message.trace_id_high.ok_or( [INFO] [stderr] | _______________________________________________^ [INFO] [stderr] 34 | | Error::Msg(String::from("Decoded context does not have a TraceID (high)")) [INFO] [stderr] 35 | | )?; [INFO] [stderr] | |_____^ help: try this: `ok_or_else(|| Error::Msg(String::from("Decoded context does not have a TraceID (high)")))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/tracer/extract.rs:37:35 [INFO] [stderr] | [INFO] [stderr] 37 | let span_id = message.span_id.ok_or( [INFO] [stderr] | ___________________________________^ [INFO] [stderr] 38 | | Error::Msg(String::from("Decoded context does not have a SpanID")) [INFO] [stderr] 39 | | )?; [INFO] [stderr] | |_____^ help: try this: `ok_or_else(|| Error::Msg(String::from("Decoded context does not have a SpanID")))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: local variable doesn't need to be boxed here [INFO] [stderr] --> src/tracer/extract.rs:78:21 [INFO] [stderr] | [INFO] [stderr] 78 | pub fn http_headers(carrier: Box<&MapCarrier>) -> Result> { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::boxed_local)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#boxed_local [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/tracer/extract.rs:87:46 [INFO] [stderr] | [INFO] [stderr] 87 | let span_id = carrier.get("X-B3-SpanId").ok_or( [INFO] [stderr] | ______________________________________________^ [INFO] [stderr] 88 | | Error::Msg(String::from("Decoded context does not have a SpanID")) [INFO] [stderr] 89 | | )?; [INFO] [stderr] | |_____^ help: try this: `ok_or_else(|| Error::Msg(String::from("Decoded context does not have a SpanID")))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/tracer/extract.rs:94:42 [INFO] [stderr] | [INFO] [stderr] 94 | .debug(carrier.get("X-B3-Flags").unwrap_or(String::from("0")) == "1") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from("0"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/tracer/inject.rs:26:17 [INFO] [stderr] | [INFO] [stderr] 26 | let flags = match inner_context.debug() { [INFO] [stderr] | _________________^ [INFO] [stderr] 27 | | false => 0, [INFO] [stderr] 28 | | true => 1, [INFO] [stderr] 29 | | }; [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if inner_context.debug() { 1 } else { 0 }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: local variable doesn't need to be boxed here [INFO] [stderr] --> src/tracer/inject.rs:54:44 [INFO] [stderr] | [INFO] [stderr] 54 | pub fn http_headers(context: &SpanContext, carrier: Box<&mut MapCarrier>) -> Result<()> { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#boxed_local [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/tracer/inject.rs:66:31 [INFO] [stderr] | [INFO] [stderr] 66 | carrier.set("X-B3-Flags", match inner_context.debug() { [INFO] [stderr] | _______________________________^ [INFO] [stderr] 67 | | false => "0", [INFO] [stderr] 68 | | true => "1", [INFO] [stderr] 69 | | }); [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if inner_context.debug() { "1" } else { "0" }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/tracer/inject.rs:70:33 [INFO] [stderr] | [INFO] [stderr] 70 | carrier.set("X-B3-Sampled", match inner_context.sampled() { [INFO] [stderr] | _________________________________^ [INFO] [stderr] 71 | | false => "0", [INFO] [stderr] 72 | | true => "1", [INFO] [stderr] 73 | | }); [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if inner_context.sampled() { "1" } else { "0" }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/tracer/mod.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | / pub fn new() -> (Tracer, SpanReceiver) { [INFO] [stderr] 44 | | let (sender, receiver) = unbounded(); [INFO] [stderr] 45 | | let tracer = Tracer::new(ZipkinTracer { [INFO] [stderr] 46 | | sender, [INFO] [stderr] 47 | | }); [INFO] [stderr] 48 | | (tracer, receiver) [INFO] [stderr] 49 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/collectors/mod.rs:61:50 [INFO] [stderr] | [INFO] [stderr] 61 | let timestamp = compute_duration(UNIX_EPOCH, span.start_time().clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*span.start_time()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/collectors/mod.rs:62:37 [INFO] [stderr] | [INFO] [stderr] 62 | let duration = compute_duration(span.start_time().clone(), span.finish_time().clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*span.start_time()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/collectors/mod.rs:62:64 [INFO] [stderr] | [INFO] [stderr] 62 | let duration = compute_duration(span.start_time().clone(), span.finish_time().clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*span.finish_time()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/collectors/mod.rs:85:54 [INFO] [stderr] | [INFO] [stderr] 85 | let timestamp = compute_duration(UNIX_EPOCH, log.timestamp().unwrap().clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*log.timestamp().unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `MICROSECOND` [INFO] [stderr] --> src/collectors/mod.rs:171:45 [INFO] [stderr] | [INFO] [stderr] 171 | assert!(encoded.duration.unwrap() < 1 * MICROSECOND, "Unlikely long duration"); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/thrift_gen/zipkin_core.rs:50:32 [INFO] [stderr] | [INFO] [stderr] 50 | pub fn write_to_out_protocol(&self, o_prot: &mut TOutputProtocol) -> thrift::Result<()> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/tracer/extract.rs:30:41 [INFO] [stderr] | [INFO] [stderr] 30 | let trace_id_low = message.trace_id.ok_or( [INFO] [stderr] | _________________________________________^ [INFO] [stderr] 31 | | Error::Msg(String::from("Decoded context does not have a TraceID (low)")) [INFO] [stderr] 32 | | )?; [INFO] [stderr] | |_____^ help: try this: `ok_or_else(|| Error::Msg(String::from("Decoded context does not have a TraceID (low)")))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/tracer/extract.rs:33:47 [INFO] [stderr] | [INFO] [stderr] 33 | let trace_id_high = message.trace_id_high.ok_or( [INFO] [stderr] | _______________________________________________^ [INFO] [stderr] 34 | | Error::Msg(String::from("Decoded context does not have a TraceID (high)")) [INFO] [stderr] 35 | | )?; [INFO] [stderr] | |_____^ help: try this: `ok_or_else(|| Error::Msg(String::from("Decoded context does not have a TraceID (high)")))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/tracer/extract.rs:37:35 [INFO] [stderr] | [INFO] [stderr] 37 | let span_id = message.span_id.ok_or( [INFO] [stderr] | ___________________________________^ [INFO] [stderr] 38 | | Error::Msg(String::from("Decoded context does not have a SpanID")) [INFO] [stderr] 39 | | )?; [INFO] [stderr] | |_____^ help: try this: `ok_or_else(|| Error::Msg(String::from("Decoded context does not have a SpanID")))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: local variable doesn't need to be boxed here [INFO] [stderr] --> src/tracer/extract.rs:78:21 [INFO] [stderr] | [INFO] [stderr] 78 | pub fn http_headers(carrier: Box<&MapCarrier>) -> Result> { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::boxed_local)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#boxed_local [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/tracer/extract.rs:87:46 [INFO] [stderr] | [INFO] [stderr] 87 | let span_id = carrier.get("X-B3-SpanId").ok_or( [INFO] [stderr] | ______________________________________________^ [INFO] [stderr] 88 | | Error::Msg(String::from("Decoded context does not have a SpanID")) [INFO] [stderr] 89 | | )?; [INFO] [stderr] | |_____^ help: try this: `ok_or_else(|| Error::Msg(String::from("Decoded context does not have a SpanID")))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/tracer/extract.rs:94:42 [INFO] [stderr] | [INFO] [stderr] 94 | .debug(carrier.get("X-B3-Flags").unwrap_or(String::from("0")) == "1") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from("0"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: The function/method `::new` doesn't need a mutable reference [INFO] [stderr] --> src/tracer/extract.rs:212:45 [INFO] [stderr] | [INFO] [stderr] 212 | let context = http_headers(Box::new(&mut headers)).unwrap().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/tracer/inject.rs:26:17 [INFO] [stderr] | [INFO] [stderr] 26 | let flags = match inner_context.debug() { [INFO] [stderr] | _________________^ [INFO] [stderr] 27 | | false => 0, [INFO] [stderr] 28 | | true => 1, [INFO] [stderr] 29 | | }; [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if inner_context.debug() { 1 } else { 0 }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: local variable doesn't need to be boxed here [INFO] [stderr] --> src/tracer/inject.rs:54:44 [INFO] [stderr] | [INFO] [stderr] 54 | pub fn http_headers(context: &SpanContext, carrier: Box<&mut MapCarrier>) -> Result<()> { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#boxed_local [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/tracer/inject.rs:66:31 [INFO] [stderr] | [INFO] [stderr] 66 | carrier.set("X-B3-Flags", match inner_context.debug() { [INFO] [stderr] | _______________________________^ [INFO] [stderr] 67 | | false => "0", [INFO] [stderr] 68 | | true => "1", [INFO] [stderr] 69 | | }); [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if inner_context.debug() { "1" } else { "0" }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/tracer/inject.rs:70:33 [INFO] [stderr] | [INFO] [stderr] 70 | carrier.set("X-B3-Sampled", match inner_context.sampled() { [INFO] [stderr] | _________________________________^ [INFO] [stderr] 71 | | false => "0", [INFO] [stderr] 72 | | true => "1", [INFO] [stderr] 73 | | }); [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if inner_context.sampled() { "1" } else { "0" }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/tracer/inject.rs:162:20 [INFO] [stderr] | [INFO] [stderr] 162 | assert_eq!(headers.get("X-B3-TraceId").unwrap(), "0102030405060708090a0b0c0d0e0f10"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&headers["X-B3-TraceId"]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/tracer/inject.rs:163:20 [INFO] [stderr] | [INFO] [stderr] 163 | assert_eq!(headers.get("X-B3-ParentSpanId").unwrap(), "2a"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&headers["X-B3-ParentSpanId"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/tracer/inject.rs:164:20 [INFO] [stderr] | [INFO] [stderr] 164 | assert_eq!(headers.get("X-B3-SpanId").unwrap(), "2a"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&headers["X-B3-SpanId"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/tracer/inject.rs:165:20 [INFO] [stderr] | [INFO] [stderr] 165 | assert_eq!(headers.get("X-B3-Flags").unwrap(), "1"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&headers["X-B3-Flags"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/tracer/inject.rs:166:20 [INFO] [stderr] | [INFO] [stderr] 166 | assert_eq!(headers.get("X-B3-Sampled").unwrap(), "1"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&headers["X-B3-Sampled"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/tracer/inject.rs:167:20 [INFO] [stderr] | [INFO] [stderr] 167 | assert_eq!(headers.get("OT-Baggage-a").unwrap(), "1"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&headers["OT-Baggage-a"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/tracer/inject.rs:168:20 [INFO] [stderr] | [INFO] [stderr] 168 | assert_eq!(headers.get("OT-Baggage-b").unwrap(), "2"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&headers["OT-Baggage-b"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/tracer/inject.rs:169:20 [INFO] [stderr] | [INFO] [stderr] 169 | assert_eq!(headers.get("OT-Baggage-c").unwrap(), "3"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&headers["OT-Baggage-c"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/tracer/trace_id.rs:159:9 [INFO] [stderr] | [INFO] [stderr] 159 | / match id.0 { [INFO] [stderr] 160 | | InnerID::Short(_) => panic!("Generated IDs should be long"), [INFO] [stderr] 161 | | _ => () [INFO] [stderr] 162 | | } [INFO] [stderr] | |_________^ help: try this: `if let InnerID::Short(_) = id.0 { panic!("Generated IDs should be long") }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tracer/trace_id.rs:178:37 [INFO] [stderr] | [INFO] [stderr] 178 | let id1 = TraceID::from(inner.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tracer/trace_id.rs:186:37 [INFO] [stderr] | [INFO] [stderr] 186 | let id1 = TraceID::from(inner.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/tracer/mod.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | / pub fn new() -> (Tracer, SpanReceiver) { [INFO] [stderr] 44 | | let (sender, receiver) = unbounded(); [INFO] [stderr] 45 | | let tracer = Tracer::new(ZipkinTracer { [INFO] [stderr] 46 | | sender, [INFO] [stderr] 47 | | }); [INFO] [stderr] 48 | | (tracer, receiver) [INFO] [stderr] 49 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> examples/basics.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | / match collector.collect(span) { [INFO] [stderr] 28 | | Err(err) => println!("Failed to report span: {:?}", err), [INFO] [stderr] 29 | | _ => (), [INFO] [stderr] 30 | | } [INFO] [stderr] | |_________^ help: try this: `if let Err(err) = collector.collect(span) { println!("Failed to report span: {:?}", err) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 17.61s [INFO] running `"docker" "inspect" "e3389cd95f9f5645ba9b5182dc2c4f5d1cd8be4210aa735f1a7190c7dbd5e28b"` [INFO] running `"docker" "rm" "-f" "e3389cd95f9f5645ba9b5182dc2c4f5d1cd8be4210aa735f1a7190c7dbd5e28b"` [INFO] [stdout] e3389cd95f9f5645ba9b5182dc2c4f5d1cd8be4210aa735f1a7190c7dbd5e28b