[INFO] crate opentracingrust 0.3.1 is already in cache [INFO] extracting crate opentracingrust 0.3.1 into work/ex/clippy-test-run/sources/stable/reg/opentracingrust/0.3.1 [INFO] extracting crate opentracingrust 0.3.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/opentracingrust/0.3.1 [INFO] validating manifest of opentracingrust-0.3.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of opentracingrust-0.3.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing opentracingrust-0.3.1 [INFO] finished frobbing opentracingrust-0.3.1 [INFO] frobbed toml for opentracingrust-0.3.1 written to work/ex/clippy-test-run/sources/stable/reg/opentracingrust/0.3.1/Cargo.toml [INFO] started frobbing opentracingrust-0.3.1 [INFO] finished frobbing opentracingrust-0.3.1 [INFO] frobbed toml for opentracingrust-0.3.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/opentracingrust/0.3.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting opentracingrust-0.3.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/opentracingrust/0.3.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4dc6b5d8935da6bc812b22178b5825d1540c20e1cd4cb43ede0e786dd2bb45ac [INFO] running `"docker" "start" "-a" "4dc6b5d8935da6bc812b22178b5825d1540c20e1cd4cb43ede0e786dd2bb45ac"` [INFO] [stderr] Checking crossbeam-utils v0.3.2 [INFO] [stderr] Checking crossbeam-epoch v0.4.3 [INFO] [stderr] Checking crossbeam-channel v0.1.3 [INFO] [stderr] Checking opentracingrust v0.3.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/utils/reporter.rs:69:13 [INFO] [stderr] | [INFO] [stderr] 69 | stopping: stopping, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `stopping` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/utils/reporter.rs:69:13 [INFO] [stderr] | [INFO] [stderr] 69 | stopping: stopping, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `stopping` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tracers/file.rs:491:40 [INFO] [stderr] | [INFO] [stderr] 491 | span.child_of(make_context(123456, 123)); [INFO] [stderr] | ^^^^^^ help: consider: `123_456` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tracers/file.rs:492:39 [INFO] [stderr] | [INFO] [stderr] 492 | span.follows(make_context(123456, 456)); [INFO] [stderr] | ^^^^^^ help: consider: `123_456` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tracers/file.rs:502:54 [INFO] [stderr] | [INFO] [stderr] 502 | .at(UNIX_EPOCH + Duration::from_secs(123456)) [INFO] [stderr] | ^^^^^^ help: consider: `123_456` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tracers/file.rs:507:54 [INFO] [stderr] | [INFO] [stderr] 507 | .at(UNIX_EPOCH + Duration::from_secs(654321)) [INFO] [stderr] | ^^^^^^ help: consider: `654_321` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: impl for `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/carrier.rs:81:21 [INFO] [stderr] | [INFO] [stderr] 81 | impl MapCarrier for HashMap { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 81 | impl MapCarrier for HashMap { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/carrier.rs:87:9 [INFO] [stderr] | [INFO] [stderr] 87 | self.get(key).map(|v| v.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.get(key).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/carrier.rs:101:9 [INFO] [stderr] | [INFO] [stderr] 101 | self.get(key).map(|v| v.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.get(key).cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `span::log::Log` [INFO] [stderr] --> src/span/log.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | / pub fn new() -> Log { [INFO] [stderr] 52 | | Log { [INFO] [stderr] 53 | | fields: LogFileds::new(), [INFO] [stderr] 54 | | timestamp: None, [INFO] [stderr] 55 | | } [INFO] [stderr] 56 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 49 | impl Default for span::log::Log { [INFO] [stderr] 50 | fn default() -> Self { [INFO] [stderr] 51 | Self::new() [INFO] [stderr] 52 | } [INFO] [stderr] 53 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/span/log.rs:68:16 [INFO] [stderr] | [INFO] [stderr] 68 | if let None = self.timestamp { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 69 | | self.timestamp = Some(SystemTime::now()) [INFO] [stderr] 70 | | } [INFO] [stderr] | |_________- help: try this: `if self.timestamp.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `span::tag::SpanTags` [INFO] [stderr] --> src/span/tag.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | / pub fn new() -> SpanTags { [INFO] [stderr] 14 | | SpanTags(HashMap::new()) [INFO] [stderr] 15 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 9 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/tracers/file.rs:149:5 [INFO] [stderr] | [INFO] [stderr] 149 | / pub fn new() -> (Tracer, SpanReceiver) { [INFO] [stderr] 150 | | let (sender, receiver) = unbounded(); [INFO] [stderr] 151 | | let tracer = FileTracer { sender }; [INFO] [stderr] 152 | | (Tracer::new(tracer), receiver) [INFO] [stderr] 153 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tracers/file.rs:170:21 [INFO] [stderr] | [INFO] [stderr] 170 | let start = span.start_time().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*span.start_time()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/tracers/file.rs:173:28 [INFO] [stderr] | [INFO] [stderr] 173 | let delta = secs + duration.subsec_nanos() as f64 * 1e-9; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(duration.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/tracers/file.rs:178:26 [INFO] [stderr] | [INFO] [stderr] 178 | let ref_id = match reference { [INFO] [stderr] | __________________________^ [INFO] [stderr] 179 | | &SpanReference::ChildOf(ref parent) | [INFO] [stderr] 180 | | &SpanReference::FollowsFrom(ref parent) => { [INFO] [stderr] 181 | | let context = parent.impl_context::(); [INFO] [stderr] ... | [INFO] [stderr] 186 | | } [INFO] [stderr] 187 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 178 | let ref_id = match *reference { [INFO] [stderr] 179 | SpanReference::ChildOf(ref parent) | [INFO] [stderr] 180 | SpanReference::FollowsFrom(ref parent) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/tracers/file.rs:188:28 [INFO] [stderr] | [INFO] [stderr] 188 | let ref_type = match reference { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 189 | | &SpanReference::ChildOf(_) => "Child of span ID", [INFO] [stderr] 190 | | &SpanReference::FollowsFrom(_) => "Follows from span ID" [INFO] [stderr] 191 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 188 | let ref_type = match *reference { [INFO] [stderr] 189 | SpanReference::ChildOf(_) => "Child of span ID", [INFO] [stderr] 190 | SpanReference::FollowsFrom(_) => "Follows from span ID" [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/tracers/file.rs:206:25 [INFO] [stderr] | [INFO] [stderr] 206 | let value = match value { [INFO] [stderr] | _________________________^ [INFO] [stderr] 207 | | &TagValue::Boolean(v) => v.to_string(), [INFO] [stderr] 208 | | &TagValue::Float(v) => v.to_string(), [INFO] [stderr] 209 | | &TagValue::Integer(v) => v.to_string(), [INFO] [stderr] 210 | | &TagValue::String(ref v) => v.clone(), [INFO] [stderr] 211 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 206 | let value = match *value { [INFO] [stderr] 207 | TagValue::Boolean(v) => v.to_string(), [INFO] [stderr] 208 | TagValue::Float(v) => v.to_string(), [INFO] [stderr] 209 | TagValue::Integer(v) => v.to_string(), [INFO] [stderr] 210 | TagValue::String(ref v) => v.clone(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/tracers/file.rs:226:29 [INFO] [stderr] | [INFO] [stderr] 226 | let value = match value { [INFO] [stderr] | _____________________________^ [INFO] [stderr] 227 | | &LogValue::Boolean(v) => v.to_string(), [INFO] [stderr] 228 | | &LogValue::Float(v) => v.to_string(), [INFO] [stderr] 229 | | &LogValue::Integer(v) => v.to_string(), [INFO] [stderr] 230 | | &LogValue::String(ref v) => v.clone(), [INFO] [stderr] 231 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 226 | let value = match *value { [INFO] [stderr] 227 | LogValue::Boolean(v) => v.to_string(), [INFO] [stderr] 228 | LogValue::Float(v) => v.to_string(), [INFO] [stderr] 229 | LogValue::Integer(v) => v.to_string(), [INFO] [stderr] 230 | LogValue::String(ref v) => v.clone(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/tracers/file.rs:250:9 [INFO] [stderr] | [INFO] [stderr] 250 | / match reference { [INFO] [stderr] 251 | | &SpanReference::ChildOf(ref parent) | [INFO] [stderr] 252 | | &SpanReference::FollowsFrom(ref parent) => { [INFO] [stderr] 253 | | let context = parent.impl_context::(); [INFO] [stderr] ... | [INFO] [stderr] 258 | | } [INFO] [stderr] 259 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 250 | match *reference { [INFO] [stderr] 251 | SpanReference::ChildOf(ref parent) | [INFO] [stderr] 252 | SpanReference::FollowsFrom(ref parent) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/tracers/noop.rs:74:5 [INFO] [stderr] | [INFO] [stderr] 74 | / pub fn new() -> (Tracer, SpanReceiver) { [INFO] [stderr] 75 | | let (sender, receiver) = unbounded(); [INFO] [stderr] 76 | | let tracer = NoopTracer { sender }; [INFO] [stderr] 77 | | (Tracer::new(tracer), receiver) [INFO] [stderr] 78 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/tracers/noop.rs:99:9 [INFO] [stderr] | [INFO] [stderr] 99 | / match reference { [INFO] [stderr] 100 | | &SpanReference::ChildOf(ref parent) | [INFO] [stderr] 101 | | &SpanReference::FollowsFrom(ref parent) => { [INFO] [stderr] 102 | | let context = parent.impl_context::(); [INFO] [stderr] ... | [INFO] [stderr] 107 | | } [INFO] [stderr] 108 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 99 | match *reference { [INFO] [stderr] 100 | SpanReference::ChildOf(ref parent) | [INFO] [stderr] 101 | SpanReference::FollowsFrom(ref parent) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: impl for `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/carrier.rs:81:21 [INFO] [stderr] | [INFO] [stderr] 81 | impl MapCarrier for HashMap { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 81 | impl MapCarrier for HashMap { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/carrier.rs:87:9 [INFO] [stderr] | [INFO] [stderr] 87 | self.get(key).map(|v| v.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.get(key).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/carrier.rs:101:9 [INFO] [stderr] | [INFO] [stderr] 101 | self.get(key).map(|v| v.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.get(key).cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/carrier.rs:120:24 [INFO] [stderr] | [INFO] [stderr] 120 | assert_eq!(tree.get("aa").unwrap(), "d"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&tree["aa"]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/carrier.rs:132:36 [INFO] [stderr] | [INFO] [stderr] 132 | if key.starts_with("a") { [INFO] [stderr] | ^^^ help: try using a char instead: `'a'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/carrier.rs:149:29 [INFO] [stderr] | [INFO] [stderr] 149 | assert_eq!("d", tree.get("a").unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&tree["a"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/carrier.rs:150:29 [INFO] [stderr] | [INFO] [stderr] 150 | assert_eq!("e", tree.get("b").unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&tree["b"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/carrier.rs:151:29 [INFO] [stderr] | [INFO] [stderr] 151 | assert_eq!("f", tree.get("c").unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&tree["c"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/carrier.rs:163:24 [INFO] [stderr] | [INFO] [stderr] 163 | assert_eq!(map.get("aa").unwrap(), "d"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&map["aa"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/carrier.rs:175:36 [INFO] [stderr] | [INFO] [stderr] 175 | if key.starts_with("a") { [INFO] [stderr] | ^^^ help: try using a char instead: `'a'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/carrier.rs:192:29 [INFO] [stderr] | [INFO] [stderr] 192 | assert_eq!("d", map.get("a").unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `&map["a"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/carrier.rs:193:29 [INFO] [stderr] | [INFO] [stderr] 193 | assert_eq!("e", map.get("b").unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `&map["b"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/carrier.rs:194:29 [INFO] [stderr] | [INFO] [stderr] 194 | assert_eq!("f", map.get("c").unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `&map["c"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `span::log::Log` [INFO] [stderr] --> src/span/log.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | / pub fn new() -> Log { [INFO] [stderr] 52 | | Log { [INFO] [stderr] 53 | | fields: LogFileds::new(), [INFO] [stderr] 54 | | timestamp: None, [INFO] [stderr] 55 | | } [INFO] [stderr] 56 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 49 | impl Default for span::log::Log { [INFO] [stderr] 50 | fn default() -> Self { [INFO] [stderr] 51 | Self::new() [INFO] [stderr] 52 | } [INFO] [stderr] 53 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/span/log.rs:68:16 [INFO] [stderr] | [INFO] [stderr] 68 | if let None = self.timestamp { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 69 | | self.timestamp = Some(SystemTime::now()) [INFO] [stderr] 70 | | } [INFO] [stderr] | |_________- help: try this: `if self.timestamp.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/span/log.rs:195:33 [INFO] [stderr] | [INFO] [stderr] 195 | let log = Log::new().at(time.clone()); [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `time` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `span::tag::SpanTags` [INFO] [stderr] --> src/span/tag.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | / pub fn new() -> SpanTags { [INFO] [stderr] 14 | | SpanTags(HashMap::new()) [INFO] [stderr] 15 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 9 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/span/tag.rs:84:9 [INFO] [stderr] | [INFO] [stderr] 84 | / match tags.get("key") { [INFO] [stderr] 85 | | Some(_) => panic!("Expected no tag"), [INFO] [stderr] 86 | | None => {} [INFO] [stderr] 87 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(_) = tags.get("key") { panic!("Expected no tag") }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/span/tag.rs:96:13 [INFO] [stderr] | [INFO] [stderr] 96 | / match value { [INFO] [stderr] 97 | | &TagValue::Integer(i) => assert_eq!(i, 42), [INFO] [stderr] 98 | | _ => panic!("Invalid value type") [INFO] [stderr] 99 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 96 | match *value { [INFO] [stderr] 97 | TagValue::Integer(i) => assert_eq!(i, 42), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/span/mod.rs:438:9 [INFO] [stderr] | [INFO] [stderr] 438 | / fn new(options: StartOptions) -> (Span, SpanReceiver) { [INFO] [stderr] 439 | | let (sender, receiver) = unbounded(); [INFO] [stderr] 440 | | let context = SpanContext::new(ImplContextBox::new(TestContext { [INFO] [stderr] 441 | | id: String::from("test-id") [INFO] [stderr] 442 | | })); [INFO] [stderr] 443 | | (Span::new("test-span", context, options, sender), receiver) [INFO] [stderr] 444 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/span/mod.rs:525:9 [INFO] [stderr] | [INFO] [stderr] 525 | / match span.references().get(0).unwrap() { [INFO] [stderr] 526 | | &SpanReference::ChildOf(ref context) => { [INFO] [stderr] 527 | | let span = context.impl_context::().unwrap(); [INFO] [stderr] 528 | | assert_eq!(span.id, "test-id-2"); [INFO] [stderr] 529 | | }, [INFO] [stderr] 530 | | _ => panic!("Invalid span reference") [INFO] [stderr] 531 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 525 | match *span.references().get(0).unwrap() { [INFO] [stderr] 526 | SpanReference::ChildOf(ref context) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/span/mod.rs:549:9 [INFO] [stderr] | [INFO] [stderr] 549 | / match span.references().get(0).unwrap() { [INFO] [stderr] 550 | | &SpanReference::FollowsFrom(ref context) => { [INFO] [stderr] 551 | | let span = context.impl_context::().unwrap(); [INFO] [stderr] 552 | | assert_eq!(span.id, "test-id-2"); [INFO] [stderr] 553 | | }, [INFO] [stderr] 554 | | _ => panic!("Invalid span reference") [INFO] [stderr] 555 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 549 | match *span.references().get(0).unwrap() { [INFO] [stderr] 550 | SpanReference::FollowsFrom(ref context) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/span/mod.rs:668:46 [INFO] [stderr] | [INFO] [stderr] 668 | Some(&TagValue::Float(v)) => assert_eq!(v, 1.2), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/span/mod.rs:668:46 [INFO] [stderr] | [INFO] [stderr] 668 | Some(&TagValue::Float(v)) => assert_eq!(v, 1.2), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/span/mod.rs:763:29 [INFO] [stderr] | [INFO] [stderr] 763 | .start_time(ten_minutes_ago.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `ten_minutes_ago` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/tracers/file.rs:149:5 [INFO] [stderr] | [INFO] [stderr] 149 | / pub fn new() -> (Tracer, SpanReceiver) { [INFO] [stderr] 150 | | let (sender, receiver) = unbounded(); [INFO] [stderr] 151 | | let tracer = FileTracer { sender }; [INFO] [stderr] 152 | | (Tracer::new(tracer), receiver) [INFO] [stderr] 153 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tracers/file.rs:170:21 [INFO] [stderr] | [INFO] [stderr] 170 | let start = span.start_time().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*span.start_time()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/tracers/file.rs:173:28 [INFO] [stderr] | [INFO] [stderr] 173 | let delta = secs + duration.subsec_nanos() as f64 * 1e-9; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(duration.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/tracers/file.rs:178:26 [INFO] [stderr] | [INFO] [stderr] 178 | let ref_id = match reference { [INFO] [stderr] | __________________________^ [INFO] [stderr] 179 | | &SpanReference::ChildOf(ref parent) | [INFO] [stderr] 180 | | &SpanReference::FollowsFrom(ref parent) => { [INFO] [stderr] 181 | | let context = parent.impl_context::(); [INFO] [stderr] ... | [INFO] [stderr] 186 | | } [INFO] [stderr] 187 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 178 | let ref_id = match *reference { [INFO] [stderr] 179 | SpanReference::ChildOf(ref parent) | [INFO] [stderr] 180 | SpanReference::FollowsFrom(ref parent) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/tracers/file.rs:188:28 [INFO] [stderr] | [INFO] [stderr] 188 | let ref_type = match reference { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 189 | | &SpanReference::ChildOf(_) => "Child of span ID", [INFO] [stderr] 190 | | &SpanReference::FollowsFrom(_) => "Follows from span ID" [INFO] [stderr] 191 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 188 | let ref_type = match *reference { [INFO] [stderr] 189 | SpanReference::ChildOf(_) => "Child of span ID", [INFO] [stderr] 190 | SpanReference::FollowsFrom(_) => "Follows from span ID" [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/tracers/file.rs:206:25 [INFO] [stderr] | [INFO] [stderr] 206 | let value = match value { [INFO] [stderr] | _________________________^ [INFO] [stderr] 207 | | &TagValue::Boolean(v) => v.to_string(), [INFO] [stderr] 208 | | &TagValue::Float(v) => v.to_string(), [INFO] [stderr] 209 | | &TagValue::Integer(v) => v.to_string(), [INFO] [stderr] 210 | | &TagValue::String(ref v) => v.clone(), [INFO] [stderr] 211 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 206 | let value = match *value { [INFO] [stderr] 207 | TagValue::Boolean(v) => v.to_string(), [INFO] [stderr] 208 | TagValue::Float(v) => v.to_string(), [INFO] [stderr] 209 | TagValue::Integer(v) => v.to_string(), [INFO] [stderr] 210 | TagValue::String(ref v) => v.clone(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/tracers/file.rs:226:29 [INFO] [stderr] | [INFO] [stderr] 226 | let value = match value { [INFO] [stderr] | _____________________________^ [INFO] [stderr] 227 | | &LogValue::Boolean(v) => v.to_string(), [INFO] [stderr] 228 | | &LogValue::Float(v) => v.to_string(), [INFO] [stderr] 229 | | &LogValue::Integer(v) => v.to_string(), [INFO] [stderr] 230 | | &LogValue::String(ref v) => v.clone(), [INFO] [stderr] 231 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 226 | let value = match *value { [INFO] [stderr] 227 | LogValue::Boolean(v) => v.to_string(), [INFO] [stderr] 228 | LogValue::Float(v) => v.to_string(), [INFO] [stderr] 229 | LogValue::Integer(v) => v.to_string(), [INFO] [stderr] 230 | LogValue::String(ref v) => v.clone(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/tracers/file.rs:250:9 [INFO] [stderr] | [INFO] [stderr] 250 | / match reference { [INFO] [stderr] 251 | | &SpanReference::ChildOf(ref parent) | [INFO] [stderr] 252 | | &SpanReference::FollowsFrom(ref parent) => { [INFO] [stderr] 253 | | let context = parent.impl_context::(); [INFO] [stderr] ... | [INFO] [stderr] 258 | | } [INFO] [stderr] 259 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 250 | match *reference { [INFO] [stderr] 251 | SpanReference::ChildOf(ref parent) | [INFO] [stderr] 252 | SpanReference::FollowsFrom(ref parent) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/tracers/file.rs:453:36 [INFO] [stderr] | [INFO] [stderr] 453 | assert_eq!("1234", map.get("TraceID").unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&map["TraceID"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/tracers/file.rs:454:36 [INFO] [stderr] | [INFO] [stderr] 454 | assert_eq!("5678", map.get("SpanID").unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&map["SpanID"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/tracers/file.rs:455:34 [INFO] [stderr] | [INFO] [stderr] 455 | assert_eq!("ab", map.get("Baggage-Item1").unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&map["Baggage-Item1"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/tracers/file.rs:456:34 [INFO] [stderr] | [INFO] [stderr] 456 | assert_eq!("cd", map.get("Baggage-Item2").unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&map["Baggage-Item2"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/tracers/file.rs:471:36 [INFO] [stderr] | [INFO] [stderr] 471 | assert_eq!("1234", map.get("TraceID").unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&map["TraceID"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/tracers/file.rs:472:36 [INFO] [stderr] | [INFO] [stderr] 472 | assert_eq!("5678", map.get("SpanID").unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&map["SpanID"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/tracers/file.rs:473:34 [INFO] [stderr] | [INFO] [stderr] 473 | assert_eq!("ab", map.get("Baggage-Item1").unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&map["Baggage-Item1"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/tracers/file.rs:474:34 [INFO] [stderr] | [INFO] [stderr] 474 | assert_eq!("cd", map.get("Baggage-Item2").unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&map["Baggage-Item2"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/tracers/noop.rs:74:5 [INFO] [stderr] | [INFO] [stderr] 74 | / pub fn new() -> (Tracer, SpanReceiver) { [INFO] [stderr] 75 | | let (sender, receiver) = unbounded(); [INFO] [stderr] 76 | | let tracer = NoopTracer { sender }; [INFO] [stderr] 77 | | (Tracer::new(tracer), receiver) [INFO] [stderr] 78 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/tracers/noop.rs:99:9 [INFO] [stderr] | [INFO] [stderr] 99 | / match reference { [INFO] [stderr] 100 | | &SpanReference::ChildOf(ref parent) | [INFO] [stderr] 101 | | &SpanReference::FollowsFrom(ref parent) => { [INFO] [stderr] 102 | | let context = parent.impl_context::(); [INFO] [stderr] ... | [INFO] [stderr] 107 | | } [INFO] [stderr] 108 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 99 | match *reference { [INFO] [stderr] 100 | SpanReference::ChildOf(ref parent) | [INFO] [stderr] 101 | SpanReference::FollowsFrom(ref parent) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/utils/fail.rs:127:9 [INFO] [stderr] | [INFO] [stderr] 127 | / match result { [INFO] [stderr] 128 | | Ok(_) => panic!("Should have see an error"), [INFO] [stderr] 129 | | Err(_) => (), [INFO] [stderr] 130 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Ok(_) = result { panic!("Should have see an error") }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/utils/fail.rs:133:9 [INFO] [stderr] | [INFO] [stderr] 133 | / match span.tags().get("error").unwrap() { [INFO] [stderr] 134 | | &TagValue::Boolean(_) => (), [INFO] [stderr] 135 | | _ => panic!("Error tag not set") [INFO] [stderr] 136 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 133 | match *span.tags().get("error").unwrap() { [INFO] [stderr] 134 | TagValue::Boolean(_) => (), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `opentracingrust`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> examples/1-custom-tracer.rs:49:23 [INFO] [stderr] | [INFO] [stderr] 49 | trace_id: self.trace_id.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.trace_id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> examples/1-custom-tracer.rs:50:22 [INFO] [stderr] | [INFO] [stderr] 50 | span_id: self.span_id.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.span_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> examples/1-custom-tracer.rs:144:5 [INFO] [stderr] | [INFO] [stderr] 144 | / pub fn new() -> (Tracer, SpanReceiver, MemoryTracerStore) { [INFO] [stderr] 145 | | let (sender, receiver) = unbounded(); [INFO] [stderr] 146 | | let tracer = MemoryTracer { sender }; [INFO] [stderr] 147 | | (Tracer::new(tracer), receiver, Mutex::new(HashMap::new())) [INFO] [stderr] 148 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "4dc6b5d8935da6bc812b22178b5825d1540c20e1cd4cb43ede0e786dd2bb45ac"` [INFO] running `"docker" "rm" "-f" "4dc6b5d8935da6bc812b22178b5825d1540c20e1cd4cb43ede0e786dd2bb45ac"` [INFO] [stdout] 4dc6b5d8935da6bc812b22178b5825d1540c20e1cd4cb43ede0e786dd2bb45ac