[INFO] crate openssl-src 111.1.0+1.1.1a is already in cache [INFO] extracting crate openssl-src 111.1.0+1.1.1a into work/ex/clippy-test-run/sources/stable/reg/openssl-src/111.1.0+1.1.1a [INFO] extracting crate openssl-src 111.1.0+1.1.1a into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/openssl-src/111.1.0+1.1.1a [INFO] validating manifest of openssl-src-111.1.0+1.1.1a on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of openssl-src-111.1.0+1.1.1a on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing openssl-src-111.1.0+1.1.1a [INFO] finished frobbing openssl-src-111.1.0+1.1.1a [INFO] frobbed toml for openssl-src-111.1.0+1.1.1a written to work/ex/clippy-test-run/sources/stable/reg/openssl-src/111.1.0+1.1.1a/Cargo.toml [INFO] started frobbing openssl-src-111.1.0+1.1.1a [INFO] finished frobbing openssl-src-111.1.0+1.1.1a [INFO] frobbed toml for openssl-src-111.1.0+1.1.1a written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/openssl-src/111.1.0+1.1.1a/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting openssl-src-111.1.0+1.1.1a against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/openssl-src/111.1.0+1.1.1a:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f65b3ac6a0c8e2630bf7ec5579bde972426c06af6573c2685b8d2b224f4773a3 [INFO] running `"docker" "start" "-a" "f65b3ac6a0c8e2630bf7ec5579bde972426c06af6573c2685b8d2b224f4773a3"` [INFO] [stderr] Checking cc v1.0.28 [INFO] [stderr] Checking openssl-src v111.1.0+1.1.1a (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:296:13 [INFO] [stderr] | [INFO] [stderr] 296 | libs: libs, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `libs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:296:13 [INFO] [stderr] | [INFO] [stderr] 296 | libs: libs, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `libs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Build` [INFO] [stderr] --> src/lib.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | / pub fn new() -> Build { [INFO] [stderr] 30 | | Build { [INFO] [stderr] 31 | | out_dir: env::var_os("OUT_DIR").map(|s| { [INFO] [stderr] 32 | | PathBuf::from(s).join("openssl-build") [INFO] [stderr] ... | [INFO] [stderr] 36 | | } [INFO] [stderr] 37 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 16 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/lib.rs:119:28 [INFO] [stderr] | [INFO] [stderr] 119 | let features = env::var("CARGO_CFG_TARGET_FEATURE") [INFO] [stderr] | ____________________________^ [INFO] [stderr] 120 | | .unwrap_or(String::new()); [INFO] [stderr] | |_______________________________________________^ help: try this: `env::var("CARGO_CFG_TARGET_FEATURE").unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Build` [INFO] [stderr] --> src/lib.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | / pub fn new() -> Build { [INFO] [stderr] 30 | | Build { [INFO] [stderr] 31 | | out_dir: env::var_os("OUT_DIR").map(|s| { [INFO] [stderr] 32 | | PathBuf::from(s).join("openssl-build") [INFO] [stderr] ... | [INFO] [stderr] 36 | | } [INFO] [stderr] 37 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 16 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/lib.rs:119:28 [INFO] [stderr] | [INFO] [stderr] 119 | let features = env::var("CARGO_CFG_TARGET_FEATURE") [INFO] [stderr] | ____________________________^ [INFO] [stderr] 120 | | .unwrap_or(String::new()); [INFO] [stderr] | |_______________________________________________^ help: try this: `env::var("CARGO_CFG_TARGET_FEATURE").unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.01s [INFO] running `"docker" "inspect" "f65b3ac6a0c8e2630bf7ec5579bde972426c06af6573c2685b8d2b224f4773a3"` [INFO] running `"docker" "rm" "-f" "f65b3ac6a0c8e2630bf7ec5579bde972426c06af6573c2685b8d2b224f4773a3"` [INFO] [stdout] f65b3ac6a0c8e2630bf7ec5579bde972426c06af6573c2685b8d2b224f4773a3