[INFO] crate opensource 0.2.0 is already in cache [INFO] extracting crate opensource 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/opensource/0.2.0 [INFO] extracting crate opensource 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/opensource/0.2.0 [INFO] validating manifest of opensource-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of opensource-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing opensource-0.2.0 [INFO] finished frobbing opensource-0.2.0 [INFO] frobbed toml for opensource-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/opensource/0.2.0/Cargo.toml [INFO] started frobbing opensource-0.2.0 [INFO] finished frobbing opensource-0.2.0 [INFO] frobbed toml for opensource-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/opensource/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting opensource-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/opensource/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5cea388e18d55480cc43a3c9d635eb69ce60fc2ca98726cb07d8220f0c865c6d [INFO] running `"docker" "start" "-a" "5cea388e18d55480cc43a3c9d635eb69ce60fc2ca98726cb07d8220f0c865c6d"` [INFO] [stderr] Checking url v1.6.1 [INFO] [stderr] Checking serde_urlencoded v0.5.4 [INFO] [stderr] Checking reqwest v0.8.8 [INFO] [stderr] Checking opensource v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/client.rs:16:18 [INFO] [stderr] | [INFO] [stderr] 16 | const BASE_URL: &'static str = "https://api.opensource.org"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: All variants have the same postfix: `Error` [INFO] [stderr] --> src/client.rs:25:1 [INFO] [stderr] | [INFO] [stderr] 25 | / enum ErrorDetail { [INFO] [stderr] 26 | | ParseError(url::ParseError), [INFO] [stderr] 27 | | ConnectionError(reqwest::Error), [INFO] [stderr] 28 | | ReadError(io::Error), [INFO] [stderr] 29 | | JsonError(serde_json::Error), [INFO] [stderr] 30 | | APIError(RequestError), [INFO] [stderr] 31 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: remove the postfixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/client.rs:16:18 [INFO] [stderr] | [INFO] [stderr] 16 | const BASE_URL: &'static str = "https://api.opensource.org"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: All variants have the same postfix: `Error` [INFO] [stderr] --> src/client.rs:25:1 [INFO] [stderr] | [INFO] [stderr] 25 | / enum ErrorDetail { [INFO] [stderr] 26 | | ParseError(url::ParseError), [INFO] [stderr] 27 | | ConnectionError(reqwest::Error), [INFO] [stderr] 28 | | ReadError(io::Error), [INFO] [stderr] 29 | | JsonError(serde_json::Error), [INFO] [stderr] 30 | | APIError(RequestError), [INFO] [stderr] 31 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: remove the postfixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 27.28s [INFO] running `"docker" "inspect" "5cea388e18d55480cc43a3c9d635eb69ce60fc2ca98726cb07d8220f0c865c6d"` [INFO] running `"docker" "rm" "-f" "5cea388e18d55480cc43a3c9d635eb69ce60fc2ca98726cb07d8220f0c865c6d"` [INFO] [stdout] 5cea388e18d55480cc43a3c9d635eb69ce60fc2ca98726cb07d8220f0c865c6d