[INFO] crate openml 0.1.2 is already in cache [INFO] extracting crate openml 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/openml/0.1.2 [INFO] extracting crate openml 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/openml/0.1.2 [INFO] validating manifest of openml-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of openml-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing openml-0.1.2 [INFO] finished frobbing openml-0.1.2 [INFO] frobbed toml for openml-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/openml/0.1.2/Cargo.toml [INFO] started frobbing openml-0.1.2 [INFO] finished frobbing openml-0.1.2 [INFO] frobbed toml for openml-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/openml/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting openml-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/openml/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 00d76a7ac3284a6e92a656978e6a44c4a5ba901ef7e856c726c3e6865f3406a3 [INFO] running `"docker" "start" "-a" "00d76a7ac3284a6e92a656978e6a44c4a5ba901ef7e856c726c3e6865f3406a3"` [INFO] [stderr] Checking app_dirs v1.2.1 [INFO] [stderr] Checking arff v0.3.0 [INFO] [stderr] Checking simple_logger v0.5.0 [INFO] [stderr] Checking openml v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:144:58 [INFO] [stderr] | [INFO] [stderr] 144 | let task = SupervisedClassification::from_openml(146825).unwrap(); [INFO] [stderr] | ^^^^^^ help: consider: `146_825` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/baseline/naive_bayes_classifier.rs:52:18 [INFO] [stderr] | [INFO] [stderr] 52 | .or_insert(FeatureDistribution::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(FeatureDistribution::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/baseline/naive_bayes_classifier.rs:87:27 [INFO] [stderr] | [INFO] [stderr] 87 | } else if lnp1 == lnp2 { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider comparing them within some error: `(lnp1 - lnp2).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/baseline/naive_bayes_classifier.rs:87:27 [INFO] [stderr] | [INFO] [stderr] 87 | } else if lnp1 == lnp2 { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/openml_api/impls_from_openml.rs:12:24 [INFO] [stderr] | [INFO] [stderr] 12 | pub fn from_openml<'a, T: Id>(id: T) -> Result { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/openml_api/impls_from_openml.rs:28:24 [INFO] [stderr] | [INFO] [stderr] 28 | pub fn from_openml<'a, T: Id>(id: T) -> Result { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/openml_api/web_access.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | / match File::open(&path) { [INFO] [stderr] 28 | | Ok(f) => { [INFO] [stderr] 29 | | info!("Loading cached {}", url); [INFO] [stderr] 30 | | let mut file = SharedLock::new(f)?; [INFO] [stderr] ... | [INFO] [stderr] 35 | | Err(_) => {} [INFO] [stderr] 36 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 27 | if let Ok(f) = File::open(&path) { [INFO] [stderr] 28 | info!("Loading cached {}", url); [INFO] [stderr] 29 | let mut file = SharedLock::new(f)?; [INFO] [stderr] 30 | let mut data = String::new(); [INFO] [stderr] 31 | file.read_to_string(&mut data)?; [INFO] [stderr] 32 | return Ok(data); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/baseline/naive_bayes_classifier.rs:52:18 [INFO] [stderr] | [INFO] [stderr] 52 | .or_insert(FeatureDistribution::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(FeatureDistribution::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/baseline/naive_bayes_classifier.rs:87:27 [INFO] [stderr] | [INFO] [stderr] 87 | } else if lnp1 == lnp2 { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider comparing them within some error: `(lnp1 - lnp2).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/baseline/naive_bayes_classifier.rs:87:27 [INFO] [stderr] | [INFO] [stderr] 87 | } else if lnp1 == lnp2 { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `openml`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/openml_api/impls_from_openml.rs:12:24 [INFO] [stderr] | [INFO] [stderr] 12 | pub fn from_openml<'a, T: Id>(id: T) -> Result { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/openml_api/impls_from_openml.rs:28:24 [INFO] [stderr] | [INFO] [stderr] 28 | pub fn from_openml<'a, T: Id>(id: T) -> Result { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/openml_api/web_access.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | / match File::open(&path) { [INFO] [stderr] 28 | | Ok(f) => { [INFO] [stderr] 29 | | info!("Loading cached {}", url); [INFO] [stderr] 30 | | let mut file = SharedLock::new(f)?; [INFO] [stderr] ... | [INFO] [stderr] 35 | | Err(_) => {} [INFO] [stderr] 36 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 27 | if let Ok(f) = File::open(&path) { [INFO] [stderr] 28 | info!("Loading cached {}", url); [INFO] [stderr] 29 | let mut file = SharedLock::new(f)?; [INFO] [stderr] 30 | let mut data = String::new(); [INFO] [stderr] 31 | file.read_to_string(&mut data)?; [INFO] [stderr] 32 | return Ok(data); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `openml`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "00d76a7ac3284a6e92a656978e6a44c4a5ba901ef7e856c726c3e6865f3406a3"` [INFO] running `"docker" "rm" "-f" "00d76a7ac3284a6e92a656978e6a44c4a5ba901ef7e856c726c3e6865f3406a3"` [INFO] [stdout] 00d76a7ac3284a6e92a656978e6a44c4a5ba901ef7e856c726c3e6865f3406a3