[INFO] crate opengraph 0.2.4 is already in cache [INFO] extracting crate opengraph 0.2.4 into work/ex/clippy-test-run/sources/stable/reg/opengraph/0.2.4 [INFO] extracting crate opengraph 0.2.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/opengraph/0.2.4 [INFO] validating manifest of opengraph-0.2.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of opengraph-0.2.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing opengraph-0.2.4 [INFO] finished frobbing opengraph-0.2.4 [INFO] frobbed toml for opengraph-0.2.4 written to work/ex/clippy-test-run/sources/stable/reg/opengraph/0.2.4/Cargo.toml [INFO] started frobbing opengraph-0.2.4 [INFO] finished frobbing opengraph-0.2.4 [INFO] frobbed toml for opengraph-0.2.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/opengraph/0.2.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting opengraph-0.2.4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/opengraph/0.2.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e062a15a529b8e9e7383cd150bc53df52d28e151e1b10469a423f99088e21eee [INFO] running `"docker" "start" "-a" "e062a15a529b8e9e7383cd150bc53df52d28e151e1b10469a423f99088e21eee"` [INFO] [stderr] Checking markup5ever v0.7.5 [INFO] [stderr] Checking html5ever v0.22.5 [INFO] [stderr] Checking opengraph v0.2.4 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | url: url, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `url` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/audio.rs:11:17 [INFO] [stderr] | [INFO] [stderr] 11 | Audio { url: url, secure_url: None, obj_type: None } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `url` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/video.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | url: url, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `url` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | url: url, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `url` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/audio.rs:11:17 [INFO] [stderr] | [INFO] [stderr] 11 | Audio { url: url, secure_url: None, obj_type: None } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `url` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/video.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | url: url, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `url` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'core::str::::slice_unchecked': use `get_unchecked(begin..end)` instead [INFO] [stderr] --> src/scraper.rs:161:36 [INFO] [stderr] | [INFO] [stderr] 161 | property.slice_unchecked(3, end) [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'core::str::::slice_unchecked': use `get_unchecked(begin..end)` instead [INFO] [stderr] --> src/scraper.rs:161:36 [INFO] [stderr] | [INFO] [stderr] 161 | property.slice_unchecked(3, end) [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/object.rs:24:27 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn new<'a>(props: &'a Vec<(String, String)>) -> Object { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(String, String)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/object.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | / pub fn new<'a>(props: &'a Vec<(String, String)>) -> Object { [INFO] [stderr] 25 | | let mut obj = Object::default(); [INFO] [stderr] 26 | | for prop in props.iter() { [INFO] [stderr] 27 | | let key: &str = &(prop.0); [INFO] [stderr] ... | [INFO] [stderr] 60 | | obj [INFO] [stderr] 61 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/image.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | / match e { [INFO] [stderr] 27 | | UrlError::RelativeUrlWithoutBase => { [INFO] [stderr] 28 | | if let Ok(url) = url.join(&self.url) { [INFO] [stderr] 29 | | self.url = url.to_string(); [INFO] [stderr] ... | [INFO] [stderr] 32 | | _ => (), [INFO] [stderr] 33 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 26 | if let UrlError::RelativeUrlWithoutBase = e { [INFO] [stderr] 27 | if let Ok(url) = url.join(&self.url) { [INFO] [stderr] 28 | self.url = url.to_string(); [INFO] [stderr] 29 | } [INFO] [stderr] 30 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/object.rs:24:27 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn new<'a>(props: &'a Vec<(String, String)>) -> Object { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(String, String)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/object.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | / pub fn new<'a>(props: &'a Vec<(String, String)>) -> Object { [INFO] [stderr] 25 | | let mut obj = Object::default(); [INFO] [stderr] 26 | | for prop in props.iter() { [INFO] [stderr] 27 | | let key: &str = &(prop.0); [INFO] [stderr] ... | [INFO] [stderr] 60 | | obj [INFO] [stderr] 61 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/scraper.rs:133:33 [INFO] [stderr] | [INFO] [stderr] 133 | fn attr(attr_name: &str, attrs: &Vec) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Attribute]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/image.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | / match e { [INFO] [stderr] 27 | | UrlError::RelativeUrlWithoutBase => { [INFO] [stderr] 28 | | if let Ok(url) = url.join(&self.url) { [INFO] [stderr] 29 | | self.url = url.to_string(); [INFO] [stderr] ... | [INFO] [stderr] 32 | | _ => (), [INFO] [stderr] 33 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 26 | if let UrlError::RelativeUrlWithoutBase = e { [INFO] [stderr] 27 | if let Ok(url) = url.join(&self.url) { [INFO] [stderr] 28 | self.url = url.to_string(); [INFO] [stderr] 29 | } [INFO] [stderr] 30 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/scraper.rs:142:48 [INFO] [stderr] | [INFO] [stderr] 142 | pub fn extract_open_graph_from_meta_tag(attrs: &Vec) -> Vec<(String, String)> { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Attribute]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/scraper.rs:144:5 [INFO] [stderr] | [INFO] [stderr] 144 | / match extract_open_graph_prop("property", attrs) { [INFO] [stderr] 145 | | Some((key, content)) => og_props.push((key, content)), [INFO] [stderr] 146 | | None => (), [INFO] [stderr] 147 | | } [INFO] [stderr] | |_____^ help: try this: `if let Some((key, content)) = extract_open_graph_prop("property", attrs) { og_props.push((key, content)) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/scraper.rs:148:5 [INFO] [stderr] | [INFO] [stderr] 148 | / match extract_open_graph_prop("name", attrs) { [INFO] [stderr] 149 | | Some((key, content)) => og_props.push((key, content)), [INFO] [stderr] 150 | | None => (), [INFO] [stderr] 151 | | } [INFO] [stderr] | |_____^ help: try this: `if let Some((key, content)) = extract_open_graph_prop("name", attrs) { og_props.push((key, content)) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/scraper.rs:155:56 [INFO] [stderr] | [INFO] [stderr] 155 | fn extract_open_graph_prop<'a>(attr_name: &str, attrs: &Vec) -> Option<(String, String)> { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Attribute]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/scraper.rs:155:28 [INFO] [stderr] | [INFO] [stderr] 155 | fn extract_open_graph_prop<'a>(attr_name: &str, attrs: &Vec) -> Option<(String, String)> { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/scraper.rs:169:29 [INFO] [stderr] | [INFO] [stderr] 169 | pub fn extract_image(attrs: &Vec) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Attribute]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/scraper.rs:173:29 [INFO] [stderr] | [INFO] [stderr] 173 | pub fn extract_audio(attrs: &Vec) -> Option