[INFO] crate openaq-client 0.0.5 is already in cache
[INFO] extracting crate openaq-client 0.0.5 into work/ex/clippy-test-run/sources/stable/reg/openaq-client/0.0.5
[INFO] extracting crate openaq-client 0.0.5 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/openaq-client/0.0.5
[INFO] validating manifest of openaq-client-0.0.5 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of openaq-client-0.0.5 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing openaq-client-0.0.5
[INFO] finished frobbing openaq-client-0.0.5
[INFO] frobbed toml for openaq-client-0.0.5 written to work/ex/clippy-test-run/sources/stable/reg/openaq-client/0.0.5/Cargo.toml
[INFO] started frobbing openaq-client-0.0.5
[INFO] finished frobbing openaq-client-0.0.5
[INFO] frobbed toml for openaq-client-0.0.5 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/openaq-client/0.0.5/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting openaq-client-0.0.5 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/openaq-client/0.0.5:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 2fc9d615d3e140f55c6be5bed6f13dae88091bea22490c02497f03b0b78a7e0f
[INFO] running `"docker" "start" "-a" "2fc9d615d3e140f55c6be5bed6f13dae88091bea22490c02497f03b0b78a7e0f"`
[INFO] [stderr]     Checking serde-transcode v1.1.0
[INFO] [stderr]     Checking openaq-client v0.0.5 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:33:9
[INFO] [stderr]    |
[INFO] [stderr] 33 | /         return String::from("page=") + &opts.page.to_string() + "&limit=" +
[INFO] [stderr] 34 | |                &opts.limit.to_string() + "&country=" + opts.country;
[INFO] [stderr]    | |____________________________________________________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 33 |         String::from("page=") + &opts.page.to_string() + "&limit=" +
[INFO] [stderr] 34 |                &opts.limit.to_string() + "&country=" + opts.country
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:38:9
[INFO] [stderr]    |
[INFO] [stderr] 38 |         return String::from("page=") + &opts.page.to_string() + "&limit=" + &opts.limit.to_string();
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from("page=") + &opts.page.to_string() + "&limit=" + &opts.limit.to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:42:9
[INFO] [stderr]    |
[INFO] [stderr] 42 |         return String::from("page=") + &opts.page.to_string() + "&limit=" + &opts.limit.to_string();
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from("page=") + &opts.page.to_string() + "&limit=" + &opts.limit.to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:65:9
[INFO] [stderr]    |
[INFO] [stderr] 65 |         return s;
[INFO] [stderr]    |         ^^^^^^^^^ help: remove `return` as shown: `s`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:33:9
[INFO] [stderr]    |
[INFO] [stderr] 33 | /         return String::from("page=") + &opts.page.to_string() + "&limit=" +
[INFO] [stderr] 34 | |                &opts.limit.to_string() + "&country=" + opts.country;
[INFO] [stderr]    | |____________________________________________________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 33 |         String::from("page=") + &opts.page.to_string() + "&limit=" +
[INFO] [stderr] 34 |                &opts.limit.to_string() + "&country=" + opts.country
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:38:9
[INFO] [stderr]    |
[INFO] [stderr] 38 |         return String::from("page=") + &opts.page.to_string() + "&limit=" + &opts.limit.to_string();
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from("page=") + &opts.page.to_string() + "&limit=" + &opts.limit.to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:42:9
[INFO] [stderr]    |
[INFO] [stderr] 42 |         return String::from("page=") + &opts.page.to_string() + "&limit=" + &opts.limit.to_string();
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from("page=") + &opts.page.to_string() + "&limit=" + &opts.limit.to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:65:9
[INFO] [stderr]    |
[INFO] [stderr] 65 |         return s;
[INFO] [stderr]    |         ^^^^^^^^^ help: remove `return` as shown: `s`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]   --> src/lib.rs:49:24
[INFO] [stderr]    |
[INFO] [stderr] 49 |           let full_url = match &opts {
[INFO] [stderr]    |  ________________________^
[INFO] [stderr] 50 | |             &None => String::from(URL) + req,
[INFO] [stderr] 51 | |             &Some(ref o) => {
[INFO] [stderr] 52 | |                 match &o.query {
[INFO] [stderr] ...  |
[INFO] [stderr] 56 | |             }
[INFO] [stderr] 57 | |         };
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 49 |         let full_url = match opts {
[INFO] [stderr] 50 |             None => String::from(URL) + req,
[INFO] [stderr] 51 |             Some(ref o) => {
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]   --> src/lib.rs:52:17
[INFO] [stderr]    |
[INFO] [stderr] 52 | /                 match &o.query {
[INFO] [stderr] 53 | |                     &None => String::from(URL) + req,
[INFO] [stderr] 54 | |                     &Some(ref q) => String::from(URL) + req + "?" + q,
[INFO] [stderr] 55 | |                 }
[INFO] [stderr]    | |_________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 52 |                 match o.query {
[INFO] [stderr] 53 |                     None => String::from(URL) + req,
[INFO] [stderr] 54 |                     Some(ref q) => String::from(URL) + req + "?" + q,
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]   --> src/lib.rs:49:24
[INFO] [stderr]    |
[INFO] [stderr] 49 |           let full_url = match &opts {
[INFO] [stderr]    |  ________________________^
[INFO] [stderr] 50 | |             &None => String::from(URL) + req,
[INFO] [stderr] 51 | |             &Some(ref o) => {
[INFO] [stderr] 52 | |                 match &o.query {
[INFO] [stderr] ...  |
[INFO] [stderr] 56 | |             }
[INFO] [stderr] 57 | |         };
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 49 |         let full_url = match opts {
[INFO] [stderr] 50 |             None => String::from(URL) + req,
[INFO] [stderr] 51 |             Some(ref o) => {
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]   --> src/lib.rs:52:17
[INFO] [stderr]    |
[INFO] [stderr] 52 | /                 match &o.query {
[INFO] [stderr] 53 | |                     &None => String::from(URL) + req,
[INFO] [stderr] 54 | |                     &Some(ref q) => String::from(URL) + req + "?" + q,
[INFO] [stderr] 55 | |                 }
[INFO] [stderr]    | |_________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 52 |                 match o.query {
[INFO] [stderr] 53 |                     None => String::from(URL) + req,
[INFO] [stderr] 54 |                     Some(ref q) => String::from(URL) + req + "?" + q,
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 5.02s
[INFO] running `"docker" "inspect" "2fc9d615d3e140f55c6be5bed6f13dae88091bea22490c02497f03b0b78a7e0f"`
[INFO] running `"docker" "rm" "-f" "2fc9d615d3e140f55c6be5bed6f13dae88091bea22490c02497f03b0b78a7e0f"`
[INFO] [stdout] 2fc9d615d3e140f55c6be5bed6f13dae88091bea22490c02497f03b0b78a7e0f