[INFO] crate openalias 0.2.0 is already in cache [INFO] extracting crate openalias 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/openalias/0.2.0 [INFO] extracting crate openalias 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/openalias/0.2.0 [INFO] validating manifest of openalias-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of openalias-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing openalias-0.2.0 [INFO] finished frobbing openalias-0.2.0 [INFO] frobbed toml for openalias-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/openalias/0.2.0/Cargo.toml [INFO] started frobbing openalias-0.2.0 [INFO] finished frobbing openalias-0.2.0 [INFO] frobbed toml for openalias-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/openalias/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting openalias-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/openalias/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 305c3b4ff90ae2a9b989290c7ebb908467b5860515f55a0f5c03832e73ee015e [INFO] running `"docker" "start" "-a" "305c3b4ff90ae2a9b989290c7ebb908467b5860515f55a0f5c03832e73ee015e"` [INFO] [stderr] Compiling rustfmt v0.9.0 [INFO] [stderr] Compiling embed-resource v1.1.4 [INFO] [stderr] Compiling peg v0.5.7 [INFO] [stderr] Compiling strings v0.1.1 [INFO] [stderr] Checking resolve v0.1.2 [INFO] [stderr] Compiling serde v1.0.85 [INFO] [stderr] Compiling syntex_pos v0.59.1 [INFO] [stderr] Compiling serde_json v1.0.37 [INFO] [stderr] Compiling extprim v1.6.0 [INFO] [stderr] Compiling toml v0.4.10 [INFO] [stderr] Compiling syntex_errors v0.59.1 [INFO] [stderr] Compiling syntex_syntax v0.59.1 [INFO] [stderr] Compiling openalias v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> /opt/crater/target/debug/build/openalias-529f917ef5f8073f/out/grammar.rs:33:12 [INFO] [stderr] | [INFO] [stderr] 33 | if self.expected.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.expected.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: You appear to be counting bytes the naive way [INFO] [stderr] --> /opt/crater/target/debug/build/openalias-529f917ef5f8073f/out/grammar.rs:82:16 [INFO] [stderr] | [INFO] [stderr] 82 | let line = before.as_bytes().iter().filter(|&&c| c == b'\n').count() + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider using the bytecount crate: `bytecount::count(before.as_bytes(), b'\n')` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::naive_bytecount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#naive_bytecount [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> /opt/crater/target/debug/build/openalias-529f917ef5f8073f/out/grammar.rs:140:57 [INFO] [stderr] | [INFO] [stderr] 140 | __repeat_value.push(__value); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 140 | __repeat_value.push(()); [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> /opt/crater/target/debug/build/openalias-529f917ef5f8073f/out/grammar.rs:147:28 [INFO] [stderr] | [INFO] [stderr] 147 | if __repeat_value.len() >= 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!__repeat_value.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> /opt/crater/target/debug/build/openalias-529f917ef5f8073f/out/grammar.rs:178:40 [INFO] [stderr] | [INFO] [stderr] 178 | if __repeat_value.len() >= 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!__repeat_value.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant [INFO] [stderr] --> /opt/crater/target/debug/build/openalias-529f917ef5f8073f/out/grammar.rs:213:57 [INFO] [stderr] | [INFO] [stderr] 213 | / if let Some(cksum) = parsed.ok() { [INFO] [stderr] 214 | | out.checksum = Some((cksum, false)); [INFO] [stderr] 215 | | } else { [INFO] [stderr] 216 | | return Failed; [INFO] [stderr] 217 | | } [INFO] [stderr] | |_________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::if_let_some_result)] on by default [INFO] [stderr] = help: Consider matching on `Ok(cksum)` and removing the call to `ok` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> /opt/crater/target/debug/build/openalias-529f917ef5f8073f/out/grammar.rs:265:49 [INFO] [stderr] | [INFO] [stderr] 265 | __repeat_value.push(__value); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 265 | __repeat_value.push(()); [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> /opt/crater/target/debug/build/openalias-529f917ef5f8073f/out/grammar.rs:584:49 [INFO] [stderr] | [INFO] [stderr] 584 | __repeat_value.push(__value); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 584 | __repeat_value.push(()); [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> /opt/crater/target/debug/build/openalias-529f917ef5f8073f/out/grammar.rs:591:20 [INFO] [stderr] | [INFO] [stderr] 591 | if __repeat_value.len() >= 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!__repeat_value.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/openalias-529f917ef5f8073f/out/grammar.rs:612:1 [INFO] [stderr] | [INFO] [stderr] 612 | / pub fn oa1<'input>(__input: &'input str) -> ParseResult {# ! [ allow ( non_snake_case , unused ) ] let mut __state = ParseState::new(); [INFO] [stderr] 613 | | match __parse_oa1(__input, &mut __state, 0) { [INFO] [stderr] 614 | | Matched(__pos, __value) => { [INFO] [stderr] 615 | | if __pos == __input.len() { [INFO] [stderr] ... | [INFO] [stderr] 627 | | }) [INFO] [stderr] 628 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> /opt/crater/target/debug/build/openalias-529f917ef5f8073f/out/grammar.rs:613:5 [INFO] [stderr] | [INFO] [stderr] 613 | / match __parse_oa1(__input, &mut __state, 0) { [INFO] [stderr] 614 | | Matched(__pos, __value) => { [INFO] [stderr] 615 | | if __pos == __input.len() { [INFO] [stderr] 616 | | return Ok(__value); [INFO] [stderr] ... | [INFO] [stderr] 619 | | _ => {} [INFO] [stderr] 620 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 613 | if let Matched(__pos, __value) = __parse_oa1(__input, &mut __state, 0) { [INFO] [stderr] 614 | if __pos == __input.len() { [INFO] [stderr] 615 | return Ok(__value); [INFO] [stderr] 616 | } [INFO] [stderr] 617 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/openalias-529f917ef5f8073f/out/grammar.rs:630:1 [INFO] [stderr] | [INFO] [stderr] 630 | / pub fn checksum_val<'input>(__input: &'input str) -> ParseResult {# ! [ allow ( non_snake_case , unused ) ] let mut __state = ParseState::new(); [INFO] [stderr] 631 | | match __parse_checksum_val(__input, &mut __state, 0) { [INFO] [stderr] 632 | | Matched(__pos, __value) => { [INFO] [stderr] 633 | | if __pos == __input.len() { [INFO] [stderr] ... | [INFO] [stderr] 645 | | }) [INFO] [stderr] 646 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> /opt/crater/target/debug/build/openalias-529f917ef5f8073f/out/grammar.rs:631:5 [INFO] [stderr] | [INFO] [stderr] 631 | / match __parse_checksum_val(__input, &mut __state, 0) { [INFO] [stderr] 632 | | Matched(__pos, __value) => { [INFO] [stderr] 633 | | if __pos == __input.len() { [INFO] [stderr] 634 | | return Ok(__value); [INFO] [stderr] ... | [INFO] [stderr] 637 | | _ => {} [INFO] [stderr] 638 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 631 | if let Matched(__pos, __value) = __parse_checksum_val(__input, &mut __state, 0) { [INFO] [stderr] 632 | if __pos == __input.len() { [INFO] [stderr] 633 | return Ok(__value); [INFO] [stderr] 634 | } [INFO] [stderr] 635 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> /opt/crater/target/debug/build/openalias-529f917ef5f8073f/out/grammar.rs:33:12 [INFO] [stderr] | [INFO] [stderr] 33 | if self.expected.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.expected.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: You appear to be counting bytes the naive way [INFO] [stderr] --> /opt/crater/target/debug/build/openalias-529f917ef5f8073f/out/grammar.rs:82:16 [INFO] [stderr] | [INFO] [stderr] 82 | let line = before.as_bytes().iter().filter(|&&c| c == b'\n').count() + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider using the bytecount crate: `bytecount::count(before.as_bytes(), b'\n')` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::naive_bytecount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#naive_bytecount [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> /opt/crater/target/debug/build/openalias-529f917ef5f8073f/out/grammar.rs:140:57 [INFO] [stderr] | [INFO] [stderr] 140 | __repeat_value.push(__value); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 140 | __repeat_value.push(()); [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> /opt/crater/target/debug/build/openalias-529f917ef5f8073f/out/grammar.rs:147:28 [INFO] [stderr] | [INFO] [stderr] 147 | if __repeat_value.len() >= 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!__repeat_value.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> /opt/crater/target/debug/build/openalias-529f917ef5f8073f/out/grammar.rs:178:40 [INFO] [stderr] | [INFO] [stderr] 178 | if __repeat_value.len() >= 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!__repeat_value.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant [INFO] [stderr] --> /opt/crater/target/debug/build/openalias-529f917ef5f8073f/out/grammar.rs:213:57 [INFO] [stderr] | [INFO] [stderr] 213 | / if let Some(cksum) = parsed.ok() { [INFO] [stderr] 214 | | out.checksum = Some((cksum, false)); [INFO] [stderr] 215 | | } else { [INFO] [stderr] 216 | | return Failed; [INFO] [stderr] 217 | | } [INFO] [stderr] | |_________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::if_let_some_result)] on by default [INFO] [stderr] = help: Consider matching on `Ok(cksum)` and removing the call to `ok` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> /opt/crater/target/debug/build/openalias-529f917ef5f8073f/out/grammar.rs:265:49 [INFO] [stderr] | [INFO] [stderr] 265 | __repeat_value.push(__value); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 265 | __repeat_value.push(()); [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> /opt/crater/target/debug/build/openalias-529f917ef5f8073f/out/grammar.rs:584:49 [INFO] [stderr] | [INFO] [stderr] 584 | __repeat_value.push(__value); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 584 | __repeat_value.push(()); [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> /opt/crater/target/debug/build/openalias-529f917ef5f8073f/out/grammar.rs:591:20 [INFO] [stderr] | [INFO] [stderr] 591 | if __repeat_value.len() >= 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!__repeat_value.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/openalias-529f917ef5f8073f/out/grammar.rs:612:1 [INFO] [stderr] | [INFO] [stderr] 612 | / pub fn oa1<'input>(__input: &'input str) -> ParseResult {# ! [ allow ( non_snake_case , unused ) ] let mut __state = ParseState::new(); [INFO] [stderr] 613 | | match __parse_oa1(__input, &mut __state, 0) { [INFO] [stderr] 614 | | Matched(__pos, __value) => { [INFO] [stderr] 615 | | if __pos == __input.len() { [INFO] [stderr] ... | [INFO] [stderr] 627 | | }) [INFO] [stderr] 628 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> /opt/crater/target/debug/build/openalias-529f917ef5f8073f/out/grammar.rs:613:5 [INFO] [stderr] | [INFO] [stderr] 613 | / match __parse_oa1(__input, &mut __state, 0) { [INFO] [stderr] 614 | | Matched(__pos, __value) => { [INFO] [stderr] 615 | | if __pos == __input.len() { [INFO] [stderr] 616 | | return Ok(__value); [INFO] [stderr] ... | [INFO] [stderr] 619 | | _ => {} [INFO] [stderr] 620 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 613 | if let Matched(__pos, __value) = __parse_oa1(__input, &mut __state, 0) { [INFO] [stderr] 614 | if __pos == __input.len() { [INFO] [stderr] 615 | return Ok(__value); [INFO] [stderr] 616 | } [INFO] [stderr] 617 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> /opt/crater/target/debug/build/openalias-529f917ef5f8073f/out/grammar.rs:630:1 [INFO] [stderr] | [INFO] [stderr] 630 | / pub fn checksum_val<'input>(__input: &'input str) -> ParseResult {# ! [ allow ( non_snake_case , unused ) ] let mut __state = ParseState::new(); [INFO] [stderr] 631 | | match __parse_checksum_val(__input, &mut __state, 0) { [INFO] [stderr] 632 | | Matched(__pos, __value) => { [INFO] [stderr] 633 | | if __pos == __input.len() { [INFO] [stderr] ... | [INFO] [stderr] 645 | | }) [INFO] [stderr] 646 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> /opt/crater/target/debug/build/openalias-529f917ef5f8073f/out/grammar.rs:631:5 [INFO] [stderr] | [INFO] [stderr] 631 | / match __parse_checksum_val(__input, &mut __state, 0) { [INFO] [stderr] 632 | | Matched(__pos, __value) => { [INFO] [stderr] 633 | | if __pos == __input.len() { [INFO] [stderr] 634 | | return Ok(__value); [INFO] [stderr] ... | [INFO] [stderr] 637 | | _ => {} [INFO] [stderr] 638 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 631 | if let Matched(__pos, __value) = __parse_checksum_val(__input, &mut __state, 0) { [INFO] [stderr] 632 | if __pos == __input.len() { [INFO] [stderr] 633 | return Ok(__value); [INFO] [stderr] 634 | } [INFO] [stderr] 635 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 35 [INFO] [stderr] --> src/main.rs:28:1 [INFO] [stderr] | [INFO] [stderr] 28 | / fn result_main() -> Result<(), Error> { [INFO] [stderr] 29 | | let opts = Options::parse(); [INFO] [stderr] 30 | | [INFO] [stderr] 31 | | for addr in opts.aliases { [INFO] [stderr] ... | [INFO] [stderr] 121 | | Ok(()) [INFO] [stderr] 122 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 35 [INFO] [stderr] --> src/main.rs:28:1 [INFO] [stderr] | [INFO] [stderr] 28 | / fn result_main() -> Result<(), Error> { [INFO] [stderr] 29 | | let opts = Options::parse(); [INFO] [stderr] 30 | | [INFO] [stderr] 31 | | for addr in opts.aliases { [INFO] [stderr] ... | [INFO] [stderr] 121 | | Ok(()) [INFO] [stderr] 122 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 25s [INFO] running `"docker" "inspect" "305c3b4ff90ae2a9b989290c7ebb908467b5860515f55a0f5c03832e73ee015e"` [INFO] running `"docker" "rm" "-f" "305c3b4ff90ae2a9b989290c7ebb908467b5860515f55a0f5c03832e73ee015e"` [INFO] [stdout] 305c3b4ff90ae2a9b989290c7ebb908467b5860515f55a0f5c03832e73ee015e