[INFO] crate open_read_later 1.1.1 is already in cache
[INFO] extracting crate open_read_later 1.1.1 into work/ex/clippy-test-run/sources/stable/reg/open_read_later/1.1.1
[INFO] extracting crate open_read_later 1.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/open_read_later/1.1.1
[INFO] validating manifest of open_read_later-1.1.1 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of open_read_later-1.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing open_read_later-1.1.1
[INFO] finished frobbing open_read_later-1.1.1
[INFO] frobbed toml for open_read_later-1.1.1 written to work/ex/clippy-test-run/sources/stable/reg/open_read_later/1.1.1/Cargo.toml
[INFO] started frobbing open_read_later-1.1.1
[INFO] finished frobbing open_read_later-1.1.1
[INFO] frobbed toml for open_read_later-1.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/open_read_later/1.1.1/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting open_read_later-1.1.1 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/open_read_later/1.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] ee3491d33988fce715b87b145982083cdb0a5daa6222d85a448ec79041d57e0f
[INFO] running `"docker" "start" "-a" "ee3491d33988fce715b87b145982083cdb0a5daa6222d85a448ec79041d57e0f"`
[INFO] [stderr]     Checking open_read_later v1.1.1 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/read_later_list.rs:62:33
[INFO] [stderr]    |
[INFO] [stderr] 62 |                                 url: url,
[INFO] [stderr]    |                                 ^^^^^^^^ help: replace it with: `url`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/read_later_list.rs:63:33
[INFO] [stderr]    |
[INFO] [stderr] 63 |                                 title: title,
[INFO] [stderr]    |                                 ^^^^^^^^^^^^ help: replace it with: `title`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/read_later_list.rs:67:33
[INFO] [stderr]    |
[INFO] [stderr] 67 |                                 url: url,
[INFO] [stderr]    |                                 ^^^^^^^^ help: replace it with: `url`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/read_later_list.rs:68:33
[INFO] [stderr]    |
[INFO] [stderr] 68 |                                 title: title,
[INFO] [stderr]    |                                 ^^^^^^^^^^^^ help: replace it with: `title`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/read_later_list.rs:62:33
[INFO] [stderr]    |
[INFO] [stderr] 62 |                                 url: url,
[INFO] [stderr]    |                                 ^^^^^^^^ help: replace it with: `url`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/read_later_list.rs:63:33
[INFO] [stderr]    |
[INFO] [stderr] 63 |                                 title: title,
[INFO] [stderr]    |                                 ^^^^^^^^^^^^ help: replace it with: `title`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/read_later_list.rs:67:33
[INFO] [stderr]    |
[INFO] [stderr] 67 |                                 url: url,
[INFO] [stderr]    |                                 ^^^^^^^^ help: replace it with: `url`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/read_later_list.rs:68:33
[INFO] [stderr]    |
[INFO] [stderr] 68 |                                 title: title,
[INFO] [stderr]    |                                 ^^^^^^^^^^^^ help: replace it with: `title`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/read_later_list.rs:195:21
[INFO] [stderr]     |
[INFO] [stderr] 195 |             None => return Err(format!("Link {} does not exist", url)),
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format!("Link {} does not exist", url))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/read_later_list.rs:215:21
[INFO] [stderr]     |
[INFO] [stderr] 215 |             None => return Err(format!("Link {} does not exist", url)),
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format!("Link {} does not exist", url))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/read_later_list.rs:195:21
[INFO] [stderr]     |
[INFO] [stderr] 195 |             None => return Err(format!("Link {} does not exist", url)),
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format!("Link {} does not exist", url))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/read_later_list.rs:215:21
[INFO] [stderr]     |
[INFO] [stderr] 215 |             None => return Err(format!("Link {} does not exist", url)),
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format!("Link {} does not exist", url))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `read_later_list::LinkEntryBuilder`
[INFO] [stderr]   --> src/read_later_list.rs:23:5
[INFO] [stderr]    |
[INFO] [stderr] 23 | /     pub fn new() -> LinkEntryBuilder {
[INFO] [stderr] 24 | |         LinkEntryBuilder {
[INFO] [stderr] 25 | |             url: None,
[INFO] [stderr] 26 | |             title: None,
[INFO] [stderr] 27 | |             tags: Vec::new(),
[INFO] [stderr] 28 | |         }
[INFO] [stderr] 29 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 16 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/read_later_list.rs:100:40
[INFO] [stderr]     |
[INFO] [stderr] 100 |                                 .split(",")
[INFO] [stderr]     |                                        ^^^ help: try using a char instead: `','`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: item `read_later_list::ReadLaterList` has a public `len` method but no corresponding `is_empty` method
[INFO] [stderr]    --> src/read_later_list.rs:132:1
[INFO] [stderr]     |
[INFO] [stderr] 132 | / impl ReadLaterList {
[INFO] [stderr] 133 | |     pub fn new() -> ReadLaterList {
[INFO] [stderr] 134 | |         ReadLaterList { links: HashMap::new() }
[INFO] [stderr] 135 | |     }
[INFO] [stderr] ...   |
[INFO] [stderr] 231 | |     }
[INFO] [stderr] 232 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_without_is_empty)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `read_later_list::ReadLaterList`
[INFO] [stderr]    --> src/read_later_list.rs:133:5
[INFO] [stderr]     |
[INFO] [stderr] 133 | /     pub fn new() -> ReadLaterList {
[INFO] [stderr] 134 | |         ReadLaterList { links: HashMap::new() }
[INFO] [stderr] 135 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 128 | #[derive(Default)]
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this lifetime isn't used in the function definition
[INFO] [stderr]    --> src/read_later_list.rs:137:18
[INFO] [stderr]     |
[INFO] [stderr] 137 |     pub fn parse<'a>(text: &str) -> Result<ReadLaterList, String> {
[INFO] [stderr]     |                  ^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::extra_unused_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `read_later_list::LinkEntryBuilder`
[INFO] [stderr]   --> src/read_later_list.rs:23:5
[INFO] [stderr]    |
[INFO] [stderr] 23 | /     pub fn new() -> LinkEntryBuilder {
[INFO] [stderr] 24 | |         LinkEntryBuilder {
[INFO] [stderr] 25 | |             url: None,
[INFO] [stderr] 26 | |             title: None,
[INFO] [stderr] 27 | |             tags: Vec::new(),
[INFO] [stderr] 28 | |         }
[INFO] [stderr] 29 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 16 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/read_later_list.rs:100:40
[INFO] [stderr]     |
[INFO] [stderr] 100 |                                 .split(",")
[INFO] [stderr]     |                                        ^^^ help: try using a char instead: `','`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: item `read_later_list::ReadLaterList` has a public `len` method but no corresponding `is_empty` method
[INFO] [stderr]    --> src/read_later_list.rs:132:1
[INFO] [stderr]     |
[INFO] [stderr] 132 | / impl ReadLaterList {
[INFO] [stderr] 133 | |     pub fn new() -> ReadLaterList {
[INFO] [stderr] 134 | |         ReadLaterList { links: HashMap::new() }
[INFO] [stderr] 135 | |     }
[INFO] [stderr] ...   |
[INFO] [stderr] 231 | |     }
[INFO] [stderr] 232 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_without_is_empty)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `read_later_list::ReadLaterList`
[INFO] [stderr]    --> src/read_later_list.rs:133:5
[INFO] [stderr]     |
[INFO] [stderr] 133 | /     pub fn new() -> ReadLaterList {
[INFO] [stderr] 134 | |         ReadLaterList { links: HashMap::new() }
[INFO] [stderr] 135 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 128 | #[derive(Default)]
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this lifetime isn't used in the function definition
[INFO] [stderr]    --> src/read_later_list.rs:137:18
[INFO] [stderr]     |
[INFO] [stderr] 137 |     pub fn parse<'a>(text: &str) -> Result<ReadLaterList, String> {
[INFO] [stderr]     |                  ^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::extra_unused_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/main.rs:33:20
[INFO] [stderr]    |
[INFO] [stderr] 33 |     let home_dir = env::home_dir().ok_or("Cannot find home directory")?;
[INFO] [stderr]    |                    ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/main.rs:33:20
[INFO] [stderr]    |
[INFO] [stderr] 33 |     let home_dir = env::home_dir().ok_or("Cannot find home directory")?;
[INFO] [stderr]    |                    ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead
[INFO] [stderr]  --> src/util.rs:9:5
[INFO] [stderr]   |
[INFO] [stderr] 9 |     stdout_handle.write(prompt.as_bytes())?;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[deny(clippy::unused_io_amount)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/main.rs:42:52
[INFO] [stderr]    |
[INFO] [stderr] 42 |     let list_text = read_from_file(list_file_path).unwrap_or(String::from(""));
[INFO] [stderr]    |                                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| String::from(""))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/main.rs:61:1
[INFO] [stderr]     |
[INFO] [stderr] 61  | / fn parse_args<'a>(default_list_file: &'a PathBuf) -> ArgMatches<'a> {
[INFO] [stderr] 62  | |     App::new("readlater")
[INFO] [stderr] 63  | |         .version(env!("CARGO_PKG_VERSION"))
[INFO] [stderr] 64  | |         .author("Jeremy Dormitzer <jeremy.dormitzer@gmail.com>")
[INFO] [stderr] ...   |
[INFO] [stderr] 145 | |         .get_matches()
[INFO] [stderr] 146 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/main.rs:173:29
[INFO] [stderr]     |
[INFO] [stderr] 173 |         Some(link_entry) => format!("{}", link_entry.title),
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `link_entry.title.to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/main.rs:181:29
[INFO] [stderr]     |
[INFO] [stderr] 181 |         Some(link_entry) => format!("{}", link_entry.tags.join(", ")),
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `link_entry.tags.join(", ").to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/main.rs:209:24
[INFO] [stderr]     |
[INFO] [stderr] 209 |                 .split(",")
[INFO] [stderr]     |                        ^^^ help: try using a char instead: `','`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]    --> src/main.rs:212:31
[INFO] [stderr]     |
[INFO] [stderr] 212 |                 .filter(|tag| !(tag.trim() == ""))
[INFO] [stderr]     |                               ^^^^^^^^^^^^^^^^^^^ help: try: `tag.trim() != ""`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::nonminimal_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/main.rs:217:32
[INFO] [stderr]     |
[INFO] [stderr] 217 |                         .split(",")
[INFO] [stderr]     |                                ^^^ help: try using a char instead: `','`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead
[INFO] [stderr]  --> src/util.rs:9:5
[INFO] [stderr]   |
[INFO] [stderr] 9 |     stdout_handle.write(prompt.as_bytes())?;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[deny(clippy::unused_io_amount)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/main.rs:308:19
[INFO] [stderr]     |
[INFO] [stderr] 308 |       let results = read_later_list
[INFO] [stderr]     |  ___________________^
[INFO] [stderr] 309 | |         .iter_links()
[INFO] [stderr] 310 | |         .filter(|link_entry| {
[INFO] [stderr] 311 | |             re.is_match(&link_entry.url) || re.is_match(&link_entry.title) ||
[INFO] [stderr] 312 | |                 re.is_match(&link_entry.tags.join(", "))
[INFO] [stderr] 313 | |         })
[INFO] [stderr] 314 | |         .map(|link| link.clone())
[INFO] [stderr]     | |_________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] help: Consider calling the dedicated `cloned` method
[INFO] [stderr]     |
[INFO] [stderr] 308 |     let results = read_later_list
[INFO] [stderr] 309 |         .iter_links()
[INFO] [stderr] 310 |         .filter(|link_entry| {
[INFO] [stderr] 311 |             re.is_match(&link_entry.url) || re.is_match(&link_entry.title) ||
[INFO] [stderr] 312 |                 re.is_match(&link_entry.tags.join(", "))
[INFO] [stderr] 313 |         }).cloned()
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/main.rs:42:52
[INFO] [stderr]    |
[INFO] [stderr] 42 |     let list_text = read_from_file(list_file_path).unwrap_or(String::from(""));
[INFO] [stderr]    |                                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| String::from(""))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/main.rs:61:1
[INFO] [stderr]     |
[INFO] [stderr] 61  | / fn parse_args<'a>(default_list_file: &'a PathBuf) -> ArgMatches<'a> {
[INFO] [stderr] 62  | |     App::new("readlater")
[INFO] [stderr] 63  | |         .version(env!("CARGO_PKG_VERSION"))
[INFO] [stderr] 64  | |         .author("Jeremy Dormitzer <jeremy.dormitzer@gmail.com>")
[INFO] [stderr] ...   |
[INFO] [stderr] 145 | |         .get_matches()
[INFO] [stderr] 146 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `open_read_later`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/main.rs:173:29
[INFO] [stderr]     |
[INFO] [stderr] 173 |         Some(link_entry) => format!("{}", link_entry.title),
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `link_entry.title.to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/main.rs:181:29
[INFO] [stderr]     |
[INFO] [stderr] 181 |         Some(link_entry) => format!("{}", link_entry.tags.join(", ")),
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `link_entry.tags.join(", ").to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/main.rs:209:24
[INFO] [stderr]     |
[INFO] [stderr] 209 |                 .split(",")
[INFO] [stderr]     |                        ^^^ help: try using a char instead: `','`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]    --> src/main.rs:212:31
[INFO] [stderr]     |
[INFO] [stderr] 212 |                 .filter(|tag| !(tag.trim() == ""))
[INFO] [stderr]     |                               ^^^^^^^^^^^^^^^^^^^ help: try: `tag.trim() != ""`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::nonminimal_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/main.rs:217:32
[INFO] [stderr]     |
[INFO] [stderr] 217 |                         .split(",")
[INFO] [stderr]     |                                ^^^ help: try using a char instead: `','`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/main.rs:308:19
[INFO] [stderr]     |
[INFO] [stderr] 308 |       let results = read_later_list
[INFO] [stderr]     |  ___________________^
[INFO] [stderr] 309 | |         .iter_links()
[INFO] [stderr] 310 | |         .filter(|link_entry| {
[INFO] [stderr] 311 | |             re.is_match(&link_entry.url) || re.is_match(&link_entry.title) ||
[INFO] [stderr] 312 | |                 re.is_match(&link_entry.tags.join(", "))
[INFO] [stderr] 313 | |         })
[INFO] [stderr] 314 | |         .map(|link| link.clone())
[INFO] [stderr]     | |_________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] help: Consider calling the dedicated `cloned` method
[INFO] [stderr]     |
[INFO] [stderr] 308 |     let results = read_later_list
[INFO] [stderr] 309 |         .iter_links()
[INFO] [stderr] 310 |         .filter(|link_entry| {
[INFO] [stderr] 311 |             re.is_match(&link_entry.url) || re.is_match(&link_entry.title) ||
[INFO] [stderr] 312 |                 re.is_match(&link_entry.tags.join(", "))
[INFO] [stderr] 313 |         }).cloned()
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `open_read_later`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "ee3491d33988fce715b87b145982083cdb0a5daa6222d85a448ec79041d57e0f"`
[INFO] running `"docker" "rm" "-f" "ee3491d33988fce715b87b145982083cdb0a5daa6222d85a448ec79041d57e0f"`
[INFO] [stdout] ee3491d33988fce715b87b145982083cdb0a5daa6222d85a448ec79041d57e0f