[INFO] crate open-location-code 0.1.0 is already in cache [INFO] extracting crate open-location-code 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/open-location-code/0.1.0 [INFO] extracting crate open-location-code 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/open-location-code/0.1.0 [INFO] validating manifest of open-location-code-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of open-location-code-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing open-location-code-0.1.0 [INFO] finished frobbing open-location-code-0.1.0 [INFO] frobbed toml for open-location-code-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/open-location-code/0.1.0/Cargo.toml [INFO] started frobbing open-location-code-0.1.0 [INFO] finished frobbing open-location-code-0.1.0 [INFO] frobbed toml for open-location-code-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/open-location-code/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting open-location-code-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/open-location-code/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 536ab88e2f3f7e570000883b6db7894d378239b15c5f3a6e966f830917c1019b [INFO] running `"docker" "start" "-a" "536ab88e2f3f7e570000883b6db7894d378239b15c5f3a6e966f830917c1019b"` [INFO] [stderr] Checking geo v0.4.13 [INFO] [stderr] Checking open-location-code v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codearea.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | south: south, west: west, north: north, east: east, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `south` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codearea.rs:15:27 [INFO] [stderr] | [INFO] [stderr] 15 | south: south, west: west, north: north, east: east, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `west` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codearea.rs:15:39 [INFO] [stderr] | [INFO] [stderr] 15 | south: south, west: west, north: north, east: east, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `north` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codearea.rs:15:53 [INFO] [stderr] | [INFO] [stderr] 15 | south: south, west: west, north: north, east: east, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `east` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codearea.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | code_length: code_length [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `code_length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codearea.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | south: south, west: west, north: north, east: east, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `south` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codearea.rs:15:27 [INFO] [stderr] | [INFO] [stderr] 15 | south: south, west: west, north: north, east: east, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `west` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codearea.rs:15:39 [INFO] [stderr] | [INFO] [stderr] 15 | south: south, west: west, north: north, east: east, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `north` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codearea.rs:15:53 [INFO] [stderr] | [INFO] [stderr] 15 | south: south, west: west, north: north, east: east, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `east` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codearea.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | code_length: code_length [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `code_length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/consts.rs:9:30 [INFO] [stderr] | [INFO] [stderr] 9 | pub const PADDING_CHAR_STR: &'static str = "0"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/consts.rs:37:42 [INFO] [stderr] | [INFO] [stderr] 37 | 20.0f64, 1.0f64, 0.05f64, 0.0025f64, 0.000125f64 [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.000_125f64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/private.rs:58:31 [INFO] [stderr] | [INFO] [stderr] 58 | value.trunc() != (value + 0.0000000001f64).trunc() [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `0.000_000_000_1f64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/consts.rs:9:30 [INFO] [stderr] | [INFO] [stderr] 9 | pub const PADDING_CHAR_STR: &'static str = "0"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/consts.rs:37:42 [INFO] [stderr] | [INFO] [stderr] 37 | 20.0f64, 1.0f64, 0.05f64, 0.0025f64, 0.000125f64 [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.000_125f64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/private.rs:58:31 [INFO] [stderr] | [INFO] [stderr] 58 | value.trunc() != (value + 0.0000000001f64).trunc() [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `0.000_000_000_1f64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/private.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | value.trunc() != (value + 0.0000000001f64).trunc() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(value.trunc() - (value + 0.0000000001f64).trunc()).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/private.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | value.trunc() != (value + 0.0000000001f64).trunc() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/interface.rs:61:42 [INFO] [stderr] | [INFO] [stderr] 61 | let padding: String = code.drain(ppos..eppos+1).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: use: `ppos..=eppos` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/private.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | value.trunc() != (value + 0.0000000001f64).trunc() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(value.trunc() - (value + 0.0000000001f64).trunc()).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/private.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | value.trunc() != (value + 0.0000000001f64).trunc() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/interface.rs:61:42 [INFO] [stderr] | [INFO] [stderr] 61 | let padding: String = code.drain(ppos..eppos+1).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: use: `ppos..=eppos` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `open-location-code`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `open-location-code`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "536ab88e2f3f7e570000883b6db7894d378239b15c5f3a6e966f830917c1019b"` [INFO] running `"docker" "rm" "-f" "536ab88e2f3f7e570000883b6db7894d378239b15c5f3a6e966f830917c1019b"` [INFO] [stdout] 536ab88e2f3f7e570000883b6db7894d378239b15c5f3a6e966f830917c1019b