[INFO] crate opcua-types 0.5.0 is already in cache [INFO] extracting crate opcua-types 0.5.0 into work/ex/clippy-test-run/sources/stable/reg/opcua-types/0.5.0 [INFO] extracting crate opcua-types 0.5.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/opcua-types/0.5.0 [INFO] validating manifest of opcua-types-0.5.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of opcua-types-0.5.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing opcua-types-0.5.0 [INFO] finished frobbing opcua-types-0.5.0 [INFO] frobbed toml for opcua-types-0.5.0 written to work/ex/clippy-test-run/sources/stable/reg/opcua-types/0.5.0/Cargo.toml [INFO] started frobbing opcua-types-0.5.0 [INFO] finished frobbing opcua-types-0.5.0 [INFO] frobbed toml for opcua-types-0.5.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/opcua-types/0.5.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting opcua-types-0.5.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/opcua-types/0.5.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 94044f2a2c973f489446aa4ac6177ea3670b336ff664ebf087ce4631f23bcefe [INFO] running `"docker" "start" "-a" "94044f2a2c973f489446aa4ac6177ea3670b336ff664ebf087ce4631f23bcefe"` [INFO] [stderr] Checking opcua-types v0.5.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/numeric_range.rs:52:44 [INFO] [stderr] | [INFO] [stderr] 52 | ("0123456789", NumericRange::Index(123456789), "123456789"), [INFO] [stderr] | ^^^^^^^^^ help: consider: `123_456_789` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/numeric_range.rs:53:44 [INFO] [stderr] | [INFO] [stderr] 53 | ("4294967295", NumericRange::Index(4294967295), "4294967295"), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_294_967_295` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests/encoding.rs:52:21 [INFO] [stderr] | [INFO] [stderr] 52 | serialize_test(-17444000 as i32); [INFO] [stderr] | ^^^^^^^^ help: consider: `17_444_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests/encoding.rs:53:20 [INFO] [stderr] | [INFO] [stderr] 53 | serialize_test(32004440 as i32); [INFO] [stderr] | ^^^^^^^^ help: consider: `32_004_440` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests/encoding.rs:60:20 [INFO] [stderr] | [INFO] [stderr] 60 | serialize_test(57055500 as u32); [INFO] [stderr] | ^^^^^^^^ help: consider: `57_055_500` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests/encoding.rs:61:20 [INFO] [stderr] | [INFO] [stderr] 61 | serialize_test(32555000 as u32); [INFO] [stderr] | ^^^^^^^^ help: consider: `32_555_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests/encoding.rs:67:21 [INFO] [stderr] | [INFO] [stderr] 67 | serialize_test(-17442224000 as i64); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `17_442_224_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests/encoding.rs:68:20 [INFO] [stderr] | [INFO] [stderr] 68 | serialize_test(32022204440 as i64); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `32_022_204_440` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests/encoding.rs:75:20 [INFO] [stderr] | [INFO] [stderr] 75 | serialize_test(57054445500 as u64); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `57_054_445_500` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests/encoding.rs:76:20 [INFO] [stderr] | [INFO] [stderr] 76 | serialize_test(34442555000 as u64); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `34_442_555_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests/encoding.rs:89:20 [INFO] [stderr] | [INFO] [stderr] 89 | serialize_test(12.43424324234 as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `12.434_243_242_34` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests/encoding.rs:90:20 [INFO] [stderr] | [INFO] [stderr] 90 | serialize_test(5686.222342342 as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `5_686.222_342_342` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests/encoding.rs:183:34 [INFO] [stderr] | [INFO] [stderr] 183 | let node_id = NodeId::new(1, 0xdeadbeef as u32); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xdead_beef` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests/encoding.rs:314:29 [INFO] [stderr] | [INFO] [stderr] 314 | let v = Variant::Int32(-9999999); [INFO] [stderr] | ^^^^^^^ help: consider: `9_999_999` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests/encoding.rs:317:29 [INFO] [stderr] | [INFO] [stderr] 317 | let v = Variant::UInt32(24424244); [INFO] [stderr] | ^^^^^^^^ help: consider: `24_424_244` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests/encoding.rs:320:29 [INFO] [stderr] | [INFO] [stderr] 320 | let v = Variant::Int64(-384747424424244); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `384_747_424_424_244` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests/encoding.rs:323:29 [INFO] [stderr] | [INFO] [stderr] 323 | let v = Variant::UInt64(9384747424422314244); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `9_384_747_424_422_314_244` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests/encoding.rs:432:29 [INFO] [stderr] | [INFO] [stderr] 432 | namespace_uri: Some(437437), [INFO] [stderr] | ^^^^^^ help: consider: `437_437` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: slow zero-filling initialization [INFO] [stderr] --> src/string.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 66 | let mut buf: Vec = Vec::with_capacity(len as usize); [INFO] [stderr] | -------------------------------- help: consider replace allocation with: `vec![0; len as usize]` [INFO] [stderr] 67 | buf.resize(len as usize, 0u8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::slow_vector_initialization)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#slow_vector_initialization [INFO] [stderr] [INFO] [stderr] warning: slow zero-filling initialization [INFO] [stderr] --> src/byte_string.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 57 | let mut buf: Vec = Vec::with_capacity(len as usize); [INFO] [stderr] | -------------------------------- help: consider replace allocation with: `vec![0; len as usize]` [INFO] [stderr] 58 | buf.resize(len as usize, 0u8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#slow_vector_initialization [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/date_time.rs:97:12 [INFO] [stderr] | [INFO] [stderr] 97 | if nanos as i64 >= NANOS_PER_SECOND { [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(nanos)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/date_time.rs:100:26 [INFO] [stderr] | [INFO] [stderr] 100 | let dt = Utc.ymd(year as i32, month as u32, day as u32) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(year)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/date_time.rs:100:39 [INFO] [stderr] | [INFO] [stderr] 100 | let dt = Utc.ymd(year as i32, month as u32, day as u32) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(month)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/date_time.rs:100:53 [INFO] [stderr] | [INFO] [stderr] 100 | let dt = Utc.ymd(year as i32, month as u32, day as u32) [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(day)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/date_time.rs:101:27 [INFO] [stderr] | [INFO] [stderr] 101 | .and_hms_nano(hour as u32, minute as u32, second as u32, nanos); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(hour)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/date_time.rs:101:40 [INFO] [stderr] | [INFO] [stderr] 101 | .and_hms_nano(hour as u32, minute as u32, second as u32, nanos); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(minute)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/date_time.rs:101:55 [INFO] [stderr] | [INFO] [stderr] 101 | .and_hms_nano(hour as u32, minute as u32, second as u32, nanos); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(second)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/date_time.rs:221:17 [INFO] [stderr] | [INFO] [stderr] 221 | Utc.ymd(MIN_YEAR as i32, 1, 1).and_hms(0, 0, 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i32::from(MIN_YEAR)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/date_time.rs:227:17 [INFO] [stderr] | [INFO] [stderr] 227 | Utc.ymd(MAX_YEAR as i32, 12, 31).and_hms(23, 59, 59) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i32::from(MAX_YEAR)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/variant.rs:56:23 [INFO] [stderr] | [INFO] [stderr] 56 | pub fn is_numeric(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/variant.rs:793:43 [INFO] [stderr] | [INFO] [stderr] 793 | Variant::SByte(value) => Some(value as f64), [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/variant.rs:794:42 [INFO] [stderr] | [INFO] [stderr] 794 | Variant::Byte(value) => Some(value as f64), [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/variant.rs:795:43 [INFO] [stderr] | [INFO] [stderr] 795 | Variant::Int16(value) => Some(value as f64), [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/variant.rs:796:44 [INFO] [stderr] | [INFO] [stderr] 796 | Variant::UInt16(value) => Some(value as f64), [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/variant.rs:797:43 [INFO] [stderr] | [INFO] [stderr] 797 | Variant::Int32(value) => Some(value as f64), [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/variant.rs:798:44 [INFO] [stderr] | [INFO] [stderr] 798 | Variant::UInt32(value) => Some(value as f64), [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/variant.rs:807:43 [INFO] [stderr] | [INFO] [stderr] 807 | Variant::Float(value) => Some(value as f64), [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name [INFO] [stderr] --> src/variant.rs:831:27 [INFO] [stderr] | [INFO] [stderr] 831 | pub fn into_u32_array(&self) -> Result, StatusCode> { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/variant.rs:839:57 [INFO] [stderr] | [INFO] [stderr] 839 | Variant::Byte(ref value) => *value as u32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(*value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/variant.rs:841:59 [INFO] [stderr] | [INFO] [stderr] 841 | Variant::UInt16(ref value) => *value as u32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(*value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/supported_message.rs:27:21 [INFO] [stderr] | [INFO] [stderr] 27 | $( $x($x), )* [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 296 | / supported_messages_enum![ [INFO] [stderr] 297 | | ServiceFault, [INFO] [stderr] 298 | | OpenSecureChannelRequest, [INFO] [stderr] 299 | | OpenSecureChannelResponse, [INFO] [stderr] ... | [INFO] [stderr] 345 | | CallResponse, [INFO] [stderr] 346 | | ]; [INFO] [stderr] | |__- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 27 | $( $x(Box<$x>), )* [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/numeric_range.rs:119:45 [INFO] [stderr] | [INFO] [stderr] 119 | } else if parts.len() > MAX_INDICES { [INFO] [stderr] | _____________________________________________^ [INFO] [stderr] 120 | | // More than MAX_INDICES really? [INFO] [stderr] 121 | | Err(()) [INFO] [stderr] 122 | | } else if parts.len() > 1 { [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/numeric_range.rs:117:29 [INFO] [stderr] | [INFO] [stderr] 117 | if parts.is_empty() { [INFO] [stderr] | _____________________________^ [INFO] [stderr] 118 | | Err(()) [INFO] [stderr] 119 | | } else if parts.len() > MAX_INDICES { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: slow zero-filling initialization [INFO] [stderr] --> src/string.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 66 | let mut buf: Vec = Vec::with_capacity(len as usize); [INFO] [stderr] | -------------------------------- help: consider replace allocation with: `vec![0; len as usize]` [INFO] [stderr] 67 | buf.resize(len as usize, 0u8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::slow_vector_initialization)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#slow_vector_initialization [INFO] [stderr] [INFO] [stderr] warning: slow zero-filling initialization [INFO] [stderr] --> src/byte_string.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 57 | let mut buf: Vec = Vec::with_capacity(len as usize); [INFO] [stderr] | -------------------------------- help: consider replace allocation with: `vec![0; len as usize]` [INFO] [stderr] 58 | buf.resize(len as usize, 0u8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#slow_vector_initialization [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/date_time.rs:97:12 [INFO] [stderr] | [INFO] [stderr] 97 | if nanos as i64 >= NANOS_PER_SECOND { [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(nanos)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/date_time.rs:100:26 [INFO] [stderr] | [INFO] [stderr] 100 | let dt = Utc.ymd(year as i32, month as u32, day as u32) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(year)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/date_time.rs:100:39 [INFO] [stderr] | [INFO] [stderr] 100 | let dt = Utc.ymd(year as i32, month as u32, day as u32) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(month)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/date_time.rs:100:53 [INFO] [stderr] | [INFO] [stderr] 100 | let dt = Utc.ymd(year as i32, month as u32, day as u32) [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(day)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/date_time.rs:101:27 [INFO] [stderr] | [INFO] [stderr] 101 | .and_hms_nano(hour as u32, minute as u32, second as u32, nanos); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(hour)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/date_time.rs:101:40 [INFO] [stderr] | [INFO] [stderr] 101 | .and_hms_nano(hour as u32, minute as u32, second as u32, nanos); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(minute)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/date_time.rs:101:55 [INFO] [stderr] | [INFO] [stderr] 101 | .and_hms_nano(hour as u32, minute as u32, second as u32, nanos); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(second)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/date_time.rs:221:17 [INFO] [stderr] | [INFO] [stderr] 221 | Utc.ymd(MIN_YEAR as i32, 1, 1).and_hms(0, 0, 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i32::from(MIN_YEAR)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/date_time.rs:227:17 [INFO] [stderr] | [INFO] [stderr] 227 | Utc.ymd(MAX_YEAR as i32, 12, 31).and_hms(23, 59, 59) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i32::from(MAX_YEAR)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/variant.rs:56:23 [INFO] [stderr] | [INFO] [stderr] 56 | pub fn is_numeric(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/variant.rs:793:43 [INFO] [stderr] | [INFO] [stderr] 793 | Variant::SByte(value) => Some(value as f64), [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/variant.rs:794:42 [INFO] [stderr] | [INFO] [stderr] 794 | Variant::Byte(value) => Some(value as f64), [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/variant.rs:795:43 [INFO] [stderr] | [INFO] [stderr] 795 | Variant::Int16(value) => Some(value as f64), [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/variant.rs:796:44 [INFO] [stderr] | [INFO] [stderr] 796 | Variant::UInt16(value) => Some(value as f64), [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/variant.rs:797:43 [INFO] [stderr] | [INFO] [stderr] 797 | Variant::Int32(value) => Some(value as f64), [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/variant.rs:798:44 [INFO] [stderr] | [INFO] [stderr] 798 | Variant::UInt32(value) => Some(value as f64), [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/variant.rs:807:43 [INFO] [stderr] | [INFO] [stderr] 807 | Variant::Float(value) => Some(value as f64), [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name [INFO] [stderr] --> src/variant.rs:831:27 [INFO] [stderr] | [INFO] [stderr] 831 | pub fn into_u32_array(&self) -> Result, StatusCode> { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/variant.rs:839:57 [INFO] [stderr] | [INFO] [stderr] 839 | Variant::Byte(ref value) => *value as u32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(*value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/variant.rs:841:59 [INFO] [stderr] | [INFO] [stderr] 841 | Variant::UInt16(ref value) => *value as u32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(*value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/supported_message.rs:27:21 [INFO] [stderr] | [INFO] [stderr] 27 | $( $x($x), )* [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 296 | / supported_messages_enum![ [INFO] [stderr] 297 | | ServiceFault, [INFO] [stderr] 298 | | OpenSecureChannelRequest, [INFO] [stderr] 299 | | OpenSecureChannelResponse, [INFO] [stderr] ... | [INFO] [stderr] 345 | | CallResponse, [INFO] [stderr] 346 | | ]; [INFO] [stderr] | |__- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 27 | $( $x(Box<$x>), )* [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/numeric_range.rs:119:45 [INFO] [stderr] | [INFO] [stderr] 119 | } else if parts.len() > MAX_INDICES { [INFO] [stderr] | _____________________________________________^ [INFO] [stderr] 120 | | // More than MAX_INDICES really? [INFO] [stderr] 121 | | Err(()) [INFO] [stderr] 122 | | } else if parts.len() > 1 { [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/numeric_range.rs:117:29 [INFO] [stderr] | [INFO] [stderr] 117 | if parts.is_empty() { [INFO] [stderr] | _____________________________^ [INFO] [stderr] 118 | | Err(()) [INFO] [stderr] 119 | | } else if parts.len() > MAX_INDICES { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `opcua-types`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/tests/encoding.rs:88:20 [INFO] [stderr] | [INFO] [stderr] 88 | serialize_test(0 as f64); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `opcua-types`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "94044f2a2c973f489446aa4ac6177ea3670b336ff664ebf087ce4631f23bcefe"` [INFO] running `"docker" "rm" "-f" "94044f2a2c973f489446aa4ac6177ea3670b336ff664ebf087ce4631f23bcefe"` [INFO] [stdout] 94044f2a2c973f489446aa4ac6177ea3670b336ff664ebf087ce4631f23bcefe