[INFO] crate opcua-client 0.5.0 is already in cache
[INFO] extracting crate opcua-client 0.5.0 into work/ex/clippy-test-run/sources/stable/reg/opcua-client/0.5.0
[INFO] extracting crate opcua-client 0.5.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/opcua-client/0.5.0
[INFO] validating manifest of opcua-client-0.5.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of opcua-client-0.5.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing opcua-client-0.5.0
[INFO] finished frobbing opcua-client-0.5.0
[INFO] frobbed toml for opcua-client-0.5.0 written to work/ex/clippy-test-run/sources/stable/reg/opcua-client/0.5.0/Cargo.toml
[INFO] started frobbing opcua-client-0.5.0
[INFO] finished frobbing opcua-client-0.5.0
[INFO] frobbed toml for opcua-client-0.5.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/opcua-client/0.5.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting opcua-client-0.5.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/opcua-client/0.5.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] d055d91644bbb7252cf7bcb8d6b31adb179eae3c9fa50964a9c567adbeb3fb93
[INFO] running `"docker" "start" "-a" "d055d91644bbb7252cf7bcb8d6b31adb179eae3c9fa50964a9c567adbeb3fb93"`
[INFO] [stderr]     Checking opcua-types v0.5.0
[INFO] [stderr]     Checking opcua-core v0.5.0
[INFO] [stderr]     Checking opcua-client v0.5.0 (/opt/crater/workdir)
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/session_state.rs:189:9
[INFO] [stderr]     |
[INFO] [stderr] 189 |         request_header
[INFO] [stderr]     |         ^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/session_state.rs:180:30
[INFO] [stderr]     |
[INFO] [stderr] 180 |           let request_header = RequestHeader {
[INFO] [stderr]     |  ______________________________^
[INFO] [stderr] 181 | |             authentication_token: self.authentication_token.clone(),
[INFO] [stderr] 182 | |             timestamp: DateTime::now(),
[INFO] [stderr] 183 | |             request_handle: self.request_handle.next(),
[INFO] [stderr] ...   |
[INFO] [stderr] 187 | |             additional_header: ExtensionObject::null(),
[INFO] [stderr] 188 | |         };
[INFO] [stderr]     | |_________^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/session_state.rs:189:9
[INFO] [stderr]     |
[INFO] [stderr] 189 |         request_header
[INFO] [stderr]     |         ^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/session_state.rs:180:30
[INFO] [stderr]     |
[INFO] [stderr] 180 |           let request_header = RequestHeader {
[INFO] [stderr]     |  ______________________________^
[INFO] [stderr] 181 | |             authentication_token: self.authentication_token.clone(),
[INFO] [stderr] 182 | |             timestamp: DateTime::now(),
[INFO] [stderr] 183 | |             request_handle: self.request_handle.next(),
[INFO] [stderr] ...   |
[INFO] [stderr] 187 | |             additional_header: ExtensionObject::null(),
[INFO] [stderr] 188 | |         };
[INFO] [stderr]     | |_________^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `session`
[INFO] [stderr]   --> src/client.rs:26:5
[INFO] [stderr]    |
[INFO] [stderr] 26 |     session: Arc<RwLock<Session>>,
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `session`
[INFO] [stderr]   --> src/client.rs:26:5
[INFO] [stderr]    |
[INFO] [stderr] 26 |     session: Arc<RwLock<Session>>,
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `set_last_attempt`
[INFO] [stderr]   --> src/session_retry.rs:46:5
[INFO] [stderr]    |
[INFO] [stderr] 46 |     pub fn set_last_attempt(&mut self, last_attempt: DateTime<Utc>) {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/comms/tcp_transport.rs:72:61
[INFO] [stderr]    |
[INFO] [stderr] 72 |     fn turn_received_chunks_into_message(&mut self, chunks: &Vec<MessageChunk>) -> Result<SupportedMessage, StatusCode> {
[INFO] [stderr]    |                                                             ^^^^^^^^^^^^^^^^^^ help: change this to: `&[MessageChunk]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/comms/tcp_transport.rs:72:61
[INFO] [stderr]    |
[INFO] [stderr] 72 |     fn turn_received_chunks_into_message(&mut self, chunks: &Vec<MessageChunk>) -> Result<SupportedMessage, StatusCode> {
[INFO] [stderr]    |                                                             ^^^^^^^^^^^^^^^^^^ help: change this to: `&[MessageChunk]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: The function/method `write` doesn't need a mutable reference
[INFO] [stderr]    --> src/comms/tcp_transport.rs:132:61
[INFO] [stderr]     |
[INFO] [stderr] 132 |                 self.send_buffer.write(request_id, request, &mut secure_channel)
[INFO] [stderr]     |                                                             ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unnecessary_mut_passed)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stderr] 
[INFO] [stderr] warning: The function/method `write` doesn't need a mutable reference
[INFO] [stderr]    --> src/comms/tcp_transport.rs:132:61
[INFO] [stderr]     |
[INFO] [stderr] 132 |                 self.send_buffer.write(request_id, request, &mut secure_channel)
[INFO] [stderr]     |                                                             ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unnecessary_mut_passed)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stderr] 
[INFO] [stderr] warning: this function has too many arguments (8/7)
[INFO] [stderr]    --> src/subscription.rs:146:5
[INFO] [stderr]     |
[INFO] [stderr] 146 | /     pub fn new(subscription_id: u32, publishing_interval: f64, lifetime_count: u32, max_keep_alive_count: u32, max_notifications_per_publish: u32,
[INFO] [stderr] 147 | |                publishing_enabled: bool, priority: u8, data_change_callback: Arc<Mutex<dyn OnDataChange + Send + Sync + 'static>>)
[INFO] [stderr] 148 | |                -> Subscription
[INFO] [stderr] 149 | |     {
[INFO] [stderr] ...   |
[INFO] [stderr] 161 | |         }
[INFO] [stderr] 162 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::too_many_arguments)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice
[INFO] [stderr]    --> src/subscription.rs:200:25
[INFO] [stderr]     |
[INFO] [stderr] 200 |         items_to_modify.into_iter().for_each(|i| {
[INFO] [stderr]     |                         ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::into_iter_on_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/subscription.rs:247:27
[INFO] [stderr]     |
[INFO] [stderr] 247 |                 .map(|id| self.monitored_items.get(&id).unwrap()).collect();
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.monitored_items[&id]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/subscription_state.rs:28:18
[INFO] [stderr]    |
[INFO] [stderr] 28 |             Some(self.subscriptions.keys().map(|k| *k).collect())
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.subscriptions.keys().cloned()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: this function has too many arguments (8/7)
[INFO] [stderr]    --> src/subscription.rs:146:5
[INFO] [stderr]     |
[INFO] [stderr] 146 | /     pub fn new(subscription_id: u32, publishing_interval: f64, lifetime_count: u32, max_keep_alive_count: u32, max_notifications_per_publish: u32,
[INFO] [stderr] 147 | |                publishing_enabled: bool, priority: u8, data_change_callback: Arc<Mutex<dyn OnDataChange + Send + Sync + 'static>>)
[INFO] [stderr] 148 | |                -> Subscription
[INFO] [stderr] 149 | |     {
[INFO] [stderr] ...   |
[INFO] [stderr] 161 | |         }
[INFO] [stderr] 162 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::too_many_arguments)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice
[INFO] [stderr]    --> src/subscription.rs:200:25
[INFO] [stderr]     |
[INFO] [stderr] 200 |         items_to_modify.into_iter().for_each(|i| {
[INFO] [stderr]     |                         ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::into_iter_on_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/subscription.rs:247:27
[INFO] [stderr]     |
[INFO] [stderr] 247 |                 .map(|id| self.monitored_items.get(&id).unwrap()).collect();
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.monitored_items[&id]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/subscription_state.rs:28:18
[INFO] [stderr]    |
[INFO] [stderr] 28 |             Some(self.subscriptions.keys().map(|k| *k).collect())
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.subscriptions.keys().cloned()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change
[INFO] [stderr]    --> src/session_state.rs:253:59
[INFO] [stderr]     |
[INFO] [stderr] 253 |                 if request_duration.num_milliseconds() >= request_timeout as i64 {
[INFO] [stderr]     |                                                           ^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(request_timeout)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change
[INFO] [stderr]    --> src/session_state.rs:253:59
[INFO] [stderr]     |
[INFO] [stderr] 253 |                 if request_duration.num_milliseconds() >= request_timeout as i64 {
[INFO] [stderr]     |                                                           ^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(request_timeout)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/config.rs:96:9
[INFO] [stderr]     |
[INFO] [stderr] 96  | /         let mut valid = true;
[INFO] [stderr] 97  | | 
[INFO] [stderr] 98  | |         if self.application_name.is_empty() {
[INFO] [stderr] 99  | |             error!("Application name is empty");
[INFO] [stderr] 100 | |             valid = false;
[INFO] [stderr] 101 | |         }
[INFO] [stderr]     | |_________^ help: it is more idiomatic to write: `let <mut> valid = if self.application_name.is_empty() { ..; false } else { true };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/client.rs:170:17
[INFO] [stderr]     |
[INFO] [stderr] 170 |             Err(format!("No default endpoint has been specified"))
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"No default endpoint has been specified".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]    --> src/client.rs:290:9
[INFO] [stderr]     |
[INFO] [stderr] 290 |         let _ = session.connect()?;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_unit_value)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]    --> src/client.rs:292:9
[INFO] [stderr]     |
[INFO] [stderr] 292 |         let _ = session.disconnect();
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()`
[INFO] [stderr]    --> src/client.rs:312:20
[INFO] [stderr]     |
[INFO] [stderr] 312 |               if let Ok(_) = connected {
[INFO] [stderr]     |  _____________-      ^^^^^
[INFO] [stderr] 313 | |                 // Find me some some servers
[INFO] [stderr] 314 | |                 let servers = session.find_servers(discovery_endpoint_url.clone());
[INFO] [stderr] 315 | |                 let result = if let Ok(servers) = servers {
[INFO] [stderr] ...   |
[INFO] [stderr] 327 | |                 Err(result)
[INFO] [stderr] 328 | |             }
[INFO] [stderr]     | |_____________- help: try this: `if connected.is_ok()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]    --> src/client.rs:322:17
[INFO] [stderr]     |
[INFO] [stderr] 322 |                 let _ = session.disconnect();
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()`
[INFO] [stderr]    --> src/client.rs:367:28
[INFO] [stderr]     |
[INFO] [stderr] 367 |                       if let Ok(_) = connected {
[INFO] [stderr]     |  _____________________-      ^^^^^
[INFO] [stderr] 368 | |                         // Register with the server
[INFO] [stderr] 369 | |                         let result = session.register_server(server);
[INFO] [stderr] 370 | |                         let _ = session.disconnect();
[INFO] [stderr] ...   |
[INFO] [stderr] 375 | |                         Err(result)
[INFO] [stderr] 376 | |                     }
[INFO] [stderr]     | |_____________________- help: try this: `if connected.is_ok()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]    --> src/client.rs:370:25
[INFO] [stderr]     |
[INFO] [stderr] 370 |                         let _ = session.disconnect();
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/client.rs:414:22
[INFO] [stderr]     |
[INFO] [stderr] 414 |           let result = endpoints.iter().find(|e| {
[INFO] [stderr]     |  ______________________^
[INFO] [stderr] 415 | |             e.security_mode == security_mode &&
[INFO] [stderr] 416 | |                 e.security_policy_uri.as_ref() == security_policy_uri &&
[INFO] [stderr] 417 | |                 url_matches(e.endpoint_url.as_ref(), &endpoint_url)
[INFO] [stderr] 418 | |         }).map(|e| e.clone());
[INFO] [stderr]     | |_____________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] help: Consider calling the dedicated `cloned` method
[INFO] [stderr]     |
[INFO] [stderr] 414 |         let result = endpoints.iter().find(|e| {
[INFO] [stderr] 415 |             e.security_mode == security_mode &&
[INFO] [stderr] 416 |                 e.security_policy_uri.as_ref() == security_policy_uri &&
[INFO] [stderr] 417 |                 url_matches(e.endpoint_url.as_ref(), &endpoint_url)
[INFO] [stderr] 418 |         }).cloned();
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/client.rs:424:13
[INFO] [stderr]     |
[INFO] [stderr] 424 | /             endpoints.iter().find(|e| {
[INFO] [stderr] 425 | |                 e.security_mode == security_mode &&
[INFO] [stderr] 426 | |                     e.security_policy_uri.as_ref() == security_policy_uri &&
[INFO] [stderr] 427 | |                     url_matches_except_host(e.endpoint_url.as_ref(), &endpoint_url)
[INFO] [stderr] 428 | |             }).map(|e| e.clone())
[INFO] [stderr]     | |_________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] help: Consider calling the dedicated `cloned` method
[INFO] [stderr]     |
[INFO] [stderr] 424 |             endpoints.iter().find(|e| {
[INFO] [stderr] 425 |                 e.security_mode == security_mode &&
[INFO] [stderr] 426 |                     e.security_policy_uri.as_ref() == security_policy_uri &&
[INFO] [stderr] 427 |                     url_matches_except_host(e.endpoint_url.as_ref(), &endpoint_url)
[INFO] [stderr] 428 |             }).cloned()
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/config.rs:96:9
[INFO] [stderr]     |
[INFO] [stderr] 96  | /         let mut valid = true;
[INFO] [stderr] 97  | | 
[INFO] [stderr] 98  | |         if self.application_name.is_empty() {
[INFO] [stderr] 99  | |             error!("Application name is empty");
[INFO] [stderr] 100 | |             valid = false;
[INFO] [stderr] 101 | |         }
[INFO] [stderr]     | |_________^ help: it is more idiomatic to write: `let <mut> valid = if self.application_name.is_empty() { ..; false } else { true };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/client.rs:467:9
[INFO] [stderr]     |
[INFO] [stderr] 467 | /         endpoints.iter().find(|e| {
[INFO] [stderr] 468 | |             // Endpoint matches if the security mode, policy and url match
[INFO] [stderr] 469 | |             security_mode == e.security_mode &&
[INFO] [stderr] 470 | |                 security_policy == SecurityPolicy::from_uri(e.security_policy_uri.as_ref()) &&
[INFO] [stderr] 471 | |                 url_matches_except_host(&endpoint_url, e.endpoint_url.as_ref())
[INFO] [stderr] 472 | |         }).map(|e| e.clone())
[INFO] [stderr]     | |_____________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] help: Consider calling the dedicated `cloned` method
[INFO] [stderr]     |
[INFO] [stderr] 467 |         endpoints.iter().find(|e| {
[INFO] [stderr] 468 |             // Endpoint matches if the security mode, policy and url match
[INFO] [stderr] 469 |             security_mode == e.security_mode &&
[INFO] [stderr] 470 |                 security_policy == SecurityPolicy::from_uri(e.security_policy_uri.as_ref()) &&
[INFO] [stderr] 471 |                 url_matches_except_host(&endpoint_url, e.endpoint_url.as_ref())
[INFO] [stderr] 472 |         }).cloned()
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/client.rs:170:17
[INFO] [stderr]     |
[INFO] [stderr] 170 |             Err(format!("No default endpoint has been specified"))
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"No default endpoint has been specified".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]    --> src/client.rs:290:9
[INFO] [stderr]     |
[INFO] [stderr] 290 |         let _ = session.connect()?;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_unit_value)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]    --> src/client.rs:292:9
[INFO] [stderr]     |
[INFO] [stderr] 292 |         let _ = session.disconnect();
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/session.rs:308:28
[INFO] [stderr]     |
[INFO] [stderr] 308 |         let endpoint_url = UAString::from(self.session_info.endpoint.endpoint_url.clone());
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `UAString::from()`: `self.session_info.endpoint.endpoint_url.clone()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()`
[INFO] [stderr]    --> src/client.rs:312:20
[INFO] [stderr]     |
[INFO] [stderr] 312 |               if let Ok(_) = connected {
[INFO] [stderr]     |  _____________-      ^^^^^
[INFO] [stderr] 313 | |                 // Find me some some servers
[INFO] [stderr] 314 | |                 let servers = session.find_servers(discovery_endpoint_url.clone());
[INFO] [stderr] 315 | |                 let result = if let Ok(servers) = servers {
[INFO] [stderr] ...   |
[INFO] [stderr] 327 | |                 Err(result)
[INFO] [stderr] 328 | |             }
[INFO] [stderr]     | |_____________- help: try this: `if connected.is_ok()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]    --> src/client.rs:322:17
[INFO] [stderr]     |
[INFO] [stderr] 322 |                 let _ = session.disconnect();
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()`
[INFO] [stderr]    --> src/client.rs:367:28
[INFO] [stderr]     |
[INFO] [stderr] 367 |                       if let Ok(_) = connected {
[INFO] [stderr]     |  _____________________-      ^^^^^
[INFO] [stderr] 368 | |                         // Register with the server
[INFO] [stderr] 369 | |                         let result = session.register_server(server);
[INFO] [stderr] 370 | |                         let _ = session.disconnect();
[INFO] [stderr] ...   |
[INFO] [stderr] 375 | |                         Err(result)
[INFO] [stderr] 376 | |                     }
[INFO] [stderr]     | |_____________________- help: try this: `if connected.is_ok()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]    --> src/client.rs:370:25
[INFO] [stderr]     |
[INFO] [stderr] 370 |                         let _ = session.disconnect();
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/client.rs:414:22
[INFO] [stderr]     |
[INFO] [stderr] 414 |           let result = endpoints.iter().find(|e| {
[INFO] [stderr]     |  ______________________^
[INFO] [stderr] 415 | |             e.security_mode == security_mode &&
[INFO] [stderr] 416 | |                 e.security_policy_uri.as_ref() == security_policy_uri &&
[INFO] [stderr] 417 | |                 url_matches(e.endpoint_url.as_ref(), &endpoint_url)
[INFO] [stderr] 418 | |         }).map(|e| e.clone());
[INFO] [stderr]     | |_____________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] help: Consider calling the dedicated `cloned` method
[INFO] [stderr]     |
[INFO] [stderr] 414 |         let result = endpoints.iter().find(|e| {
[INFO] [stderr] 415 |             e.security_mode == security_mode &&
[INFO] [stderr] 416 |                 e.security_policy_uri.as_ref() == security_policy_uri &&
[INFO] [stderr] 417 |                 url_matches(e.endpoint_url.as_ref(), &endpoint_url)
[INFO] [stderr] 418 |         }).cloned();
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/client.rs:424:13
[INFO] [stderr]     |
[INFO] [stderr] 424 | /             endpoints.iter().find(|e| {
[INFO] [stderr] 425 | |                 e.security_mode == security_mode &&
[INFO] [stderr] 426 | |                     e.security_policy_uri.as_ref() == security_policy_uri &&
[INFO] [stderr] 427 | |                     url_matches_except_host(e.endpoint_url.as_ref(), &endpoint_url)
[INFO] [stderr] 428 | |             }).map(|e| e.clone())
[INFO] [stderr]     | |_________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] help: Consider calling the dedicated `cloned` method
[INFO] [stderr]     |
[INFO] [stderr] 424 |             endpoints.iter().find(|e| {
[INFO] [stderr] 425 |                 e.security_mode == security_mode &&
[INFO] [stderr] 426 |                     e.security_policy_uri.as_ref() == security_policy_uri &&
[INFO] [stderr] 427 |                     url_matches_except_host(e.endpoint_url.as_ref(), &endpoint_url)
[INFO] [stderr] 428 |             }).cloned()
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/client.rs:467:9
[INFO] [stderr]     |
[INFO] [stderr] 467 | /         endpoints.iter().find(|e| {
[INFO] [stderr] 468 | |             // Endpoint matches if the security mode, policy and url match
[INFO] [stderr] 469 | |             security_mode == e.security_mode &&
[INFO] [stderr] 470 | |                 security_policy == SecurityPolicy::from_uri(e.security_policy_uri.as_ref()) &&
[INFO] [stderr] 471 | |                 url_matches_except_host(&endpoint_url, e.endpoint_url.as_ref())
[INFO] [stderr] 472 | |         }).map(|e| e.clone())
[INFO] [stderr]     | |_____________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] help: Consider calling the dedicated `cloned` method
[INFO] [stderr]     |
[INFO] [stderr] 467 |         endpoints.iter().find(|e| {
[INFO] [stderr] 468 |             // Endpoint matches if the security mode, policy and url match
[INFO] [stderr] 469 |             security_mode == e.security_mode &&
[INFO] [stderr] 470 |                 security_policy == SecurityPolicy::from_uri(e.security_policy_uri.as_ref()) &&
[INFO] [stderr] 471 |                 url_matches_except_host(&endpoint_url, e.endpoint_url.as_ref())
[INFO] [stderr] 472 |         }).cloned()
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this function has too many arguments (8/7)
[INFO] [stderr]    --> src/session.rs:635:5
[INFO] [stderr]     |
[INFO] [stderr] 635 | /     pub fn create_subscription<CB>(&mut self, publishing_interval: f64, lifetime_count: u32, max_keep_alive_count: u32, max_notifications_per_publish: u32, priority: u8, publishing_enabled: bool, callback: CB)
[INFO] [stderr] 636 | |                                    -> Result<u32, StatusCode>
[INFO] [stderr] 637 | |         where CB: OnDataChange + Send + Sync + 'static {
[INFO] [stderr] 638 | |         self.create_subscription_inner(publishing_interval, lifetime_count, max_keep_alive_count, max_notifications_per_publish, priority, publishing_enabled, Arc::new(Mutex::new(callback)))
[INFO] [stderr] 639 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stderr] 
[INFO] [stderr] warning: this function has too many arguments (8/7)
[INFO] [stderr]    --> src/session.rs:642:5
[INFO] [stderr]     |
[INFO] [stderr] 642 | /     fn create_subscription_inner(&mut self, publishing_interval: f64, lifetime_count: u32, max_keep_alive_count: u32, max_notifications_per_publish: u32, priority: u8, publishing_enabled: bool,
[INFO] [stderr] 643 | |                                  callback: Arc<Mutex<dyn OnDataChange + Send + Sync + 'static>>)
[INFO] [stderr] 644 | |                                  -> Result<u32, StatusCode>
[INFO] [stderr] 645 | |     {
[INFO] [stderr] ...   |
[INFO] [stderr] 682 | |         }
[INFO] [stderr] 683 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/session.rs:308:28
[INFO] [stderr]     |
[INFO] [stderr] 308 |         let endpoint_url = UAString::from(self.session_info.endpoint.endpoint_url.clone());
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `UAString::from()`: `self.session_info.endpoint.endpoint_url.clone()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: this function has too many arguments (8/7)
[INFO] [stderr]    --> src/session.rs:635:5
[INFO] [stderr]     |
[INFO] [stderr] 635 | /     pub fn create_subscription<CB>(&mut self, publishing_interval: f64, lifetime_count: u32, max_keep_alive_count: u32, max_notifications_per_publish: u32, priority: u8, publishing_enabled: bool, callback: CB)
[INFO] [stderr] 636 | |                                    -> Result<u32, StatusCode>
[INFO] [stderr] 637 | |         where CB: OnDataChange + Send + Sync + 'static {
[INFO] [stderr] 638 | |         self.create_subscription_inner(publishing_interval, lifetime_count, max_keep_alive_count, max_notifications_per_publish, priority, publishing_enabled, Arc::new(Mutex::new(callback)))
[INFO] [stderr] 639 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stderr] 
[INFO] [stderr] warning: this function has too many arguments (8/7)
[INFO] [stderr]    --> src/session.rs:642:5
[INFO] [stderr]     |
[INFO] [stderr] 642 | /     fn create_subscription_inner(&mut self, publishing_interval: f64, lifetime_count: u32, max_keep_alive_count: u32, max_notifications_per_publish: u32, priority: u8, publishing_enabled: bool,
[INFO] [stderr] 643 | |                                  callback: Arc<Mutex<dyn OnDataChange + Send + Sync + 'static>>)
[INFO] [stderr] 644 | |                                  -> Result<u32, StatusCode>
[INFO] [stderr] 645 | |     {
[INFO] [stderr] ...   |
[INFO] [stderr] 682 | |         }
[INFO] [stderr] 683 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]    --> src/session.rs:949:24
[INFO] [stderr]     |
[INFO] [stderr] 949 |                   if let Some(_) = response.results {
[INFO] [stderr]     |  _________________-      ^^^^^^^
[INFO] [stderr] 950 | |                     let mut subscription_state = trace_write_lock_unwrap!(self.subscription_state);
[INFO] [stderr] 951 | |                     subscription_state.delete_monitored_items(subscription_id, items_to_delete);
[INFO] [stderr] 952 | |                 }
[INFO] [stderr]     | |_________________- help: try this: `if response.results.is_some()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()`
[INFO] [stderr]     --> src/session.rs:1048:28
[INFO] [stderr]      |
[INFO] [stderr] 1048 |                       if let Ok(_) = self.reconnect_and_activate_session() {
[INFO] [stderr]      |  _____________________-      ^^^^^
[INFO] [stderr] 1049 | |                         self.session_retry.reset_retry_count();
[INFO] [stderr] 1050 | |                     } else {
[INFO] [stderr] 1051 | |                         self.session_retry.increment_retry_count();
[INFO] [stderr] 1052 | |                     }
[INFO] [stderr]      | |_____________________- help: try this: `if self.reconnect_and_activate_session().is_ok()`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]     --> src/session.rs:1131:17
[INFO] [stderr]      |
[INFO] [stderr] 1131 | /                 match cmd {
[INFO] [stderr] 1132 | |                     SubscriptionTimerCommand::CreateTimer(subscription_id) => {
[INFO] [stderr] 1133 | |                         let timer_task = Self::make_subscription_timer(subscription_id, session_state, subscription_state);
[INFO] [stderr] 1134 | |                         tokio::spawn(timer_task);
[INFO] [stderr] 1135 | |                     }
[INFO] [stderr] 1136 | |                     _ => {}
[INFO] [stderr] 1137 | |                 }
[INFO] [stderr]      | |_________________^
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]      |
[INFO] [stderr] 1131 |                 if let SubscriptionTimerCommand::CreateTimer(subscription_id) = cmd {
[INFO] [stderr] 1132 |     let timer_task = Self::make_subscription_timer(subscription_id, session_state, subscription_state);
[INFO] [stderr] 1133 |     tokio::spawn(timer_task);
[INFO] [stderr] 1134 | }
[INFO] [stderr]      |
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]     --> src/session.rs:1166:28
[INFO] [stderr]      |
[INFO] [stderr] 1166 |                         if publishing_interval != subscription.publishing_interval() {
[INFO] [stderr]      |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(publishing_interval - subscription.publishing_interval()).abs() < error`
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[deny(clippy::float_cmp)] on by default
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]     --> src/session.rs:1166:28
[INFO] [stderr]      |
[INFO] [stderr] 1166 |                         if publishing_interval != subscription.publishing_interval() {
[INFO] [stderr]      |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]    --> src/session.rs:949:24
[INFO] [stderr]     |
[INFO] [stderr] 949 |                   if let Some(_) = response.results {
[INFO] [stderr]     |  _________________-      ^^^^^^^
[INFO] [stderr] 950 | |                     let mut subscription_state = trace_write_lock_unwrap!(self.subscription_state);
[INFO] [stderr] 951 | |                     subscription_state.delete_monitored_items(subscription_id, items_to_delete);
[INFO] [stderr] 952 | |                 }
[INFO] [stderr]     | |_________________- help: try this: `if response.results.is_some()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `builder::ClientBuilder`
[INFO] [stderr]   --> src/builder.rs:46:5
[INFO] [stderr]    |
[INFO] [stderr] 46 | /     pub fn new() -> ClientBuilder {
[INFO] [stderr] 47 | |         ClientBuilder {
[INFO] [stderr] 48 | |             config: ClientConfig::default()
[INFO] [stderr] 49 | |         }
[INFO] [stderr] 50 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 40 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()`
[INFO] [stderr]     --> src/session.rs:1048:28
[INFO] [stderr]      |
[INFO] [stderr] 1048 |                       if let Ok(_) = self.reconnect_and_activate_session() {
[INFO] [stderr]      |  _____________________-      ^^^^^
[INFO] [stderr] 1049 | |                         self.session_retry.reset_retry_count();
[INFO] [stderr] 1050 | |                     } else {
[INFO] [stderr] 1051 | |                         self.session_retry.increment_retry_count();
[INFO] [stderr] 1052 | |                     }
[INFO] [stderr]      | |_____________________- help: try this: `if self.reconnect_and_activate_session().is_ok()`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]     --> src/session.rs:1131:17
[INFO] [stderr]      |
[INFO] [stderr] 1131 | /                 match cmd {
[INFO] [stderr] 1132 | |                     SubscriptionTimerCommand::CreateTimer(subscription_id) => {
[INFO] [stderr] 1133 | |                         let timer_task = Self::make_subscription_timer(subscription_id, session_state, subscription_state);
[INFO] [stderr] 1134 | |                         tokio::spawn(timer_task);
[INFO] [stderr] 1135 | |                     }
[INFO] [stderr] 1136 | |                     _ => {}
[INFO] [stderr] 1137 | |                 }
[INFO] [stderr]      | |_________________^
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]      |
[INFO] [stderr] 1131 |                 if let SubscriptionTimerCommand::CreateTimer(subscription_id) = cmd {
[INFO] [stderr] 1132 |     let timer_task = Self::make_subscription_timer(subscription_id, session_state, subscription_state);
[INFO] [stderr] 1133 |     tokio::spawn(timer_task);
[INFO] [stderr] 1134 | }
[INFO] [stderr]      |
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]     --> src/session.rs:1166:28
[INFO] [stderr]      |
[INFO] [stderr] 1166 |                         if publishing_interval != subscription.publishing_interval() {
[INFO] [stderr]      |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(publishing_interval - subscription.publishing_interval()).abs() < error`
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[deny(clippy::float_cmp)] on by default
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]     --> src/session.rs:1166:28
[INFO] [stderr]      |
[INFO] [stderr] 1166 |                         if publishing_interval != subscription.publishing_interval() {
[INFO] [stderr]      |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `builder::ClientBuilder`
[INFO] [stderr]   --> src/builder.rs:46:5
[INFO] [stderr]    |
[INFO] [stderr] 46 | /     pub fn new() -> ClientBuilder {
[INFO] [stderr] 47 | |         ClientBuilder {
[INFO] [stderr] 48 | |             config: ClientConfig::default()
[INFO] [stderr] 49 | |         }
[INFO] [stderr] 50 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 40 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `opcua-client`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `opcua-client`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "d055d91644bbb7252cf7bcb8d6b31adb179eae3c9fa50964a9c567adbeb3fb93"`
[INFO] running `"docker" "rm" "-f" "d055d91644bbb7252cf7bcb8d6b31adb179eae3c9fa50964a9c567adbeb3fb93"`
[INFO] [stdout] d055d91644bbb7252cf7bcb8d6b31adb179eae3c9fa50964a9c567adbeb3fb93