[INFO] crate oozz 0.4.1 is already in cache [INFO] extracting crate oozz 0.4.1 into work/ex/clippy-test-run/sources/stable/reg/oozz/0.4.1 [INFO] extracting crate oozz 0.4.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/oozz/0.4.1 [INFO] validating manifest of oozz-0.4.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of oozz-0.4.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing oozz-0.4.1 [INFO] finished frobbing oozz-0.4.1 [INFO] frobbed toml for oozz-0.4.1 written to work/ex/clippy-test-run/sources/stable/reg/oozz/0.4.1/Cargo.toml [INFO] started frobbing oozz-0.4.1 [INFO] finished frobbing oozz-0.4.1 [INFO] frobbed toml for oozz-0.4.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/oozz/0.4.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting oozz-0.4.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/oozz/0.4.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4dc0d7ff6e9b5240cd28859a9b68e3477f7f92495090cffa2917b87f4e90f45e [INFO] running `"docker" "start" "-a" "4dc0d7ff6e9b5240cd28859a9b68e3477f7f92495090cffa2917b87f4e90f45e"` [INFO] [stderr] Checking term_size v0.3.1 [INFO] [stderr] Checking oozz v0.4.1 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:18:21 [INFO] [stderr] | [INFO] [stderr] 18 | pub const LETTERS: &'static str = "abcdefghijklmnopqrstuvwxyz.! /'\"_$1234567890"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:20:15 [INFO] [stderr] | [INFO] [stderr] 20 | const CHARS: &'static str = include_str!("../resources/chars.latin1"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:21:15 [INFO] [stderr] | [INFO] [stderr] 21 | const EXTRA: &'static str = include_str!("../resources/extra.latin1"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:22:14 [INFO] [stderr] | [INFO] [stderr] 22 | const OOZZ: &'static str = include_str!("../resources/oozz.latin1"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:18:21 [INFO] [stderr] | [INFO] [stderr] 18 | pub const LETTERS: &'static str = "abcdefghijklmnopqrstuvwxyz.! /'\"_$1234567890"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:20:15 [INFO] [stderr] | [INFO] [stderr] 20 | const CHARS: &'static str = include_str!("../resources/chars.latin1"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:21:15 [INFO] [stderr] | [INFO] [stderr] 21 | const EXTRA: &'static str = include_str!("../resources/extra.latin1"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:22:14 [INFO] [stderr] | [INFO] [stderr] 22 | const OOZZ: &'static str = include_str!("../resources/oozz.latin1"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] error: regex syntax error: backreferences are not supported [INFO] [stderr] --> src/lib.rs:34:66 [INFO] [stderr] | [INFO] [stderr] 34 | static ref VALID_RE: Regex = Regex::new(r"[^a-zA-Z\s!\./'\042_\$0-9]").unwrap(); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::invalid_regex)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#invalid_regex [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:118:13 [INFO] [stderr] | [INFO] [stderr] 118 | captured_padding = captured_padding + &cap[2].parse::().expect("Failed to parse cursor_forward_re capture"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `captured_padding += &cap[2].parse::().expect("Failed to parse cursor_forward_re capture")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/lib.rs:118:32 [INFO] [stderr] | [INFO] [stderr] 118 | captured_padding = captured_padding + &cap[2].parse::().expect("Failed to parse cursor_forward_re capture"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^---------------------------------------------------------------------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `cap[2].parse::().expect("Failed to parse cursor_forward_re capture")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:243:34 [INFO] [stderr] | [INFO] [stderr] 243 | for c in chars {out.push(format!("{}", c));} [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using .to_string(): `c.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:244:33 [INFO] [stderr] | [INFO] [stderr] 244 | for o in oozz {out.push(format!("{}", o));} [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using .to_string(): `o.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `oozz`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: regex syntax error: backreferences are not supported [INFO] [stderr] --> src/lib.rs:34:66 [INFO] [stderr] | [INFO] [stderr] 34 | static ref VALID_RE: Regex = Regex::new(r"[^a-zA-Z\s!\./'\042_\$0-9]").unwrap(); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::invalid_regex)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#invalid_regex [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:118:13 [INFO] [stderr] | [INFO] [stderr] 118 | captured_padding = captured_padding + &cap[2].parse::().expect("Failed to parse cursor_forward_re capture"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `captured_padding += &cap[2].parse::().expect("Failed to parse cursor_forward_re capture")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/lib.rs:118:32 [INFO] [stderr] | [INFO] [stderr] 118 | captured_padding = captured_padding + &cap[2].parse::().expect("Failed to parse cursor_forward_re capture"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^---------------------------------------------------------------------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `cap[2].parse::().expect("Failed to parse cursor_forward_re capture")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:243:34 [INFO] [stderr] | [INFO] [stderr] 243 | for c in chars {out.push(format!("{}", c));} [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using .to_string(): `c.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:244:33 [INFO] [stderr] | [INFO] [stderr] 244 | for o in oozz {out.push(format!("{}", o));} [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using .to_string(): `o.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/test.rs:40:21 [INFO] [stderr] | [INFO] [stderr] 40 | let test_char = chars.get(&'c').unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&chars[&'c']` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/test.rs:67:18 [INFO] [stderr] | [INFO] [stderr] 67 | let target = oozz.get(9).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&oozz[9]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `oozz`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "4dc0d7ff6e9b5240cd28859a9b68e3477f7f92495090cffa2917b87f4e90f45e"` [INFO] running `"docker" "rm" "-f" "4dc0d7ff6e9b5240cd28859a9b68e3477f7f92495090cffa2917b87f4e90f45e"` [INFO] [stdout] 4dc0d7ff6e9b5240cd28859a9b68e3477f7f92495090cffa2917b87f4e90f45e