[INFO] crate onyx 0.2.0 is already in cache [INFO] extracting crate onyx 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/onyx/0.2.0 [INFO] extracting crate onyx 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/onyx/0.2.0 [INFO] validating manifest of onyx-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of onyx-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing onyx-0.2.0 [INFO] removed 0 missing examples [INFO] finished frobbing onyx-0.2.0 [INFO] frobbed toml for onyx-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/onyx/0.2.0/Cargo.toml [INFO] started frobbing onyx-0.2.0 [INFO] removed 0 missing examples [INFO] finished frobbing onyx-0.2.0 [INFO] frobbed toml for onyx-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/onyx/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting onyx-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/onyx/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 26bea9c21b4011a16d085e015ab1cac79fe9bbced1ab6dfbd4804759a4e1c3ba [INFO] running `"docker" "start" "-a" "26bea9c21b4011a16d085e015ab1cac79fe9bbced1ab6dfbd4804759a4e1c3ba"` [INFO] [stderr] Compiling glium v0.16.0 [INFO] [stderr] Checking onyx v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ui.rs:210:21 [INFO] [stderr] | [INFO] [stderr] 210 | font: font, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `font` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ui.rs:397:13 [INFO] [stderr] | [INFO] [stderr] 397 | content: content, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `content` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/context.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | display: display, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `display` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/context.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | quad: quad, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `quad` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/context.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | white: white, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `white` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/context.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | default_shader: default_shader, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `default_shader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:110:13 [INFO] [stderr] | [INFO] [stderr] 110 | scene: scene, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `scene` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:111:13 [INFO] [stderr] | [INFO] [stderr] 111 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ui.rs:210:21 [INFO] [stderr] | [INFO] [stderr] 210 | font: font, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `font` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ui.rs:397:13 [INFO] [stderr] | [INFO] [stderr] 397 | content: content, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `content` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/context.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | display: display, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `display` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/context.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | quad: quad, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `quad` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/context.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | white: white, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `white` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/context.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | default_shader: default_shader, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `default_shader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:110:13 [INFO] [stderr] | [INFO] [stderr] 110 | scene: scene, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `scene` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:111:13 [INFO] [stderr] | [INFO] [stderr] 111 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/math/mat.rs:95:9 [INFO] [stderr] | [INFO] [stderr] 95 | return result [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/math/mat.rs:119:9 [INFO] [stderr] | [INFO] [stderr] 119 | return result [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/math/mat.rs:95:9 [INFO] [stderr] | [INFO] [stderr] 95 | return result [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/math/mat.rs:119:9 [INFO] [stderr] | [INFO] [stderr] 119 | return result [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ui.rs:24:14 [INFO] [stderr] | [INFO] [stderr] 24 | fn align(&self, pos: f32, size: f32, desired: f32) -> (f32, f32) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ui.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | fn size(&self, parent: f32, children: f32) -> f32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ui.rs:59:15 [INFO] [stderr] | [INFO] [stderr] 59 | fn expand(&self, size0: Vec2, size1: Vec2) -> Vec2 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ui.rs:67:14 [INFO] [stderr] | [INFO] [stderr] 67 | fn child(&self, index: usize, count: usize, position: Vec2, size: Vec2, child: Vec2) -> (Vec2, Vec2) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/ui.rs:262:9 [INFO] [stderr] | [INFO] [stderr] 262 | / match &self.widget(widget).content { [INFO] [stderr] 263 | | &Content::Label(ref texture) => Vec2::new(texture.get_width() as f32, texture.get_height().unwrap() as f32), [INFO] [stderr] 264 | | _ => Vec2::zero(), [INFO] [stderr] 265 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 262 | match self.widget(widget).content { [INFO] [stderr] 263 | Content::Label(ref texture) => Vec2::new(texture.get_width() as f32, texture.get_height().unwrap() as f32), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/ui.rs:339:9 [INFO] [stderr] | [INFO] [stderr] 339 | / match &self.widget(widget).content { [INFO] [stderr] 340 | | &Content::Label(ref text) => { [INFO] [stderr] 341 | | frame.set_color(style.label.color); [INFO] [stderr] 342 | | frame.draw_text(text, rect); [INFO] [stderr] ... | [INFO] [stderr] 357 | | }, [INFO] [stderr] 358 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 339 | match self.widget(widget).content { [INFO] [stderr] 340 | Content::Label(ref text) => { [INFO] [stderr] 341 | frame.set_color(style.label.color); [INFO] [stderr] 342 | frame.draw_text(text, rect); [INFO] [stderr] 343 | }, [INFO] [stderr] 344 | Content::Panel => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ui.rs:24:14 [INFO] [stderr] | [INFO] [stderr] 24 | fn align(&self, pos: f32, size: f32, desired: f32) -> (f32, f32) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ui.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | fn size(&self, parent: f32, children: f32) -> f32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ui.rs:59:15 [INFO] [stderr] | [INFO] [stderr] 59 | fn expand(&self, size0: Vec2, size1: Vec2) -> Vec2 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ui.rs:67:14 [INFO] [stderr] | [INFO] [stderr] 67 | fn child(&self, index: usize, count: usize, position: Vec2, size: Vec2, child: Vec2) -> (Vec2, Vec2) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/ui.rs:262:9 [INFO] [stderr] | [INFO] [stderr] 262 | / match &self.widget(widget).content { [INFO] [stderr] 263 | | &Content::Label(ref texture) => Vec2::new(texture.get_width() as f32, texture.get_height().unwrap() as f32), [INFO] [stderr] 264 | | _ => Vec2::zero(), [INFO] [stderr] 265 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 262 | match self.widget(widget).content { [INFO] [stderr] 263 | Content::Label(ref texture) => Vec2::new(texture.get_width() as f32, texture.get_height().unwrap() as f32), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/ui.rs:339:9 [INFO] [stderr] | [INFO] [stderr] 339 | / match &self.widget(widget).content { [INFO] [stderr] 340 | | &Content::Label(ref text) => { [INFO] [stderr] 341 | | frame.set_color(style.label.color); [INFO] [stderr] 342 | | frame.draw_text(text, rect); [INFO] [stderr] ... | [INFO] [stderr] 357 | | }, [INFO] [stderr] 358 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 339 | match self.widget(widget).content { [INFO] [stderr] 340 | Content::Label(ref text) => { [INFO] [stderr] 341 | frame.set_color(style.label.color); [INFO] [stderr] 342 | frame.draw_text(text, rect); [INFO] [stderr] 343 | }, [INFO] [stderr] 344 | Content::Panel => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `transform::TransformSystem` [INFO] [stderr] --> src/transform.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | / pub fn new() -> Self { [INFO] [stderr] 20 | | Self { transforms: Vec::new() } [INFO] [stderr] 21 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 14 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `transform::TransformSystem` [INFO] [stderr] --> src/transform.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | / pub fn new() -> Self { [INFO] [stderr] 20 | | Self { transforms: Vec::new() } [INFO] [stderr] 21 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 14 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> examples/example-pong.rs:137:9 [INFO] [stderr] | [INFO] [stderr] 137 | / if self.ball.max().x > max.x - self.right_plank.size.x && self.ball.max().x < max.x { [INFO] [stderr] 138 | | if self.ball.min().y < self.right_plank.max().y && self.ball.max().y > self.right_plank.min().y { [INFO] [stderr] 139 | | self.ball.center.x = max.x - self.right_plank.size.x - 0.5 * self.ball.size.x; [INFO] [stderr] 140 | | self.ball.velocity.x = -self.ball.velocity.x; [INFO] [stderr] 141 | | } [INFO] [stderr] 142 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 137 | if self.ball.max().x > max.x - self.right_plank.size.x && self.ball.max().x < max.x && self.ball.min().y < self.right_plank.max().y && self.ball.max().y > self.right_plank.min().y { [INFO] [stderr] 138 | self.ball.center.x = max.x - self.right_plank.size.x - 0.5 * self.ball.size.x; [INFO] [stderr] 139 | self.ball.velocity.x = -self.ball.velocity.x; [INFO] [stderr] 140 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> examples/example-pong.rs:148:9 [INFO] [stderr] | [INFO] [stderr] 148 | / if self.ball.min().x < min.x + self.left_plank.size.x && self.ball.max().x > min.x { [INFO] [stderr] 149 | | if self.ball.min().y < self.left_plank.max().y && self.ball.max().y > self.left_plank.min().y { [INFO] [stderr] 150 | | self.ball.center.x = min.x + self.left_plank.size.x + 0.5 * self.ball.size.x; [INFO] [stderr] 151 | | self.ball.velocity.x = -self.ball.velocity.x; [INFO] [stderr] 152 | | } [INFO] [stderr] 153 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 148 | if self.ball.min().x < min.x + self.left_plank.size.x && self.ball.max().x > min.x && self.ball.min().y < self.left_plank.max().y && self.ball.max().y > self.left_plank.min().y { [INFO] [stderr] 149 | self.ball.center.x = min.x + self.left_plank.size.x + 0.5 * self.ball.size.x; [INFO] [stderr] 150 | self.ball.velocity.x = -self.ball.velocity.x; [INFO] [stderr] 151 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 38.24s [INFO] running `"docker" "inspect" "26bea9c21b4011a16d085e015ab1cac79fe9bbced1ab6dfbd4804759a4e1c3ba"` [INFO] running `"docker" "rm" "-f" "26bea9c21b4011a16d085e015ab1cac79fe9bbced1ab6dfbd4804759a4e1c3ba"` [INFO] [stdout] 26bea9c21b4011a16d085e015ab1cac79fe9bbced1ab6dfbd4804759a4e1c3ba