[INFO] crate onvif-rs 0.0.4 is already in cache [INFO] extracting crate onvif-rs 0.0.4 into work/ex/clippy-test-run/sources/stable/reg/onvif-rs/0.0.4 [INFO] extracting crate onvif-rs 0.0.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/onvif-rs/0.0.4 [INFO] validating manifest of onvif-rs-0.0.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of onvif-rs-0.0.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing onvif-rs-0.0.4 [INFO] finished frobbing onvif-rs-0.0.4 [INFO] frobbed toml for onvif-rs-0.0.4 written to work/ex/clippy-test-run/sources/stable/reg/onvif-rs/0.0.4/Cargo.toml [INFO] started frobbing onvif-rs-0.0.4 [INFO] finished frobbing onvif-rs-0.0.4 [INFO] frobbed toml for onvif-rs-0.0.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/onvif-rs/0.0.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting onvif-rs-0.0.4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/onvif-rs/0.0.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0cf3ed833ce34640b9f811d85ac9c1dc38e53e40ea0ea72a000ca214420f77d7 [INFO] running `"docker" "start" "-a" "0cf3ed833ce34640b9f811d85ac9c1dc38e53e40ea0ea72a000ca214420f77d7"` [INFO] [stderr] Checking backtrace-sys v0.1.28 [INFO] [stderr] Checking backtrace v0.3.13 [INFO] [stderr] Checking failure v0.1.5 [INFO] [stderr] Checking quick-xml v0.12.4 [INFO] [stderr] Checking onvif-rs v0.0.4 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/discovery.rs:170:7 [INFO] [stderr] | [INFO] [stderr] 170 | s [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/discovery.rs:169:15 [INFO] [stderr] | [INFO] [stderr] 169 | let s = s.replace("__uuid__", "7c208633-8086-4a83-a9d4-b3fd8673b8f7"); //TODO: Replace hardcoded uuid with a generated one [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/discovery.rs:170:7 [INFO] [stderr] | [INFO] [stderr] 170 | s [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/discovery.rs:169:15 [INFO] [stderr] | [INFO] [stderr] 169 | let s = s.replace("__uuid__", "7c208633-8086-4a83-a9d4-b3fd8673b8f7"); //TODO: Replace hardcoded uuid with a generated one [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: field is never used: `password` [INFO] [stderr] --> src/device.rs:6:3 [INFO] [stderr] | [INFO] [stderr] 6 | password: String, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/discovery.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | / match e.name() { [INFO] [stderr] 65 | | b"SOAP-ENV:Header" => break, [INFO] [stderr] 66 | | _ => (), [INFO] [stderr] 67 | | }; [INFO] [stderr] | |_________^ help: try this: `if let b"SOAP-ENV:Header" = e.name() { break }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/discovery.rs:167:21 [INFO] [stderr] | [INFO] [stderr] 167 | let s: &str = soap_tmpl.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 167 | let s: &str = &(*soap_tmpl).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 167 | let s: &str = &str::clone(soap_tmpl); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `onvif-rs`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: field is never used: `password` [INFO] [stderr] --> src/device.rs:6:3 [INFO] [stderr] | [INFO] [stderr] 6 | password: String, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/discovery.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | / match e.name() { [INFO] [stderr] 65 | | b"SOAP-ENV:Header" => break, [INFO] [stderr] 66 | | _ => (), [INFO] [stderr] 67 | | }; [INFO] [stderr] | |_________^ help: try this: `if let b"SOAP-ENV:Header" = e.name() { break }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/discovery.rs:167:21 [INFO] [stderr] | [INFO] [stderr] 167 | let s: &str = soap_tmpl.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 167 | let s: &str = &(*soap_tmpl).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 167 | let s: &str = &str::clone(soap_tmpl); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `onvif-rs`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "0cf3ed833ce34640b9f811d85ac9c1dc38e53e40ea0ea72a000ca214420f77d7"` [INFO] running `"docker" "rm" "-f" "0cf3ed833ce34640b9f811d85ac9c1dc38e53e40ea0ea72a000ca214420f77d7"` [INFO] [stdout] 0cf3ed833ce34640b9f811d85ac9c1dc38e53e40ea0ea72a000ca214420f77d7