[INFO] crate onitama 0.1.2 is already in cache
[INFO] extracting crate onitama 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/onitama/0.1.2
[INFO] extracting crate onitama 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/onitama/0.1.2
[INFO] validating manifest of onitama-0.1.2 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of onitama-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing onitama-0.1.2
[INFO] finished frobbing onitama-0.1.2
[INFO] frobbed toml for onitama-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/onitama/0.1.2/Cargo.toml
[INFO] started frobbing onitama-0.1.2
[INFO] finished frobbing onitama-0.1.2
[INFO] frobbed toml for onitama-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/onitama/0.1.2/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting onitama-0.1.2 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/onitama/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] c00510f797d5cdb11d07085b969ac92cb656351ee14fcaab00d838ce98d7c6e6
[INFO] running `"docker" "start" "-a" "c00510f797d5cdb11d07085b969ac92cb656351ee14fcaab00d838ce98d7c6e6"`
[INFO] [stderr]     Checking onitama v0.1.2 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/piece.rs:27:16
[INFO] [stderr]    |
[INFO] [stderr] 27 |         Piece {side: side, king: king}
[INFO] [stderr]    |                ^^^^^^^^^^ help: replace it with: `side`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/piece.rs:27:28
[INFO] [stderr]    |
[INFO] [stderr] 27 |         Piece {side: side, king: king}
[INFO] [stderr]    |                            ^^^^^^^^^^ help: replace it with: `king`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/board.rs:99:20
[INFO] [stderr]    |
[INFO] [stderr] 99 |         BoardIter {board: board, index: 0}
[INFO] [stderr]    |                    ^^^^^^^^^^^^ help: replace it with: `board`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/piece.rs:27:16
[INFO] [stderr]    |
[INFO] [stderr] 27 |         Piece {side: side, king: king}
[INFO] [stderr]    |                ^^^^^^^^^^ help: replace it with: `side`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/piece.rs:27:28
[INFO] [stderr]    |
[INFO] [stderr] 27 |         Piece {side: side, king: king}
[INFO] [stderr]    |                            ^^^^^^^^^^ help: replace it with: `king`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/board.rs:99:20
[INFO] [stderr]    |
[INFO] [stderr] 99 |         BoardIter {board: board, index: 0}
[INFO] [stderr]    |                    ^^^^^^^^^^^^ help: replace it with: `board`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/location.rs:13:20
[INFO] [stderr]    |
[INFO] [stderr] 13 |     pub fn can_add(&self, s: Step) -> bool {
[INFO] [stderr]    |                    ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/location.rs:43:17
[INFO] [stderr]    |
[INFO] [stderr] 43 |     pub fn flip(&self) -> Step {
[INFO] [stderr]    |                 ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/card.rs:17:18
[INFO] [stderr]    |
[INFO] [stderr] 17 |     pub fn steps(&self) -> StepAlternatives {
[INFO] [stderr]    |                  ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/card.rs:20:26
[INFO] [stderr]    |
[INFO] [stderr] 20 |     pub fn flipped_steps(&self) -> StepAlternatives {
[INFO] [stderr]    |                          ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/card.rs:23:20
[INFO] [stderr]    |
[INFO] [stderr] 23 |     pub fn starter(&self) -> Side {
[INFO] [stderr]    |                    ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/card.rs:26:15
[INFO] [stderr]    |
[INFO] [stderr] 26 |     pub fn id(&self) -> CardId {
[INFO] [stderr]    |               ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `board::Board`
[INFO] [stderr]   --> src/board.rs:10:5
[INFO] [stderr]    |
[INFO] [stderr] 10 | /     pub fn new() -> Board {
[INFO] [stderr] 11 | |         Board([
[INFO] [stderr] 12 | |             [
[INFO] [stderr] 13 | |                 Some(Piece::new(Side::WHITE, false)),
[INFO] [stderr] ...  |
[INFO] [stderr] 27 | |         ])
[INFO] [stderr] 28 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 8  | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/board.rs:51:25
[INFO] [stderr]    |
[INFO] [stderr] 51 |         let mut board = self.0.clone();
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.0`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: this `.fold` can be written more succinctly using another method
[INFO] [stderr]   --> src/board.rs:58:62
[INFO] [stderr]    |
[INFO] [stderr] 58 |         self.iter().filter_map(|x| x.1).map(|p| p.king as u8).fold(0, |a, b| a+b) < 2
[INFO] [stderr]    |                                                              ^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unnecessary_fold)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/game.rs:19:38
[INFO] [stderr]    |
[INFO] [stderr] 19 |             let mut cs: Vec<usize> = cards.clone().to_vec().iter().map(|c| c.id()).collect();
[INFO] [stderr]    |                                      ^^^^^^^^^^^^^ help: try removing the `clone` call: `cards`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/location.rs:13:20
[INFO] [stderr]    |
[INFO] [stderr] 13 |     pub fn can_add(&self, s: Step) -> bool {
[INFO] [stderr]    |                    ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/location.rs:43:17
[INFO] [stderr]    |
[INFO] [stderr] 43 |     pub fn flip(&self) -> Step {
[INFO] [stderr]    |                 ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/card.rs:17:18
[INFO] [stderr]    |
[INFO] [stderr] 17 |     pub fn steps(&self) -> StepAlternatives {
[INFO] [stderr]    |                  ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/card.rs:20:26
[INFO] [stderr]    |
[INFO] [stderr] 20 |     pub fn flipped_steps(&self) -> StepAlternatives {
[INFO] [stderr]    |                          ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/card.rs:23:20
[INFO] [stderr]    |
[INFO] [stderr] 23 |     pub fn starter(&self) -> Side {
[INFO] [stderr]    |                    ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/card.rs:26:15
[INFO] [stderr]    |
[INFO] [stderr] 26 |     pub fn id(&self) -> CardId {
[INFO] [stderr]    |               ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `board::Board`
[INFO] [stderr]   --> src/board.rs:10:5
[INFO] [stderr]    |
[INFO] [stderr] 10 | /     pub fn new() -> Board {
[INFO] [stderr] 11 | |         Board([
[INFO] [stderr] 12 | |             [
[INFO] [stderr] 13 | |                 Some(Piece::new(Side::WHITE, false)),
[INFO] [stderr] ...  |
[INFO] [stderr] 27 | |         ])
[INFO] [stderr] 28 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 8  | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/board.rs:51:25
[INFO] [stderr]    |
[INFO] [stderr] 51 |         let mut board = self.0.clone();
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.0`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: this `.fold` can be written more succinctly using another method
[INFO] [stderr]   --> src/board.rs:58:62
[INFO] [stderr]    |
[INFO] [stderr] 58 |         self.iter().filter_map(|x| x.1).map(|p| p.king as u8).fold(0, |a, b| a+b) < 2
[INFO] [stderr]    |                                                              ^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unnecessary_fold)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/game.rs:19:38
[INFO] [stderr]    |
[INFO] [stderr] 19 |             let mut cs: Vec<usize> = cards.clone().to_vec().iter().map(|c| c.id()).collect();
[INFO] [stderr]    |                                      ^^^^^^^^^^^^^ help: try removing the `clone` call: `cards`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.72s
[INFO] running `"docker" "inspect" "c00510f797d5cdb11d07085b969ac92cb656351ee14fcaab00d838ce98d7c6e6"`
[INFO] running `"docker" "rm" "-f" "c00510f797d5cdb11d07085b969ac92cb656351ee14fcaab00d838ce98d7c6e6"`
[INFO] [stdout] c00510f797d5cdb11d07085b969ac92cb656351ee14fcaab00d838ce98d7c6e6