[INFO] crate onefetch 1.0.0 is already in cache
[INFO] extracting crate onefetch 1.0.0 into work/ex/clippy-test-run/sources/stable/reg/onefetch/1.0.0
[INFO] extracting crate onefetch 1.0.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/onefetch/1.0.0
[INFO] validating manifest of onefetch-1.0.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of onefetch-1.0.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing onefetch-1.0.0
[INFO] finished frobbing onefetch-1.0.0
[INFO] frobbed toml for onefetch-1.0.0 written to work/ex/clippy-test-run/sources/stable/reg/onefetch/1.0.0/Cargo.toml
[INFO] started frobbing onefetch-1.0.0
[INFO] finished frobbing onefetch-1.0.0
[INFO] frobbed toml for onefetch-1.0.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/onefetch/1.0.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting onefetch-1.0.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/onefetch/1.0.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] f160219cca274abf41e56b4323a9ca2d326be3166f19db55d71ccda5964becff
[INFO] running `"docker" "start" "-a" "f160219cca274abf41e56b4323a9ca2d326be3166f19db55d71ccda5964becff"`
[INFO] [stderr]    Compiling libgit2-sys v0.7.11
[INFO] [stderr]    Compiling globset v0.4.2
[INFO] [stderr]     Checking license v0.7.2
[INFO] [stderr]    Compiling handlebars v1.1.0
[INFO] [stderr]    Compiling ignore v0.4.6
[INFO] [stderr]    Compiling tokei v8.0.1
[INFO] [stderr]     Checking git2 v0.7.5
[INFO] [stderr]     Checking onefetch v1.0.0 (/opt/crater/workdir)
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/main.rs:218:26
[INFO] [stderr]     |
[INFO] [stderr] 218 |                         .unwrap_or("".into())
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".into())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/main.rs:221:73
[INFO] [stderr]     |
[INFO] [stderr] 221 |         .map(|entry| license::Kind::from_str(&fs::read_to_string(entry).unwrap_or("".into())))
[INFO] [stderr]     |                                                                         ^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "".into())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/main.rs:263:5
[INFO] [stderr]     |
[INFO] [stderr] 263 | /     match remote_upstream {
[INFO] [stderr] 264 | |         Some(url) => remote_url = url.clone(),
[INFO] [stderr] 265 | |         None => (),
[INFO] [stderr] 266 | |     };
[INFO] [stderr]     | |_____^ help: try this: `if let Some(url) = remote_upstream { remote_url = url.clone() }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:271:8
[INFO] [stderr]     |
[INFO] [stderr] 271 |     if name_parts.len() > 0 {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!name_parts.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/main.rs:218:26
[INFO] [stderr]     |
[INFO] [stderr] 218 |                         .unwrap_or("".into())
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".into())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/main.rs:221:73
[INFO] [stderr]     |
[INFO] [stderr] 221 |         .map(|entry| license::Kind::from_str(&fs::read_to_string(entry).unwrap_or("".into())))
[INFO] [stderr]     |                                                                         ^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "".into())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/main.rs:263:5
[INFO] [stderr]     |
[INFO] [stderr] 263 | /     match remote_upstream {
[INFO] [stderr] 264 | |         Some(url) => remote_url = url.clone(),
[INFO] [stderr] 265 | |         None => (),
[INFO] [stderr] 266 | |     };
[INFO] [stderr]     | |_____^ help: try this: `if let Some(url) = remote_upstream { remote_url = url.clone() }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:271:8
[INFO] [stderr]     |
[INFO] [stderr] 271 |     if name_parts.len() > 0 {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!name_parts.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 45.14s
[INFO] running `"docker" "inspect" "f160219cca274abf41e56b4323a9ca2d326be3166f19db55d71ccda5964becff"`
[INFO] running `"docker" "rm" "-f" "f160219cca274abf41e56b4323a9ca2d326be3166f19db55d71ccda5964becff"`
[INFO] [stdout] f160219cca274abf41e56b4323a9ca2d326be3166f19db55d71ccda5964becff