[INFO] crate one-stack-vec 0.5.1 is already in cache [INFO] extracting crate one-stack-vec 0.5.1 into work/ex/clippy-test-run/sources/stable/reg/one-stack-vec/0.5.1 [INFO] extracting crate one-stack-vec 0.5.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/one-stack-vec/0.5.1 [INFO] validating manifest of one-stack-vec-0.5.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of one-stack-vec-0.5.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing one-stack-vec-0.5.1 [INFO] finished frobbing one-stack-vec-0.5.1 [INFO] frobbed toml for one-stack-vec-0.5.1 written to work/ex/clippy-test-run/sources/stable/reg/one-stack-vec/0.5.1/Cargo.toml [INFO] started frobbing one-stack-vec-0.5.1 [INFO] finished frobbing one-stack-vec-0.5.1 [INFO] frobbed toml for one-stack-vec-0.5.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/one-stack-vec/0.5.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting one-stack-vec-0.5.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/one-stack-vec/0.5.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] dc5e722c52d0e7f3c07b6e53f1e42a02ecc0f08ec861a08ad5b76da3af20b636 [INFO] running `"docker" "start" "-a" "dc5e722c52d0e7f3c07b6e53f1e42a02ecc0f08ec861a08ad5b76da3af20b636"` [INFO] [stderr] Checking one-stack-vec v0.5.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/iter.rs:11:13 [INFO] [stderr] | [INFO] [stderr] 11 | item: item, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `item` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/iter.rs:11:13 [INFO] [stderr] | [INFO] [stderr] 11 | item: item, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `item` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/iter.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | / match &mut self.item { [INFO] [stderr] 23 | | &mut None => None, [INFO] [stderr] 24 | | &mut Some((ref first, ref mut vec)) => { [INFO] [stderr] 25 | | if self.is_first { [INFO] [stderr] ... | [INFO] [stderr] 31 | | } [INFO] [stderr] 32 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 22 | match *(&mut self.item) { [INFO] [stderr] 23 | None => None, [INFO] [stderr] 24 | Some((ref first, ref mut vec)) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: item `OneStackVec` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lib.rs:38:1 [INFO] [stderr] | [INFO] [stderr] 38 | / impl OneStackVec { [INFO] [stderr] 39 | | pub fn new() -> OneStackVec { [INFO] [stderr] 40 | | OneStackVec(None) [INFO] [stderr] 41 | | } [INFO] [stderr] ... | [INFO] [stderr] 105 | | } [INFO] [stderr] 106 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `OneStackVec` [INFO] [stderr] --> src/lib.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | / pub fn new() -> OneStackVec { [INFO] [stderr] 40 | | OneStackVec(None) [INFO] [stderr] 41 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 36 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/lib.rs:60:9 [INFO] [stderr] | [INFO] [stderr] 60 | / match &self.0 { [INFO] [stderr] 61 | | &None => None, [INFO] [stderr] 62 | | &Some((ref one, ref vec)) => { [INFO] [stderr] 63 | | if index == 0 { [INFO] [stderr] ... | [INFO] [stderr] 68 | | } [INFO] [stderr] 69 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 60 | match self.0 { [INFO] [stderr] 61 | None => None, [INFO] [stderr] 62 | Some((ref one, ref vec)) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:76:44 [INFO] [stderr] | [INFO] [stderr] 76 | &mut Some((_, ref mut vec)) if vec.len() > 0 => vec.pop(), [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!vec.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: replacing an `Option` with `None` [INFO] [stderr] --> src/lib.rs:79:33 [INFO] [stderr] | [INFO] [stderr] 79 | let old_inner = mem::replace(inner, None); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider `Option::take()` instead: `inner.take()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::mem_replace_option_with_none)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_option_with_none [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/lib.rs:86:9 [INFO] [stderr] | [INFO] [stderr] 86 | / match &self.0 { [INFO] [stderr] 87 | | &None => 0, [INFO] [stderr] 88 | | &Some((_, ref vec)) => vec.len() + 1, [INFO] [stderr] 89 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 86 | match self.0 { [INFO] [stderr] 87 | None => 0, [INFO] [stderr] 88 | Some((_, ref vec)) => vec.len() + 1, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:93:5 [INFO] [stderr] | [INFO] [stderr] 93 | / pub fn iter<'a>(&'a self) -> Iter<'a, T> { [INFO] [stderr] 94 | | Iter::with(self.0.as_ref().map(|&(ref first, ref vec)| (first, vec.iter()))) [INFO] [stderr] 95 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/lib.rs:101:9 [INFO] [stderr] | [INFO] [stderr] 101 | / match &self.0 { [INFO] [stderr] 102 | | &None => false, [INFO] [stderr] 103 | | &Some((ref first, ref vec)) => first.eq(x) || vec.contains(x), [INFO] [stderr] 104 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 101 | match self.0 { [INFO] [stderr] 102 | None => false, [INFO] [stderr] 103 | Some((ref first, ref vec)) => first.eq(x) || vec.contains(x), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/lib.rs:113:9 [INFO] [stderr] | [INFO] [stderr] 113 | / match &self.0 { [INFO] [stderr] 114 | | &None => write!(f, "OneStackVec ()"), [INFO] [stderr] 115 | | &Some((ref first, ref another)) => { [INFO] [stderr] 116 | | write!(f, "OneStackVec ( {:?}, {:?} )", first, another) [INFO] [stderr] 117 | | } [INFO] [stderr] 118 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 113 | match self.0 { [INFO] [stderr] 114 | None => write!(f, "OneStackVec ()"), [INFO] [stderr] 115 | Some((ref first, ref another)) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:221:13 [INFO] [stderr] | [INFO] [stderr] 221 | tmp_vec [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 233 | let item1: OneStackVec = one_stack_vec![]; [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:217:31 [INFO] [stderr] | [INFO] [stderr] 217 | let mut tmp_vec = $crate::OneStackVec::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 233 | let item1: OneStackVec = one_stack_vec![]; [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:221:13 [INFO] [stderr] | [INFO] [stderr] 221 | tmp_vec [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 234 | let item2: OneStackVec = one_stack_vec![]; [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:217:31 [INFO] [stderr] | [INFO] [stderr] 217 | let mut tmp_vec = $crate::OneStackVec::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 234 | let item2: OneStackVec = one_stack_vec![]; [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:221:13 [INFO] [stderr] | [INFO] [stderr] 221 | tmp_vec [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 238 | let item2 = one_stack_vec![]; [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:217:31 [INFO] [stderr] | [INFO] [stderr] 217 | let mut tmp_vec = $crate::OneStackVec::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 238 | let item2 = one_stack_vec![]; [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:221:13 [INFO] [stderr] | [INFO] [stderr] 221 | tmp_vec [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 262 | let vec: OneStackVec = one_stack_vec![]; [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:217:31 [INFO] [stderr] | [INFO] [stderr] 217 | let mut tmp_vec = $crate::OneStackVec::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 262 | let vec: OneStackVec = one_stack_vec![]; [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/iter.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | / match &mut self.item { [INFO] [stderr] 23 | | &mut None => None, [INFO] [stderr] 24 | | &mut Some((ref first, ref mut vec)) => { [INFO] [stderr] 25 | | if self.is_first { [INFO] [stderr] ... | [INFO] [stderr] 31 | | } [INFO] [stderr] 32 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 22 | match *(&mut self.item) { [INFO] [stderr] 23 | None => None, [INFO] [stderr] 24 | Some((ref first, ref mut vec)) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: item `OneStackVec` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lib.rs:38:1 [INFO] [stderr] | [INFO] [stderr] 38 | / impl OneStackVec { [INFO] [stderr] 39 | | pub fn new() -> OneStackVec { [INFO] [stderr] 40 | | OneStackVec(None) [INFO] [stderr] 41 | | } [INFO] [stderr] ... | [INFO] [stderr] 105 | | } [INFO] [stderr] 106 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `OneStackVec` [INFO] [stderr] --> src/lib.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | / pub fn new() -> OneStackVec { [INFO] [stderr] 40 | | OneStackVec(None) [INFO] [stderr] 41 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 36 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/lib.rs:60:9 [INFO] [stderr] | [INFO] [stderr] 60 | / match &self.0 { [INFO] [stderr] 61 | | &None => None, [INFO] [stderr] 62 | | &Some((ref one, ref vec)) => { [INFO] [stderr] 63 | | if index == 0 { [INFO] [stderr] ... | [INFO] [stderr] 68 | | } [INFO] [stderr] 69 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 60 | match self.0 { [INFO] [stderr] 61 | None => None, [INFO] [stderr] 62 | Some((ref one, ref vec)) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:76:44 [INFO] [stderr] | [INFO] [stderr] 76 | &mut Some((_, ref mut vec)) if vec.len() > 0 => vec.pop(), [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!vec.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: replacing an `Option` with `None` [INFO] [stderr] --> src/lib.rs:79:33 [INFO] [stderr] | [INFO] [stderr] 79 | let old_inner = mem::replace(inner, None); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider `Option::take()` instead: `inner.take()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::mem_replace_option_with_none)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_option_with_none [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/lib.rs:86:9 [INFO] [stderr] | [INFO] [stderr] 86 | / match &self.0 { [INFO] [stderr] 87 | | &None => 0, [INFO] [stderr] 88 | | &Some((_, ref vec)) => vec.len() + 1, [INFO] [stderr] 89 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 86 | match self.0 { [INFO] [stderr] 87 | None => 0, [INFO] [stderr] 88 | Some((_, ref vec)) => vec.len() + 1, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:93:5 [INFO] [stderr] | [INFO] [stderr] 93 | / pub fn iter<'a>(&'a self) -> Iter<'a, T> { [INFO] [stderr] 94 | | Iter::with(self.0.as_ref().map(|&(ref first, ref vec)| (first, vec.iter()))) [INFO] [stderr] 95 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/lib.rs:101:9 [INFO] [stderr] | [INFO] [stderr] 101 | / match &self.0 { [INFO] [stderr] 102 | | &None => false, [INFO] [stderr] 103 | | &Some((ref first, ref vec)) => first.eq(x) || vec.contains(x), [INFO] [stderr] 104 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 101 | match self.0 { [INFO] [stderr] 102 | None => false, [INFO] [stderr] 103 | Some((ref first, ref vec)) => first.eq(x) || vec.contains(x), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/lib.rs:113:9 [INFO] [stderr] | [INFO] [stderr] 113 | / match &self.0 { [INFO] [stderr] 114 | | &None => write!(f, "OneStackVec ()"), [INFO] [stderr] 115 | | &Some((ref first, ref another)) => { [INFO] [stderr] 116 | | write!(f, "OneStackVec ( {:?}, {:?} )", first, another) [INFO] [stderr] 117 | | } [INFO] [stderr] 118 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 113 | match self.0 { [INFO] [stderr] 114 | None => write!(f, "OneStackVec ()"), [INFO] [stderr] 115 | Some((ref first, ref another)) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.48s [INFO] running `"docker" "inspect" "dc5e722c52d0e7f3c07b6e53f1e42a02ecc0f08ec861a08ad5b76da3af20b636"` [INFO] running `"docker" "rm" "-f" "dc5e722c52d0e7f3c07b6e53f1e42a02ecc0f08ec861a08ad5b76da3af20b636"` [INFO] [stdout] dc5e722c52d0e7f3c07b6e53f1e42a02ecc0f08ec861a08ad5b76da3af20b636