[INFO] crate olekit 1.0.2 is already in cache [INFO] extracting crate olekit 1.0.2 into work/ex/clippy-test-run/sources/stable/reg/olekit/1.0.2 [INFO] extracting crate olekit 1.0.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/olekit/1.0.2 [INFO] validating manifest of olekit-1.0.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of olekit-1.0.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing olekit-1.0.2 [INFO] finished frobbing olekit-1.0.2 [INFO] frobbed toml for olekit-1.0.2 written to work/ex/clippy-test-run/sources/stable/reg/olekit/1.0.2/Cargo.toml [INFO] started frobbing olekit-1.0.2 [INFO] finished frobbing olekit-1.0.2 [INFO] frobbed toml for olekit-1.0.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/olekit/1.0.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting olekit-1.0.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/olekit/1.0.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 781899861ec83973a1a54c3dd64788c76fc2730390e7cebfdeb956469d46ecc8 [INFO] running `"docker" "start" "-a" "781899861ec83973a1a54c3dd64788c76fc2730390e7cebfdeb956469d46ecc8"` [INFO] [stderr] Checking ole v0.1.15 [INFO] [stderr] Checking olekit v1.0.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/olekit.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | human: human, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `human` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/olekit.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/olekit.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/olekit.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | more_details: more_details, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `more_details` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/olekit.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | idirid: idirid, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `idirid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/olekit.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | full_path: full_path [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `full_path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/format.rs:160:5 [INFO] [stderr] | [INFO] [stderr] 160 | print!("{}:\n", self.format_name(entry, &name)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/olekit.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | human: human, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `human` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/olekit.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/olekit.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/olekit.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | more_details: more_details, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `more_details` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/olekit.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | idirid: idirid, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `idirid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/olekit.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | full_path: full_path [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `full_path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/format.rs:160:5 [INFO] [stderr] | [INFO] [stderr] 160 | print!("{}:\n", self.format_name(entry, &name)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format.rs:22:31 [INFO] [stderr] | [INFO] [stderr] 22 | const DIF_TIME_WINDOWS: u64 = 116444736000000000u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `116_444_736_000_000_000u64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format.rs:74:13 [INFO] [stderr] | [INFO] [stderr] 74 | / 10000000) as i64, 0).format("%Y-%m-%d %H:%M:%S").to_string(); [INFO] [stderr] | ^^^^^^^^ help: consider: `10_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format.rs:22:31 [INFO] [stderr] | [INFO] [stderr] 22 | const DIF_TIME_WINDOWS: u64 = 116444736000000000u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `116_444_736_000_000_000u64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format.rs:74:13 [INFO] [stderr] | [INFO] [stderr] 74 | / 10000000) as i64, 0).format("%Y-%m-%d %H:%M:%S").to_string(); [INFO] [stderr] | ^^^^^^^^ help: consider: `10_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/format.rs:26:34 [INFO] [stderr] | [INFO] [stderr] 26 | fn print_entry(&self, entries: &std::vec::Vec<&ole::Entry>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[&ole::Entry]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/format.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | / match self.color() { [INFO] [stderr] 52 | | false => std::string::String::from(name), [INFO] [stderr] 53 | | true => match entry._type() { [INFO] [stderr] 54 | | ole::EntryType::UserStorage [INFO] [stderr] ... | [INFO] [stderr] 63 | | } [INFO] [stderr] 64 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 51 | if self.color() { match entry._type() { [INFO] [stderr] 52 | ole::EntryType::UserStorage [INFO] [stderr] 53 | => ansi_term::Colour::Blue.paint(name).to_string(), [INFO] [stderr] 54 | ole::EntryType::UserStream [INFO] [stderr] 55 | => ansi_term::Colour::Green.paint(name).to_string(), [INFO] [stderr] 56 | ole::EntryType::RootStorage [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/format.rs:69:5 [INFO] [stderr] | [INFO] [stderr] 69 | / let result: std::string::String; [INFO] [stderr] 70 | | if date == 0 { [INFO] [stderr] 71 | | result = std::string::String::from("(no MAC specified)"); [INFO] [stderr] 72 | | } else { [INFO] [stderr] 73 | | result = chrono::Utc.timestamp(((date - DIF_TIME_WINDOWS) [INFO] [stderr] 74 | | / 10000000) as i64, 0).format("%Y-%m-%d %H:%M:%S").to_string(); [INFO] [stderr] 75 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] help: it is more idiomatic to write [INFO] [stderr] | [INFO] [stderr] 69 | let result = if date == 0 { std::string::String::from("(no MAC specified)") } else { chrono::Utc.timestamp(((date - DIF_TIME_WINDOWS) [INFO] [stderr] 70 | / 10000000) as i64, 0).format("%Y-%m-%d %H:%M:%S").to_string() }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/format.rs:180:3 [INFO] [stderr] | [INFO] [stderr] 180 | match self.human { [INFO] [stderr] | _________^ [INFO] [stderr] 181 | | false => format!("{:>8}", size), [INFO] [stderr] 182 | | true => format!("{:>8}", self.format_human_size(size)) [INFO] [stderr] 183 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self.human { format!("{:>8}", self.format_human_size(size)) } else { format!("{:>8}", size) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:95:3 [INFO] [stderr] | [INFO] [stderr] 95 | / match olekit::olekit(&matches) { [INFO] [stderr] 96 | | Err(e) => eprintln!("An error has occured: {}", e), [INFO] [stderr] 97 | | _ => {} [INFO] [stderr] 98 | | }; [INFO] [stderr] | |___^ help: try this: `if let Err(e) = olekit::olekit(&matches) { eprintln!("An error has occured: {}", e) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/format.rs:26:34 [INFO] [stderr] | [INFO] [stderr] 26 | fn print_entry(&self, entries: &std::vec::Vec<&ole::Entry>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[&ole::Entry]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/format.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | / match self.color() { [INFO] [stderr] 52 | | false => std::string::String::from(name), [INFO] [stderr] 53 | | true => match entry._type() { [INFO] [stderr] 54 | | ole::EntryType::UserStorage [INFO] [stderr] ... | [INFO] [stderr] 63 | | } [INFO] [stderr] 64 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 51 | if self.color() { match entry._type() { [INFO] [stderr] 52 | ole::EntryType::UserStorage [INFO] [stderr] 53 | => ansi_term::Colour::Blue.paint(name).to_string(), [INFO] [stderr] 54 | ole::EntryType::UserStream [INFO] [stderr] 55 | => ansi_term::Colour::Green.paint(name).to_string(), [INFO] [stderr] 56 | ole::EntryType::RootStorage [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/format.rs:69:5 [INFO] [stderr] | [INFO] [stderr] 69 | / let result: std::string::String; [INFO] [stderr] 70 | | if date == 0 { [INFO] [stderr] 71 | | result = std::string::String::from("(no MAC specified)"); [INFO] [stderr] 72 | | } else { [INFO] [stderr] 73 | | result = chrono::Utc.timestamp(((date - DIF_TIME_WINDOWS) [INFO] [stderr] 74 | | / 10000000) as i64, 0).format("%Y-%m-%d %H:%M:%S").to_string(); [INFO] [stderr] 75 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] help: it is more idiomatic to write [INFO] [stderr] | [INFO] [stderr] 69 | let result = if date == 0 { std::string::String::from("(no MAC specified)") } else { chrono::Utc.timestamp(((date - DIF_TIME_WINDOWS) [INFO] [stderr] 70 | / 10000000) as i64, 0).format("%Y-%m-%d %H:%M:%S").to_string() }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/format.rs:180:3 [INFO] [stderr] | [INFO] [stderr] 180 | match self.human { [INFO] [stderr] | _________^ [INFO] [stderr] 181 | | false => format!("{:>8}", size), [INFO] [stderr] 182 | | true => format!("{:>8}", self.format_human_size(size)) [INFO] [stderr] 183 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self.human { format!("{:>8}", self.format_human_size(size)) } else { format!("{:>8}", size) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:95:3 [INFO] [stderr] | [INFO] [stderr] 95 | / match olekit::olekit(&matches) { [INFO] [stderr] 96 | | Err(e) => eprintln!("An error has occured: {}", e), [INFO] [stderr] 97 | | _ => {} [INFO] [stderr] 98 | | }; [INFO] [stderr] | |___^ help: try this: `if let Err(e) = olekit::olekit(&matches) { eprintln!("An error has occured: {}", e) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.31s [INFO] running `"docker" "inspect" "781899861ec83973a1a54c3dd64788c76fc2730390e7cebfdeb956469d46ecc8"` [INFO] running `"docker" "rm" "-f" "781899861ec83973a1a54c3dd64788c76fc2730390e7cebfdeb956469d46ecc8"` [INFO] [stdout] 781899861ec83973a1a54c3dd64788c76fc2730390e7cebfdeb956469d46ecc8