[INFO] crate oidc 0.2.0 is already in cache [INFO] extracting crate oidc 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/oidc/0.2.0 [INFO] extracting crate oidc 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/oidc/0.2.0 [INFO] validating manifest of oidc-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of oidc-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing oidc-0.2.0 [INFO] finished frobbing oidc-0.2.0 [INFO] frobbed toml for oidc-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/oidc/0.2.0/Cargo.toml [INFO] started frobbing oidc-0.2.0 [INFO] finished frobbing oidc-0.2.0 [INFO] frobbed toml for oidc-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/oidc/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting oidc-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/oidc/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9c6d095b9bbd2cce8eeec0534da74ca183b5a276181e5e943e74760b05bb817e [INFO] running `"docker" "start" "-a" "9c6d095b9bbd2cce8eeec0534da74ca183b5a276181e5e943e74760b05bb817e"` [INFO] [stderr] Compiling if_chain v0.1.3 [INFO] [stderr] Compiling serde_json v1.0.37 [INFO] [stderr] Checking hyper-old-types v0.11.0 [INFO] [stderr] Checking validator v0.8.0 [INFO] [stderr] Checking biscuit v0.1.0 [INFO] [stderr] Checking reqwest v0.9.9 [INFO] [stderr] Compiling validator_derive v0.8.0 [INFO] [stderr] Checking inth-oauth2 v0.16.0 [INFO] [stderr] Checking oidc v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:343:30 [INFO] [stderr] | [INFO] [stderr] 343 | if now.timestamp() < 1504758600 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_504_758_600` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:343:30 [INFO] [stderr] | [INFO] [stderr] 343 | if now.timestamp() < 1504758600 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_504_758_600` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:227:40 [INFO] [stderr] | [INFO] [stderr] 227 | self.jwks.find(&token_kid).ok_or(Decode::MissingKey(token_kid))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Decode::MissingKey(token_kid))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:235:13 [INFO] [stderr] | [INFO] [stderr] 235 | / if let &jwa::Algorithm::Signature(sig) = alg { [INFO] [stderr] 236 | | if header.registered.algorithm != sig { [INFO] [stderr] 237 | | return wrong_key!(sig, header.registered.algorithm); [INFO] [stderr] 238 | | } [INFO] [stderr] 239 | | } else { [INFO] [stderr] 240 | | return wrong_key!(SignatureAlgorithm::default(), alg); [INFO] [stderr] 241 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 235 | if let jwa::Algorithm::Signature(sig) = *alg { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/lib.rs:326:20 [INFO] [stderr] | [INFO] [stderr] 326 | if let None = claims.azp { [INFO] [stderr] | _____________- ^^^^ [INFO] [stderr] 327 | | return Err(Validation::Missing(Missing::AuthorizedParty).into()); [INFO] [stderr] 328 | | } [INFO] [stderr] | |_____________- help: try this: `if claims.azp.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:227:40 [INFO] [stderr] | [INFO] [stderr] 227 | self.jwks.find(&token_kid).ok_or(Decode::MissingKey(token_kid))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Decode::MissingKey(token_kid))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:235:13 [INFO] [stderr] | [INFO] [stderr] 235 | / if let &jwa::Algorithm::Signature(sig) = alg { [INFO] [stderr] 236 | | if header.registered.algorithm != sig { [INFO] [stderr] 237 | | return wrong_key!(sig, header.registered.algorithm); [INFO] [stderr] 238 | | } [INFO] [stderr] 239 | | } else { [INFO] [stderr] 240 | | return wrong_key!(SignatureAlgorithm::default(), alg); [INFO] [stderr] 241 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 235 | if let jwa::Algorithm::Signature(sig) = *alg { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/lib.rs:326:20 [INFO] [stderr] | [INFO] [stderr] 326 | if let None = claims.azp { [INFO] [stderr] | _____________- ^^^^ [INFO] [stderr] 327 | | return Err(Validation::Missing(Missing::AuthorizedParty).into()); [INFO] [stderr] 328 | | } [INFO] [stderr] | |_____________- help: try this: `if claims.azp.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 36.69s [INFO] running `"docker" "inspect" "9c6d095b9bbd2cce8eeec0534da74ca183b5a276181e5e943e74760b05bb817e"` [INFO] running `"docker" "rm" "-f" "9c6d095b9bbd2cce8eeec0534da74ca183b5a276181e5e943e74760b05bb817e"` [INFO] [stdout] 9c6d095b9bbd2cce8eeec0534da74ca183b5a276181e5e943e74760b05bb817e